Granny's Programming Pearls "inside of every large program is a small program struggling to get out" JavaRanch.com/granny.jsp
Win a copy of Penetration Testing Basics this week in the Security forum!

Using Methods in methods

Stephen Foy
Ranch Hand
Posts: 143
Hi,

i am writing a program, and i have made a randomGenrate method, which i would like to use in my rollDice method. Any help on how i can achieve this? Thanks

Stephen Huey
Ranch Hand
Posts: 618
What problem are you having? This should compile and run:

Stephen Foy
Ranch Hand
Posts: 143
Its that i want to use the randomGenerate number in other methods, i have it working now.

I want it to print out 3 different random numbers, but it prints out the same always.

Campbell Ritchie
Sheriff
Posts: 50639
83
You need to check the Math.random() method carefully in the API. If I remember correctly, it returns a double number pseudo-randomly chosen between 0 and under 1, or something like 0 . . . 0.999999999....

Firstly, you should try to avoid using more than one random number generator within an app; if you hve two which are set off simultaneously, they may produce the same number each.

Secondly, if you multiply by 6, you will never get a "6;" you will get from 0 to 5.999999..., so you have to add 1 to your (int)(randomNumber * 6). Using round will actually bias your numbers; you will occasionally get a 6 or a 0, but with a lower probability than for 1 2 3 4 and 5.

The reason you are getting the same number printed out three times is that you have no means of changing the number in your loop in your rollOne() method.

Another way to get pseudo-random numbers would be the nextInt(6) method in the java.util.Random class. Again you would have to add 1.

So, a much simpler way to sort out the problem is EITHER

OR

When I first encountered the random number generating methods, I wrote out a class which mimics rolling a die, so I can use it whenever I want random numbers in a particular tange.

BTW: There is an example of random number generation in Deitel's book, where they add all the 1s, the 2s, the 3s etc, to count how many times each numebr comes up in, say, 10000 rolls, and they also count how many times the same number comes up twice in succession; if you have a die and roll it, you should get the same number twice once in 6 pairs, the same number thrice once in 36, etc etc.

Stephen Foy
Ranch Hand
Posts: 143
Thanks for that, really helps. Oh and i managed to sort the getting a 0 problem, by using a while loop, which looped the number till it wasnt 0.

Thanks alot!

Bert Bates
author
Sheriff
Posts: 8900
5
Uh oh!

Oh and i managed to sort the getting a 0 problem, by using a while loop, which looped the number till it wasnt 0.

That sounds like an approach that could lead to severly un-random dice!

I think the (Math.random() * 6) + 1 idea is better

Stephen Foy
Ranch Hand
Posts: 143
at first i tried.

math.Random()+ 1 * 6 and never worked

fred rosenberger
lowercase baba
Bartender
Posts: 12227
36
multiplying by 6, adding 1 and rounding down should always give you a value of 1,2,3,4,5 or 6.

if you get the lowest possible value from the RNG, 0, add 1, you get 1, rounded down is 1.

if you get the highest possible value, 5.9999... to however many decimal places, add one, you get 6.99999...., and rounded down give you 6.

if there is any difference in the distribution, this is the first i've ever heard of it.

Paul Clapham
Sheriff
Posts: 21443
33
Or you could try java.util.Random.nextInt(6) + 1; if you read its documentation, there seems to have been some thought put into making sure that nextInt() does actually return a pseudo-random sequence of integers between 0 and 5 inclusive.

Stephen Foy
Ranch Hand
Posts: 143
i managed to get it to do different random values, hope this is an appropriate way. Any suggestions?

Junilu Lacar
Bartender
Posts: 8040
64
You might find some useful information on random numbers here:

http://www.javaranch.com/maha/Resources/gotchas_1_.html

http://javaa.com/modules.php?name=News&pagenum=29