• Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Liutauras Vilda
  • Jeanne Boyarsky
  • Devaka Cooray
  • Paul Clapham
Sheriffs:
  • Tim Cooke
  • Knute Snortum
  • Bear Bibeault
Saloon Keepers:
  • Ron McLeod
  • Tim Moores
  • Stephan van Hulst
  • Piet Souris
  • Ganesh Patekar
Bartenders:
  • Frits Walraven
  • Carey Brown
  • Tim Holloway

Check an array for equality

 
Ranch Hand
Posts: 424
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I have an array of int type, I want check that array to see if it has equal elements for example: {1,1,1,1,1} return true, otherwise false.
I have written this code, it works well but I want know if its good or there better algorithm.

 
Ranch Hand
Posts: 518
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
See java.util.Arrays. It has some methods you'll be interested in.
 
Sheriff
Posts: 11343
Mac Safari Java
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
"Talt,"

Welcome to JavaRanch!

Please revise your display name to meet the JavaRanch Naming Policy. To maintain the friendly atmosphere here at the ranch, we like folks to use real (or at least real-looking) names, with a first and a last name.

You can edit your display name here. Thank you for your prompt attention!

-Marc
 
Java Cowboy
Posts: 16084
88
Android Scala IntelliJ IDE Spring Java
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Your code works, but looks unnecessarily complicated. You can do it in a more simple way like this:

[ January 10, 2007: Message edited by: Jesper Young ]
 
Ranch Hand
Posts: 1970
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

Originally posted by Scott Johnson:
See java.util.Arrays. It has some methods you'll be interested in.



It does have some good methods for working with arrays, but not one for testing if all elements are the same ... does it?
 
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

Originally posted by Peter Chase:


It does have some good methods for working with arrays, but not one for testing if all elements are the same ... does it?


You can always use Array's equals method:


[ January 11, 2007: Message edited by: Gary Edwards ]
 
Wanderer
Posts: 18671
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
There appear to be two different ideas here about what is meant by "check an array for equality". Gary and (maybe) Scott are talking about checking if two different arrays are equal to each other, in the sense that the corresponding elements are equal. I.e. a[0] == b[0], a[1] == b[1], etc. But the original poster and others are talking about checking one array to see if all the elements are equal to each other. I.e. a[0] == a[1] == a[2] etc. These are completely different problems; let's not mix them up.
 
Gary Edwards
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Oops...I really ought to learn how to read things a little more closely!
 
ahmed yehia
Ranch Hand
Posts: 424
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
The orignal problem I have is to check a grid of elements
modeled as 2D array to see if 1 row or column has equal elements.
However checking 1D array seems different.
 
Ranch Hand
Posts: 122
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
You could speed up the code a bit:
 
It is sorta covered in the JavaRanch Style Guide.
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!