ArrayList Problem(s)

[Joseph Carr]

I am having trouble with an ArrayList that I am using, I substituted it for a loop with a regular array and now i am getting an error when I compile: "<identifier> expected." I've tried implementing the ArrayList in a variety of ways, but keep getting the same error. For clarification I am using BlueJ 2.2.1 on Mac OS X 10.5.2
Some of the other code may be wrong, but just because I've been moving everything around while tearing my hair out trying to find out what went wrong...

 
 import java.util.ArrayList;
 
public class GameStats {
 
    ArrayList<String> gameStatStrArray = new ArrayList<String>();
    string stat1 = new String();
   
    gameStatStrArray.add("statStr1");
    gameStatStrArray.add("statStr2");
    gameStatStrArray.add("statStr3");
    
    ArrayList<int> gameStatIntArray = new ArrayList<int>();
    int statInt1;
    int statInt2;
    int statInt3;
    gameStatIntArray.add(statInt1);
    gameStatIntArray.add(statInt2);
    gameStatIntArray.add(statInt3);
    
        
    public int gameStatsGetter(String getThis)
    {
        String gettingThis = getThis;
        int idx = gameStatsStrArray.indexOf(gettingThis);
        int gotThis = gameStatsIntArray(idx);
            return gotThis;
    }
 
   
    public void gameStatsSetter(String setThis, int setToThis)
    {
        String settingThis = setThis;
        int idx = gameStatsStrArray.indexOf(settingThis);
        gameStatsIntArray(idx) = setToThis;
            
        
          System.out.println("I did set this " + gameStatsStrArray[x]);
          System.out.println("To This " + gameStatsIntArray[x]);
         
            
          
        
    }
} 

[ February 20, 2008: Message edited by: Joseph Carr ]

[Bear Bibeault]

It always helps to cut/paste the actual error message rather than paraphrasing it. The error message contains valuable information that gets lost when you do not post it.

[marc weber]

In general, a class contains fields (variables) and methods.

When you want to "do" something (like add elements to a List), these statements need to go inside a method body.

[Joseph Carr]

I understand. I'll try and be more clear, when I compiled this code in BlueJ it gives me a popup box that I cannot copy so I will type it word for word here:

    
<identifier> expected
 
The symbol named in the error message was 
expected to appear at this point in the code.
It was not there; instead, there was some other
symbol. Try to think about why this symbol may
be expected here.

It's blueJ so the error message is weird. I'd do it in Netbeans or Xcode but I cannot get either of them to compile a single class for some reason...

When you want to "do" something (like add elements to a List), these statements need to go inside a method body.

I'd like to initialize this ArrayList immediately, the other ArrayList (gameStatIntArrayList) will be more dynamic so i'll be initializing it inside of a method.
I can still use the while loop on an Array ratehr than implementing this ArrayList, I just thought that this was the more efficient way to go....four hours later...
[ February 20, 2008: Message edited by: Joseph Carr ]

[Bear Bibeault]

Try the command line?

[marc weber]

Originally posted by Joseph Carr:
...when I compiled this code in BlueJ it gives me a popup box...

<identifier> expected...

At that point in the code, you are inside a class definition, so the compiler is expecting an identifier for either a variable or a method. Instead, you are providing a statement to be executed...

gameStatStrArray.add("statStr1");

This type of statement needs to be inside the body of a method (or constructor).

[Joseph Carr]

Thanks Bear. I don't thinkn the compiler liked me trying to add stuff into ArrayList outside of a method. Another snafu was using an integer type in an ArrayList (superfluous and just plain wrong). So I just created an initializer method that I have to run before the other methods will work. Thanks for all your help, it was really simpler than I was making it (usually the case).

So, I fixed the code:

   
import java.util.ArrayList;
 
public class GameStats {
 
    ArrayList<String> gameStatStrArray = new ArrayList<String>();
    
     int statInt1;
     int statInt2;
     int statInt3;
    
   
    int[] gameStatIntArray ={
        statInt1,
        statInt2,
        statInt3};
    
    public void initGameStats() {
         gameStatStrArray.add("statStr1");
         gameStatStrArray.add("statStr2");
         gameStatStrArray.add("statStr3");
}
 
    public int gameStatsGetter(String getThis)
    {
        String gettingThis = getThis;
        int idx = gameStatStrArray.indexOf(gettingThis);
        int gotThis = gameStatIntArray[idx];
            return gotThis;
    }
 
   
    public void gameStatsSetter(String setThis, int setToThis)
    {
        int idx;
        idx = gameStatStrArray.indexOf(setThis);
        gameStatIntArray[idx] = setToThis;
            
        
          System.out.println("I did set this " + setThis);
          System.out.println("To This " + gameStatIntArray[idx]);
         
            
          
        
    }
} 

[Sean Connery]

Originally posted by Joseph Carr:
....
Another snafu was using an integer type in an ArrayList (superfluous and just plain wrong).
....

Just an FYI, but prior to 1.5, ArrayList could only take Objects (NOT primitive variables). However, since 1.5, they introduced autoboxing, so you could do something like:

    
  List<Integer> myList = new ArrayList(); 
  myList.add(123); //Oh NO! a Primitive!  Oh yeah, we're using 1.5, no prob!
 

But you are correct, the generic portion (<Integer> of the List must take an Object.

Cheers,
UbuntuClimber

[Ben Souther]

"Ubuntu Climber ",
Please check your private messages.
-Ben

[Campbell Ritchie]

Originally posted by Ubuntu Climber:
[QB]

    
  List<Integer> myList = new ArrayList();
. . .

Aaaah!

Don't declare a generic object and then instantiate it with a non-generic reference. That is called using a raw type, which for reasons I have forgotten is very much frowned upon. In fact Sun keep threatening to upgrade it to a compiler error.

The correct syntax would be
List<Integer> myList = new ArrayList<Integer>();