To know about File Upload

[vijay kumar dahiya]

Hello To Every One,
when I upload the File like a image from html page Its not show on servlet page using appropriate logic.
I read the FileUpload Home page.But I am still confused.
I want to know Is true that file uploaded image can not show directly on servlet? firstly Its store to database or memory then Its reterive to servlet or JSP.?
Please assist me.
Thanks.

[Bear Bibeault]

Whether you are creating pages with JSP, Servlets, php, or Fred's Fabulous Framework, it's all HTML by the time it gets to the browser. And in HTML, images are referenced with the <img> tag.

You can;t just blurt image data out into a page and expect the browser to know what to do with it -- it needs the <img> tag -- whose src can point to a servlet that serves up the image data (and just the image data).

[vijay kumar dahiya]

Can you help me please,how Image data display on Servlet page.
Here my servlet file:
Upload file.java:

import java.io.*; 
import java.io.IOException; 
import java.util.Iterator; 
import java.util.List; 
  
import javax.servlet.ServletException; 
import javax.servlet.http.HttpServlet; 
import javax.servlet.http.HttpServletRequest; 
import javax.servlet.http.HttpServletResponse; 
  
import org.apache.commons.fileupload.DiskFileUpload; 
import org.apache.commons.fileupload.FileItem; 
import org.apache.commons.fileupload.FileItemFactory; 
import org.apache.commons.fileupload.FileUpload; 
import org.apache.commons.fileupload.FileUploadException; 
  
public class UploadFile extends HttpServlet { 
  
public void doPost(HttpServletRequest req,HttpServletResponse res) 
{ 
try     
    {  
FileUpload fup=new FileUpload(); 
boolean isMultipart = FileUpload.isMultipartContent(req); 
// Create a new file upload handler 
System.out.println(isMultipart); 
DiskFileUpload upload = new DiskFileUpload(); 
  
// Parse the request 
List  items = upload.parseRequest(req); 
  
Iterator iter = items.iterator(); 
while (iter.hasNext())  
        { 
  
FileItem item = (FileItem) iter.next(); 
if (item.isFormField())     { 
System.out.println("its a field"); 
            } 
 else  
            { 
System.out.println("its a file"); 
System.out.println(item.getName()); 
File cfile=new File(item.getName()); 
File tosave=new File(getServletContext().getRealPath("/"),cfile.getName()); 
item.write(tosave); 
String contentType = req.getContentType(); 
System.out.println("Content type is :: " +contentType); 
if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0))  
        { 
InputStream in = req.getInputStream(); 
int len = req.getContentLength(); 
System.out.println("Length is: "+len); 
byte [] dataBytes = new byte[len]; 
int index=in.read(dataBytes, 1, len); 
System.out.println("********"); 
System.out.println("index is: "+index); 
System.out.println("+++++++++"); 
             res.reset(); 
res.setContentType("image/gif"); 
     res.getOutputStream().write(dataBytes, 0, len); 
res.getOutputStream().flush();     
         System.out.println("Suceesfully displayed"); 
            } 
            } 
        } 
    }     
catch(Exception e){System.out.println(e);} 
} 
} 

Servlet page not display the image properly.Although Servlet page show a small icon.and server side show Length but not show the index value,Its show -1.like that:

Length is: 6315 
****************** 
index is: -1 
++++++++++++ 

please help me.

[Paul Clapham]

So the purpose of this example is just to send the uploaded image file back to the browser?

Looking at your code, you start out fine by getting the uploaded data into a file. But then instead of reading from that file and copying it back to the response, you try to read from the request!

[vijay kumar dahiya]

So,How I do that.?
Please help me.

[Paul Clapham]

Okay. So you have a FileItem object. The Apache software will have read the uploaded file from the request and put it into that object. So what you want to do is to read the data out of that object and copy it to the output stream.

Now your task is to see if FileItem has a method which returns an InputStream, or something similar which you can read from. So check the API documentation and see if there is one.

Let us know how you get on with that.

[vijay kumar dahiya]

Dear Sir,
I read the org.apache.commons.fileupload
Interface FileItem have a method:
java.io.InputStream getInputStream()
Returns an InputStream that can be used to retrieve the contents of the file.

I write that in code:
UploadFile.java:

FileUpload fup=new FileUpload();
boolean isMultipart = FileUpload.isMultipartContent(req);
// Create a new file upload handler
System.out.println(isMultipart);
DiskFileUpload upload = new DiskFileUpload();
// Parse the request
List  items = upload.parseRequest(req);
Iterator iter = items.iterator();
while (iter.hasNext()) {
FileItem item = (FileItem) iter.next();
InputStream in=item.getInputStream();
int len = req.getContentLength();
 System.out.println("Length is: "+len); 
byte [] dataBytes = new byte[len]; 
int index=in.read(dataBytes, 1, len);
System.out.println("********");
 System.out.println("index"+index);
System.out.println("+++++++++");
}

It give a error:

symbol: class InputStream
location: class UploadFile
       InputStream in=item.getInputStream();
       ^

[Ulf Dittmer]

Does the code have an import statement for the InputStream class?

[vijay kumar dahiya]

Oh Sorry Sir,
firstly I used import java.io.File;
now I am using import java.io.*;
that error have remove.
Now I am try to effort to find desired result.I came back later if problem occurs.
Thanks.

[vijay kumar dahiya]

Dear sir,
Servlet are not display proper image.Its show only a small icon.
Here my Home.html:

<html>
<form method="post" action="upload.jsp" enctype="multipart/form-data">
Name
<input type="text" name="name"/>
<tr>
File
<input type="file" name="file"/>
<input type="submit"/>
</form>
</html>

UploadFile.java: using that code snippet-
although InputStream are properly work.But Servlet not display a proper image.

res.reset();
res.setContentType("image/gif");
    OutputStream out=item.getOutputStream();
out.write(dataBytes,0,len);
out.flush();

Please help me..
[ December 12, 2008: Message edited by: vijay kumar dahiya ]

[Ulf Dittmer]

OutputStream out=item.getOutputStream();
out.write(dataBytes,0,len);
out.flush();

This looks wrong. You need to read from the FileItem (using its getInputStream method), and write its bytes to the servlet output stream (res.getOutputStream).

[vijay kumar dahiya]

Dear Sir,
I try this:

res.setContentType("image/jpg");
     res.getOutputStream().write(dataBytes,0,len);
res.getOutputStream().flush();  

But use above code It not display on servlet,Its appear a downloaded form and downloaded on disk when click on save button.Other thing is that It not a .jpg form.that mean It does not open by photo gallery.that message show file format not supported by Photo Gallary.
when I add that line:

res.reset();//reset the response
 
res.setContentType("image/jpg");
     res.getOutputStream().write(dataBytes,0,len);
res.getOutputStream().flush(); 

then servlet show a small icon not show a proper image.
and server side show:

java.lang.IllegalStateException: Response already commited

please help me I try this program from a long time.

[Ulf Dittmer]

The call to res.reset() shouldn't be necessary. Is the code doing anything else with the response before the call to setContentType?

In general, for debugging problems with HTTP request and responses the Firefox extension LiveHTTPheaders is very helpful. It logs all requests sent by the browser, and also the responses it gets back.

[vijay kumar dahiya]

Dear Sir,
Before call the setContentType("image/jpg");
Server side show:

Length is: 6320 
****************** 
index is:6017 
++++++++++++ 
Sucessfully send

and at run time It not display on servlet,Its appear a downloaded form and downloaded on disk when click on save button.Other thing is that It not a .jpg form.that mean It does not open by photo gallery.that message show file format not supported by Photo Gallary.
Please help..

[Ulf Dittmer]

Oh wait:

<form method="post" action="upload.jsp" enctype="multipart/form-data">

Are you using a JSP for this? A JSP can't stream binary content (like an image).

But you said it was a servlet.

[vijay kumar dahiya]

Oh,Sorry for that:
Actually Its My home.html file:

<html>
<form method="post" action="tmp" enctype="multipart/form-data">
Name
<input type="text" name="name"/>
File
<input type="file" name="file"/>
<input type="submit"/>
</form>
</html>

web.xml:

<web-app>
<servlet>
<servlet-name>one</servlet-name>
<servlet-class>UploadFile</servlet-class>
</servlet>
<servlet-mapping>
<servlet-name>one</servlet-name>
<url-pattern>/tmp</url-pattern>
</servlet-mapping>
<welcome-file-list>
<welcome-file>Home.html</welcome-file>
</welcome-file-list>
</web-app>

UploadFile.java

import java.io.*;
import java.io.IOException;
import java.util.Iterator;
import java.util.List;
 
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
 
import org.apache.commons.fileupload.DiskFileUpload;
import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileItemFactory;
import org.apache.commons.fileupload.FileUpload;
import org.apache.commons.fileupload.FileUploadException;
import javax.activation.DataSource;
public class UploadFile extends HttpServlet {
 
public void doPost(HttpServletRequest req,HttpServletResponse res)
{
try{
FileUpload fup=new FileUpload();
boolean isMultipart = FileUpload.isMultipartContent(req);
// Create a new file upload handler
System.out.println(isMultipart);
DiskFileUpload upload = new DiskFileUpload();
 
// Parse the request
List items = upload.parseRequest(req);
 
Iterator iter = items.iterator();
while (iter.hasNext()) {
 
FileItem item = (FileItem) iter.next();
InputStream in=item.getInputStream();
int len = req.getContentLength();
System.out.println("*************");
System.out.println("Length is: "+len);
System.out.println("+++++++++++");
byte [] dataBytes = new byte[len];
int index=in.read(dataBytes, 0, len);
System.out.println("********");
System.out.println("index"+index);
System.out.println("+++++++++");
// res.reset();
res.setContentType("image/jpg");
res.getOutputStream().write(dataBytes,0,len);
res.getOutputStream().flush();
System.out.println("Suceesfully send");
}
}
catch(Exception e){System.out.println(e);}
}
}

Problem are still persist.

[Ulf Dittmer]

Is the loop possibly being executed more than once? You can only send a single image per request.

To give it its proper filename upon saving, you need to add something like this:

response.setHeader("Content-Disposition", "attachment; filename=\"image.jpg\"")

If you want to display it instead, use "inline" instead of "attachment".

[vijay kumar dahiya]

Dear Sir,
Yes, loop are executed twice when sending one request.
I used that:

res.setContentType("image/jpg");
res.setHeader("Content-Disposition", "attachment; filename=\"image004.jpg\"");
res.getOutputStream().write(dataBytes,0,len);
res.getOutputStream().flush();  

But same problem exist.

[Ulf Dittmer]

Yes, loop are executed twice when sending one request.

Then you need to find out why it's executed twice, and either stop that from happening, or make sure that the code writing the image is only executed once.
[ December 13, 2008: Message edited by: Ulf Dittmer ]

[vijay kumar dahiya]

Dear Sir,
I simply changing in Home.html.Now I send only one thing that is Image.
Now loop is executed only once.
Home.html:

<html>
<form method="post" action="tmp" enctype="multipart/form-data">
File
<input type="file" name="file"/>
<input type="submit"/>
</form>
</html>

UploadFile.java is same
But same problem exist.It not display on servlet,Its appear a downloaded form and downloaded on disk when click on save button.Other thing is that It not a .jpg form.that mean It does not open by photo gallery.that message show file format not supported by Photo Gallary.
please help me..

[Ulf Dittmer]

If that's happening even though you're setting the Content-Disposition header, I'd use the LiveHTTPheaders extension I mentioned earlier to examine what, exactly, is being sent as the response.

[vijay kumar dahiya]

Dear Sir,
Can you give me any example How I use LiveHTTPheaders extension or any reference of that.I try did at better at my level.

[Ulf Dittmer]

Its web site is the first link that comes up in Google for "livehttpheader". If you install it in Firefox it'll add a new menu item under "Tools". I don't think there's much documentation, but by playing around with it it should become clear what it does, and how it does it, pretty soon.

[vijay kumar dahiya]

Dear Sir,
I install the Live HTTP headers 0.14 from Google in Firefox.
Also appearing a new menu of Live HTTP headers in Tools options.
I run the weblogic on Firefox and run that progarm but same issue persist.

[Ulf Dittmer]

What have you found out? LiveHTTPHeader is a debugging tool that can tell you what's happening over the HTTP wire, not a tool that fixes anything. Have you inspected the HTTP response headers?

[vijay kumar dahiya]

Dear Sir,
Its not show a new thing.
Same previous.

[Ulf Dittmer]

What do you mean by "not a new thing"? You haven't told us what it showed before.

Post the response headers here; you can copy them straight out of the LiveHTTPHeader window. That might give us a clue as to what is going wrong.

[vijay kumar dahiya]

Dear Sir,
I am using Live HTTP headers.So I am not know more about it.
I thing your mean

from Tools option have a Live HTTP headers menu.
when I click on Live HTTP headers new window of Live HTTP headers appears.
Its Text area show some matters.That matter I will paste here ?

Actually Sir,
I am not guess exactly what are you talking for.

[Ulf Dittmer]

While the LiveHTTPHeader window is open -make sure its "Capture" checkbox is checked- you upload the file in a different window in the same browser. The LiveHTTPHeader window should now be showing the HTTP request and the HTTP response; that is the main function of this extension. Copy the response headers and post them here.

Play around with it a bit so you get a feeling for what it does and how it shows the HTTP information. It's a very useful tool for anyone developing web applications.
[ December 13, 2008: Message edited by: Ulf Dittmer ]

[vijay kumar dahiya]

Dear Sir,
At run time different window are open in the same browser.
"Capture" checkbox is also checked of LiveHTTPHeader window.
Of LiveHTTPHeader window have four tabs-Headers,Generator,Config,About.
Here I paste the matter of Header Tab.

 
<a href="http://localhost:7001/UploadR/Home.html" target="_blank" rel="nofollow">http://localhost:7001/UploadR/Home.html</a>
 
GET /UploadR/Home.html HTTP/1.1
Host: localhost:7001
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: <a href="http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadR%2CName%3DUploadR%2CType%3DWebAppComponent" target="_blank" rel="nofollow">http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadR%2CName%3DUploadR%2CType%3DWebAppComponent</a>
Cookie: ADMINCONSOLESESSION=JEl5s2P0rnr2yi1DCPPrr62u0ljVQ7XbtoIi82K0C9iivyTc85ON!1444095759
If-Modified-Since: Sat, 13 Dec 2008 20:48:30 GMT
 
HTTP/1.x 304 Not Modified
Date: Sat, 13 Dec 2008 21:43:42 GMT
Server: WebLogic WebLogic Server 8.1  Thu Mar 20 23:06:05 PST 2003 246620
Content-Length: 0
----------------------------------------------------------
<a href="http://localhost:7001/UploadR/Home.html" target="_blank" rel="nofollow">http://localhost:7001/UploadR/Home.html</a>
 
GET /UploadR/Home.html HTTP/1.1
Host: localhost:7001
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: <a href="http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadR%2CName%3DUploadR%2CType%3DWebAppComponent" target="_blank" rel="nofollow">http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadR%2CName%3DUploadR%2CType%3DWebAppComponent</a>
Cookie: ADMINCONSOLESESSION=JEl5s2P0rnr2yi1DCPPrr62u0ljVQ7XbtoIi82K0C9iivyTc85ON!1444095759
If-Modified-Since: Sat, 13 Dec 2008 20:48:30 GMT
Cache-Control: max-age=0
 
HTTP/1.x 304 Not Modified
Date: Sat, 13 Dec 2008 21:43:54 GMT
Server: WebLogic WebLogic Server 8.1  Thu Mar 20 23:06:05 PST 2003 246620
Content-Length: 0
----------------------------------------------------------
<a href="http://localhost:7001/UploadK1/Home.html" target="_blank" rel="nofollow">http://localhost:7001/UploadK1/Home.html</a>
 
GET /UploadK1/Home.html HTTP/1.1
Host: localhost:7001
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: <a href="http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadK1%2CName%3DUploadK1%2CType%3DWebAppComponent" target="_blank" rel="nofollow">http://localhost:7001/console/actions/mbean/EditMBeanAction?reloadNav=false&tab=testing&MBean=vijay%3AApplication%3DUploadK1%2CName%3DUploadK1%2CType%3DWebAppComponent</a>
Cookie: ADMINCONSOLESESSION=JEl5s2P0rnr2yi1DCPPrr62u0ljVQ7XbtoIi82K0C9iivyTc85ON!1444095759
If-Modified-Since: Sat, 13 Dec 2008 16:50:56 GMT
 
HTTP/1.x 304 Not Modified
Date: Sat, 13 Dec 2008 21:44:43 GMT
Server: WebLogic WebLogic Server 8.1  Thu Mar 20 23:06:05 PST 2003 246620
Content-Length: 0
----------------------------------------------------------

[Ulf Dittmer]

That's just the page with the upload form. But the interesting part is actually doing an upload, and then observing the headers that get sent back along with the image.

[vijay kumar dahiya]

Dear Sir,
That matter of Live HTTP headers after click on Submit button then open a Live HTTp headers window It show blank then downloading the image and open it but it show a image by Photo Gallery then I close the photo Gallery.After that that matter appears in Live HTTP headers window.

<a href="https://addons.mozilla.org/blocklist/2/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0.4/Firefox/2008102920/WINNT_x86-msvc/en-US/release/Windows_NT%206.0/default/default/" target="_blank" rel="nofollow">https://addons.mozilla.org/blocklist/2/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0.4/Firefox/2008102920/WINNT_x86-msvc/en-US/release/Windows_NT%206.0/default/default/</a>
 
GET /blocklist/2/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0.4/Firefox/2008102920/WINNT_x86-msvc/en-US/release/Windows_NT%206.0/default/default/ HTTP/1.1
Host: addons.mozilla.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Cache-Control: no-cache
Cookie: dloadday=203.145.134.195.1223915958663250
 
HTTP/1.x 200 OK
Date: Sun, 14 Dec 2008 09:03:57 GMT
Connection: Keep-Alive
Via: NS-CACHE-6.0:   4
Server: Apache/2.2.3 (Red Hat)
X-Powered-By: PHP/5.1.6
Cteonnt-Length: 1561
Content-Type: text/xml
Cache-Control: private
Content-Encoding: gzip
Content-Length: 482
----------------------------------------------------------

[vijay kumar dahiya]

Dear Sir,
After click on Submit button,Headers Tab of Live HTTP headers window display blank.
But Generator Tab show that matter:

POST /UploadK1/tmp -----------------------------2921238217421
 Content-Disposition: form-data; name="file"; filename="Image004.jpg"
 Content-Type: image/jpeg
 
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="name"
 
 vij
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: text/plain
 
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="name"
 
 vijay
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: image/pjpeg
 
 ����

And some time Generator tab show that matter:

POST /UploadK1/tmp -----------------------------4827543632391
 Content-Disposition: form-data; name="file"; filename="Image004.jpg"
 Content-Type: image/jpeg
 
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="name"
 
 vij
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: text/plain
 
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="name"
 
 vijay
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: image/pjpeg
 
 ����

please help me..

[ UD: removed irrelevant stuff that was screwing up the layout ]
[ December 14, 2008: Message edited by: Ulf Dittmer ]

[Ulf Dittmer]

That's the HTTP upload request. Right after the Upload should be a section starting with "HTTP/1.x 200 OK" - those would the response headers that are of interest here.

You may need to scroll through the LiveHTTPHeaders window; it fills up fast because it's logging a lot of information for each request/response.
[ December 14, 2008: Message edited by: Ulf Dittmer ]

[vijay kumar dahiya]

Dear Sir,
Some time Generator tab of Live HTTP headers show that:

POST /UploadK1/tmp -----------------------------2921238217421
 Content-Disposition: form-data; name="file"; filename="Image004.jpg"
 Content-Type: image/jpeg
 
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="name"
 
 vij
 -----------------------------7d8e101b0704
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: text/plain
 
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="name"
 
 vijay
 -----------------------------7d8c7151807c0
 Content-Disposition: form-data; name="file"; filename="C:\Core\Image004.jpg"
 Content-Type: image/pjpeg
 
 ����
 
[ UD: removed a lot of unrelated stuff that was screwing up the layout ]

and some time show that:

[ UD: removed a lot of unrelated stuff that was screwing up the layout ]

Under Generator tab:
On Right side:
Under Show have four check boxes- redirects,invalid,images,CSS.images and CSS are checked.
Under Request have one check box request which is By default unchecked.

But Headers tab show empty.
[ December 14, 2008: Message edited by: Ulf Dittmer ]

[Ulf Dittmer]

I'm not sure why the Headers tab would be empty. The contents of the Generator tab don't matter.
[ December 14, 2008: Message edited by: Ulf Dittmer ]