• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

idiom for finally closing resources

 
Michael Zellmann
Greenhorn
Posts: 18
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I want to dependably close the data base resources used in my application, despite exceptions. I also want to do this with sensible, clean code. The finally block seems critical, as well as avoiding duplication. Below is my current thought on how to do this, but I am not sure if it is good practice. I would welcome any suggestions from more experienced programmers.
 
Jeanne Boyarsky
author & internet detective
Marshal
Posts: 34860
369
Eclipse IDE Java VI Editor
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Michael,
Assigning it to null is unnecessary as the variables go out of scope immediately after anyway. Other than that, you have the idiom down.

Two things people do to make this work even better:
1) Create a utility class that has a method like DbUtils.close(rs,stmt,conn). This lets the idiom exist in only one place.
2) Have the code in a superclass with an abstract method just to implement the executeQuery/loop through result set parts.
 
David O'Meara
Rancher
Posts: 13459
Android Eclipse IDE Ubuntu
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Agreed, although:

1) the catch is not required and the try/finally is valid (and sometimes preferred) without it
2) The inner try/catch should catch SQLException, not 'Exception'
3) I like to log the inner exception in case it causes resource leaks, but I'm not too strict on this.
 
Scott Selikoff
author
Saloon Keeper
Posts: 4020
18
Eclipse IDE Flex Google Web Toolkit
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I went through a similar tirade not long ago in my blog. Generally, I prefer "if (null != rs) try { rs.close(); } catch (Exception e) {}" in the form of reusable static method.

Granted, you don't actually need to check if rs is null, although its good to. Changing the value to null in the finally is clever for garbage collection, but shouldn't be needed. 99.99% of the time, I create, use, and throw away ResultSets in a single method call so I can't see them ever hanging around such that they wouldn't be garbage collected.
[ December 16, 2008: Message edited by: Scott Selikoff ]
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic