Swing GUI wierdness

[vaibhav mishra]

I have the following swing code

/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package minebomber;
import java.awt.BorderLayout;
import java.awt.Font;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import sun.font.Font2D;
/**
*
* @author ramakant
*/
class GUIclass {
int row, column;
JFrame frame;
Boolean bombs[][];
int cellvalues[][];
GUIclass(int row, int column, int[][] cellvalues, Boolean[][] bombs) {
//throw new UnsupportedOperationException("Not yet implemented");
this.row = row;
this.column = column;
this.cellvalues = cellvalues;
this.bombs = bombs;
}
int ix, jx; // declare classwide to let loop variable access available for inner class in createUI()
JButton[][] mineButton;
JLabel label;
void createUI() {
//throw new UnsupportedOperationException("Not yet implemented");
frame = new JFrame();
JPanel mineBoard = new JPanel();
mineBoard.setLayout(new GridLayout(row, column));
mineButton = new JButton[row][column];
for (int i = 0; i < row; i++) {
for (int j = 0; j < column; j++) {
mineButton[i][j] = new JButton();
mineBoard.add(mineButton[i][j]);
//mineButton[i][j].setText
}
}
frame.getContentPane().add(BorderLayout.CENTER, mineBoard);
frame.setDefaultCloseOperation(frame.EXIT_ON_CLOSE);
frame.setSize(column * 40, row * 40);
frame.setVisible(true);
for (ix = 0; ix < row; ix++) {
for (jx = 0; jx < column; jx++) {
mineButton[ix][jx].addActionListener(new mineBombed(ix, jx));
}
}
}
class mineBombed implements ActionListener {
int i, j;
mineBombed(int i, int j) {
this.i = i;
this.j = j;
}
public void actionPerformed(ActionEvent e) {
if (!bombs[i][j]) {
//throw new UnsupportedOperationException("Not supported yet.");
//JOptionPane.showMessageDialog(null, "Button from row : "+i+"and Column : "+j+"pressed");
mineButton[i][j].setText(((Integer) cellvalues[i][j]).toString());
}else{
JOptionPane.showMessageDialog(null, "Game Over");
System.exit(0);
}
}
}
}

I ran this with default row value of 16 and column value of 30
you can use whatever value you like for other variables
this produces a GUI window with lots of button and I want to change buttons value to whatever is in cellvalues array
but all I get is 3 dots


can you solve the problem

other helping classes are

Calculation.java

/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package minebomber;
import java.lang.Boolean;
/**
*
* @author ramakant
*/
class Calculation {
int row,column;
//Boolean x[][];
public static void main(String[] args) {
}
Calculation(int row,int column){
this.row = row;
this.column = column;
}
Boolean[][] fillBombs(int row, int column) {
Boolean x[][] = new Boolean[row][column];
for (int i = 0; i < row; i++) {
for (int j = 0; j < column; j++) {
x[i][j] = false;
}
}
for (int i = 0; i < (row * column / 4.8); i++) {
int tempRow = (int) (Math.random() * row);
int tempColumn = (int) (Math.random() * column);
x[tempRow][tempColumn] = true;
System.out.println("");
}
return x;
}
int[][] fillvalues(Boolean[][] bombs) {
//throw new UnsupportedOperationException("Not yet implemented");
int values[][] = new int[row][column];
int neighbours[] = new int[8];
for (int i = 0; i < row; i++) {
for (int j = 0; j < column; j++) {
values[i][j]=0;
for (int k = i-1; k < i+2; k++) {
for (int m = j-1; m < j+2; m++) {
if( k>0 && k<row && m>0 && m<column && bombs[k][m] && !( k==i && m==j ) ) {
if(bombs[k][m])values[i][j]++;
}
}
}
}
}
return values;
}
}
[code]
and
[B]Mines.java[/B]
[code]
/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package minebomber;
import javax.swing.JFrame;
/**
*
* @author ramakant
*/
class Mines {
int row;
int column;
public static void main(String[] args) {
Mines mine = new Mines(16, 30);
mine.startit();
}
Mines(int row, int column) {
this.row = row;
this.column = column;
}
JFrame frame;
void startit() {
Boolean bombs[][] = new Boolean[row][column];
//throw new UnsupportedOperationException("Not yet implemented");
//frame = new JFrame();
//JPanel board = new JPanel();
//board.setLayout(new GridLayout(row,column));
int[][] cell = new int[row][column];
//JButton[][] cellButton = new JButton[row][column];
/*for (int i = 0; i < row; i++) {
for (int j = 0; j < column; j++) {
cellButton[i][j].setText("");
}
}*/
Calculation calc = new Calculation(row, column);
bombs = calc.fillBombs(row, column);
cell = calc.fillvalues(bombs);
GUIclass UI = new GUIclass(row, column, cell, bombs);
UI.createUI();
}
}

[Michael Dunn]

mineButton[i][j] = new JButton();
mineButton[i][j].setMargin(new java.awt.Insets(0,0,0,0));//<---add this line

[vaibhav mishra]

Thank you very much for your immediate reply

that did solve the problem
can you explain what I did wrong and what this line did
it would be of great help

Thanks again

[Michael Dunn]

it would be better if you noted on your cross-posts at other sites that you
now have a solution

[Michael Dunn]

> can you explain what I did wrong and what this line did

you didn't actually do anything wrong, it's just how java handles text
when there's insufficient space i.e. button is smaller that its preferredSize.
e.g. if you had a JLabel with "Happy Birthday vaibhav mishra",
and you sized the label to be not too wide, the text might show as Happy Birthd...

with JButtons, sometimes removing the margin works, sometimes reducing the
font size also works, and other times you need to do both - bottom line is it
depends on how small your buttons are

[vaibhav mishra]

got it
Thanks