Shocking code

[Rick Beaver]

Not sure if this will work - but I thought people may find it amusing to see some funny code that people have come across - so I thought I would give it a go with some prize snippets I have encountered. My first one comes from a Servlet...

 
public void doGet(HttpServletRequest request, HttpServletResponse response) {
    doPost(request, response);
}

Anyone else have some interesting examples?

[Gregg Bolinger]

That's not really that strange, is it? I mean, what I have done is:

public abstract class BaseServlet extends HttpServlet {
 
   public void doGet(...) throws ... {
      processRequest(...);
   }
 
   public void doPost(...) throws ... {
      processRequest(...);
   }
 
   public abstract void processRequest(...) throws ...;
  
}

Would you call that Shocking?

[Thomas Paul]

And the problem with this code is what? It is the exact code found on page 25 of the book, Java Servlet Programming" by Jason Hunter.

[Rick Beaver]

Second one - I especially liked this...

  
public boolean checkIfSet() {
    if (isSet) {
        return true;
    } else {
        return false;
    }
}

[Rick Beaver]

Perhaps the first isnt that bad - it just seemed unintuitive to me.

I use the same method as you Gregg - I put my code in a seperate method for both doGet and doPost.

[Gregg Bolinger]

Originally posted by Rick Beaver:
Second one - I especially liked this...

  
public boolean checkIfSet() {
    if (isSet) {
        return true;
    } else {
        return false;
    }
}

The method and variable names are strange, but the work being done isn't that strange. If isSet is private you'd still need a method to check it's boolean state, would you not?

So I am assuming you just mean the variable and method names are odd. If that is the case, then yes, very. However, you aren't really shocking anyone yet. I've seen a lot worse.

[Rick Beaver]

Originally posted by Gregg Bolinger:

  
public boolean checkIfSet() {
    if (isSet) {
        return true;
    } else {
        return false;
    }
}

The method and variable names are strange, but the work being done isn't that strange. If isSet is private you'd still need a method to check it's boolean state, would you not?

So I am assuming you just mean the variable and method names are odd. If that is the case, then yes, very. However, you aren't really shocking anyone yet. I've seen a lot worse.[/QB]

---

</blockquote>

My point is that this method could be just

public boolean checkIfSet() {
    return isSet;
}
 

So perhaps my examples are poor? Oh well, I was just trying to perhaps get a smile.

Maybe you could post some examples that are more amusing?

[Gregg Bolinger]

Originally posted by Rick Beaver:
Oh well, I was just trying to perhaps get a smile.

Well, you've acomplished that at least. Now stop fooling around and go answer my latest thread in JSF.
[ June 01, 2005: Message edited by: Gregg Bolinger ]

[Ernest Friedman-Hill]

The best source for examples of unbelievably bad code is here. You can waste hours there and have a good laugh.
[ June 01, 2005: Message edited by: Ernest Friedman-Hill ]

[Michael Ernest]

For a 'well-known' code example that probably looks pretty strange at first sight:

public boolean equals(Object obj)
{
   if (this == obj) 
      return true;
   else
      return false;
}

[Gerald Davis]

I see a lot of this type of code in OOP, but sometime it is hard to see, explain or find.