• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

using Boolean objects

 
Dorcas Rebanha
Greenhorn
Posts: 18
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Is the following code correct:



If it's not correct, please provide a correct example. I'm trying to do something very simple, and maybe I'm overthinking it. But I'm not sure how to use a Boolean.

Thank you.
[ December 12, 2008: Message edited by: Dorcas Rebanha ]
 
Henry Wong
author
Marshal
Pie
Posts: 21493
84
C++ Chrome Eclipse IDE Firefox Browser Java jQuery Linux VI Editor Windows
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
The code in this "if" statement...



Will never run -- as a Boolean will never return true, when compared to a string. Perhaps, you meant to do this...



Henry
 
Mike Simmons
Ranch Hand
Posts: 3090
14
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
If you're using JDK 5 or later, then this:

can also be written like this:

However both these bits of code share another problem with your original code above - they all throw a NullPointerException if authorized is null. (And so far, there's been no code shown setting it to anything, so yes, it's probably null.) So when using a Boolean like this, you generally need to either (a) test the reference before you use it, to see if it's null, or (b) write your code in a way that ensures the variable has been set non-null before you use it. However, both of these are somewhat error prone, as people can forget to check or ensure when they modify the code. Consequently I usually prefer to use a boolean primitive rather than a Boolean object - that way there's no possibility of null. Usually that's a good thing, I think.
 
Rob Spoor
Sheriff
Pie
Posts: 20661
65
Chrome Eclipse IDE Java Windows
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
The safest way is the following:

Boolean.TRUE is a constant that represents true as a Boolean; there is also Boolean.FALSE.

By putting it first, and calling equals on it instead of the return value of getAuthorized(), you prevent any NullPointerExceptions (NPEs). It's always best to call equals on a constant like Boolean.TRUE or a String constant just to prevent NPEs:
 
Campbell Ritchie
Sheriff
Pie
Posts: 50175
79
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I would agree with Mike Simmonds; just write if (getAuthorised()) . . .

If you get a NullPointerException, that means there is another error somewhere, that you have forgotten to initialise whatever you were supposed to initialise.
By the way: the preferred naming style for that sort of method is "isAuthorised()".
 
Dorcas Rebanha
Greenhorn
Posts: 18
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks for all the help! You have given me what I needed, and taught me other stuff, too.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic