Catching exception break a loop.

[Lucas Franceschi]

het there.

This:

    public class LineChart extends HttpServlet{

public String BuildChart(HashMap params, HashMap dados){
Object dado = params.get("Imagem_Altura");
Integer Imagem_Altura = ((Integer)dado).intValue();

dado = params.get("Imagem_Largura");
Integer Imagem_Largura = ((Integer)dado).intValue();

dado = params.get("Grafico_Titulo");
String Grafico_titulo = (String)dado;

dado = params.get("Grafico_Legenda");
Boolean Grafico_legenda = (Boolean)dado;

dado = params.get("Grafico_Tooltips");
Boolean Grafico_tooltips = (Boolean)dado;

dado = params.get("Grafico_Urls");
Boolean Grafico_urls = (Boolean)dado;

dado = params.get("Mostra_Margem_A");
Boolean Mostra_Margem_A = (Boolean)dado;

dado = params.get("Mostra_Margem_B");
Boolean Mostra_Margem_B = (Boolean)dado;

dado = params.get("Mostra_Margem_C");
Boolean Mostra_Margem_C = (Boolean)dado;

dado = params.get("Mostra_Margem_D");
Boolean Mostra_Margem_D = (Boolean)dado;
 
dado = params.get("Mostra_Margem_E");
Boolean Mostra_Margem_E = (Boolean)dado;
 
dado = params.get("app_path");
String app_path = (String)dado;

ArrayList MesPorDado = new ArrayList();
for (int q = 1; q <= 12; q++){
MesPorDado.add(q);
}
Collection dados_collection = dados.values();
ArrayList[] dados_array = (ArrayList[]) dados_collection.toArray(new ArrayList[0]);
for (int x = 0; x < dados.size(); x++){
ArrayList Valor = dados_array[x];
BigDecimal mes = (BigDecimal) Valor.get(5);
Integer Posicao = mes.intValue();
Posicao--;
MesPorDado.set(Posicao, x);
}
System.out.println(MesPorDado);
for(int i = 0; i < dados.size(); i++){
try{
Collection series = dados.values();
Integer Indice = (Integer) MesPorDado.get(i);
ArrayList[] array = (ArrayList[]) series.toArray(new ArrayList[0]);
ArrayList Valor = array[Indice];
BigDecimal Soma_MargemA = (BigDecimal) Valor.get(0);
BigDecimal Soma_MargemB = (BigDecimal) Valor.get(1);
BigDecimal Soma_MargemC = (BigDecimal) Valor.get(2);
BigDecimal Soma_MargemD = (BigDecimal) Valor.get(3);
BigDecimal Soma_MargemE = (BigDecimal) Valor.get(4);
BigDecimal bigDecimalCatega = (BigDecimal) Valor.get(5);
Integer Catega = bigDecimalCatega.intValue();
String Mes = "";
switch(Catega){
case 1:
Mes = "JAN";
break;
case 2:
Mes = "FEV";
break;
case 3:
Mes = "MAR";
break;
case 4:
Mes = "ABR";
break;
case 5: 
Mes = "MAI";
break;
case 6: 
Mes = "JUN";
break;
case 7:
Mes = "JUL";
break;
case 8:
Mes = "AGO";d
break;
case 9:
Mes = "SET";
break;
case 10:
Mes = "OUT";
break;
case 11:
Mes = "NOV";
break;
case 12:
Mes = "DEZ";
}
if (Mostra_Margem_A)
dataset.addValue(Soma_MargemA, "Margem A", Mes);
if (Mostra_Margem_B)
dataset.addValue(Soma_MargemB, "Margem B", Mes);
if (Mostra_Margem_C)
dataset.addValue(Soma_MargemC, "Margem C", Mes);
if (Mostra_Margem_D)
dataset.addValue(Soma_MargemD, "Margem D", Mes);
if (Mostra_Margem_E)
dataset.addValue(Soma_MargemE, "Margem E", Mes);
}
catch(ArrayIndexOutOfBoundsException aiobe)
{
aiobe.printStackTrace();
}

}
JFreeChart chart = ChartFactory.createLineChart(
Grafico_titulo,
"Meses",
"",
dataset,
PlotOrientation.VERTICAL,
Grafico_legenda,
Grafico_tooltips,
Grafico_urls
);
app_path = app_path.trim();
System.out.println(app_path+"WEB-INF\\reports\\images\\"+Grafico_titulo.trim()+System.currentTimeMillis()+".png");
File Arquivo = new File(app_path+"WEB-INF\\reports\\images\\"+Grafico_titulo.trim()+System.currentTimeMillis()+".png");
try {
ImageIO.write( chart.createBufferedImage(Imagem_Largura, Imagem_Altura), "PNG", Arquivo);
} catch (java.io.IOException ioe) {
ioe.printStackTrace();
System.exit(-1);
} catch (NullPointerException npe) {
npe.printStackTrace();
System.exit(-1);
} catch (IllegalArgumentException iae) {
iae.printStackTrace();
System.exit(-1);
} finally {
System.out.println("Imagem gerada com sucesso!");
return (Arquivo.getPath());
}

}
}

is my code.

the problem is that this:

   for(int i = 0; i < dados.size(); i++){
try{
Collection series = dados.values();
Integer Indice = (Integer) MesPorDado.get(i);
ArrayList[] array = (ArrayList[]) series.toArray(new ArrayList[0]);
ArrayList Valor = array[Indice];
BigDecimal Soma_MargemA = (BigDecimal) Valor.get(0);
BigDecimal Soma_MargemB = (BigDecimal) Valor.get(1);
BigDecimal Soma_MargemC = (BigDecimal) Valor.get(2);
BigDecimal Soma_MargemD = (BigDecimal) Valor.get(3);
BigDecimal Soma_MargemE = (BigDecimal) Valor.get(4);
BigDecimal bigDecimalCatega = (BigDecimal) Valor.get(5);
Integer Catega = bigDecimalCatega.intValue();
String Mes = "";
switch(Catega){
case 1:
Mes = "JAN";
break;
case 2:
Mes = "FEV";
break;
case 3:
Mes = "MAR";
break;
case 4:
Mes = "ABR";
break;
case 5: 
Mes = "MAI";
break;
case 6: 
Mes = "JUN";
break;
case 7:
Mes = "JUL";
break;
case 8:
Mes = "AGO";d
break;
case 9:
Mes = "SET";
break;
case 10:
Mes = "OUT";
break;
case 11:
Mes = "NOV";
break;
case 12:
Mes = "DEZ";
}
if (Mostra_Margem_A)
dataset.addValue(Soma_MargemA, "Margem A", Mes);
if (Mostra_Margem_B)
dataset.addValue(Soma_MargemB, "Margem B", Mes);
if (Mostra_Margem_C)
dataset.addValue(Soma_MargemC, "Margem C", Mes);
if (Mostra_Margem_D)
dataset.addValue(Soma_MargemD, "Margem D", Mes);
if (Mostra_Margem_E)
dataset.addValue(Soma_MargemE, "Margem E", Mes);
}
catch(ArrayIndexOutOfBoundsException aiobe)
{
aiobe.printStackTrace();
}

} 

loop is getting me like this:

the reason is that, when system throws the "ArrayIndexOutOfBoundsException", it just print the StackTrace, and SHOULD continue the loop normally.

but....

it doesn't.

when the system gets the ArrayIndexOutOfBoundsException, the loop(for) break; the next itens (in the array) aren't even handled by the program..


anyone knows if there is a problem in catching an exception inside a loop?

[Campbell Ritchie]

Welcome to JavaRanch

Difficult to understand this problem, but I think you are making things far too complicated.

Where are you getting the out of bounds exception? You ought not to catch such an unchecked Exception at all, but find out why it occurring and prevent it. You have two for loops which appear correctly formed, so they ought not to throw exceptions.
You are creating an ArrayList[] which looks strange; an ArrayList ought to be parameterised (ArrayList<Foo> ) and you ought not to create an array of parameterised objects. It is however easy to create a List<List<Foo>>.

Why are you using a switch (which ought to have 12 "break;" statements, please, not 11)?
You can set up the Mes variable much more easily like this

private static final String[] Mesas = {"Jan", "Fev", "Mar", "Abr", "Mai", "Jun", "Jul", "Ago", "Set", "Out", "Nov", "Dez"};
. . .
Mes = Mesas[Catega - 1];

Your populating your data from a pair of HashMaps looks very complicated. What you are passing doesn't look like a typical use for a Map, but an object in its own right.

public String buildChart(ChartData data)
{
   int imagemAltura = data.getAltura();
   int imagemLargessa = data.getLargessa();
   String graficoTitulo = data.getGraficoTitulo();
 . . .
 . . .
}

I don't understand where you get the ArrayLists from, but that looks like something which ought to be a field of the ChartData object too.

This ChartData object will be very large!

Your 5 Soma numbers and the number for the month look like values which ought to be in their own object too.

I can't see just looking at your code why you are losing the loop. I suspect the Exception occurs because you are trying to get 6 objects out of an ArrayList which doesn't contain 6 objects, but you should be able to work that out from the stack trace. Are you sure it is the ArrayIndexOutOfBoundsException causing the trouble; you have two catches (NullPointer and IllegalArgument) which you ought not to use, but include System.exit(-1) and your catch (IOException) also includes an exit call.
[ November 10, 2008: Message edited by: Campbell Ritchie ]

[Lucas Franceschi]

Originally posted by Campbell Ritchie:
Welcome to JavaRanch

Difficult to understand this problem, but I think you are making things far too complicated.

Where are you getting the out of bounds exception? You ought not to catch such an unchecked Exception at all, but find out why it occurring and prevent it. You have two for loops which appear correctly formed, so they ought not to throw exceptions.
You are creating an ArrayList[] which looks strange; an ArrayList ought to be parameterised (ArrayList<Foo> and you ought not to create an array of parameterised objects. It is however easy to create a List<List<Foo>>.

Why are you using a switch (which ought to have 12 "break;" statements, please, not 11)?
You can set up the Mes variable much more easily like this

private static final String[] Mesas = {"Jan", "Fev", "Mar", "Abr", "Mai", "Jun", "Jul", "Ago", "Set", "Out", "Nov", "Dez"};
. . .
Mes = Mesas[Catega - 1];

Your populating your data from a pair of HashMaps looks very complicated. What you are passing doesn't look like a typical use for a Map, but an object in its own right.

public String buildChart(ChartData data)
{
   int imagemAltura = data.getAltura();
   int imagemLargessa = data.getLargessa();
   String graficoTitulo = data.getGraficoTitulo();
 . . .
 . . .
}

I don't understand where you get the ArrayLists from, but that looks like something which ought to be a field of the ChartData object too.

This ChartData object will be very large!

Your 5 Soma numbers and the number for the month look like values which ought to be in their own object too.

I can't see just looking at your code why you are losing the loop. I suspect the Exception occurs because you are trying to get 6 objects out of an ArrayList which doesn't contain 6 objects, but you should be able to work that out from the stack trace. Are you sure it is the ArrayIndexOutOfBoundsException causing the trouble; you have two catches (NullPointer and IllegalArgument) which you ought not to use, but include System.exit(-1) and your catch (IOException) also includes an exit call.

ok! that 12 cases really (no, i mean, Really.) made me feel like a newbie in java (actually i am.)
but!

my real problem is not solved yet.
I still getting off the loop when i get the exception.

and i've been using this forum for years, i just have never registered...
and the i'm brazillian, so the name of the variables and some comments may be in portuguese.

[Campbell Ritchie]

I wondered about the language; I thought it wasn't Italian.

I don't know why you are not repeating the loop, unless it is a different Exception. Sorry.

Anybody else?

[Martijn Verburg]

I just ran the code myself (guessing what params would be) and it ran without error. Which line is actually causing the ArrayOutofBounds? As Campbell suggests you should not really just catch this exception and continue, it is important to solve the root cause.

[Rodrigo Tomita]

Lucas,

the reason is that, when system throws the "ArrayIndexOutOfBoundsException", it just print the StackTrace, and SHOULD continue the loop normally.

but....

it doesn't.

Actually it should continue the for loop - and probably, it does . Try something like the following and you will see:

for (int i = 0; i < 10; i++) {
    try {
        System.out.println(i);
        if (i == 5) {
            throw new Exception();
        }
    } catch (Exception e) {
        System.out.println("Exception");
    }
}

I would suggest you to insert some println() statements in your code in order to check exactly when the exception is happening (or better yet if you have an IDE with a debugger).

Good luck.

[Lucas Franceschi]

actually. i've already debugged the code, and the line that trows the exception is

  
for(int i = 0; i < dados.size(); i++){
try{
Collection series = dados.values();
Integer Indice = (Integer) MesPorDado.get(i);
ArrayList[] array = (ArrayList[]) series.toArray(new ArrayList[0]);
ArrayList Valor = array[Indice];

this last row:

  ArrayList Valor = array[Indice];  

martijn,
the exception is trown with one specific case in the params structure, it's also why i'm trying to solve this without changing the root cause of this.

the root cause come from the parameters structure, but this params come from a database that cannot be changed, as the name suggests i only need to create a LineChart, only manipulating the data, not changing it on the database.

that's also why i need to pass through this exception just ignoring that line presence, there would be another ways to pass throguht this exception, but i'm afraid I would have to change a lot of other classes, such as the structure of this one.

[Lucas Franceschi]

oh, and thanks for all of you guys, i appreciate the help.

[Joanne Neal]

The only way I can see for the loop not to continue when the exception is thrown is if the exception is thrown on the last iteration through the loop. Check the value of 'i' when the exception is thrown and compare it to dados.size().

[Lucas Franceschi]

Problem Solved. Thank you for the help People!

because I know you ranchers are curious, I will tell you what was the problem:

looks like the loop was stopping because there were no other value to go for!

I was going throught MesPorDado just as if I was in dados, and that was my problem.

he only thing I did to solve this, was having some sleep, drinking a coffee and doing something else. that helped me thinking off the problem, and then I just saw that it was right in front of my eyes...

I do appreciate that you take your time to help. it was a great difference in solving this one.

i'm sorry if my horrible english, or my javaranch newbieness was bad, but I try to do what I can.

so i insist to say, do not waste your time with this anymore, it is ALREADY SOLVED. and save your time for those who really need.

thank you all for helping.

[Campbell Ritchie]

Success! Well done.

[Lucas Franceschi]

yes, thanks for the help.