Which is Model and Controller in this example?

Ranch Hand

Posts: 37

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi, I am new to struts2. I have followed an example from www.roseindia.net.
my code goes here.

Login.java code goes here (action class)

import com.opensymphony.xwork2.ActionSupport;
import java.util.Date;

/**
 * Validate a user login. 
 */
public class Login extends ActionSupport {

public String execute() throws Exception {
        System.out.println("Validating login");
if(!getUsername().equals("good") || !getPassword().equals("good")){
            addActionError("Invalid user name or password! Please try again!");
            return ERROR;
}else{
  return SUCCESS;
  }
}

// ---- Username property ----
 
 /**
 * Field to store User username.
 * 
 */
 private String username = null;

/**
 * Provide User username.
 *
 * @return Returns the User username.
 */
 public String getUsername() {
 return username;
 }
 
 /**
 * Store new User username
 *
 * @param value The username to set.
 */
 public void setUsername(String value) {
 username = value;
 }
 
 // ---- Username property ----
 
 /**
 * Field to store User password.
 * 
 */
 private String password = null;

/**
 * Provide User password.
 *
 * @return Returns the User password.
 */
 public String getPassword() {
 return password;
 }
 
 /**
 * Store new User password
 *
 * @param value The password to set.
 */
 public void setPassword(String value) {
 password = value;
 }
 
}

action mapping is done in struts.xml code goes here:

I know that jsp is used for view-purpose. Now, i wanted to make out which is Model and controlloer in my above example.

Can any one please help me??

Regards,

Thanks & Regards,
Author

David Newton

Author

Posts: 12617

I like...

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

The controller proper is the Struts 2 filter. Struts 2 actions can act as both a model and "sub-controller". Note that the MVC pattern is a term that's somewhat abused in the web development world and the boundaries between layers aren't always as clear as they are in a pure MVC design.

As an aside, note that your comments have lead to a documentation error--the // ---- Username comment is made twice. Also, the tags around the first sentence in JavaDoc comments are redundant, and make it harder to read. It's also arguable that the name of the method is in itself enough documentation. Lastly, a string's default value is already null; setting it explicitly is redundant.

Consider instead simplifying the source:

It's half the size, easier to read, and produces essentially the same JavaDoc output: simple setters and getters that perform no other function other than setting and getting values don't really need any other documentation other than their name. IMO essentially no information has been lost, and it's half the size.
[ December 23, 2008: Message edited by: David Newton ]

It is no measure of health to be well adjusted to a profoundly sick society. -Krishnamurti Tiny ad:

free, earth-friendly heat - a kickstarter for putting coin in your pocket while saving the earth

https://coderanch.com/t/751654/free-earth-friendly-heat-kickstarter