Help please-Exception thrown by the execute method

[sree visu]

I don't understand why i get a classcastException when i cast the ActionForm.
I am a newbie to structs and hence i have given all my code except ce
Here is my code

    
package com.cff.controller;
public class LoginAction extends Action{
    LoginService loginServices=null;
    String scrName=null;
    @Override
 public ActionForward execute(ActionMapping mapping, ActionForm form,
                               HttpServletRequest request,
                               HttpServletResponse response) {
  
    ServletContext context = getServlet().getServletContext();
    
    // Use Struts actions to record business processing errors.
    ActionErrors errors = new ActionErrors();
    // Store this set in the request scope, in case we need to
    // send the ErrorPage view.
    saveErrors(request, errors);

    try {

      // Create a session object
      HttpSession session = request.getSession();
      loginServices=new LoginService();
      // Cast the action form to an application-specific form

/* ---------------------I get a ClassCastException here------------------------------------*/
      LoginForm myForm = (LoginForm) form;                         */-------------------------------------------------------Please see here -----------------ClassCastException is thrown here----------------------------*/
/*----------------------------------------------------------------------------------------------*/
      // Business logic to get from database
      scrName=loginServices.getLoginServices(myForm.getUser(), myForm.getPass());
      
      try{
          if(scrName.length()==0){
             
            return mapping.findForward("error");
          }
          else{
               session.setAttribute("scrName", scrName);
              // Dispatch to Success view
                 return mapping.findForward("success");
          }
      }catch(Exception e){
          return mapping.findForward("error");
      }
     
      // Store the item on the session-scope
     

    // Handle any unexpected expections
    } catch (RuntimeException e) {

      // Log stack trace
      context.log("An unexpected error: ", e);

      // Record the error
      errors.add(ActionErrors.GLOBAL_ERROR,
                 new ActionError("error.unexpectedError",
                                 e.getMessage()));

      // and forward to the error handling page 
      return mapping.findForward("error");
    }
  }
}

Here is my LoginForm.java

   public class LoginForm extends ActionForm {

  private  String user = null;
    private String pass = null;
    
    public LoginForm(String user,String pass){
        this.user=null;
        this.pass=null;
    }
    public LoginForm(){}
    public String getPass() {
        return pass;
    }

    public void setPass(String pass) {
        this.pass = pass;
    }

    public String getUser() {
        return user;
    }

    public void setUser(String user) {
        this.user = user;
    }
/**
 * 
 * @param mapping
 * @param request
 * @return
 */
   
    @Override
    public ActionErrors validate(ActionMapping mapping,
            HttpServletRequest request) {
        ActionErrors errors = new ActionErrors();
               //Form verification done already using JavaScript  for 
               //user friendliness at client side
              return errors;
    }
    public void Reset(ActionMapping mapping,HttpServletRequest request){
        user=null;
        pass=null;
    }
}
 

Here is my page where i redirect to this Action Class

I have just added the <form> tag alone

 <form action="loginform.do" name="loginPage" method=post>                   
<td class="row1"> <table   border="0"  >
     <tbody>
       <tr> 
         <td  > </td>
       </tr>
       <tr> 
         <td  ><span >Login name:</span></td>
         <td><input type="text" name="user" size="25" value="${param.user}"maxlength="40" /> 
         </td>
       </tr>
       <tr> 
         <td ><span>Password:</span></td>
         <td><input type="password" name="pass" size="25" maxlength="25" /> 
         </td>
       </tr>
       <tr > 
         <td ><span class="gen"> </span> <input type="submit" name="login" value="Login" /> 
         </td>
       </tr>
       <tr > 
         <td  > <a >New 
           User</a> | <a >Forgot Password</a> 
         </td>
       </tr>
     </tbody>
   </table></td>


</form>		    

Here is my Web.xml

  <?xml version="1.0" encoding="UTF-8"?>
<web-app version="2.5" xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd">
    <servlet>
        <servlet-name>action</servlet-name>
        <servlet-class>org.apache.struts.action.ActionServlet</servlet-class>
        <init-param>
            <param-name>config</param-name>
            <param-value>/WEB-INF/struts-config.xml</param-value>
        </init-param>
        <init-param>
            <param-name>debug</param-name>
            <param-value>2</param-value>
        </init-param>
        <init-param>
            <param-name>detail</param-name>
            <param-value>2</param-value>
        </init-param>
        <load-on-startup>2</load-on-startup>
        </servlet>
  
    <servlet-mapping>
        <servlet-name>action</servlet-name>
        <url-pattern>*.do</url-pattern>
    </servlet-mapping>
    
    <session-config>
        <session-timeout>
            30
        </session-timeout>
    </session-config>
    <welcome-file-list>
        <welcome-file>index.jsp</welcome-file>
        </welcome-file-list>
    <jsp-config>
        <taglib>
            <taglib-uri>/WEB-INF/struts-bean.tld</taglib-uri>
            <taglib-location>/WEB-INF/struts-bean.tld</taglib-location>
        </taglib>
        <taglib>
            <taglib-uri>/WEB-INF/struts-html.tld</taglib-uri>
            <taglib-location>/WEB-INF/struts-html.tld</taglib-location>
        </taglib>
        <taglib>
            <taglib-uri>/WEB-INF/struts-logic.tld</taglib-uri>
            <taglib-location>/WEB-INF/struts-logic.tld</taglib-location>
        </taglib>
        <taglib>
            <taglib-uri>/WEB-INF/struts-nested.tld</taglib-uri>
            <taglib-location>/WEB-INF/struts-nested.tld</taglib-location>
        </taglib>
        <taglib>
            <taglib-uri>/WEB-INF/struts-tiles.tld</taglib-uri>
            <taglib-location>/WEB-INF/struts-tiles.tld</taglib-location>
        </taglib>
        </jsp-config>
//database connectivity
    <resource-ref>
        <res-ref-name>jdbc/gadgets</res-ref-name>
        <res-type>javax.sql.DataSource</res-type>
        <res-auth>Container</res-auth>
        <res-sharing-scope>Shareable</res-sharing-scope>
    </resource-ref>
    </web-app>  

Here is my structs-config.xml

<?xml version="1.0" encoding="UTF-8" ?>

<!DOCTYPE struts-config PUBLIC
          "-//Apache Software Foundation//DTD Struts Configuration 1.2//EN"
          "http://jakarta.apache.org/struts/dtds/struts-config_1_2.dtd">


<struts-config>
    <form-beans>
        <form-bean name="Login" 
        type="com.cff.model.Login"/>
    </form-beans> 
    
    
    <global-exceptions>
    
    </global-exceptions>

    <global-forwards>
        <forward name="welcome"  path="/Welcome.do"/>
    </global-forwards>

    <action-mappings>
        <action path="/loginform"  
                type="com.cff.controller.LoginAction"
                name="Login" scope="request" validate="true"
                input="/lostpassword.jsp">
                    <forward name="sucess" path="/index.jsp"/>
                    <forward name="error" path="/lostpassword.jsp"/>
                    </action>
    </action-mappings>
    
    <controller processorClass="org.apache.struts.tiles.TilesRequestProcessor"/>

    <message-resources parameter="com/myapp/struts/ApplicationResource"/>    
    
    <!-- ========================= Tiles plugin ===============================-->
    <!--
    This plugin initialize Tiles definition factory. This later can takes some
    parameters explained here after. The plugin first read parameters from
    web.xml, thenoverload them with parameters defined here. All parameters
    are optional.
    The plugin should be declared in each struts-config file.
    - definitions-config: (optional)
    Specify configuration file names. There can be several comma
    separated file names (default: ?? )
    - moduleAware: (optional - struts1.1)
    Specify if the Tiles definition factory is module aware. If true
    (default), there will be one factory for each Struts module.
    If false, there will be one common factory for all module. In this
    later case, it is still needed to declare one plugin per module.
    The factory will be initialized with parameters found in the first
    initialized plugin (generally the one associated with the default
    module).
    true : One factory per module. (default)
    false : one single shared factory for all modules
    - definitions-parser-validate: (optional)
    Specify if xml parser should validate the Tiles configuration file.
    true : validate. DTD should be specified in file header (default)
    false : no validation

    Paths found in Tiles definitions are relative to the main context.
    -->
    <plug-in className="org.apache.struts.tiles.TilesPlugin" >
        <set-property property="definitions-config" value="/WEB-INF/tiles-defs.xml" />      
        <set-property property="moduleAware" value="true" />
    </plug-in>
    
    <!-- ========================= Validator plugin ================================= -->
    <plug-in className="org.apache.struts.validator.ValidatorPlugIn">
        <set-property
            property="pathnames"
            value="/WEB-INF/validator-rules.xml,/WEB-INF/validation.xml"/>
    </plug-in>
  
</struts-config>

[David Newton]

Why aren't you using the Struts form tags?

[sree visu]

This is because i have completely checked for errors at the client side using java script and have validated it.I am using structs to make a the front controller so that the redirection could be easy.So i have not used the validate method too

[David Newton]

Do you access the form page through an action?

(btw, your "reset" method is named "Reset", which probably won't work.)