Spring/Hibernate/Jboss/JTA/getCurrentSession()/createQuery is not valid without active transaction

[Santosh Ramachandrula]

I am working on JTA with Hibernate getCurrentSession(), I am using spring--> AOP transactions.

Dao class where the exception is ocurring.

 Query query = sessionFactory.getCurrentSession().createQuery("from " + clazz.getName()); 

I am injecting sessionFactory into Dao* implementations. When I do Code inspection on sessionFactory in AbstractCRUDDao, transactionManager is null

What are the configuration/code changes that I need to do to get this to work? Following is the error that I am getting

  14:39:09,203 INFO  [STDOUT] 14:39:09,078 ERROR AbstractCRUDDao:127 - ERROR
org.hibernate.HibernateException: createQuery is not valid without active transaction
	at org.hibernate.context.ThreadLocalSessionContext$TransactionProtectionWrapper.invoke(ThreadLocalSessionContext.java:338)
	at $Proxy118.createQuery(Unknown Source)
	at com.santosh.model.dao.AbstractCRUDDao.findAll(AbstractCRUDDao.java:114)
	at com.santosh.model.dao.PersonDao.findAll(PersonDao.java:16)
	at com.santosh.delegate.PersonDelegate.findAll(PersonDelegate.java:30)
	at com.santosh.action.PersonAction.loadAllPerson(PersonAction.java:69)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 

Following is the applicationContext.xml

 
	<bean id="dataSource"
		class="org.springframework.jdbc.datasource.DriverManagerDataSource">
		<property name="driverClassName" value="org.apache.derby.jdbc.ClientDriver"></property>
		<property name="url" value="jdbc:derby://localhost:1527/firstdb;"></property>
	</bean>
	<bean id="sessionFactory"
		class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
		<property name="dataSource" ref="dataSource" />
		<property name="mappingResources">
			<list>
				<value>com/santosh/model/Person.hbm.xml</value>
				<value>com/santosh/model/Event.hbm.xml</value>
				<value>com/santosh/model/Speaker.hbm.xml</value>
			</list>
		</property>
		<property name="hibernateProperties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.DerbyDialect</prop>
				<prop key="hibernate.current_session_context_class">thread</prop>
			</props>
		</property>
	</bean>	
	<bean id="abstractCrudDao" class="com.santosh.model.dao.AbstractCRUDDao" abstract="true">
		<property name="sessionFactory" ref="sessionFactory" />
	</bean>
	<bean id="speakerDao" class="com.santosh.model.dao.SpeakerDao" parent="abstractCrudDao"></bean>
	<bean id="eventDao" class="com.santosh.model.dao.EventDao" parent="abstractCrudDao"></bean>
	<bean id="personDao" class="com.santosh.model.dao.PersonDao" parent="abstractCrudDao"></bean>	
	<bean id="personDelegate" class="com.santosh.delegate.PersonDelegate" >
		<property name="personDao" ref="personDao" />
	</bean>
	<bean id="com.santosh.action.PersonActionSpring" class="com.santosh.action.PersonAction"  scope="prototype">
	<property name="personDelegate" ref="personDelegate" />
	</bean>

	<bean id="transactionManager"
		class="org.springframework.transaction.jta.JtaTransactionManager">
		<property name="userTransactionName" value="java:comp/UserTransaction" />
		<property name="transactionManagerName" value="java:/TransactionManager" />
  </bean>	
 <tx:advice id="txAdvice">
    <tx:attributes>
  	 	<tx:method name="*find*" propagation="REQUIRED" read-only="true"/>
  	 	<tx:method name="*" propagation="REQUIRED" read-only="false"/>
  	 </tx:attributes>
  </tx:advice>  
  <aop:config>
  	<aop:advisor pointcut="execution(* *Dao*.*(..))" advice-ref="txAdvice" />
  </aop:config>
 

[Seamus Minogue]

Santosh,

This is from my appContext file which works. Thought it might help you out

<bean id="hibernateTemplate" class="org.springframework.orm.hibernate3.HibernateTemplate">
		<property name="sessionFactory">
			<ref bean="sessionFactory" />
		</property>
	</bean>


<bean id="RoleDao" class="RoleDao">

		<property name="hibernateTemplate">

			<ref bean="hibernateTemplate" />

		</property>

	</bean>

And then my RoleDao class extends org.springframework.orm.hibernate3.support.HibernateDaoSupport;



Other than that my context is pretty much the same as yours.


Although, now that I look at it I dont do things like

   Query query = sessionFactory.getCurrentSession().createQuery("from " + clazz.getName());   

I get the session from the HibernateDaoSupport class. Take a look at the API
http://static.springframework.org/spring/docs/1.2.x/api/org/springframework/orm/hibernate/support/HibernateDaoSupport.html


example:

getHibernateTemplate.getSession()

Hope that helps

[Santosh Ramachandrula]

Seamus, Thanks for your reply. I got past the above error with following configuration in my applicationContext.xml

<property name="jtaTransactionManager">
            <bean factory-bean="transactionManager" factory-method="getTransactionManager"/>
        </property>

Now I am getting following error

   18:49:17,703 INFO  [STDOUT] 18:49:17,687 ERROR AbstractCRUDDao:127 - ERROR
org.hibernate.TransactionException: could not register synchronization
	at org.hibernate.transaction.JTATransaction.registerSynchronization(JTATransaction.java:316)
	at org.hibernate.context.ThreadLocalSessionContext.currentSession(ThreadLocalSessionContext.java:105)
	at org.hibernate.impl.SessionFactoryImpl.getCurrentSession(SessionFactoryImpl.java:574)
	at com.santosh.model.dao.AbstractCRUDDao.findAll(AbstractCRUDDao.java:114) 

I did some google and made the following changes to configurations but still it does not work as of now.

  <prop key="hibernate.transaction.factory_class">org.hibernate.transaction.JTATransactionFactory</prop>
				<prop key="hibernate.transaction.manager_lookup_class">org.hibernate.transaction.JBossTransactionManagerLookup</prop>  

[Santosh Ramachandrula]

Seamus, Is your DAO handling transactions at method level using HibernateTemplate? Can you please post your DAO code if you can?

[Seamus Minogue]

Santosh,

Actually transaction handling is being done at the service level. The reason being:

My service may call multiple DAO's and if any of them throw and error I want to rollback the transaction. Here is my DAO:

public class BaseDaoImpl extends HibernateDaoSupport {

	/*
	 * (non-Javadoc)
	 * 
	 * @see com.s120.joshua.dao.BaseDao#save(com.s120.joshua.dao.Entity)
	 */
	public void save(Entity transientInstance) throws Exception {

		try {

			getHibernateTemplate().save(transientInstance);

		} catch (RuntimeException re) {

			throw re;
		}
	}
}

And here is the snippet from my applicationContext which does the transaction stuff:

<!--
		the transactional advice (i.e. what 'happens'; see the <aop:advisor/>
		bean below)
	-->
	<tx:advice id="txAdvice" transaction-manager="transactionManager">
		<!-- the transactional semantics... -->
		<tx:attributes>
			<!-- all methods starting with 'get' are read-only -->
			<tx:method name="save*" propagation="REQUIRES_NEW"
				rollback-for="Exception,HibernateException,MessagingException"
				read-only="false" />
			<tx:method name="delete*" propagation="REQUIRES_NEW"
				rollback-for="Exception,HibernateException,MessagingException"
				read-only="false" />
			<tx:method name="*" propagation="SUPPORTS" />
		</tx:attributes>
	</tx:advice>


<!-- Black Magic Begins Here...All Hail Rom-Ram -->
	<aop:config>
		<aop:pointcut id="baseServiceOperation"
			expression="execution(* com.s120.joshua.services.BaseService.*(..))" />
		<aop:advisor advice-ref="txAdvice" pointcut-ref="baseServiceOperation" />
	</aop:config>

Hope that helps.

[Santosh Ramachandrula]

Following configuration worked for me(got some help from Spring forum). With Spring JTA/Jboss5.0/Hibernate3.2

Issue in my configuration was AOP decleration and I had to comment out this piece of code

  <!--<prop key="hibernate.current_session_context_class">thread</prop>-->  

Configuration that worked for me

 	 <bean id="txManager" class="org.springframework.transaction.jta.JtaTransactionManager">
        <property name="transactionManagerName" value="java:/TransactionManager"/>
        <property name="userTransactionName" value="UserTransaction"/>
    </bean>
 
 <tx:advice id="txAdvice" transaction-manager="txManager">
    <tx:attributes>
  	 	<tx:method name="*find*" propagation="REQUIRED" read-only="true"/>
  	 	<tx:method name="*" propagation="REQUIRED" read-only="false"/>
  	 </tx:attributes>
  </tx:advice>
  
  <aop:config>
  	<aop:advisor pointcut="execution(* com.santosh.delegate.PersonDelegate.*(..))" advice-ref="txAdvice" />
  </aop:config>   

With this

   <prop key="hibernate.current_session_context_class">thread</prop> 

I was getting following exception

  org.hibernate.HibernateException: createQuery is not valid without active transaction
	at org.hibernate.context.ThreadLocalSessionContext$TransactionProtectionWrapper.invoke(ThreadLocalSessionContext.java:338)
	at $Proxy118.createQuery(Unknown Source)