Forum:

Struts

How to find method in Sturts

Ranch Hand

Posts: 32

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

HI,
Can any one tell me how to find that if the method is of type 'post' or not.
I want to know this because i made a simple login page in sturts . It's working fine but the problem is that when i submits the form it stores the old values in the textfields , even when i restart tomcat and runs application very first time it was still displaying the old value in the fields.

Sagar Rohankar

Ranch Hand

Posts: 2908

I like...

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Pradeeep Sharma wrote:HI,
Can any one tell me how to find that if the method is of type 'post' or not.

HttpServletRequest#getMethod()

Pradeeep Sharma wrote:
I want to know this because i made a simple login page in sturts . It's working fine but the problem is that when i submits the form it stores the old values in the textfields , even when i restart tomcat and runs application very first time it was still displaying the old value in the fields.

That's a weird problem, If you restart the tomcat all the values, whatever may be the scope, will destroy..

Had you hard coded the login values in your JSP code ? Please post your Login.jsp and Login action class.

[LEARNING bLOG] | [Freelance Web Designer] | [and "Rohan" is part of my surname]

Pradeeep Sharma

Ranch Hand

Posts: 32

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

/-----------------------------------register.jsp--------------------------------------------------------/
<%@ page language="java" import="java.util.*" pageEncoding="ISO-8859-1"%>
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html"%>
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
<%
String path = request.getContextPath();
String basePath = request.getScheme()+"://"+request.getServerName()+":"+request.getServerPort()+path+"/";
%>
<% String strShowError="";  %>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
	<head>
		<base href="<%=basePath%>" >

<title>My JSP 'register.jsp' starting page</title>

</head>

<body><br>
	<html:form action="/registerUser">
		<table border="0"    >
 			<tr>
 				<td  >Registration Form
 				</td>
 				
 			</tr>
 			<tr>
 			<td   class="text">
 			<table border="0"   >
 			<tr>
 				
 				<td  >User Name
 				</td>
 				<td ><html:text property="txtUserName" ></html:text>
 				</td>
 				
 			</tr>
 			<tr>
 				<td >Password
 				</td>
 				<td><html:password property="txtPassword" redisplay="false"></html:password>
 				</td>
 				
 			</tr>
 			<tr>
 				
 				<td >Confirm Password
 				</td>
 				<td><html:password property="txtCfmPassword" redisplay="false"></html:password>
 				</td>
 				
 			</tr>
 			<tr>
 				
 				<td>
 				</td>
 				<td ><html:submit></html:submit>
 				</td>
 			</tr>
 			</table>
 			</td >
 			<td class="text"    >
 				${registerUserForm.strShowError}
 			</td>
 			</tr>
 			
 		</table>
  </html:form>
		<html:link page="/index.do">Sign in</html:link>
	</body>
</html>
/-----------------------------------register.jsp--------------------------------------------------------/

/-----------------------------------registerAction.java--------------------------------------------------------/

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package com.demo.struts.action;
import java.sql.*;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import com.demo.struts.form.RegisterUserForm;
import com.demo.struts.model.RegisterUser;

/** 
 * MyEclipse Struts
 * Creation date: 02-06-2009
 * 
 * XDoclet definition:
 * @struts.action path="/demo" name="demoForm" input="/form/demo.jsp" scope="request" validate="true"
 */
public class RegisterUserAction extends Action {
	/*
	 * Generated Methods
	 */
    String userName;
    String password;
    String cfmPassword;
	String strStatus;
	String error;
	String strReceivedError;
    RegisterUser objRgUser;
    RegisterUserForm objRgUserForm;
    
    public ActionForward execute(ActionMapping mapping, ActionForm form,                           
			HttpServletRequest request, HttpServletResponse response)throws Exception {
    	
    	objRgUserForm=(RegisterUserForm)form;
    	objRgUser=new RegisterUser();
    	//objRgUserForm=new RegisterUserForm();
    	userName=objRgUserForm.getTxtUserName();
    	password=objRgUserForm.getTxtPassword();
    	cfmPassword=objRgUserForm.getTxtCfmPassword();
    	strReceivedError=objRgUser.registerUser(userName, password, cfmPassword,error);                                                     
    	((RegisterUserForm) objRgUserForm).setStrShowError(strReceivedError);
		return mapping.findForward("Success");
	}
}

/-----------------------------------registerAction.java--------------------------------------------------------/
No, i never hardcoded these values, it might be taking from setter and getter methods. As u asked i have posted the view and controller pages, please check tham and let me know the solution.

With regards
Pradeep

Sagar Rohankar

Ranch Hand

Posts: 2908

I like...

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Where you faced the problem, in login page or in registration page.. Also some doubts,

the XDoclet shows, action path as :

But in register.jsp the action path is:

[LEARNING bLOG] | [Freelance Web Designer] | [and "Rohan" is part of my surname]

Pradeeep Sharma

Ranch Hand

Posts: 32

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I am facing problem in both forms . Below i am pasting the struts-config.xml for register page...

Sagar Rohankar

Ranch Hand

Posts: 2908

I like...

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Code looks fine or may be I'm missing something.. Still, just want some modification ,

Defining instance variables for action class is considered as bad practice, they might store the variables values for the next request fot the same action class. To know more about, search Struts action class instance variables
So make them local,

public class RegisterUserAction extends Action {
	/*
	 * Generated Methods
	 */
    String userName; // Why this instance varibale, make them local
    String password;
    String cfmPassword;
	String strStatus;
	String error;
	String strReceivedError;
    RegisterUser objRgUser;
    RegisterUserForm objRgUserForm;
    
    public ActionForward execute(ActionMapping mapping, ActionForm form,                           
			HttpServletRequest request, HttpServletResponse response)throws Exception {
    	
    	objRgUserForm=(RegisterUserForm)form;
    	objRgUser=new RegisterUser();
    	//objRgUserForm=new RegisterUserForm();
    	userName=objRgUserForm.getTxtUserName();
    	password=objRgUserForm.getTxtPassword();
    	cfmPassword=objRgUserForm.getTxtCfmPassword();
    	strReceivedError=objRgUser.registerUser(userName, password, cfmPassword,error);                                                     
    	((RegisterUserForm) objRgUserForm).setStrShowError(strReceivedError);
		return mapping.findForward("Success");
	}
}

try this.

[LEARNING bLOG] | [Freelance Web Designer] | [and "Rohan" is part of my surname]

Pradeeep Sharma

Ranch Hand

Posts: 32

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi,
Yup this is working now, by making instance variables local. Thanks for the help.
But i have confusion now that , the action class is called only when i submit the form, that means the action class's variables(weather they are instance or local) should be defined and initialized only when the class is called, then why the Form was showing the old values even when the page was opened for the first time.

Sagar Rohankar

Ranch Hand

Posts: 2908

I like...

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Pradeeep Sharma wrote:Hi,
Yup this is working now, by making instance variables local. Thanks for the help.

You're welcome

Pradeeep Sharma wrote:
But i have confusion now that , the action class is called only when i submit the form, that means the action class's variables(weather they are instance or local) should be defined and initialized only when the class is called,

Yes, you are right, for the very first request, Servlet container (server) creates and initialized the instance variables, and for the any sub sequent request for the same action, server uses thread of that class to serve. And I told you, you can have many resources to discussed this on web.

Pradeeep Sharma wrote:
then why the Form was showing the old values even when the page was opened for the first time.

That's where I'm confused, coz you said I restarted the server, and still you have those previous sessioned values, are you serializing/persisting this values some where

else Its magic

[LEARNING bLOG] | [Freelance Web Designer] | [and "Rohan" is part of my surname]

Pradeeep Sharma

Ranch Hand

Posts: 32

posted 16 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

No, i was not doing anything else the code i posted.

With a little knowledge, a cast iron skillet is non-stick and lasts a lifetime.