Need help with Mini Telephone Directoy program please

[Alex Reynders]

Hi guys,

I please need your help with a few issues that I have with this Mini Telephone Directory program.

Firstly I would like to know if is it possible to convert a TreeMap into an array?

The reason why I'm asking this is because I've used a TreeMap to store the names(as keys) and the numbers(as values),

According to my assignment specs I have to: " * Use a JTable inside a JScrollPane to show all the name-number pairs. "

I've created a new class called myTable and this is what it looks like so far:

   
class myTable extends JFrame {
    
    TelephoneDirectory td2 = new TelephoneDirectory();
    
    int l = td2.tm.size();  

    
    public myTable() {
        super("Phonebook Entries");
        setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
        String columnNames[] = {"Name and Surname", "Phone Number"};
        Object rows[][] = new Object[l][2];
        
        JTable table = new JTable(rows, columnNames);
        JScrollPane scrollPane = new JScrollPane(table);
        
        setContentPane(scrollPane);
        
        String[] strArray1 = new String[l];
        
        
        String[] strArray2 = new String[l];
       
        
        for(int i = 0; i < l; i++) {
            rows[i][0] = strArray1[i];
            rows[i][1] = strArray2[i];
        }
        
        table = new JTable(rows, columnNames);
        scrollPane.getViewport().add(table);
        
        setVisible(true);
        pack();
    }
}

I'm not sure if what I've done so far is correct as well as what code I should add at line 21 and line 24, could you please help me out on this one?

Here is all my code I did so far for this program:

 
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.WindowEvent;
import java.awt.event.WindowListener;
import java.util.ArrayList;
import java.util.TreeMap;
import javax.swing.*;

public class TelephoneDirectory extends JFrame implements ActionListener {
    
    JLabel nameLabel, numberLabel, messageLabel, seperator;
    
    JButton addButton, modButton, retrieveButton, removeButton, clearButton, viewButton;
    
    JTextField nameText, numberText;
    
    String name, number;
    
    TreeMap<String, String> tm = new TreeMap<String, String>();
    
    boolean inputValid;
    boolean addValid;
    
    String regex1 = "[A-Z][a-z]+\\s[A-Z][a-z]+\\s*";
    String regex2 =  "[A-Z][a-z]+\\s[a-z]+\\s[A-Z][a-z]+\\s*";
    String regex3 =  "[A-Z][a-z]+\\s[a-z]+\\s[A-Z][a-z]+\\s*";
    String regex4 = "[0-9]{3}.[0-9]{3}.[0-9]{4}+\\s*";
    
    public TelephoneDirectory() {
        super("Mini Telephone Book");
        
        setLayout(new FlowLayout());
        
        nameLabel = new JLabel("        Name and Surname :       ");
        add(nameLabel);
        nameLabel.setToolTipText("Name and surname must be in the format: e.g.  Johnny Bravo");
        nameText = new JTextField(15);
        add(nameText);
        nameText.setToolTipText("Name and surname must be in the format: e.g.  Johnny Bravo");
        numberLabel = new JLabel("  Phone Number : ");
        add(numberLabel);
        numberLabel.setToolTipText("Number must be in the format: e.g.  905 123 3456");
        numberText = new JTextField(15);
        add(numberText);
        numberText.setToolTipText("Number must be in the format: e.g.  905 123 3456");
        addButton = new JButton("ADD ENTRY");
        add(addButton);
        removeButton = new JButton("REMOVE ENTRY");
        add(removeButton);
        retrieveButton = new JButton("RETRIEVE NUMBER");
        add(retrieveButton);
        viewButton = new JButton("VIEW ALL ENTRIES");
        add(viewButton);
        clearButton = new JButton("CLEAR TEXTFIELDS");
        add(clearButton);
        seperator = new JLabel("*----------------------------------------------------------*");
        add(seperator);
        messageLabel = new JLabel("");
        add(messageLabel);
        seperator = new JLabel("*----------------------------------------------------*");
        add(seperator);
        
        nameText.addActionListener(this);
        numberText.addActionListener(this);
        addButton.addActionListener(this);
        viewButton.addActionListener(this);
        retrieveButton.addActionListener(this);
        removeButton.addActionListener(this);
        clearButton.addActionListener(this);
        
        
        addWindowListener(new WindowListener(){
            public void windowClosed(WindowEvent arg0) {
                System.out.println("Window close event occured");
            }
            public void windowActivated(WindowEvent arg0) {
                System.out.println("Window Activated");
            }
            public void windowClosing(WindowEvent arg0) {
                try {
                    Object[] options = {"Yes", "Minimize", "Cancel"};
                    int a = JOptionPane.showOptionDialog(
                        null, "WARNING! - All data will be lost when exiting this program?", "Select an option", 
                        JOptionPane.YES_NO_CANCEL_OPTION, JOptionPane.WARNING_MESSAGE, null, options, options[0]);
                        if(a == JOptionPane.YES_OPTION) {
                            setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                        }
                        if(a == JOptionPane.NO_OPTION) {
                            setDefaultCloseOperation(JFrame.ICONIFIED);
                        }
                        if(a== JOptionPane.CANCEL_OPTION) {
                            setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
                        }
                }catch(Exception e) {
                    JOptionPane.showMessageDialog(null,"Error Occured");
                    }
            }
            public void windowDeactivated(WindowEvent arg0) {
                System.out.println("Window Deactivated");
            }
            public void windowDeiconified(WindowEvent arg0) {
                System.out.println("Window Deiconified");
            }
            public void windowIconified(WindowEvent arg0) {
                System.out.println("Window Iconified");
            }
            public void windowOpened(WindowEvent arg0) {
                System.out.println("Window Opened");
            }
        });
        
        
    }
    
    
    boolean checkInput() throws InputIncorrectException {
        if(!name.matches(regex1) && !name.matches(regex2) && !name.matches(regex3)) {
            inputValid = false;
            throw new InputIncorrectException();
        } else {
            name = nameText.getText();
            inputValid = true;
        }
        return inputValid;
    }
    
    
    boolean checkInput2() throws InputIncorrectException {
        if(!number.matches(regex4)) {
            inputValid = false;
            throw new InputIncorrectException();
        } else {
            number = numberText.getText();
            inputValid = true;
        }
        return inputValid;
    }
    
    
    boolean addValid() throws InputIncorrectException {
		checkInput();
		checkInput2();
		if(inputValid = false) {
			addValid = false;
		} else {
			addValid = true;
		}
		return addValid;
	}
    
    public void actionPerformed(ActionEvent ae) {
        
            name = nameText.getText();
            if(ae.getSource().equals(nameText)) {
                    try {
                            checkInput();
                            name = nameText.getText();
                            messageLabel.setText("Correct input");
                    } catch (InputIncorrectException iie) {
                        messageLabel.setText("Name-Surname must be e.g. Johnny Bravo");
                    }
            }
        
        
            number = numberText.getText();
            if(ae.getSource().equals(numberText)) {
                try {
                        checkInput2();
                        number = numberText.getText();
                        messageLabel.setText("Correct input");
                } catch (InputIncorrectException iie) {
                    messageLabel.setText("Number must be e.g. 905 123 3456");
                }
            }
        
        
            if(ae.getSource().equals(addButton)) {
				name = nameText.getText();
				number = numberText.getText();
				try {
					addValid();
					if(!addValid) {
						messageLabel.setText("Could not add contact - Incorrect format!");
					} else {
						if(!tm.containsKey(name)) {
							tm.put(name, number);
							messageLabel.setText("Contact added.");
						} else {
							messageLabel.setText("Already contains the entry " + nameText.getText() +  " !");
						} 
						if (name.equals("") || number.equals("")) {
							messageLabel.setText("Check that the fields are not empty!");
						}
					}
				} catch (Exception e) {
				    messageLabel.setText("Could not add contact - Incorrect format!");
				  }
			}
            
            
            if(ae.getSource().equals(removeButton)) {
                name = nameText.getText();
                number = numberText.getText();
                try {
                    if(!tm.containsValue(number)) {   
                        messageLabel.setText("Cannot remove entry - First retrieve number!");
                    } else {
                        if(tm.containsKey(name)) {
                        tm.remove(name);
                        clearAll();
                        messageLabel.setText("Contact has been removed.");
                    } else {
                        messageLabel.setText("Does not contain entry " + nameText.getText() +  " !");
                    }
                    }
                } catch (Exception e) {}
            }
            
            
            if(ae.getSource().equals(retrieveButton)) {
                name = nameText.getText();
                number = numberText.getText();
                try {
                    if(tm.containsKey(name)) {
                        name = nameText.getText();
                        String a = tm.get(name);
                        numberText.setText(a);
                        messageLabel.setText(nameText.getText() + " 's number is: " + a);
                    } else {
                        messageLabel.setText("Entry " + nameText.getText() +  " does not exist!");
                    }
                } catch (Exception e) {}
            }
            
            
            if(ae.getSource().equals(viewButton)){
                new myTable();
            }
            
            
            
            if(ae.getSource().equals(clearButton)) {
              clearAll();
            }
    }
    
    
    void clearAll() {
        nameText.setText("");
        numberText.setText("");
        messageLabel.setText("");
    }
    
    
    public static void main(String[] args) {
        TelephoneDirectory td = new TelephoneDirectory();
        td.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        td.setSize(265, 335);
        td.setVisible(true);
    }
    
}


class InputIncorrectException extends Exception {}


class myTable extends JFrame {
    
    TelephoneDirectory td2 = new TelephoneDirectory();
    
    int l = td2.tm.size();  

    
    public myTable() {
        super("Phonebook Entries");
        setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
        String columnNames[] = {"Name and Surname", "Phone Number"};
        Object rows[][] = new Object[l][2];
        
        JTable table = new JTable(rows, columnNames);
        JScrollPane scrollPane = new JScrollPane(table);
        
        setContentPane(scrollPane);
        
        String[] strArray1 = new String[l];
        
        
        String[] strArray2 = new String[l];
        
        
        for(int i = 0; i < l; i++) {
            rows[i][0] = strArray1[i];
            rows[i][1] = strArray2[i];
        }
        
        table = new JTable(rows, columnNames);
        scrollPane.getViewport().add(table);
        
        setVisible(true);
        pack();
    }
}

Thank you very much

P.S. - Any other hints or tips are also welcome

Regards

[Campbell Ritchie]

Please be careful with long lines; they fall off the edge of the screen. I had to add a newline to avoid left-and-right scrolling.

TreeMap implements the Map interface and the Map interface has a method which puts all the Entries into a Set and you can change a Set to an array . . .
Do you need a TreeMap? Is the sorting necessary to your application? If not, can you use a HashMap instead?

JTables are usually discussed in the Swing forum, so I shall have to move you there.

[Alex Reynders]

Please be careful with long lines; they fall off the edge of the screen.
I had to add a newline to avoid left-and-right scrolling.

Sorry Campbell Ritchie it won't happen again. Thanks for mentioning it.

Well I think it will look better in the JTable when all the entries are sorted, but don't think it is really necessary...

If I use HashMap how will this change things? Please explain...

Thanks.

[Tony Docherty]

If I use HashMap how will this change things? Please explain...

It won't change things are far as your problem is concerned. The reason Campbell mentioned a HashMap is it is more efficient than a TreeMap (particularly for large data sets) and so unless ordering is important it is better to use a HashMap. The get, put, containsKey type methods run in constant time in a HashMap and log(n) time in a TreeMap.

In your case, unless performance becomes a real issue, I'd use a TreeMap because as you say displaying sorted data looks better than displaying random entries.

[Alex Reynders]

Tony Docherty, thanks for the reply.

Well performance isn't going to be an issue here because its only a small assignment
I have to do so there isn't a large data set in this case.

How would you deal with this problem and how can I change this code
so that the entries that were added will be shown in the JTable?

Could you please give some examples or some help to overcome this problem that I have.

Thanks.

[Tony Docherty]

Campbell has outlined one way. Another is to create a 2D array where one dimension is 2 and the other is the size of the Map and then iterate over the Map's keys and fill the array with each of the keys and it's associated value as you go.

[Michael Dunn]

personally, I think you're over-complicating it.

some things to consider:
1) you're only after name and number, so just use the JTable's model.
2) JTable also has a built in rowSorter (java 1.6+)
3) a JFormattedTextField might be better than your JTextField/regex checking/error generation
4) use a better layout manager for TelephoneDirectory() - check what happens when the frame is dragged wider/leaner
5) clean up windowClosing - get rid of minimize, and the only code there should be to exit on 'YES', meaning the frame
should be set to DO_NOTHING_ON_CLOSE initially