Compiling Struts from CMD.

[Vickey singh Verma]

Hello everyone, I have a struts actionform code shown below. I'm unable to figure out the errors. Please help me out.


----------------------------------------------------------------------------------

   
package struts1;

import java.io.IOException;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionForward;


public class LookupAction extends Action
{
protected Double getQuote(String symbol)
{
if(symbol.equalsignoreCase("SUNW"))
{
return new Double(25.00);
}

return null;
}

public ActionForward execute(ActionMapping mapping, ActionForm

form,HttpServletRequest request,HttpServletResponse response) throws

IOException,ServletException
{
Double prie=null;
String target=new String("success");

if(form!=null)
{
LookupForm lookupForm=(LookupForm)form;
String symbol =lookupFrom.getSymbol();
price=getQoute(symbol);
}

if(price==null)
{
target=new String("failure");
}
else
{
request.setAttribute("PRICE",price);
}

return(mapping.findForwad(target));

}
}


cmd o/p






C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\webapps\struts1>javac LookupAction.
java -classpath "C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\common\lib\servlet
-api.jar"
LookupAction.java:7: package org.apache.struts.action does not exist
import org.apache.struts.action.Action;
^
LookupAction.java:8: package org.apache.struts.action does not exist
import org.apache.struts.action.ActionForm;
^
LookupAction.java:9: package org.apache.struts.action does not exist
import org.apache.struts.action.ActionMapping;
^
LookupAction.java:10: package org.apache.struts.action does not exist
import org.apache.struts.action.ActionForward;
^
LookupAction.java:13: cannot find symbol
symbol: class Action
public class LookupAction extends Action
^
LookupAction.java:25: cannot find symbol
symbol : class ActionMapping
location: class struts1.LookupAction
public ActionForward execute(ActionMapping mapping, ActionForm form,HttpServle
tRequest request,HttpServletResponse response) throws IOException,ServletExcep
tion
^
LookupAction.java:25: cannot find symbol
symbol : class ActionForm
location: class struts1.LookupAction
public ActionForward execute(ActionMapping mapping, ActionForm form,HttpServle
tRequest request,HttpServletResponse response) throws IOException,ServletExcep
tion
^
LookupAction.java:25: cannot find symbol
symbol : class ActionForward
location: class struts1.LookupAction
public ActionForward execute(ActionMapping mapping, ActionForm form,HttpServle
tRequest request,HttpServletResponse response) throws IOException,ServletExcep
tion
^
LookupAction.java:17: cannot find symbol
symbol : method equalsignoreCase(java.lang.String)
location: class java.lang.String
if(symbol.equalsignoreCase("SUNW"))
^
LookupAction.java:32: cannot find symbol
symbol : class LookupForm
location: class struts1.LookupAction
LookupForm lookupForm=(LookupForm)form;
^
LookupAction.java:32: cannot find symbol
symbol : class LookupForm
location: class struts1.LookupAction
LookupForm lookupForm=(LookupForm)form;
^
LookupAction.java:33: cannot find symbol
symbol : variable lookupFrom
location: class struts1.LookupAction
String symbol =lookupFrom.getSymbol();
^
LookupAction.java:34: cannot find symbol
symbol : variable price
location: class struts1.LookupAction
price=getQoute(symbol);
^
LookupAction.java:34: cannot find symbol
symbol : method getQoute(java.lang.String)
location: class struts1.LookupAction
price=getQoute(symbol);
^
LookupAction.java:37: cannot find symbol
symbol : variable price
location: class struts1.LookupAction
if(price==null)
^
LookupAction.java:43: cannot find symbol
symbol : variable price
location: class struts1.LookupAction
request.setAttribute("PRICE",price);
^
16 errors

--------------------------------------------------------------------------------------
How can I include the package org.apache.action.....
where is it present, I have already pasted the struts lib in the WEB-INF/lib folder.

[Sagar Rohankar]

The problem is in the way you're compiling,

 C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\webapps\struts1>javac LookupAction.java -classpath "C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\common\lib\servlet-api.jar"   

Look out the "-classpath" flag, It's position is wrong.
Correct one,

 C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\webapps\struts1>javac -classpath "C:\apache-tomcat-5.5.27\apache-tomcat-5.5.27\common\lib\servlet-api.jar" LookupAction.java    

And are you sure, its enough to pass "servlet-api.jar" file only, I think it will need struts.jar, too

[David Newton]

In addition, there's a large number of typos, all of which are reported in the compile errors. Are you not using an IDE to write the code?

public class LookupAction extends Action {  
    protected Double getQuote(String symbol) {  
        if (symbol.equalsIgnoreCase("SUNW")) {  // TYPO
            return 25.00; // AUTOBOXING
        }  
        return null;  
    }  
  
    public ActionForward execute(ActionMapping mapping, 
                                 ActionForm form,
                                 HttpServletRequest request,
                                 HttpServletResponse response) 
                         throws IOException,ServletException {  
        Double price = null;  // TYPO
        String target = "success";  // MISCONCENPTION
  
        if (form != null) {  
            LookupForm lookupForm = (LookupForm) form;  
            String symbol = lookupForm.getSymbol();  // TYPO
            price = getQuote(symbol);  // TYPO
        }  
  
        if (price == null) {  
            target = "failure";  // MISCONCEPTION
        } else {  
            request.setAttribute("PRICE", price);  
        }  
  
        return mapping.findForward(target);  // TYPO
    }  
}

Note that while you *may* have intended it to behave this way, if the form is null, you'll end up on the "success" forward, which seems wrong given the rest of the code. Those aside... if the form itself is null then Struts itself is likely broken--you *can* check for a null form but I'm not entirely sure it's necessary. Personally, I'd write you logic something closer to this:

public ActionForward execute(ActionMapping mapping, 
                             ActionForm form,
                             HttpServletRequest request,
                             HttpServletResponse response) 
                     throws IOException,ServletException {  
    if (form == null) {
        return mapping.findForward("failure");
    }
    
    LookupForm lookupForm = (LookupForm) form;  
    price = getQuote(lookupForm.getSymbol());
    
    if (price == null) {
        return mapping.findForward("failure");
    }

    request.setAttribute("PRICE", price);  
    return mapping.findForward("success"));
}  

I don't have a problem with multiple return points in short methods, especially when it's very clear and linear like it is here. It's also clear how null forms will be handled, whereas the original version had to be read completely to the end of the function to know what would happen (and even then I had to scan back to the top to see what "target" was set to).

You also need to make sure *your* classes are available on the compilation classpath (for example, one of the compiler messages was about a missing LookupForm class).