Best Practice where to write return statement?

[Amandeep Singh]

   1. public String hello(){  
   2. try{  
   3.   
   4.   
   5.  return string;  
   6. }  
   7. catch(){  
   8.   
   9. }  
  10.   
  11.   
  12.   
  13. }  

what is the best practice, should i use return statement inside try ?

   1. public String hello(){  
   2. try{  
   3.   
   4.   
   5.   
   6. }  
   7. catch(){  
   8.   
   9. }  
  10.  return string;  
  11. }  

or
what is the best practice, should i use return statement after catch ?

Please don't consider finally block in my example.

[Piyush Porwal]

From what I have read in the books, a try..catch block should consists of minimal code which can throw an exception. So if return is not expected to throw any exception, it should be outside of the try block. If you are doing something funky in the return like as simple as

return new Dog()

then move it out only when you do not expect Dog constructor to throw an exception or if you do not want to catch it.

[Martijn Verburg]

Piyush Porwal wrote:From what I have read in the books, a try..catch block should consists of minimal code which can throw an exception. So if return is not expected to throw any exception, it should be outside of the try block. If you are doing something funky in the return like as simple as

return new Dog()

then move it out only when you do not expect Dog constructor to throw an exception or if you do not want to catch it.

A great answer in my opinion , I've seen too many times where people simply wrap the entire code block in try/catch, not always necessary!

[Amandeep Singh]

oh Yah I am returning a String. So it will never throw a exception. So it should be outside try and catch block. Great Answer. Thanks