text field validation

[Deeps Mistry]

Hi,

I am using struts 1.1 .

I have 5 columns(Product Description Nett Price (W/o Tax) Quantity UOM Nett Weight ) and 10 rows in my table. I am generating the text boxes using DynaActionForm and <logic:iterate>

I want to validate the columns as follows:
If i enter anything in Product Description, then the remaining columns must not be empty.

I have tried the following but the problem with it is that it is validating only the first row.

struts-config.xml:

  <form-bean name="purchaseOrderBeanForm" type="org.apache.struts.action.DynaActionForm">
     		<form-property name="lines" type="ActionForm.AddPOBean[]" size="10" />
</form-bean>  

AddPOBean:

public class AddPOBean {
	
	private String pod = null;
	private String pon = null;
	private String poq = null;
	private String uom1 = null;
	private String nweigth = null;
	private String ponumber = null;
	private String custName = null;
	private String b2b = null;
	private String taxrate = null;
	
	
	
	
	public String getCustName() {
		return custName;
	}
	public void setCustName(String custName) {
		this.custName = custName;
	}
	public String getB2b() {
		return b2b;
	}
	public void setB2b(String b2b) {
		this.b2b = b2b;
	}
	public String getTaxrate() {
		return taxrate;
	}
	public void setTaxrate(String taxrate) {
		this.taxrate = taxrate;
	}
	public String getPonumber() {
		return ponumber;
	}
	public void setPonumber(String ponumber) {
		this.ponumber = ponumber;
	}
	public String getNweigth() {
		return nweigth;
	}
	public void setNweigth(String nweigth) {
		this.nweigth = nweigth;
	}
	public String getPod() {
		return pod;
	}
	public void setPod(String pod) {
		this.pod = pod;
	}
	public String getPon() {
		return pon;
	}
	public void setPon(String pon) {
		this.pon = pon;
	}
	public String getPoq() {
		return poq;
	}
	public void setPoq(String poq) {
		this.poq = poq;
	}
	public String getUom1() {
		return uom1;
	}
	public void setUom1(String uom1) {
		this.uom1 = uom1;
	}

}
 
   

jsp:

 
 <tr>
                    <td >S/No.</td>
                    <td  > Product Description</td>
                    <td >Nett Price (W/o Tax)</td>
                    <td > Quantity</td>
                    <td >UOM</td>
                    <td ><html:select property="UOM" onchange="changeValue(this.value);">
						<html:option value="nos."></html:option>
						<html:option value="kg"></html:option>                    
                    </html:select></td>
                    <td  > Nett  Weight</td>
                   </tr>

</tr>
                    <% int i = 1; %>
                	<logic:iterate id="lines" name="purchaseOrderBeanForm" property="lines">
					  <tr>
					  <td><%=i %></td>
					  <td ><html:text indexed="true" name="lines" property="pod" styleId="pod"/></td>
					  <td ><html:text indexed="true" name="lines" property="pon" styleId="pon" size="10"/></td>
					  <td ><html:text indexed="true" name="lines" property="poq" size="7" styleId="poq"/></td>
					  <td></td>
					  <td><html:text indexed="true" name="lines" property="uom1" size="4" value="nos." styleId="uom"/></td>
					  <td ><html:text indexed="true" name="lines" property="nweigth" size="6" styleId="nwt"/></td>
					  </tr>
					   <% i++; %>
					</logic:iterate>
                  	 <tr>
<html:submit value="Save" onclick="return submitForm();"/>

function submitForm()
{

	if(document.getElementById('pono').value == "")
	{
		alert('Please enter P.O.No./verbal')
		return false;
	}
	else if(document.getElementById('pono').value != "" && document.getElementById('pod').value == "")
	{
		alert('Please enter Product Description')
		return false;
	}
	else if(document.getElementById('pono').value != "" && document.getElementById('pon').value == "")
	{
		alert('Please enter Nett Price')
		return false;
	}
	
	else if(document.getElementById('pono').value != "" && document.getElementById('poq').value == "")
	{
		alert('Please enter Quantity')
		return false;
	}
	
	else if(document.getElementById('pono').value != "" && document.getElementById('uom').value == "")
	{
		alert('Please enter UOM')
		return false;
	}
	
	else if(document.getElementById('b2b').value == "select")
	{
		alert('Please select Delivery Bond-to-Bond')
		return false;
	}
	
	else if(document.getElementById('b2b').value == "No" && document.getElementById('taxrate').value == "select")
	{
		alert('Please select Tax Rate')
		return false;
	}
	else
	{
		document.form.submit();
	}
}
   

generated html code:

   
<tr>
                    <td >S/No.</td>
                    <td  > Product Description</td>
                    <td >Nett Price (W/o Tax)</td>
                    <td > Quantity</td>
                    <td >UOM</td>
                    <td ><select name="UOM" onchange="changeValue(this.value);"><option value="nos." selected="selected">nos.</option>
						<option value="kg">kg</option></select></td>
                    <td  > Nett  Weight</td>
                   </tr>
                    
                	
					  <tr>
					  <td>1</td>
					  <td ><input type="text" name="lines[0].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[0].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[0].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[0].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[0].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>2</td>
					  <td ><input type="text" name="lines[1].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[1].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[1].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[1].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[1].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>3</td>
					  <td ><input type="text" name="lines[2].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[2].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[2].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[2].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[2].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>4</td>
					  <td ><input type="text" name="lines[3].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[3].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[3].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[3].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[3].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>5</td>
					  <td ><input type="text" name="lines[4].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[4].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[4].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[4].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[4].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>6</td>
					  <td ><input type="text" name="lines[5].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[5].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[5].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[5].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[5].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>7</td>
					  <td ><input type="text" name="lines[6].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[6].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[6].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[6].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[6].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>8</td>
					  <td ><input type="text" name="lines[7].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[7].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[7].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[7].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[7].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>9</td>
					  <td ><input type="text" name="lines[8].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[8].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[8].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[8].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[8].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
					
					  <tr>
					  <td>10</td>
					  <td ><input type="text" name="lines[9].pod" value="" id="pod"></td>
					  <td ><input type="text" name="lines[9].pon" size="10" value="" id="pon"></td>
					  <td ><input type="text" name="lines[9].poq" size="7" value="" id="poq"></td>
					  <td></td>
					  <td><input type="text" name="lines[9].uom1" size="4" value="nos." id="uom"></td>
					  <td ><input type="text" name="lines[9].nweigth" size="6" value="" id="nwt"></td>
					  </tr>
					   
 

What should i do?
Thanks

[Eric Pascarello]

ids are singular. You can not have multiple elements with the same id.

Also you will have to loop through each row of elements and check it. One general if statement will not cover all of the elements.

Eric