Minimum Value and Sum of Values in Array

[Joe Saunders]

For whatever reason, the for loop can find the maximum value of the randomly generated array O.K., but when it tries to find the minimum or sum the array it is wrong.
Any help is appreciated! I've been working on this for days though it should be easy enough...
Thanks in advanced.

    
import hsa.Console;
import java.io.*;
import java.awt.*;

public class RandomArray

{
    static Console c;
    public static void main (String[] args)
    
    {
        c = new Console ();
        int option;
       
        do
        {
            //menu
            c.println("1. Generate Random Numbers and Calculate");
            c.println("2. Exit");
            option = c.readInt();
        
            if (option == 1)
            {
                generatenumbers();
            }
        }
        while (option != 2);
    }
        
    //Generates 15 randomly generated integers and calculates sum, average, max and min
    public static void generatenumbers ()
        
    {
        long number[] = new long[15], maximum = number[0], sum = 0;
        long minimum = 100;
           
        for (int x=0;x < 15;x++) // assigns random numbers to the array at x
        {
            number[x]= (Math.round(Math.random()*99)+1);
        }
        
        for (int a=0; a < number.length; a++) // calculates maximum and minimum number
        {
            if (number[a] < minimum)
            {
                minimum = number[a];
            }
            else if (number[a] > maximum)
            {
                maximum = number[a];
            }
        }
        
        for (int a=0; a < 15; a++)
        {
            sum = sum + number[a];
        }
        
        c.print("In this array of 15 randomly generated numbers the maxmimum number is " + maximum + " and the minimum number is " + minimum + ". The sum of the numbers is " + sum);

        
        for (int y=0;y < 14;y++) // displays numbers
        {
            c.println(number[y]);
        }
    }
}

[Paul Clapham]

The minimum is wrong? In what way? What did you expect, and what did you get instead? (I can see how the sum is wrong, but it isn't obvious to me why the minimum is wrong.)

[Joe Saunders]

It gives me a value of 0 for the minimum value every time.
Sorry, I put the sum back to "sum = sum + number[a]". I had changed this when trying to get it to work, however even this still doesn't calculate the sum.

[jittu goud]

    for (int x=0;x < 14;x++) // assigns random numbers to the array at x

what is the length of the array --and how many values are you assigining in your loop

[Joe Saunders]

The length of the array is 15 and I'm assigning values for 0-14... ?

[Henry Wong]

Joe Saunders wrote:The length of the array is 15 and I'm assigning values for 0-14... ?

Really?!? Take a look again. You are assigning from 0 to a value that is (<14). Is 14 less than 14?

Henry

[Joe Saunders]

Okay, that makes sense . The minimum value is working now, but the I still get a much too high of a number for the sum.

[jittu goud]

Joe Saunders wrote:Okay, that makes sense . The minimum value is working now, but the I still get a much too high of a number for the sum.

if that made sense ...then sum should have made some sense too

[Joe Saunders]

I'm looking, I don't see the issue... it would make sense I was getting a very large sum if I was accidentally assigning too many values to the array, but from what I see, I'm not..

[Henry Wong]

Well, you have the same issue with sum, as with the other loops -- but that will cause the sum to be slightly too small, not too big (and I assume that you fixed that loop already).

BTW, just how big a value are we talking about here?

Henry

[Rob Spoor]

Henry Wong wrote:BTW, just how big a value are we talking about here?

From 1 to 100 (inclusive), so with only 15 values there should not be any overflow.

Joe, what is the sum you are getting? It should be anywhere between 15 (all ones) and 1500 (all hundreds). Well, after you've fixed your loop condition, otherwise it's between 14 and 1400.

[Joe Saunders]

I understand why it should be < 1500 and > 15 but I get numbers with 5 digits such as 75615, depending on which values are assigned.

[Henry Wong]

Joe Saunders wrote:I understand why it should be < 1500 and > 15 but I get numbers with 5 digits such as 75615, depending on which values are assigned.

Please post your latest code -- as it isn't possible to get what you are describing with your previous code.


Never mind.... I think I figured it out. Hint: is "75615" really the sum? Or is the sum "756"?

Henry

[Joe Saunders]

This is my latest code.

import hsa.Console;
import java.io.*;
import java.awt.*;

public class RandomArray

{
    static Console c;
    public static void main (String[] args)
    
    {
        c = new Console ();
        int option;
       
        do
        {
            //menu
            c.println("1. Generate Random Numbers and Calculate");
            c.println("2. Exit");
            option = c.readInt();
        
            if (option == 1)
            {
                generatenumbers();
            }
        }
        while (option != 2);
    }
        
    //Generates 15 randomly generated integers and calculates sum, average, max and min
    public static void generatenumbers ()
        
    {
        long number[] = new long[15], maximum = number[0], sum = 0;
        long minimum = 100;
           
        for (int x=0;x < 15;x++) // assigns random numbers to the array at x
        {
            number[x]= (Math.round(Math.random()*99)+1);
        }
        
        for (int a=0; a < number.length; a++) // calculates maximum and minimum number
        {
            if (number[a] < minimum)
            {
                minimum = number[a];
            }
            else if (number[a] > maximum)
            {
                maximum = number[a];
            }
        }
        
        for (int a=0; a < 15; a++)
        {
            sum = sum + number[a];
        }
        
        c.print("In this array of 15 randomly generated numbers the maxmimum number is " + maximum + " and the minimum number is " + minimum + ". The sum of the numbers is " + sum);

        
        for (int y=0;y < 14;y++) // displays numbers
        {
            c.println(number[y]);
        }
    }
}

I thought that might be the issue Henry, however it doesn't seem to be that way.

To show... I ran the program and get these numbers:
83, 19, 30, 55, 7, 28, 49, 10, 15, 9, 32, 39, 74
The sum should be 450, however I receive a sum of 53144 from the program.

[Campbell Ritchie]

It worked all right when I tried it.

[Joe Saunders]

That's odd... What would cause you to get the correct value, but for me to get something way too high??

[Paul Clapham]

How many numbers are in that list? (Hint: you have too many magic numbers in your code.)

And why are you printing your results in such a strange way? (Hint: change it to print an exclamation mark after the sum and you'll see why I call it strange.)

[Joe Saunders]

Oh, . Thank you guys.