Spring MVC AOP Logger

[Matt Thomassan]

Hello Ranchers,

I have successfully implemented AOP in a basic (non-MVC) Spring application.

But now I want to implement AOP in Spring MVC.

1) Here is the controller
AddEmployeeSimpleFormController

package com.badal.controller;

import java.util.HashMap;
import java.util.Map;
import javax.servlet.http.HttpServletRequest;
import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
import com.badal.command.Employee;
import com.badal.manager.EmployeeManager;
//import org.apache.log4j.Logger;

public class AddEmployeeSimpleFormController extends SimpleFormController{

	public EmployeeManager employeeManager;
	//static Logger logger=Logger.getLogger(AddEmployeeSimpleFormController.class);

	public void setEmployeeManager(EmployeeManager employeeManager) {
		this.employeeManager = employeeManager;
	}

	private static final String[] desigList = { 
		"manager",
		"trainee",
		"accountant",
		"sales assistant",
		"programmer",
		"architect"
	};
	
	public AddEmployeeSimpleFormController() {
		// TODO Auto-generated constructor stub
		// command class is the POJO associated with the form
		setCommandClass(Employee.class);
		setCommandName("emp");
	}
	
	
		// referenceData method is to give jsp some data before the jsp loads
	@Override
	protected Map referenceData(HttpServletRequest request) throws Exception {
		// TODO Auto-generated method stub
		Map referenceData=new HashMap();
		referenceData.put("desigList", desigList);
		
		
		return referenceData;
	}

	
	protected ModelAndView onSubmit(Object command, BindException bindException) throws Exception{
//		logger.info("From Logger: Before the method");
		Employee employeeCommand=(Employee) command;
		employeeManager.addEmployee(employeeCommand);
		
//		logger.info("From Logger: After the method");
		
		return new ModelAndView("AddEmployeeFormSuccess","employeeCommand",employeeCommand);
	}

}

2) Here is the advisor class i.e. aspects class
LogAspects.java

package com.badal.commons;
import org.apache.log4j.Logger;
import org.aspectj.lang.ProceedingJoinPoint;

public class LogAspects {
static Logger logger=Logger.getLogger(LogAspects.class);

public void beforeMethod(){
	System.out.println("Before onSubmit method...");
	logger.info("Before onSubmit method...");
}

public void afterReturningMethod(){
	System.out.println("After on Submit method...");
	logger.info("After on Submit method...");
}

public void aroundMethod(ProceedingJoinPoint proceedingJoinPoint) throws Throwable{
	System.out.println("Around Before calling method...");
	logger.info("Around Before calling method...");
	proceedingJoinPoint.proceed();
	System.out.println("Around After calling method...");
	logger.info("Around After calling method...");
}

public void afterThrowingMethod(){
	System.out.println("Around throwing method...");
	logger.info("after throwing method...");
}
	
	
}

3) Here is the main XML file:
springmvc-servlet.xml

  <beans xmlns="http://www.springframework.org/schema/beans"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xmlns:aop="http://www.springframework.org/schema/aop"
      xsi:schemaLocation="
http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-2.5.xsd">
  


	<bean id="viewResolver" class="org.springframework.web.servlet.view.InternalResourceViewResolver">
		<property name="prefix" value="/" />
		<property name="suffix" value=".jsp" />
		
	</bean>

<bean name="/addEmployeeSimpleFormController.htm" 
		class="com.badal.controller.AddEmployeeSimpleFormController">
		<property name="employeeManager" ref="employeeManagerBean"/>
		<property name="formView" value="AddEmployeeForm" />
		<property name="successView" value="AddEmployeeFormSuccess"></property>
	</bean>
	
	<bean id="emp" class="com.badal.command.Employee" />

<aop:config>
		<aop:aspect ref="logger">
			<aop:pointcut id="aopPointCut" expression="execution(* *.onSubmit(..))"/> 
			<!-- <aop:pointcut id="aopPointCut" expression="execution(* com.badal.AOPImpl.AOPImpl1.*.*(..))"/>  --> 
			<aop:before method="beforeMethod" pointcut-ref="aopPointCut" />
			<aop:after-returning method="afterReturningMethod" pointcut-ref="aopPointCut" />
			<aop:after-throwing method="afterThrowingMethod" pointcut-ref="aopPointCut" />
			<aop:around method="aroundMethod" pointcut-ref="aopPointCut" /> 
		</aop:aspect>
	</aop:config>

</beans>

The problem is whenever onSubmit() of the controller runs, all the aspects of LogAspects.java are not running.

I am unable to figure out the problem.

Please give me any pointers.

Thank You.

Best Regards

[David Newton]

Where's the aspect bean definition?

[Hong Anderson]

Spring AOP is proxy-based it will not work with onSubmit.

It works only with handleRequest (since version that it's not final).