Just finished my first java program :-) Can you please give me suggestions on making my code better?

[Sebastion Hill]

Hey all, I am pretty excited because I just finished my first program. It's pretty basic but it is the first part of an on going personal project. It runs good and does what I was hoping it would but now I am curious as to which parts I could have done better on.

Just as a background note, I plan on making an application for my android phone. I typically wish that I could have a better planner (cause I am not that great at time management) so I thought I would make an application suited to my needs. This will be based upon the philosophy from guy who wrote 7 successful habits etc., Stephen Covey I think.

Anyways, this is the first part and I plan on making a GUI for this program after I get feedback on ways to improve the code. I broke the arrays into 4 different sections here because I plan on making them color coded in my GUI (e.g. blue for highest priority, maize for second highest, green third, and maybe red for the lowest priority).

But yeah, if anyone wouldn't mind providing feedback on ways that I can improve I would be EXTREMELY grateful. :-) My code is listed below:

    
/**
 * The TestActivity class does ...
 */

//import java.util.Scanner;
//import java.util.ArrayList;
import java.util.*;
import java.text.*;

class TestActivity {

      private ArrayList<Activity> Priority1 = new ArrayList<Activity>();
      private ArrayList<Activity> Priority2 = new ArrayList<Activity>();
      private ArrayList<Activity> Priority3 = new ArrayList<Activity>();
      private ArrayList<Activity> Priority4 = new ArrayList<Activity>();

      //new inner class that implements comparator
      class DateCompare implements Comparator<Activity> {
            public int compare (Activity one, Activity two) {
                   return one.getActivityDueDate().getTime().compareTo(two.getActivityDueDate().getTime());
            }
      }
      
      public static void main (String[] args) {
             TestActivity tester = new TestActivity();
             tester.selectionScreen();    
      }

      public void selectionScreen() {
             //prompt user for input choice
             Scanner reader = new Scanner(System.in);      
             System.out.println("");
             System.out.println("Please choose between one of the following options:"); // Display the string
             System.out.println("1. Create New Activity");
             System.out.println("2. Review Current List of Activities");
             System.out.println("3. Exit");
             System.out.println("");
             System.out.print("Enter number choice here: ");
             int activityChoice = reader.nextInt();
             
             //select choice based on user input
             switch (activityChoice) {
                 case 1: prompt(); break;
                 case 2: checkActivityArray(); break;
                 case 3: System.out.println(""); System.out.println("You selected exit."); System.exit(0);
                 default: System.out.println("You entered an invalid selection."); break;
             }
      }

      public void prompt() {
             //prompt user for input choice
             String activityName;
             String activityDescription;
             int activityImportanceNumber = 0;
             int activityUrgencyNumber = 0;
             boolean activityImportance = false;
             boolean activityUrgency = false;
             Calendar dueDate = Calendar.getInstance();
             
             Scanner reader = new Scanner(System.in);      

             System.out.println("");
             System.out.print("Please enter activity name: "); // Display the string
             activityName = reader.nextLine();
             System.out.print("Please enter activity description: "); // Display the string
             activityDescription = reader.nextLine();

             System.out.print("Enter '1' if this activity is 'Important' or enter '2' if it is not: ");
             try {
             activityImportanceNumber = reader.nextInt();
             } catch (InputMismatchException ex) {
                     System.out.println("You have to enter in a NUMBER aka an integer, not a string!");
                     System.out.println("Start over and try again.");
                     prompt();
             }
             switch (activityImportanceNumber) {
                    case 1: activityImportance = true; break;
                    case 2: activityImportance = false; break;
                    default: System.out.println("You must enter either a 1 or 2"); System.out.println("Start Over"); prompt();
             }

             System.out.print("Enter '1' if this activity is 'Urgent' or enter '2' if it is not: ");
             try {
             activityUrgencyNumber = reader.nextInt();
             } catch (InputMismatchException ex) {
                     System.out.println("You have to enter in a NUMBER aka an integer, not a string!");
                     System.out.println("Start over and try again.");
                     prompt();
             }
             switch (activityUrgencyNumber) {
                    case 1: activityUrgency = true; break;
                    case 2: activityUrgency = false; break;
                    default: System.out.println("You must enter either a 1 or 2"); System.out.println("Start Over"); prompt();
             }

             reader.nextLine();
             //trying it the forum way
             System.out.println("");
             System.out.println("Please enter the due date using the MM/DD/YR HH:mm aa format");
             System.out.println("Example: '05/23/2009 6:05 PM' translates into Sat May 23, 2009 6:05 PM");
             System.out.print("Due Date: ");
             String dateLine = reader.nextLine();

             SimpleDateFormat sdf = new SimpleDateFormat("MM/dd/yyyy hh:mm aa");
             try {
                 Date date = sdf.parse(dateLine);
                 dueDate.setTime(date);
             } catch (ParseException e) {
                 System.out.println("You made an error in the way you entered in the due date. Please try again.");
                 prompt();
             }
             
             //need to take the info from above and create a new activity object 
             Activity testActivity = new Activity();
             testActivity.setActivityName(activityName);
             testActivity.setActivityDescription(activityDescription);
             testActivity.setActivityImportance(activityImportance);
             testActivity.setActivityUrgency(activityUrgency);
             testActivity.setPriorityCode(activityImportance, activityUrgency);
             testActivity.setActivityDueDate(dueDate); 

             //put the activity object into an arraylist of activity objects based on priority level
             int pCode = testActivity.getPriorityCode();
             switch (pCode) {
                    case 3: Priority1.add(testActivity); break;             
                    case 4: Priority2.add(testActivity); break;
                    case 5: Priority3.add(testActivity); break;
                    case 6: Priority4.add(testActivity); break; 
                    default: System.out.println("You did something wrong!"); break;
             }
             
             //go back to the selection screen
             selectionScreen();
      }

      public void checkActivityArray() {
                 
             DateCompare dateCompare = new DateCompare(); //making an instance of the Comparator inner class
             SimpleDateFormat outputFormat = new SimpleDateFormat("EEEE MMMM d, yyyy h:mm aa");

             //going through each priority group and listing out contents IF there is something in them
             if (Priority1.isEmpty()) {
                 System.out.println("");
                 System.out.println("************ Priority Level 1 ************");
                 System.out.println("Priority 1 list is empty.");
                 System.out.println("");
             } else {
                 Collections.sort(Priority1, dateCompare); //invoke sort() and passing list and a reference
                 for (Activity loopCheck : Priority1) {
                 //check to see if the correct info was recorded into the activity just created
                 System.out.println("");
                 System.out.println("************ Priority Level 1 ************");
                 System.out.println("The activity name is: " + loopCheck.getActivityName());
                 System.out.println("The activity description is: " + loopCheck.getActivityDescription());
                 //System.out.println("The activity importance is: " + loopCheck.getActivityImportance());
                 //System.out.println("The activity urgency is: " + loopCheck.getActivityUrgency());
                 //System.out.println("The activity priority number is: " + loopCheck.getPriorityCode());
                 System.out.println("The activity due date is: " + outputFormat.format(loopCheck.getActivityDueDate().getTime()));
                 }
             }

             if (Priority2.isEmpty()) {
                 System.out.println("");
                 System.out.println("************ Priority Level 2 ************");
                 System.out.println("Priority 2 list is empty.");
                 System.out.println("");
             } else {
                 Collections.sort(Priority2, dateCompare); //invoke sort() and passing list and a reference
                 for (Activity loopCheck : Priority2) {
                 //check to see if the correct info was recorded into the activity just created
                 System.out.println("");
                 System.out.println("************ Priority Level 2 ************");
                 System.out.println("The activity name is: " + loopCheck.getActivityName());
                 System.out.println("The activity description is: " + loopCheck.getActivityDescription());
                 //System.out.println("The activity importance is: " + loopCheck.getActivityImportance());
                 //System.out.println("The activity urgency is: " + loopCheck.getActivityUrgency());
                 //System.out.println("The activity priority number is: " + loopCheck.getPriorityCode());
                 System.out.println("The activity due date is: " + outputFormat.format(loopCheck.getActivityDueDate().getTime()));
                 }
             }
             
             if (Priority3.isEmpty()) {
                 System.out.println("");
                 System.out.println("************ Priority Level 3 ************");
                 System.out.println("Priority 3 list is empty.");
                 System.out.println("");
             } else {
                 Collections.sort(Priority3, dateCompare); //invoke sort() and passing list and a reference
                 for (Activity loopCheck : Priority3) {
                 //check to see if the correct info was recorded into the activity just created
                 System.out.println("");
                 System.out.println("************ Priority Level 3 ************");
                 System.out.println("The activity name is: " + loopCheck.getActivityName());
                 System.out.println("The activity description is: " + loopCheck.getActivityDescription());
                 //System.out.println("The activity importance is: " + loopCheck.getActivityImportance());
                 //System.out.println("The activity urgency is: " + loopCheck.getActivityUrgency());
                 //System.out.println("The activity priority number is: " + loopCheck.getPriorityCode());
                 System.out.println("The activity due date is: " + outputFormat.format(loopCheck.getActivityDueDate().getTime()));
                 }
             }             

             if (Priority4.isEmpty()) {
                 System.out.println("");
                 System.out.println("************ Priority Level 4 ************");
                 System.out.println("Priority 4 list is empty.");
                 System.out.println("");
             } else {
                 Collections.sort(Priority4, dateCompare); //invoke sort() and passing list and a reference
                 for (Activity loopCheck : Priority4) {
                 //check to see if the correct info was recorded into the activity just created
                 System.out.println("");
                 System.out.println("************ Priority Level 4 ************");
                 System.out.println("The activity name is: " + loopCheck.getActivityName());
                 System.out.println("The activity description is: " + loopCheck.getActivityDescription());
                 //System.out.println("The activity importance is: " + loopCheck.getActivityImportance());
                 //System.out.println("The activity urgency is: " + loopCheck.getActivityUrgency());
                 //System.out.println("The activity priority number is: " + loopCheck.getPriorityCode());
                 System.out.println("The activity due date is: " + outputFormat.format(loopCheck.getActivityDueDate().getTime()));
                 }
             }

             //go back to the selection screen
             selectionScreen();
      }

//final bracket of class TimeManagement
}

and the activity class ...

    
/**
 * The Activity class does ...
 */

import java.util.Calendar;

class Activity { //start of class
      
      private String activityName;
      private String activityDescription;
      private boolean activityImportance;
      private boolean activityUrgency;
      private int priorityCode;
      private Calendar activityDueDate;
 
      String getActivityName() {
             return activityName;
      }

      void setActivityName(String anActivityName) {
             activityName = anActivityName;
      }

      String getActivityDescription() {
             return activityDescription;
      }

      void setActivityDescription(String anActivityDescription) {
             activityDescription = anActivityDescription;
      }

      boolean getActivityImportance() {
             return activityImportance;
      }

      void setActivityImportance(boolean anActivityImportance) {
             activityImportance = anActivityImportance;
      }

      boolean getActivityUrgency() {
             return activityUrgency;
      }

      void setActivityUrgency(boolean anActivityUrgency) {
             activityUrgency = anActivityUrgency;
      }

      int getPriorityCode() {
          return priorityCode;
      }

      void setPriorityCode(boolean anActivityImportance, boolean anActivityUrgency) {
             //code for determining priority code
             priorityCode = 0; // make sure it always starts off at zero
             // first check importance
             if (anActivityImportance) {
                priorityCode += 3;
             } else {
                priorityCode += 5;
             }
             // next check urgency before deciding on what to return
             if (anActivityUrgency) {
                //do nothing
             } else {
                priorityCode += 1;
             }    
             // this way there is a 3 returned for important and urgent 
             // there is a 4 returned for important but not urgent
             // there is a 5 returned for not important but urgent
             // there is a 6 returned for not important and not urgent
      }

      Calendar getActivityDueDate() {
             return activityDueDate;
      }
      
      void setActivityDueDate(Calendar anActivityDueDate) {
             activityDueDate = anActivityDueDate;
      }
      
} // end of class

[David Newton]

I'm not sure I would have made separate arrays for the priorities--most likely I would have simply made the priority a part of the object. It also seems to be recursive, which I'm pretty sure isn't your intent (for example, selectionScreen() calls prompt() which calls selectionScreen() etc. It'll take awhile, but eventually you'll run out of memory and crash.

The checkActivityArray() method seems to basically repeat large chunks of code. Any time you find yourself using "paste" as a programming paradigm it's time to re-think and re-factor.

[Seetharaman Venkatasamy]

1.Use LogWriter instead of System.out.println()


2.

    
public int compare (Activity one, Activity two) {                      
return   one.getActivityDueDate().getTime().compareTo(two.getActivityDueDate().getTime());  
 }  

Check method parameter before using them

[Harshit Rastogi]

 
      private ArrayList<Activity> Priority4 = new ArrayList<Activity>();   
  
   

Change this to

      private [b]List[/b]<Activity> Priority4 = new ArrayList<Activity>();   
  
    

you should always use the interface class . Thats a good practice. Because if in case you want to change it to Vector simply change the implementation

[Sebastion Hill]

David Newton wrote:I'm not sure I would have made separate arrays for the priorities--most likely I would have simply made the priority a part of the object. It also seems to be recursive, which I'm pretty sure isn't your intent (for example, selectionScreen() calls prompt() which calls selectionScreen() etc. It'll take awhile, but eventually you'll run out of memory and crash.

The checkActivityArray() method seems to basically repeat large chunks of code. Any time you find yourself using "paste" as a programming paradigm it's time to re-think and re-factor.

Thanks David. I originally thought about trying to make an array of arraylists for the priority parts but I didn't know if that was possible. I like your ideal to put the priority into the actual object, I think I'll take some time and think about how I can do that (still a newbie but it sounds good). Thanks again, I'll remember the "pasting code" you mentioned for future effors

[Sebastion Hill]

seetharaman venkatasamy wrote:1.Use LogWriter instead of System.out.println()


2.

    
public int compare (Activity one, Activity two) {                      
return   one.getActivityDueDate().getTime().compareTo(two.getActivityDueDate().getTime());  
 }  

Check method parameter before using them

Hi Seetharaman, thanks for the feedback. I am curious as to the benefits of using LogWriter instead of System.out.println() ... the reason why I ask is that I've never heard of LogWriter and wanted to double check to make sure it's not personal preferences

Also, by check method parameter did you mean just add a try-catch or is there something else I should be doing?

[Sebastion Hill]

Harshit Rastogi wrote:

 
      private ArrayList<Activity> Priority4 = new ArrayList<Activity>();   
  
   

Change this to

      private [b]List[/b]<Activity> Priority4 = new ArrayList<Activity>();   
  
    

you should always use the interface class . Thats a good practice. Because if in case you want to change it to Vector simply change the implementation

Hey Harshit, for my clarification ... I just need to change the first ArrayList to List ... due to the interface class? I'll read up on it more to get a better understanding but if you don't mind explaining it that would be great, because I am not really sure about your vector comment that follows. Thanks again

[Rob Spoor]

Suppose you find that Priority4 gives you problems. You debug a bit, and find it is a threading issue - two threads are adding elements at the same time, and the ArrayList breaks. You think: I should synchronize the ArrayList! Big problem: now you have to change all points of access to the ArrayList. Auch!

Now, let's say you declared the field as List. Now all you need to do is change just one line of code:

private List<Activity> Priority4 = new Vector<Activity>();

Or, a method I prefer:

private List<Activity> Priority4 = Collections.synchronizedList(new ArrayList<Activity>());

And voila! All access to Priority4 is now synchronized*.


* When using an Iterator you should still synchronize manually:

synchronized (Priority4)
{
    for (Activity activity: Priority4)
    {
        ...
    }
}

Still, much less code needs to be changed.

[Fred Hamilton]

I'm gonna nitpick on something that doesn't really affect functionality, but may affect readability.

Give some thoughts to the names you give your Boolean variables and methods. IMO they should be more suggestive of yes or no answers or true/false answers

So instead of things like Boolean importance and Boolean urgency, you would have things like Boolean isImportant and Boolean isUrgent.

if( activity1.isImportant ) sounds better to me than if( activity1.importance ) , see what I mean?

[Andrew Ceronoski]

Adding a GUI is really nice...but also a lot of work. For letting the user know they made an error try using a dialog box (real easy ).

Another idea is to use HTML to format your text. You often print multiple lines....you could use one "System.out.println" and use the html command \n to have a new line.

Neat program!

[Campbell Ritchie]

I would only suggest using html tags in the documentation comments, which are supposed to be translated to html anyway. There are some Swing components which support html too.

The \n character is not an html tag, and since Java5 it has been far better to use the %n tag which obtains the platform-specific line separator than \n.

[Sebastion Hill]

Rob Prime wrote:Suppose you find that Priority4 gives you problems. You debug a bit, and find it is a threading issue - two threads are adding elements at the same time, and the ArrayList breaks. You think: I should synchronize the ArrayList! Big problem: now you have to change all points of access to the ArrayList. Auch!

Now, let's say you declared the field as List. Now all you need to do is change just one line of code:

private List<Activity> Priority4 = new Vector<Activity>();

Or, a method I prefer:

private List<Activity> Priority4 = Collections.synchronizedList(new ArrayList<Activity>());

And voila! All access to Priority4 is now synchronized*.


* When using an Iterator you should still synchronize manually:

synchronized (Priority4)
{
    for (Activity activity: Priority4)
    {
        ...
    }
}

Still, much less code needs to be changed.

Thanks Rob. I will take you up on your suggestion and I will also research synchronized more to get a better understanding. I know what synchronized means in real world talk but a lot of these comments are going over my head but I am looking forward to understanding them all better! :-) thanks again

[Sebastion Hill]

Fred Hamilton wrote:I'm gonna nitpick on something that doesn't really affect functionality, but may affect readability.

Give some thoughts to the names you give your Boolean variables and methods. IMO they should be more suggestive of yes or no answers or true/false answers

So instead of things like Boolean importance and Boolean urgency, you would have things like Boolean isImportant and Boolean isUrgent.

if( activity1.isImportant ) sounds better to me than if( activity1.importance ) , see what I mean?

No worries, I was being lazy and I am glad you pointed this out. I need to make sure to develop good habits ;-)

[Sebastion Hill]

Campbell Ritchie wrote:I would only suggest using html tags in the documentation comments, which are supposed to be translated to html anyway. There are some Swing components which support html too.

The \n character is not an html tag, and since Java5 it has been far better to use the %n tag which obtains the platform-specific line separator than \n.

Andrew and Campbell, html is kind of over my head right now, though I plan on looking into it. Do I need to know HTML before learning Java or is it something that I can learn afterwards? Is html needed for the GUI?

[Campbell Ritchie]

The only bit of Java which usually uses HTML is the documentation comments. You don't need HTML to write Java. You can write documentation comments without knowing any HTML. You can create 99.99% of any GUIs without knowing HTML.
If you wish to execute an applet you will need a 3-line HTML document, which you can more or less copy out of the books.

There are a few GUI components where you get a better-looking text display with HTML. Your documentation comments are converted into HTML, which looks better if you put a few tags in. It will take ages to learn the amount of HTML you would actually use for Java programming, at a rough estimate maybe half an hour .

[Sebastion Hill]

Campbell Ritchie wrote:The only bit of Java which usually uses HTML is the documentation comments. You don't need HTML to write Java. You can write documentation comments without knowing any HTML. You can create 99.99% of any GUIs without knowing HTML.
If you wish to execute an applet you will need a 3-line HTML document, which you can more or less copy out of the books.

There are a few GUI components where you get a better-looking text display with HTML. Your documentation comments are converted into HTML, which looks better if you put a few tags in. It will take ages to learn the amount of HTML you would actually use for Java programming, at a rough estimate maybe half an hour .

Lol, I think that is a fair trade-off then. Thanks Campbell

[Campbell Ritchie]

You're welcome

And for the % tags, try this Java™ Tutorials section, which is brief but easy to understand, or the Formatter class, which is comprehensive but difficult to understand. Or there might be something in your book.

[Sebastion Hill]

So I have done some updates, mainly trying to use the suggestions I have received from forum members. I felt like an idiot after thinking about how I could eliminate the repeat code for the arrays ... lol, it finally hit me that I only needed 1 array (so this eliminated the need for synchronization, though I still plan on learning more about it).

Also, I updated my boolean expressions to make them better in terms of syntax and I also spent some time learning tags using System.out.format (again, VERY useful though I still have lots to learn).

I also added an automatic save feature as well as the option to delete activities (since they are now being saved and will start to add up).

I think I have still failed in regards to the recursive issues, any suggestions on fixing that? :-/

Well here it is, the updated code ...

    
/**
 * The TestActivity class does ...
 */

//import java.util.Scanner;
//import java.util.ArrayList;
import java.util.*;
import java.text.*;
import java.io.*;

class TestActivity {


      private List<Activity> Priority = new ArrayList<Activity>();

      //new inner class that implements comparator
      class DateCompare implements Comparator<Activity> {
            public int compare (Activity one, Activity two) {
                   return one.getActivityDueDate().getTime().compareTo(two.getActivityDueDate().getTime());
            }
      }
      
      public static void main (String[] args) {
             TestActivity tester = new TestActivity();
             tester.loadActivities();  
      }

      public void loadActivities() {

             Activity activityRestore = new Activity();

             try {
               ObjectInputStream is = new ObjectInputStream(new FileInputStream("Test.ser"));
               if (is == null) {
                 selectionScreen();
               } else {
                 try {
                   while (is != null) {
                     activityRestore = (Activity) is.readObject();
                     Priority.add(activityRestore);
                   }
                 } catch (EOFException ex) {
                     selectionScreen();
                 }
               }
             } catch (Exception ex) {
               selectionScreen();
             }   
      }

      public void selectionScreen() {
             //prompt user for input choice
             int activityChoice = 0;
             Scanner reader = new Scanner(System.in);      
             System.out.format("%nPlease choose between one of the following options:%n"); // Display the string
             System.out.format("1. Create New Activity%n");
             System.out.format("2. Review Current List of Activities%n");
             System.out.format("3. Delete An Activity From Your List%n");
             System.out.format("4. Exit%n%n");
             System.out.format("Enter number choice here: ");
             String iV = String.format("ERROR: You have entered an invalid selection.%n");
             String tA = String.format("Please try again.%n");
             try {
             activityChoice = reader.nextInt();
             } catch (InputMismatchException ex) {
                     System.out.format("%n%sYou must enter a valid integer value.%n%s", iV, tA);
                     selectionScreen();  
             }
             //select choice based on user input
             switch (activityChoice) {
                 case 1: prompt(); break;
                 case 2: reviewActivities(); break;
                 case 3: deleteActivities(); break;
                 case 4: saveActivities(); break;
                 default: System.out.format("%n%sYou must enter either a 1, 2, 3 or 4.%n%s", iV, tA); selectionScreen();
             }
      }

      public void prompt() {
             //prompt user for input choice
             String activityName;
             String activityDescription;
             int activityImportanceNumber = 0;
             int activityUrgencyNumber = 0;
             boolean isImportant = false;
             boolean isUrgent = false;
             Calendar dueDate = Calendar.getInstance();
             
             Scanner reader = new Scanner(System.in);      

             System.out.format("%nPlease enter activity name: "); // Display the string
             activityName = reader.nextLine();
             System.out.format("Please enter activity description: "); // Display the string
             activityDescription = reader.nextLine();

             String eN = String.format("ERROR: You must enter an integer value as opposed to a string.%n");
             String wN = String.format("ERROR: You must enter either a 1 or a 2.%n");
             String eD = String.format("ERROR: You must enter in a due date in the proper format.%n");
             String tA = String.format("Please start over and TRY AGAIN.%n"); 

             System.out.format("Enter '1' if this activity is 'Important' or enter '2' if it is not: ");
             try {
             activityImportanceNumber = reader.nextInt();
             } catch (InputMismatchException ex) {
                     System.out.format("%n%s%s", eN, tA);
                     prompt();
             }
             switch (activityImportanceNumber) {
                    case 1: isImportant = true; break;
                    case 2: isImportant = false; break;
                    default: System.out.format("%n%s%s, wN, tA"); prompt();
             }

             System.out.format("Enter '1' if this activity is 'Urgent' or enter '2' if it is not: ");
             try {
             activityUrgencyNumber = reader.nextInt();
             } catch (InputMismatchException ex) {
                     System.out.format("%n%s%s", eN, tA);
                     prompt();
             }
             switch (activityUrgencyNumber) {
                    case 1: isUrgent = true; break;
                    case 2: isUrgent = false; break;
                    default: System.out.format("%n%s%s", wN, tA); prompt();
             }

             reader.nextLine();
             //trying it the forum way
             System.out.format("%n");
             System.out.format("Please enter the due date using the MM/DD/YR HH:mm aa format %n");
             System.out.format("Example: '05/23/2009 6:05 PM' translates into Sat May 23, 2009 6:05 PM %n");
             System.out.format("Due Date: ");
             String dateLine = reader.nextLine();

             SimpleDateFormat sdf = new SimpleDateFormat("MM/dd/yyyy hh:mm aa");
             try {
                 Date date = sdf.parse(dateLine);
                 dueDate.setTime(date);
             } catch (ParseException e) {
                 System.out.format("%n%s%s", eD, tA);
                 prompt();
             }
             
             //need to take the info from above and create a new activity object 
             Activity testActivity = new Activity();
             testActivity.setActivityName(activityName);
             testActivity.setActivityDescription(activityDescription);
             testActivity.setActivityImportance(isImportant);
             testActivity.setActivityUrgency(isUrgent);
             testActivity.setPriorityCode(isImportant, isUrgent);
             testActivity.setActivityDueDate(dueDate);
             
             Priority.add(testActivity); //add the new activity just created to the arraylist

             selectionScreen(); //go back to the selection screen
      }

      public void reviewActivities() {
             
             DateCompare dateCompare = new DateCompare(); //making an instance of the Comparator inner class
             
             if (Priority.isEmpty()) { // check to see if the arrayList is empty
                System.out.format("%nThere are no activities in your list.%n");
             } else {
                Collections.sort(Priority, dateCompare); //invoke sort() and passing list and a reference 
                for (int x=3; x<7; x++) {
                    for (Activity searchActivities : Priority) {
                        if (searchActivities.getPriorityCode() == x) {
                        System.out.format("%n");
                        String aN = searchActivities.getActivityName();
                        System.out.format("The activity name is: %s%n", aN);
                        String aD = searchActivities.getActivityDescription();
                        System.out.format("The activity description is: %s%n", aD);
                        Date d = searchActivities.getActivityDueDate().getTime();
                        System.out.format("The activity due date is: %tB %te, %tY at %tl:%tM %tp%n", d, d, d, d, d, d);                       
                        }                     
                    }
                } 
             }

             selectionScreen(); //go back to the selection screen
      }

      public void saveActivities() {
             
             try {
                ObjectOutputStream os = new ObjectOutputStream(new FileOutputStream("Test.ser"));
                  if (Priority.isEmpty()) {
                       System.out.format("%nThere are no activities listed and therefore nothing will be saved.%n");
                       os.writeObject(Priority);
                       os.close();
                       System.exit(0);
                  } else {
                       for (Activity saveActivities : Priority) {
                       os.writeObject(saveActivities);
                       }
                       os.close();
                       System.out.format("%nYour activities have been saved and will be available next time you start.%n");
                       System.exit(0);
                  }                 
             } catch (IOException ex) {
                 System.exit(0);
             }
      }

      public void deleteActivities() {

            if (Priority.isEmpty()) {
                System.out.format("%nThere are no activities to delete.%n");
                selectionScreen();
            } else {
            	Scanner userChoice = new Scanner(System.in);
            	int activityNumber = 0;
                        
            	System.out.format("%nWhich activity number would you like to delete? Please enter an integer value: ");  
            	try {
            	activityNumber = userChoice.nextInt() - 1;
               		if (activityNumber < Priority.size()) {
                  		Priority.remove(activityNumber);
               		} else {
                  		System.out.format("%nThat number does not exist in the current list.%nPlease try again.");
                  		deleteActivities();
               		}
            	} catch (InputMismatchException ex) {
                    System.out.format("%nYou must enter a valid integer value.%n");
                    deleteActivities();  
            	}
              	selectionScreen();
	    }
      }  

//final bracket of TestActivity
}

    
/**
 * The Activity class does ...
 */

import java.util.Calendar;
import java.io.*;

class Activity implements Serializable { //start of class
      
      private String activityName;
      private String activityDescription;
      private boolean activityImportance;
      private boolean activityUrgency;
      private int priorityCode;
      private Calendar activityDueDate;
 
      String getActivityName() {
             return activityName;
      }

      void setActivityName(String anActivityName) {
             activityName = anActivityName;
      }

      String getActivityDescription() {
             return activityDescription;
      }

      void setActivityDescription(String anActivityDescription) {
             activityDescription = anActivityDescription;
      }

      boolean getActivityImportance() {
             return activityImportance;
      }

      void setActivityImportance(boolean anActivityImportance) {
             activityImportance = anActivityImportance;
      }

      boolean getActivityUrgency() {
             return activityUrgency;
      }

      void setActivityUrgency(boolean anActivityUrgency) {
             activityUrgency = anActivityUrgency;
      }

      int getPriorityCode() {
          return priorityCode;
      }

      void setPriorityCode(boolean anActivityImportance, boolean anActivityUrgency) {
             //code for determining priority code
             priorityCode = 0; // make sure it always starts off at zero
             // first check importance
             if (anActivityImportance) {
                priorityCode += 3;
             } else {
                priorityCode += 5;
             }
             // next check urgency before deciding on what to return
             if (anActivityUrgency) {
                //do nothing
             } else {
                priorityCode += 1;
             }    
             // this way there is a 3 returned for important and urgent 
             // there is a 4 returned for important but not urgent
             // there is a 5 returned for not important but urgent
             // there is a 6 returned for not important and not urgent
      }

      Calendar getActivityDueDate() {
             return activityDueDate;
      }
      
      void setActivityDueDate(Calendar anActivityDueDate) {
             activityDueDate = anActivityDueDate;
      }
      
} // end of class

[Sebastion Hill]

If no one sees any major problems with this code then my GUI work will start on Monday :-)