Corrupt file name after compression.

[pawan chopra]

I am using the following code to zip a file with name as shown in attachment. The file name consist of spanish characters. After compression file name is different an some characters are shown as +- as shown in attachment. Can any body tell me how to resolve it?

import java.io.*;
import java.util.zip.*;

public class Zip {
  static final int BUFFER = 2048;
  public static void main (String argv[]) {
     try {
        BufferedInputStream origin = null;
        FileOutputStream dest = new 
          FileOutputStream("myfigs.zip");
        ZipOutputStream out = new ZipOutputStream(new 
          BufferedOutputStream(dest));
        //out.setMethod(ZipOutputStream.DEFLATED);
        byte data[] = new byte[BUFFER];
        // get a list of files from current directory
        File f = new File(".");
        String files[] = f.list(new FilenameFilter(){

			public boolean accept(File dir, String name) {
			
				if(name.indexOf("csv")!=-1){
					return true;
				}
				return false;
			}
        	
        });

        for (int i=0; i<files.length; i++) {
        	
           System.out.println("Adding: "+new String(files[i].getBytes(),"ISO-8859-1"));
           FileInputStream fi = new 
             FileInputStream(new String(files[i].getBytes(),"ISO-8859-1"));
           origin = new 
             BufferedInputStream(fi, BUFFER);
           ZipEntry entry = new ZipEntry(new String(files[i].getBytes(),"ISO-8859-1"));
           out.putNextEntry(entry);
           int count;
           while((count = origin.read(data, 0, 
             BUFFER)) != -1) {
              out.write(data, 0, count);
           }
           origin.close();
        }
        out.close();
     } catch(Exception e) {
        e.printStackTrace();
     }
  }
}

  

>

[Campbell Ritchie]

Don't know. But it may be worthwhile unzipping the file and seeing whether it is restored correctly. Some characters don't display correctly on screen; Windows seems to be worse for that than other operating systems.

[pawan chopra]

I have tried unzipping them but it is not restored correctly. I am able to see the correct file name when file is not compressed don't know why it is happening after compression only.

[Campbell Ritchie]

Don't know. Sorry.

[pawan chopra]

I think I have got the problem. I have seen the code in ZipOutPutStream It gets byte array of file name and then write the name of the file. I have tried doing the same in the below program. It prints negative value for special characters like é.

  import java.io.UnsupportedEncodingException;

/**
 * @author p.chopra
 * created 17/07/2009
 */
public class Main {

	/**
	 * @param args
	 */
	public static void main(String[] args)
	{
		try {
			String name = "Maxis_Visitantes_por_Teléfono_Visitantes__7d_17-jul-2009.csv";
			String strr = new String(name.getBytes("UTF-8"));
			byte[] arrayNew = new byte[strr.length()];
			for (int i = 0; i < strr.length(); i++) {
				int ia = (int)strr.charAt(i);
				arrayNew[i]=(byte) ia;
				System.out.println(arrayNew[i]+"  ||  "+strr.charAt(i)+"  ||  "+(int)strr.charAt(i));
			}
			
		} catch (UnsupportedEncodingException e) {
			e.printStackTrace();
		}
	}

}
  

Can any one tel me solution how to do this how can I resolve this.

[Campbell Ritchie]

Bytes run from -128 (0x80) to +127 (0x7f). The characters used in Western European languages other than English are in the range 0x80-0xff, so they are regarded by two's complement as negative numbers. You can find the numbers in Unicode (1) and (2). I note some of those characters in no (2) are control characters.

Not sure what you are supposed to do next, but it has something to do with casting to a char, or casting to a char and doing a bitwise AND (&) with 0xff.

[Ulf Dittmer]

Not sure if it's related, but there's a longstanding problem with the java.util.zip package in that it doesn't deal well with non-ASCII filenames. See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4244499 for more information.

[pawan chopra]

Campbell Ritchie wrote:
Not sure what you are supposed to do next, but it has something to do with casting to a char, or casting to a char and doing a bitwise AND (&) with 0xff.

Actually java api is doing all this which is related to file name I am not sure how to implement this functionality with rest of the features working same. Kindly suggest me what can be the solution for this thing?

[Ulf Dittmer]

Have you read the bug report I linked to? Are you certain that that is not the problem?

[pawan chopra]

Ulf Dittmer wrote:Have you read the bug report I linked to? Are you certain that that is not the problem?

thanks for the link Ulf. yes I am facing the same problem but I am very much surprised that after 7 years still that bug exists. That bug was reported in 2001. Any specific reason for not fixing that bug in case You know?

[pawan chopra]

I have executed the following experiment:
- created several text files with English, Hungarian, Chinese, Japanese and
Korean name
- attempted to compress them using FilZip, WinZip and PKZip
- attempted to uncompress then using the above tools
My findings are:
- FilZip and WinZip cannot add files with non-English-only names (not even
Hungarian which uses Latin characters); they cannot list files
- PKZip can add add file with any names, but names are transformed: all
non-Western European accented Latin characters are converted to similar
character without accent (e.g. ű->u, ő->o) and all non-Latin characters are
converted to question marks; NOTE: Accented Western European characters are
preserved (e.g. áéíóöúüñ), thus Spanish is supported
- WinZip cannot list non-Western European file names, but can extract the
files when "Extract all" is selected; but non-Latin characters are replaced
with underscore (_); since all non-Western European Latin characters are
converted to non-accented Western European ones during compression, these files
are listed and extracted but without accents.
- FilZip and PKZip can display and extract all files but with transformation;
see above

Summary: ZIp format does not support Unicode in filenames. It might be possible
to pick one specific code page/character set that would be usable for a
specific language, but it is not know how as tested tools do not provide
control for this.

Solution: No real solution. As workaround, Spanish text should be used with all
accented characters replaced with non-accented relative (ú->u, ó->o, etc.) or
compress files using ISO8859P1 character set for filenames.

Note: PKZip is one of the first zip utilities for Windows; WinZip is the market
leader. If they cannot support Unicode, how could we?