struts2 + jsp problem - ognl.MethodFailedException: Method "setId" failed for object

[olze oli]

Hi there,

i'm using struts2, spring and hibernate3 for a liferay portlet
my struts.xml:

 <?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE struts PUBLIC
        "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
        "http://struts.apache.org/dtds/struts-2.0.dtd">
<struts>

<constant name="struts.enable.DynamicMethodInvocation" value="false"/>
<constant name="struts.devMode" value="true"/>
<constant name="struts.objectFactory" value="spring" />

<package name="lecture" namespace="/view" extends="struts-portlet-default">
    <action name="index" class="MontyBrogan.Action.LectureAction" method="execute">
        <result>/WEB-INF/jsp/lecture/listLectures.jsp</result>
    </action>

    <action name="remove" class="MontyBrogan.Action.LectureAction" method="remove">      
        <result>/WEB-INF/jsp/lecture/listLectures.jsp</result>
    </action>

    <action name="save" class="MontyBrogan.Action.LectureAction" method="save">     
        <result>/WEB-INF/jsp/lecture/listLectures.jsp</result>
    </action>

    <action name="addLecture" class="MontyBrogan.Action.LectureAction" method="save">      
        <result>/WEB-INF/jsp/lecture/addLecture.jsp</result>
    </action>
        <!-- Add actions here -->
</package>

</struts>   

the portlet is called MontyBrogan and it is displayed correctly - i can see the submit form from listLectures.jsp:

<%@ taglib prefix="s" uri="/struts-tags"%>

<p>Lectures</p>
<s:form id="newLectureForm" action="addLecture">
    <s:submit id="addLecture" value="Neue Lecture"></s:submit>
  </s:form>

<s:if test="lecture.size > 0">
    <table>
        <s:iterator value="lecture">
            <tr id="row_<s:property value="id"/>">
                <td>
                    <s:property value="Desc" />
                </td>
                <td>
                    <s:property value="ID_Prof" />
                </td>
                <td>
                    <s:url id="removeLecture" action="remove">
                        <s:param name="id" value="id" />
                    </s:url>
                    <s:a href="%{removeLecture}" targets="lecture">Remove</s:a>
                    <s:a id="a_%{id}" notifyTopics="/edit">Edit</s:a>
                </td>
            </tr>
        </s:iterator>
    </table>
</s:if>

    

but when i hit the button "Neue Lecture" i get the following error:

Hibernate: select lecture0_.ID as ID5_, lecture0_.Desc as Desc5_, lecture0_.ID_Prof as ID3_5_ from MontyBrogan.Lecture lecture0_
ognl.MethodFailedException: Method "setId" failed for object MontyBrogan.Action.LectureAction@55000c0f [java.lang.NoSuchMethodException: setId([Ljava.lang.String;)]
        at ognl.OgnlRuntime.callAppropriateMethod(OgnlRuntime.java:823)
        at ognl.OgnlRuntime.setMethodValue(OgnlRuntime.java:964)
        at ognl.ObjectPropertyAccessor.setPossibleProperty(ObjectPropertyAccessor.java:75)
        at ognl.ObjectPropertyAccessor.setProperty(ObjectPropertyAccessor.java:131)
        at com.opensymphony.xwork2.ognl.accessor.ObjectAccessor.setProperty(ObjectAccessor.java:28)
        at ognl.OgnlRuntime.setProperty(OgnlRuntime.java:1656)
       

i have a getId method in my LectureAction.java:

package MontyBrogan.Action;

import java.util.List;

import MontyBrogan.Model.Lecture;
import MontyBrogan.Service.LectureService;

import com.opensymphony.xwork2.Action;
import com.opensymphony.xwork2.Preparable;

public class LectureAction implements Preparable {
    private LectureService service;
    private List<Lecture> lectures;
    private Lecture lecture;
    private Integer id;

    public LectureAction(LectureService service) {
        this.service = service;
    }

    public String execute() {
        this.lectures = service.findAll();
        return Action.SUCCESS;
    }

    public String save() {
        this.service.save(lecture);
        this.lecture = new Lecture();
        return execute();
    }

    public String addLecture() {
        this.service.save(lecture);
        this.lecture = new Lecture();
        return execute();
    }

    public String remove() {
        service.remove(id);
        return execute();
    }

    public List<Lecture> getLectures() {
        return lectures;
    }

    public Integer getId() {
        return id;
    }

    public void setId(Integer id) {
        this.id = id;
    }

    public void setId(String id)
    {
        this.id = Integer.parseInt(id);
    }

    public void prepare() throws Exception {
        if (id != null)
            lecture = service.find(id);
    }

    public Lecture getLecture() {
        return lecture;
    }

    public void setLecture(Lecture lecture) {
        this.lecture = lecture;
    }
}    

i have no idea whats wrong - please help me
and why does it look for a getId(String) ??? shouldn't it be getId(long) or getId(int) ?

[olze oli]

i found a site where someone has the same problem:
http://www.nabble.com/Struts-2.1.2-type-conversion-failing-for-Integer-method.-td20475044.html

And one "workaround" is:
"So the workaround for me was to stop using generic properties in my Model objects."
But i have no idea whats a generic propertie??

can please someone explain me what it does mean?

[Bear Bibeault]

Please be sure to ask Struts questions in the Struts forum. I have moved this post there for you.

[olze oli]

sorry i've just overlook the "products"

[Kev Adams]

I'm getting this error too in Struts 2.1.8.

For me it happens when you *do not* enter a value in a field that maps to an integer in your action.

The jira, located at: https://issues.apache.org/struts/browse/WW-2971, says that it has been resolved, but still the problem remains. This particular incident mentions the conversion from a double, but it also is happening with an int.

Does anyone have any suggestions as to how to fix this?

I don't know if this will help, but here is a list of my jars:

commons-beanutils-1.8.0.jar
commons-digester-2.0.jar 
commons-logging-1.0.4.jar
commons-logging-api-1.1.jar
freemarker-2.3.15.jar
ognl-2.7.3.jar
spring.jar
struts2-core-2.1.8.jar
struts2-dojo-plugin-2.1.8.jar
struts2-spring-plugin-2.1.8.jar
struts2-tiles-plugin-2.1.8.jar
tiles-api-2.1.3.jar
tiles-core-2.1.3.jar
tiles-jsp-2.1.3.jar
tiles-servlet-2.1.3.jar
xwork-core-2.1.6.jar