request.getParameterValues not working

[rajeshkannan sella]

Hi all,
I have checkboxes in my JSP and I am just trying to get their values in my java code

Contact types<br><p align="left" style="padding-left: 110px;"><input type="checkbox" value="0" name="group"> All primary contacts</input> </p>
	<c:forEach items="${responsibilities}" var="resp"> 
	<p align="left" style="padding-left: 110px;">	<c:if test="${resp.id != 8}">
			<%-- Skip the 'Other' category (id=8)--%>
			<!-- option value="${resp.id}">${resp.value}</option -->
			<input type="checkbox" value="${resp.id}" name="group" align="middle"> ${resp.value}</input> <br>
		</c:if></p>
	</c:forEach><br>

My java code

 System.out.println("group ="+request.getParameterValues("group"));   

im getting null

please clarify

Thanks
Rajesh

[Sean Clark]

from the HttpServletRequest API

Returns an array of String objects containing all of the values the given request parameter has, or null if the parameter does not exist.

change your form to use get to send the data so that you can check what is being sent to the servlet in the url bar.

Also if you use firefox, you can use an addon called Firebug that will help you choose this.

Sean

[rajeshkannan sella]

Using get method is not safe for more sensitive data

[rajeshkannan sella]

in form i have

enctype="multipart/form-data" 

as this code for email functionality so it needs to be have post method with enctype.


please let me know other options

[William Brogden]

If this was my problem I would use Firefox addons to examine exact contents of the HTML page and the exact contents of the request like Sean Clark said.

You will be amazed at how easy it is to debug problems like this when you can see exactly what is being sent.

Bill

[Bear Bibeault]

rajeshkannan sella wrote:Using get method is not safe for more sensitive data

It is a myth that POST is "more secure" than GET. Neither is secure.

[rajeshkannan sella]

As suggested i made it as "get"

<form action="/LDGAdministration/SysAgenciesAlertsScreenAction.do?action=send" method="get" id="theForm" enctype="multipart/form-data">

im getting the following exception

org.apache.commons.fileupload.FileUploadBase$InvalidContentTypeException: the request doesn't contain a multipart/form-data or multipart/mixed stream, content type header is null
at org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:299)
at com.sa.ldg.controller.actions.SysAgenciesAlertsScreenAction.execute(SysAgenciesAlertsScreenAction.java:73)
at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:419)
at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:224)
at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1194)
at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.sa.ldg.config.SessionFilterServlet.doFilter(SessionFilterServlet.java:69)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.displaytag.filter.ResponseOverrideFilter.doFilter(ResponseOverrideFilter.java:125)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)

Let me know how to proceed solving this

[Sean Clark]

Hey,

I don't think you can do a GET with the data that you are trying to send.
But as I said, use Firefox along with the firebug plugin, this will allow you to see all the parameters that are being send to your application through the post.

Also you may wish to post the whole form.

Sean

[rajeshkannan sella]

i have installed the plugin but dont have any idea to how to see the parameters send.

[rajeshkannan sella]

For multipart form data Oreilys MultipartParser class will get you the parameters

MultipartParser mp = null;
		try {
			mp = new MultipartParser(request, 1*1024*1024);
		
		  Part part;
		  while ((part = mp.readNextPart()) != null) {
			String name = part.getName();
			if (part.isParam()) {
			  // it's a parameter part
			  ParamPart paramPart = (ParamPart) part;
			  String value = paramPart.getStringValue();
			  System.out.println("param; name=" + name + ", value=" + value);
			}
		  }} catch (IOException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			} // 10MB

Thanks
Rajesh

[rajeshkannan sella]

I got a new problem, Now im not able to use both MultipartParser and DiskFileUpload to get the form fields im getting exception java.io.IOException: Corrupt form data: premature ending

/* 


package com.sa.ldg.controller.actions;

import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.fileupload.DiskFileUpload;
import org.apache.commons.fileupload.FileItem;
import org.apache.log4j.Logger;
import org.apache.struts.action.*;

import com.oreilly.servlet.multipart.MultipartParser;
import com.oreilly.servlet.multipart.ParamPart;
import com.oreilly.servlet.multipart.Part;
import com.sa.ldg.config.LDGConfig;
import com.sa.ldg.dataaccess.LdgAdminSessionBean;
import com.sa.ldg.db.hibernate.model.LdgAdminuserResponsibility;
import com.sa.ldg.db.hibernate.model.LdgRegion;
import com.sa.ldg.email.EMailManager;
import com.sa.ldg.utils.LDGUtilities;

// import com.sa.ldg.view.beans.Message;

/**
 */
public class SysAgenciesAlertsScreenAction extends Action
{
	private static Logger m_log = Logger.getLogger(SysAgenciesAlertsScreenAction.class);
	
	public static List<String> getGroupValues(HttpServletRequest request)	{

		MultipartParser requestParamParser = null;
		List<String> groupValues = new ArrayList<String>();
		try {
			requestParamParser = new MultipartParser(request, request.getContentLength());
			Part part;
			while ((part = requestParamParser.readNextPart()) != null) {
				String name = part.getName();
				if (name.equals("group") && part.isParam()) {
					ParamPart paramPart = (ParamPart) part;
					groupValues.add(paramPart.getStringValue());				
				}
			}
		} catch (IOException e) {
			String message = "The Content type seems empty or not a multipart form data";
			m_log.info(message, e);
		}
		return groupValues;
		
	}
	
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response)
	{
        LDGUtilities.setAgencyName(request);
        
        String action = request.getParameter("action"); 
        
		LdgAdminSessionBean ldgSessionBean = LdgAdminSessionBean.getInstance();
		List<LdgAdminuserResponsibility> responsibilities = ldgSessionBean.getAdminUserResponsibilities();
		List<LdgRegion> regions = ldgSessionBean.getRegions();//rajesh
		request.setAttribute("responsibilities", responsibilities);
		request.setAttribute("regions", regions);//rajesh
		List<String> groupValues = new ArrayList<String>();

		if (action != null && action.equalsIgnoreCase("send")) {
            
            try {
                //
                //Parse the incoming request. We can't do this using normal servlet request.getParameter calls 
                //because the form is of type multipart/form-data in order to handle attachments
                //
                String subject = "";
                String messageText = "";
                File attachmentFile = null;
                int group = 0;
                int all =0; //rajesh
                int countryid=0;//rajesh
                int regionid=0;//rajesh
                int usertype=0;//rajesh
                int tier=0;//rajesh
                
                LDGConfig config = LDGConfig.getInstance();
                String uploadDir = config.getStringVal("email.tempdir", "c:/");

                DiskFileUpload fu = new DiskFileUpload();
                fu.setSizeMax(10000000);// If file size exceeds, a FileUploadException will be thrown

                List fileItems = fu.parseRequest(request);
                Iterator itr = fileItems.iterator();
                
                while (itr.hasNext()) {

                    FileItem fi = (FileItem)itr.next();

                    if (!fi.isFormField() && fi.getSize() > 0) {
                        
                        String fileName = new File(fi.getName()).getName();
                        attachmentFile = new File(uploadDir, fileName);
                        m_log.debug(String.format("Writing attachment to %s - file name:%s, Size:%s", uploadDir, fi.getName(), fi.getSize()));

                        fi.write(attachmentFile);
                    }
                    else {
                        if (fi.getFieldName().equals("subject")) {
                            subject = fi.getString();
                        }
                        else if (fi.getFieldName().equals("message")) {
                            messageText = fi.getString();
                        }                       
                        else if (fi.getFieldName().equals("all")) { //rajesh
                            all = Integer.parseInt(fi.getString());
                        }
                        else if (fi.getFieldName().equals("countryid")) { //rajesh
                        	countryid = Integer.parseInt(fi.getString());
                        }
                        else if (fi.getFieldName().equals("regionid")) { //rajesh
                        	regionid = Integer.parseInt(fi.getString());
                        }
                        else if (fi.getFieldName().equals("usertype")) { //rajesh
                        	usertype = Integer.parseInt(fi.getString());
                        }
                        else if (fi.getFieldName().equals("tier")) {  //rajesh
                        	tier = Integer.parseInt(fi.getString());
                        }
                    }
                }
                groupValues = getGroupValues(request);
                System.out.println("groupValues all = " +groupValues +" " +all);
                EMailManager.sendAgencyAlert(subject, messageText,
						attachmentFile, groupValues, all, countryid, regionid,
						usertype, tier);//rajesh
                request.setAttribute("successMessage", String.format("Message '%s' sent successfully.", subject));
            }
            catch (Exception ex) {
                m_log.error("Failure sending e-mail", ex);
                request.setAttribute("errorMessage", "Internal error - message not sent.");
            }
        }
        
        return (mapping.findForward("systemAgenciesAlertsScreen"));
	}
}
    

please help me

[Sunder Ganapathy]

You can only parse through the request once .