cant get counters to work correctly

[nathan gibson]

what i am trying to do is to get the program to simulate an 11 sided die rolling and then printing out the probability of each number getting rolled. something like this:

Number of Rolls:
10
Sum Of Dice Probability
1s   1.0
2s   0.0
3s   0.0
4s   0.0
5s   0.0
6s   0.0
7s   0.0
8s   0.0
9s   0.0
10s   0.0
11s   0.0

my problem is that i cant get the probability to correctly calculate. i have diagnosed it to the counter for each occurrence of trues.

  /**
 * 
 * 
 * Nathan Gibson 
 * 
 */
import java.util.Scanner;
import java.util.Random;

public class CountingWithForLoops3 
{
    public static void main(String [] args)
    {
        Scanner in;  
        in = new Scanner(System.in);
        
        int counterTrials = 1;
        int counter1 = 1;
        int counter2 = 1;
        int counter3 = 1;
        int counter4 = 1;
        int counter5 = 1;
        int counter6 = 1;
        int counter7 = 1;
        int counter8 = 1;
        int counter9 = 1;
        int counter10 = 1;
        int counter11 = 1;
        
        
        
        System.out.println("Number of Rolls: ");
        int numberOfRolls = in.nextInt();
        
        int randomNumber = ((int)(0+ Math.random()* 11));
        
        for(int side1 = 0; counterTrials <= numberOfRolls; counterTrials++) 
        if (randomNumber == 1)
            counter1++;
            
            
        
            for(int side2 = 0; counterTrials <= numberOfRolls; counterTrials++) 
            if (randomNumber == 2)
                counter2++;
                
            
                for(int side3 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                counterTrials++;
                if (randomNumber == 3)
                counter3++;
                
                
                        for(int side4= 0; counterTrials <= numberOfRolls; counterTrials++) 
                        counterTrials++;
                        if (randomNumber == 4)
                            counter4++;
                            
                        
                            for(int side5 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                            counterTrials++;
                            if (randomNumber == 5)
                                counter5++;
                                
                            
                                for(int side6 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                if (randomNumber == 6)
                                    counter6++;
                                    
                                
                                    for(int side7 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                    if (randomNumber == 7)
                                        counter7++;
                                        
                                    
                                        for(int side8= 0; counterTrials <= numberOfRolls; counterTrials++)
                                        if (randomNumber == 8)
                                            counter8++;
                                            
                                        
                                            for(int side9 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                            if (randomNumber == 9)
                                                counter9++;
                                                
                                            
                                                for(int side10 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                                if (randomNumber == 10)
                                                    counter10++;
                                                    
                                                
                                                    for(int side11= 0; counterTrials <= numberOfRolls; counterTrials++)
                                                    if (randomNumber == 11)
                                                        counter11++;
                                                        
                                                        
                                                        
        
        double probability1 = counter1 / counterTrials;
        double probability2 = counter2 / counterTrials;
        double probability3 = counter3 / counterTrials;
        double probability4 = counter4 / counterTrials;
        double probability5 = counter5 / counterTrials;
        double probability6 = counter6 / counterTrials;
        double probability7 = counter7 / counterTrials;
        double probability8 = counter8 / counterTrials;
        double probability9 = counter9 / counterTrials;
        double probability10 = counter10 / counterTrials;
        double probability11 = counter11 / counterTrials;
        
        System.out.print("Sum Of Dice              Probability");
        System.out.print("\n1s" + "                       " + probability1);
        System.out.print("\n2s" + "                       " + probability2);
        System.out.print("\n3s" + "                       " + probability3);
        System.out.print("\n4s" + "                       " + probability4);
        System.out.print("\n5s" + "                       " + probability5);
        System.out.print("\n6s" + "                       " + probability6);
        System.out.print("\n7s" + "                       " + probability7);
        System.out.print("\n8s" + "                       " + probability8);
        System.out.print("\n9s" + "                       " + probability9);
        System.out.print("\n10s" + "                      " + probability10);
        System.out.print("\n11s" + "                      " + probability11);
        
        
                                
    }
}  

[David Newton]

I think you should "play JVM" and pretend it's you executing your program: as written, what *exactly* is it going to do?

Then think about some of the following questions:
- What happens if you don't have curly braces surrounding everything you want to execute in a code block?
- How many times do you want to generate a random number?
- As written, how many rolls will be recorded for a number that is *never* rolled by the program?

[nathan gibson]

   public class DiceProbability
{
    public static void main(String [] args)
    {
        Scanner in;  
        in = new Scanner(System.in);
        
        int counterTrials = 1;
        int counter1 = 1;
        int counter2 = 1;
        int counter3 = 1;
        int counter4 = 1;
        int counter5 = 1;
        int counter6 = 1;
        int counter7 = 1;
        int counter8 = 1;
        int counter9 = 1;
        int counter10 = 1;
        int counter11 = 1;
        
        
        
        System.out.println("Number of Rolls: ");
        int numberOfRolls = in.nextInt();
        
        int randomNumber = ((int)(0+ Math.random()* 11));
        
        
        for(int side1 = 0; counterTrials <= numberOfRolls; counterTrials++) 
        randomNumber = ((int)(0+ Math.random()* 11));
        if (randomNumber == 1)
            counter1++;
            
            
        
            for(int side2 = 0; counterTrials <= numberOfRolls; counterTrials++) 
            randomNumber = ((int)(0+ Math.random()* 11));
            if (randomNumber == 2)
                counter2++;
                
            
                for(int side3 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                randomNumber = ((int)(0+ Math.random()* 11));
                if (randomNumber == 3)
                    counter3++;
                
                
                        for(int side4= 0; counterTrials <= numberOfRolls; counterTrials++) 
                        randomNumber = ((int)(0+ Math.random()* 11));
                        if (randomNumber == 4)
                            counter4++;
                            
                        
                            for(int side5 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                            randomNumber = ((int)(0+ Math.random()* 11));
                            if (randomNumber == 5)
                                counter5++;
                                
                            
                                for(int side6 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                randomNumber = ((int)(0+ Math.random()* 11));
                                if (randomNumber == 6)
                                    counter6++;
                                    
                                
                                    for(int side7 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                    randomNumber = ((int)(0+ Math.random()* 11));
                                    if (randomNumber == 7)
                                        counter7++;
                                        
                                    
                                        for(int side8= 0; counterTrials <= numberOfRolls; counterTrials++)
                                        randomNumber = ((int)(0+ Math.random()* 11));
                                        if (randomNumber == 8)
                                            counter8++;
                                            
                                        
                                            for(int side9 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                            randomNumber = ((int)(0+ Math.random()* 11));
                                            if (randomNumber == 9)
                                                counter9++;
                                                
                                            
                                                for(int side10 = 0; counterTrials <= numberOfRolls; counterTrials++) 
                                                randomNumber = ((int)(0+ Math.random()* 11));
                                                if (randomNumber == 10)
                                                    counter10++;
                                                    
                                                
                                                    for(int side11= 0; counterTrials <= numberOfRolls; counterTrials++)
                                                    randomNumber = ((int)(0+ Math.random()* 11));
                                                    if (randomNumber == 11)
                                                        counter11++;
                                                        
                                                        
                                                        
        
        double probability1 = counter1 / counterTrials;
        double probability2 = counter2 / counterTrials;
        double probability3 = counter3 / counterTrials;
        double probability4 = counter4 / counterTrials;
        double probability5 = counter5 / counterTrials;
        double probability6 = counter6 / counterTrials;
        double probability7 = counter7 / counterTrials;
        double probability8 = counter8 / counterTrials;
        double probability9 = counter9 / counterTrials;
        double probability10 = counter10 / counterTrials;
        double probability11 = counter11 / counterTrials;
        
        System.out.print("Sum Of Dice              Probability");
        System.out.print("\n1s" + "                       " + probability1);
        System.out.print("\n2s" + "                       " + probability2);
        System.out.print("\n3s" + "                       " + probability3);
        System.out.print("\n4s" + "                       " + probability4);
        System.out.print("\n5s" + "                       " + probability5);
        System.out.print("\n6s" + "                       " + probability6);
        System.out.print("\n7s" + "                       " + probability7);
        System.out.print("\n8s" + "                       " + probability8);
        System.out.print("\n9s" + "                       " + probability9);
        System.out.print("\n10s" + "                      " + probability10);
        System.out.print("\n11s" + "                      " + probability11);
        
        
                                
    }
} 

i updated to include this. did that fix what you meant by the random is never rolled? im not sure what to do with the "{}" because i dont know if i put what is in the loop in those, or if i put what is in the if statements.

[Greg Stevens]

You are missing most, if not all, of the braces for your loops. This affects the logic of your program.
Without braces, a control statement will have only a single statement associated with it. Perhaps it
would help to start with a simpler example.

  
/** Programming challenge Chapter 5: Factorials.java
 * Application that evaluates the factorials of the integers from 1 to 5.
 * @author greg
 *
 */
import javax.swing.JOptionPane;
import javax.swing.JTextArea;

public class Factorials 
{

	public static void main(String[] args)  {
		String tableString = "X\tX!\n\n"; // initialize to header
		
		// compute factorials for integers 1 through 5
		for (int num = 1; num <= 5; num++) {
			int factorial = 1;
			
			for (int i = 1; i <= num; i++) {
				factorial *= i;
			}
			
			tableString += num + "\t" + factorial + "\n"; // add row to table
		}
		
		// display results
		JTextArea factorialTable = new JTextArea(tableString);
		JOptionPane.showMessageDialog( null, factorialTable,
				"Factorial", JOptionPane.INFORMATION_MESSAGE);
	} 
	
} 
  

Take the braces off from the outer for loop and see how it breaks the code. The braces can be removed
from the inner for loop without breaking the code because there is only one statement within the braces.
I always put the braces so that I don't forget them, or, in case I need to go back and add another statement
to the for loop, the braces are already there.

There's only two loops in this example, one outer and one inner. Go over the code until you understand how
the braces associate the blocks of code to the for statements. Make sure you understand this example with
only two loops before you try to write code with several nested loops.

[Campbell Ritchie]

There is a much easier way to do it. Put your counters into an array, then use the "random" number to decide which member of the array to increment. You don't even have to start from 0; int[] elements are initialised to 0 as a default value.

[nathan gibson]

the only problem with arrays is that im in a class and we havent went over them, so i dont think we are supposed to use things we dont know about.

[nathan gibson]

do you guys think this is a better way to do the probability?

   /**
 * 
 * 
 * Nathan Gibson 
 * 
 */
import java.util.Scanner;
import java.util.Random;

public class DiceProbability
{
    public static void main(String [] args)
    {
        Scanner in;  
        in = new Scanner(System.in);
        
        int counterTrials = 1;
        int counter1 = 1;
        int counter2 = 1;
        int counter3 = 1;
        int counter4 = 1;
        int counter5 = 1;
        int counter6 = 1;
        int counter7 = 1;
        int counter8 = 1;
        int counter9 = 1;
        int counter10 = 1;
        int counter11 = 1;
        
        
        
        System.out.println("Number of Rolls: ");
        int numberOfRolls = in.nextInt();
        
        int randomNumber = ((int)(0+ Math.random()* 11));
        
        
        
         
        
        
        for(int side1 = 0; counterTrials <= numberOfRolls;) 
        randomNumber = ((int)(0+ Math.random()* 11));
        if (randomNumber == 1)
            {
                counter1++;
                
            }
            
            
        
            for(int side2 = 0; counterTrials <= numberOfRolls;) 
            randomNumber = ((int)(0+ Math.random()* 11));
            if (randomNumber == 2)
            {
                
                counter2++;
            }
            
            
                for(int side3 = 0; counterTrials <= numberOfRolls;)
                randomNumber = ((int)(0+ Math.random()* 11));
                if (randomNumber == 3)
                {
                    counter3++;
                    
                }
                
                
                
                
                        for(int side4= 0; counterTrials <= numberOfRolls;) 
                        randomNumber = ((int)(0+ Math.random()* 11));
                        if (randomNumber == 4)
                        {
                            counter4++;
                            
                        }
                        
                            
                        
                            for(int side5 = 0; counterTrials <= numberOfRolls;) 
                            randomNumber = ((int)(0+ Math.random()* 11));
                            if (randomNumber == 5)
                            {
                                counter5++;
                                
                            }
                            
                                
                            
                                for(int side6 = 0; counterTrials <= numberOfRolls;) 
                                randomNumber = ((int)(0+ Math.random()* 11));
                                if (randomNumber == 6)
                                {
                                    counter6++;
                                    
                                }
                               
                                
                                    
                                
                                    for(int side7 = 0; counterTrials <= numberOfRolls;) 
                                    randomNumber = ((int)(0+ Math.random()* 11));
                                    if (randomNumber == 7)
                                    {
                                        counter7++;
                                        
                                    }
                                    
                                        
                                    
                                        for(int side8= 0; counterTrials <= numberOfRolls;)
                                        randomNumber = ((int)(0+ Math.random()* 11));
                                        if (randomNumber == 8)
                                        {
                                            counter8++;
                                            
                                        }
                                        
                                            
                                        
                                            for(int side9 = 0; counterTrials <= numberOfRolls;) 
                                            randomNumber = ((int)(0+ Math.random()* 11));
                                            if (randomNumber == 9)
                                            {
                                                counter9++;
                                                
                                            }
                                            
                                                
                                            
                                                for(int side10 = 0; counterTrials <= numberOfRolls;) 
                                                randomNumber = ((int)(0+ Math.random()* 11));
                                                if (randomNumber == 10)
                                                {
                                                    counter10++;
                                                    
                                                }
                                                
                                                    
                                                
                                                    for(int side11= 0; counterTrials <= numberOfRolls;)
                                                    randomNumber = ((int)(0+ Math.random()* 11));
                                                    if (randomNumber == 11)
                                                    {
                                                        counter11++;
                                                        
                                                    }
                                                    

        
        System.out.print("Sum Of Dice              Probability");
        System.out.print("\n1s" + "                       " + (double) (counter1/numberOfRolls) * 100;) + "%");
        System.out.print("\n2s" + "                       " + (double) (counter2/numberOfRolls) * 100) + "%");
        System.out.print("\n3s" + "                       " + (double) (counter3/numberOfRolls) * 100) + "%");
        System.out.print("\n4s" + "                       " + (double) (counter4/numberOfRolls) * 100) + "%");
        System.out.print("\n5s" + "                       " + (double) (counter5/numberOfRolls) * 100) + "%");
        System.out.print("\n6s" + "                       " + (double) (counter6/numberOfRolls) * 100) + "%");
        System.out.print("\n7s" + "                       " + (double) (counter7/numberOfRolls) * 100) + "%");
        System.out.print("\n8s" + "                       " + (double) (counter8/numberOfRolls) * 100) + "%");
        System.out.print("\n9s" + "                       " + (double) (counter9/numberOfRolls) * 100) + "%");
        System.out.print("\n10s" + "                      " + (double) (counter10/numberOfRolls) * 100) + "%");
        System.out.print("\n11s" + "                      " + (double) (counter11/numberOfRolls) * 100) + "%");                             
        }
        
} 

i got the print statements where it calculate from an example online, but i cant get them to work right.

[David Newton]

- What is the purpose of all those loops?
- If a given number (for example, 8) is never rolled, how many rolls will your code think it was rolled?
- Again--what is the purpose of curly brackets (the "{}" characters) in Java?

As reference point, the code to solve this problem is an order of magnitude shorter than you're currently making it. It's often helpful to think about the overall nature of the problem--here's one way I might think about it:

- I'm rolling a die n times, which sounds a lot like a for-loop.
- For each roll I record which number was rolled (you're using distinct variables, someone else suggested an array, which would eliminate quite a bit of code).
- After I've rolled the die an appropriate number of times I do the calculations (which you're doing correctly, more or less, although there seems to be a spurious semi-colon in your counter1 code).

[nathan gibson]

i know that i could make it very simple, but i am supposed to use nested loops. it is supposed to repeat for the number of times that the user enters.

[David Newton]

That requirement baffles me, but the rest of my comments still stand.

[Campbell Ritchie]

Lecturers can set assignments with baffling requirements in the hope of teaching a particular topic.

But I can't see any nested loops. Lots of loops yes, but not nested. And, as you have been told before, your loops are incomplete because you have not put enough {} is.