Advice PointCut methods not being called?

[Amandeep Singh]

I have no idea, why AudienceAdvice joinpoint methods are not being called.

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:aop="http://www.springframework.org/schema/aop"
xmlns:context="http://www.springframework.org/schema/context"
xmlns:tx="http://www.springframework.org/schema/tx"
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-2.5.xsd
http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-2.5.xsd
http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx-2.5.xsd">
<bean id="kenny" class="Instrumentalist">
<property name="instrument" ref="instrument"></property>
</bean>
<bean id="instrument" class="Saxophone"></bean>

<bean id="audience" class="Audience"></bean>
<bean id="audienceadvice" class="AudienceAdvice">
<property name="audience" ref="audience"></property>
</bean>

<bean id="audiencearoundadvice" class="AudienceAroundAdvice">
<property name="audience" ref="audience"></property>
</bean>

<bean id="performancePointCut" class="org.springframework.aop.support.JdkRegexpMethodPointcut">
<property name="pattern" value=".*"></property>
</bean>

<bean id="audienceAdvisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
<property name="advice" ref="audienceadvice"></property>
<property name="pointcut" ref="performancePointCut"></property>
</bean>

<bean id="audienceAdvisor1" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
<property name="advice" ref="audienceadvice"></property>
<property name="pattern" value=".*perform"></property>
</bean>
</beans>

import java.lang.reflect.Method;
import org.springframework.aop.AfterReturningAdvice;
import org.springframework.aop.MethodBeforeAdvice;
import org.springframework.aop.ThrowsAdvice;

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
/**
 *
 * @author rocky
 */
public class AudienceAdvice implements MethodBeforeAdvice, AfterReturningAdvice, ThrowsAdvice {

    public AudienceAdvice() {
    }

    public Audience audience;

    public void setAudience(Audience audience) {
        this.audience = audience;
    }

    public void before(Method arg0, Object[] arg1, Object arg2) throws Throwable {
        audience.takeSeats();
        audience.turnCellPhoneOff();
    }

    public void afterReturning(Object arg0, Method arg1, Object[] arg2, Object arg3) throws Throwable {
        audience.clap();
    }
    public void afterThrowing(Method arg1, Object[] arg2, Object arg3, NullPointerException nullPointerException){
    audience.demandRefund();
    }
}

[Amandeep Singh]

Finally i got it solved.

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xmlns:aop="http://www.springframework.org/schema/aop"
       xmlns:context="http://www.springframework.org/schema/context"
       xmlns:tx="http://www.springframework.org/schema/tx"
       xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
       http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-2.5.xsd
       http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-2.5.xsd
       http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx-2.5.xsd">
<bean id="kenny" class="Instrumentalist">
    <property name="instrument" ref="instrument"></property>
</bean>
<bean id="instrument" class="Saxophone"></bean>

<bean id="audience" class="Audience"></bean>
<bean id="audienceadvice" class="AudienceAdvice">
    <property name="audience" ref="audience"></property>
</bean>

<bean id="audiencearoundadvice" class="AudienceAroundAdvice">
    <property name="audience" ref="audience"></property>
</bean>

<bean id="performancePointCut" class="org.springframework.aop.support.JdkRegexpMethodPointcut">
    <property name="pattern" value=".*"></property>
</bean>

<bean id="audienceAdvisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
    <property name="advice" ref="audienceadvice"></property>
    <property name="pointcut" ref="performancePointCut"></property>
</bean>

<bean id="audienceAdvisor1" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
    <property name="advice" ref="audienceadvice"></property>
    <property name="pattern" value=".*perform"></property>
</bean>

<bean id="audienceAdvisor2" class="org.springframework.aop.aspectj.AspectJExpressionPointcutAdvisor">
    <property name="expression" value="execution(* *.perform(..))"></property>
    <property name="advice" ref="audienceadvice"></property>
</bean>


<bean id="dukeTarget" class="PoeticJuggler">
    <property name="instrument" ref="instrument"></property>
</bean>
<bean id="duke" class="org.springframework.aop.framework.ProxyFactoryBean">
    <property name="target" ref="dukeTarget"></property>
    <property name="interceptorNames" value="audienceAdvisor2"></property>
    <property name="proxyInterfaces" value="Performer"></property>
</bean>

</beans>

[Removed not nice comment. Mark Spritzler]

[Mark Spritzler]

FYI, it looks like you are testing out the code from the Spring in Action book. And to let you know that that book is based mostly on Spring 2.0 version. While a lot of that book is still relevant, some of the examples are "older" way of doing things.

For instance in your Advice class, you are now tied to Spring because of the interfaces that you implemented. Where the more POJO clean way is to create a class and add either xml aop tags to declare your joinpoints or with Annotations. This keeps your "Aspect" class a pure Java object.

Here is the xml way
http://static.springsource.org/spring/docs/2.5.x/reference/aop.html#aop-schema-declaring-an-aspect

And here is the Annotation way
http://static.springsource.org/spring/docs/2.5.x/reference/aop.html#aop-at-aspectj

Good Luck

Mark