FTP in Java

[Bhupendra Gupta]

Hi team,

I am new to java and an not sure whether this is the right place to ask question about FTP in java..

I have written a small code in java which FTPs to one of the remote server.

The code gives me the list of files that are present on that server but it does not uploads the file there.(code is running successfully though)

here is the code:

	FTPClient client = new FTPClient();
			FileInputStream ftpFile = null;
			String filename = "C:\\Working\\Account\\test.txt";
			
		    client.connect("someserver.com");
		    boolean login = client.login("username", "pwd");

		    if (login) {
		        System.out.println("Login success...");
		    	 String[] names = client.listNames();
		    	    for (String name : names) {
		    	      System.out.println("Name = " + name);
		    	    }		
		    	    if(filename.length()>1){
		    	    	try{
		    	    		ftpFile = new FileInputStream(filename);
		    	    		client.storeFile(filename, ftpFile);
		    	    		
		    	    		if( client.changeToParentDirectory())
		    	    		{
		    	    			System.out.print(client.printWorkingDirectory());
		    	    			System.out.println("file transfered");
		    	    		}
		    	    		else 
		    	    		{
		    	    			System.out.println("file not transfered");
		    	    			
		    	    		}
		    	    	}catch(Exception ex){
		    	    		ex.printStackTrace();		    	    		
		    	    	}
		    	    }
		      client.logout();
		      ftpFile.close();
		    }
		    client.disconnect();

Could you please help me out with this

[Ulf Dittmer]

Welcome to JavaRanch.

In the future, please UseCodeTags when posting code of any length. It's unnecessarily hard to read the code as it is, making it less likely that people will bother to do so. I've done this for you here.

For starters, you're ignoring the return value of "storeFile". That will tell you whether the file upload was successful or not. I'm not sure why you think that "client.changeToParentDirectory()" would tell you whether the upload was successful - it tells you whether changing the directory was successful, which is something entirely different.

Also note that you're using the complete client-side path as filename for the server - including the directories. You should truncate that to just the filename.

I'll move the post to the "Other Open Source Projects" forum, where the Apache libraries are discussed.

[Joe San]

Are you using any Apache related API's by the way?