GridBagConstraints Problem

[Leandro Coutinho]

Hi!

Please run the code below. I would like that the second text field in the second row to be right after the first text field (in the second row).
I would also like to have the components in the top-left corner.

import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JTextField;

public class GBL1 {

	public static void main(String[] args) {
		JFrame frame = new JFrame();
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		
		frame.add(new GBL1Panel());
		
		frame.setSize(700, 700);
		frame.setVisible(true);
	}
}

class GBL1Panel extends JPanel {
	
	private JLabel lblName, lblPhone1, lblPhone2;
	private JTextField txtName, txtDdd1, txtPhone1,
						txtDdd2, txtPhone2;
	private JButton btnSave;
	
	public GBL1Panel() {
		setLayout(new GridBagLayout());
		
		GridBagConstraints c = new GridBagConstraints();
		c.anchor = GridBagConstraints.NORTHWEST;
				
		c.gridy = 0; // first line
		lblName = new JLabel("Nome:");
		c.gridx = 0;
		add(lblName, c);
		
		txtName = new JTextField(20);
		c.gridx = 1;
		c.gridwidth = 5;
		add(txtName);
		
		c.gridwidth = 1; // back to default
		
		c.gridy = 1; // second line
		lblPhone1 = new JLabel("Telefone 1:");
		c.gridx = 0;
		add(lblPhone1, c);		
		
		txtDdd1 = new JTextField(2);
		c.gridx = 1;
		add(txtDdd1, c);
		
		txtPhone1 = new JTextField(10);
		c.gridx = 2;
		add(txtPhone1, c);
		
		lblPhone2 = new JLabel("Telefone 2:");
		c.gridx = 3;
		add(lblPhone2, c);
						
		txtDdd2 = new JTextField(2);
		c.gridx = 4;
		add(txtDdd2, c);
		
		txtPhone2 = new JTextField(10);
		c.gridx = 5;
		add(txtPhone2, c);
		
		c.gridy = 2; // third line
		btnSave = new JButton("Cadastrar");
		c.gridx = 1;
		add(btnSave, c);
	}
}

[Mikko Kohtamäki]

You can add them into JPanel

public GBL1Panel() {
		setLayout(new GridBagLayout());

		GridBagConstraints c = new GridBagConstraints();
		c.anchor = GridBagConstraints.NORTHWEST;

		c.gridy = 0; // first line
		lblName = new JLabel("Nome:");
		c.gridx = 0;
		add(lblName, c);

		txtName = new JTextField(20);
		c.gridx = 1;
		c.gridwidth = 5;
		add(txtName);

		c.gridwidth = 1; // back to default

		c.gridy = 1; // second line
		lblPhone1 = new JLabel("Telefone 1:");
		c.gridx = 0;
		add(lblPhone1, c);

                txtDdd1 = new JTextField(2);
                txtPhone1 = new JTextField(10);
                JPanel panel = new JPanel(new FlowLayout(FlowLayout.LEADING, 0, 0));
                panel.add(txtDdd1);
                panel.add(txtPhone1);

		c.gridx = 1;
		add(panel, c);

		lblPhone2 = new JLabel("Telefone 2:");
		c.gridx = 2;
		add(lblPhone2, c);

		txtDdd2 = new JTextField(2);
		c.gridx = 3;
		add(txtDdd2, c);

		txtPhone2 = new JTextField(10);
		c.gridx = 4;
		add(txtPhone2, c);

		c.gridy = 2; // third line
		btnSave = new JButton("Cadastrar");
		c.gridx = 1;
		add(btnSave, c);
	}

[Leandro Coutinho]

good idea.

yeah, I can use one JPanel per row, but I would like to know what's wrong with the constraints. And I still need to position the elements in the top-left corner.

Thank you!

[Mikko Kohtamäki]

JPanel pane = new JPanel(new FlowLayout(FlowLayout.LEFT, 0, 0));
pane.add(new GBL1Panel());

or you can try

setAlignmentX(LEFT_ALIGNMENT);
setAlignmentY(TOP_ALIGNMENT);

for the component that contains GBL1Panel, but these often fails to function correctly



GridBagConstraints.anchor is used only for the components inside your GBL1Panel


Edit: and in GridBagLayout column widths are defined as what is the widthest component in column (component.getPreferredSize().width). you can use GridBagConstraints.gridwidth if some component should cover one or more columns

[Leandro Coutinho]

The first worked, but the second didn't.

Thanks very much for your help.

I almost don't do swing stuff, but I have to change one app from web to desktop. argh

After these problems with GridBagConstraints I started to use NetBeans' GUI builder.
Do you use some GUI builder or do you do your GUI coding?

[Mikko Kohtamäki]

Sorry while I looked your code a little better just fix one line and add another in your orginal code

FIX

line 44:
add(txtName, c);

ADD

line 75:
c.gridwidth = 2;

And the anchor thing you get from

JPanel pane = new JPanel(new FlowLayout(FlowLayout.LEFT, 0, 0));
pane.add(new GBL1Panel());

like I said in last post

[Mikko Kohtamäki]

No I have not used GUI Builder, but Netbeans yes...

[Leandro Coutinho]

Mikko Kohtamäki wrote:Sorry while I looked your code a little better just fix one line and add another in your orginal code

I hate when pass a lot of time thinking in a problem and it was a simple mistake.
I just forgot to pass the constraint...

Thanks a lot! I'll give GridBagLayout one more chance. xD

Mikko Kohtamäki wrote:No I have not used GUI Builder, but Netbeans yes...

I'm not sure if you understand. Just to clarify, GUI builder is a tool that NetBeans has to create graphical user interfaces. :]

[Mikko Kohtamäki]

I'm not sure if you understand. Just to clarify, GUI builder is a tool that NetBeans has to create graphical user interfaces. :]

Yes I understanded I just enjoy more coding by hand, builders gives me a headache... in netbeans I think it uses GroupLayout only...