Win a copy of Kotlin in Action this week in the Kotlin forum!
  • Post Reply Bookmark Topic Watch Topic
  • New Topic

I want feedback on a java tutorial i'm creating  RSS feed

 
Delete My Profile Please Deleteme
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I've created a learning java tutorial for our office, wouldn't mind a bit of feedback to see if i got the code right (i'm new to Java, from C#).
Then if anyone wants it, i could provide the finished tutorial to the wider community.
What do you guys think?
The code for the tutorial is at the below link for now (later once i'm confident the code is right, i'll write the tutorial to suit)

http://splinter.com.au/blog/?p=194

Cheers guys
 
Jelle Klap
Bartender
Posts: 1952
7
Eclipse IDE Java
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I don't have the oppertunity to really do an in-depth review right now, but one thing I noticed immediately after a quickscan of the source files is that you build-up HTML ouput in your action classes, you're using scriptlets in your JSP's, and yet you seem to be making use of the Struts MVC framework. That doesn't quite fit.
 
Maneesh Godbole
Bartender
Posts: 11445
18
Android Eclipse IDE Google Web Toolkit Java Mac Ubuntu
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Chris FromAustralia wrote:


Please check your private messages for an important administrative matter
 
Delete My Profile Please Deleteme
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Jelle Klap wrote:I don't have the oppertunity to really do an in-depth review right now, but one thing I noticed immediately after a quickscan of the source files is that you build-up HTML ouput in your action classes, you're using scriptlets in your JSP's, and yet you seem to be making use of the Struts MVC framework. That doesn't quite fit.


Thanks Jelle for taking the time to read through it. That is much appreciated.
Now instead of what i'm doing (building html in the action and passing it to the JSP) what should i be doing? I'm new to this so keep in mind that 'scriptlets' and 'mvc' are meaningless to me.
 
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!