Calling Showform on Onsubmit of SimpleFormController

[Mark Reyes]

Hi All,

I am currently experimenting on the Spring MVC by trying out some simple exercise.

I have this scenario in my mind, suppose I want to validate something using the onsubmit method of the simpleformcontroller.
In this case, I want to check if the commandclass value is correct and if there is something wrong, I want to display the form again
with form:errors.

Thru some experiment I was able to come up with below code. I call the showform on the onsubmit method. My question is, is this the right
way to do what I want. I am not sure if this is efficient or not.

  package com.alas.web;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.web.servlet.view.RedirectView;

import com.alas.dao.UserInfoDao;
import com.alas.domain.User;
import com.alas.service.LoginInfo;

public class LoginController extends SimpleFormController {
	protected final Log logger = LogFactory.getLog(getClass());

	public ModelAndView onSubmit(HttpServletRequest request,
			HttpServletResponse response, Object command, BindException errors) {
		logger.info("LoginController onSubmit...");

		LoginInfo loginInfo = (LoginInfo) command;

		logger.info("Validating Login Info....");

		// check if user exist in DB
		if (!loginInfo.getStrUserID().equals("admin")) {
			errors.rejectValue("strUserID", "user.not.enrolled",
					new Object[] { loginInfo.getStrUserID() },
					"User Not Enrolled");
			logger.info("Validating userid = " + loginInfo.getStrUserID());
			try {
				return showForm(request, errors, getFormView());
			} catch (Exception e) {
			}
		}
		if (!loginInfo.getStrPassword().equals("adminpwd")) {
			errors.rejectValue("strPassword", "incorrect.password",
					"Incorrect Password");
			logger.info("Validating password = " + loginInfo.getStrPassword());
			try {
				[b]return showForm(request, errors, getFormView());[/b]
			} catch (Exception e) {
			}
		}

		return new ModelAndView(new RedirectView(getSuccessView()));
	}


}
  

By the way, here's my another question. Given below scenario, should it be much better If I transfer below code in the validator class?
I currently used my validator class in validating for empty space which I can do also with javascript.

I want to ask those experts in spring if its alright to put all of your business logic validation in the Validator class? I am currently reluctant to
add JDBC and DAO calls in my validator. I wanted to hear if those who have created full grown enterprise application in spring has been doing these.

Thanks and looking forward to your responses.

[abhishek gem]

Dear,


Thanks for your code that helped me to answere some of my problem, keep up the good work bro..