Closed Statement issue

[Dan Parsons]

I am getting closed exception messages with my below jdbc connection to Oracle 9i from Tomcat 6 container:
java.sql.SQLException: Closed Statement
and
java.sql.SQLException: Closed Statement: next



Please advise what I can modify to eliminate the exception messages?

private Connection connection;
public ArrayList<MoneyBean> getMoneyList()
{
     ArrayList<MoneyBean> list = new ArrayList<MoneyBean>();
     connection = new DatabaseConnector.getConnection();
   
     if(connection != null)
     {
          ResultSet rs = null;
          PreparedStatement preparedStatement = null;
     
          try {
               String BankQuery = "Select money from Bank";
               preparedStatement = connection.preparedStatement(BankQuery);
               rs = preparedStatement.executeQuery();
               while(rs.next())
               {
                    MoneyBean money = new MoneyBean();
                    money.setMoney(rs.getString("money"));
                    list.add(money);
               }
          }
      }
      catch(SQLException ex)
      {
          System.out.println(ex); 
      }
      finally
      {
         try
         { 
            if(rs != null)
            { 
                rs.close(); 
            } 
          } 
          catch(Exception e) 
         { 
            e.printStackTrace(); 
          } 

          try
          { 
             if(preparedStatement != null)
             { 
                preparedStatement.close(); 
              } 
           } 
           catch(Exception e) 
          { 
              e.printStackTrace(); 
          } 

          try
          { 
            if(connection  != null)
            { 
                connection.close(); 
            } 
          } 
          catch(Exception e) 
          { 
            e.printStackTrace(); 
          }    
     }
return list;
}

Servlet controller handling of list:

private ArrayList<MoneyBean> money;
.....
money = new ArrayList<MoneyBean>(moneyManager.getMoneyList());
session.setAttribute("money", money);

[Sagar Rohankar]

Dan Parsons wrote:Please advise what I can modify to eliminate the exception messages?

You better post the stack trace . Also are you sure about compilation of this code, try is NOT immediately followed by catch block

# if(connection != null)  
#      {  
#           ResultSet rs = null;  
#           PreparedStatement preparedStatement = null;  
#        
#           try {  
#                String BankQuery = "Select money from Bank";  
#                preparedStatement = connection.preparedStatement(BankQuery);  
#                rs = preparedStatement.executeQuery();  
#                while(rs.next())  
#                {  
#                     MoneyBean money = new MoneyBean();  
#                     money.setMoney(rs.getString("money"));  
#                     list.add(money);  
#                }  
#           }  // no catch
#       }  
#       catch(SQLException ex)  
#       {  
#           System.out.println(ex);   
#       }  

[Ireneusz Kordal]

You can use appache commons DBUtils library:
http://commons.apache.org/dbutils/apidocs/org/apache/commons/dbutils/DbUtils.html

example:

  
try{
...
}finally{
   // Use this helper method so we don't have to check for null and don't have to catch any exception
   DBUtils.closeQuietly(connection, statement, resultset);
}  

or you can write your own from scratch.