Form does not validated correctly

[tangara goh]

Hi, I've been struggling with coding this form for many days. I hope someone can point out to me what went wrong. If a person leaves a blank, then an error message will appear. However, if I didn't enter anything, 2 similar messages appear, which is what I don't want. I only want error message to appear if it is blank or if the data does not conform to the regular expression. Also, I'm not so how to validate the radio button. please please help me.

Here is my code:-

   

<script language="javascript">
            function checkForm(){
                var objForm = new Object();
                var objFullNameTextBox = new Object();
                var objMessageBox = new Object();
                var objAddress = new Object();
                var objNRIC = new Object();
                var objContact = new Object();
                var objEmail = new Object();
                var objGender = new Object();
                var objType = new Object();
                var objRemarks = new Object();
                var strMemberName = new String("");
                var strEmail = new String("");
                var strAddress = new String("");
                var strNRIC = new String("");
                var strContact = new String("");
                var strGender = new String("");
                var strType = new String("");
                var strRemarks = new String("");
                var blnIsAllOkay = new Boolean(true);
                var strMessageToUser = new String("");

                objForm = document.getElementById("frmData");
                objFullNameTextBox = document.getElementById("txtFullName");
                objMessageBox = document.getElementById("divMessage");
                objAddress = document.getElementById("txtAddress");
                objNRIC = document.getElementById("txtNRIC");
                objContact = document.getElementById("txtContact");
                objEmail = document.getElementById("txtEmail");
                objGender = document.getElementById("txtGender");
                objType = document.getElementById("txtMember");
                objRemarks = document.getElementById("txtRemarks");

                strEmail = objEmail.value;
                strAddress = objAddress.value;
                strNRIC = objNRIC.value;
                strContact = objContact.value;
                strGender = objGender.value;
                strType = objType.value;
                strRemarks = objRemarks.value;
                strEmail = trimData(strEmail);
                strAddress = trimData(strAddress);
                strNRIC = trimData(strNRIC);
                strContact = trimData(strContact);
                strGender = trimData(strGender);
                strType = trimData(strType);
                strRemarks = trimData(strRemarks);
                strMemberName = objFullNameTextBox.value;
                strMemberName = trimData(strMemberName);
                if (strMemberName=="" ){
                    strMessageToUser += "Please indicate Name<br>";
                    blnIsAllOkay = false;
                }
                if (strNRIC=="" ){
                    strMessageToUser += "Please indicate NRIC No<br>";
                    blnIsAllOkay = false;
                }
                if (strAddress=="" ){
                    strMessageToUser += "Please indicate Address<br>";
                    blnIsAllOkay = false;
                }
                if (strContact=="" ){
                    strMessageToUser += "Please indicate Contact<br>";
                    blnIsAllOkay = false;
                }
                
                //function validateNRIC(pstrData){
                var NRICRegEx = /^[A-Z]\d{7}[A-Z]$/;
                //str = pstrData
                if(strNRIC.match(NRICRegEx)){
                    blnIsAllOkay == true;
                }else {
                    strMessageToUser += "Please indicate correct NRIC.<br>";
                }
                 

                // function validateEmail(pstrData){
                var emailRegEx = /^([a-zA-Z0-9_\.\-])+\@(([a-zA-Z0-9\-])+\.)+([a-zA-Z0-9]{2,4})+$/;
                //str = pstrData
                if(strEmail.match(emailRegEx)){
                    blnIsAllOkay == true;
                }else{
                    strMessageToUser += "Please indicate correct email.<br>";
                }                 
                        
                // function validateContact(pstrData){
                var ContactRegEx = /d{8}/;
                //   str = pstrData
                if (strContact.match(ContactRegEx)){
                    blnIsAllOkay == true;
                } else {
                    strMessageToUser += "Please indicate correct Contact Number<br>";
                }
                
                // To check that one of the radio buttons for Gender is selected
                // var radioChecked = false;
                //for (var i=0; i < strGender.length; i--){
                  //if(Gender[i].radioChecked){
                //strMessageToUser += "Please check that one of the buttons for Gender is selected>";
                 // }

                function trimData(pstrData){
                    var intIndex=0;
                    var intRightIndex= pstrData.length -1;
                    while((intIndex < pstrData.length) && (pstrData.charAt(intIndex) == ' '))
                    {intIndex++; }
                    while((intRightIndex > intIndex) && (pstrData.charAt(intRightIndex) == ' '))
                    {intRightIndex-=1;}
                    return pstrData.substring(intIndex, intRightIndex+1);
                }//end of function trimData

                if (blnIsAllOkay==true){
                    objForm.submit();
                }else{
                    objMessageBox.innerHTML = strMessageToUser;
                }
                  function clearErr() {
                    objMessageBox = document.getElementById("divMessage");
                    objMessageBox.innerHTML = "";
                }
                }
               </script>
    </head>
    <body>
        <form id="frmData" name="frmData" action="addmember"
              method="post" >
            <table border="0" style="width:500px;padding:3px;" >
                <tr>
                    <td colspan="2" class="tdTitle" >Member Registration</td>
                </tr>
                <tr>
                    <td>Full Name</td>
                    <td><input type="text" id="txtFullName" name="txtFullName" value=""></td>
                </tr>
                <tr>
                    <td>Email</td>
                    <td><input type="text" id="txtEmail" name="txtEmail" value=""></td>
                </tr>
                <tr>
                    <td>Address</td>
                    <td><input type="text" id="txtAddress" name="txtAddress" value=""></td>
                </tr>
                <tr>
                    <td>NRIC No</td>
                    <td><input type="text" id="txtNRIC" name="txtNRIC" value=""></td>
                </tr>
                <tr>
                    <td>Contact</td>
                    <td><input type="text" id="txtContact" name="txtContact" value=""></td>
                </tr>
                 <tr>
                    <td>Gender</td>
                    <td><input type="radio" id="txtGender" value="Male" name="txtGender"/>Male
                        <input type="radio" id="txtGender" value="Female" name="txtGender"/>Female</td>
                </tr>
                <tr>
                    <td>Type</td>
                    <td><select name="txtMember" id="txtMember">
                            <option>Member</option>
                            <option>Volunteer</option>
                        </select>
                    </td>
                </tr>
                <tr>
                    <td>Remarks</td>
                    <td><input type="text" id="txtRemarks" name="txtRemarks"></td>
                <tr>
                    <td colspan="2"><div id="divMessage"></div></td>
                </tr>
                <tr>
                    <td colspan="2" align="right">
                    <td><input type="button" id="btnSubmit" name="btnSubmit" value="Submit" onclick="checkForm();" /></td>
                        <td><input id="reset" type="reset" name="reset" value="reset" onclick="clearErr();"/></td>
                </tr>
            </table>
        </form>
    </body>
</html>



 

[Gregg Bolinger]

Looks to me like a JavaScript issue. Moving to the JavaScript forum...

[Eric Pascarello]

There is no need to do this:

                 var objForm = new Object();  
                 var objFullNameTextBox = new Object();  
                 var objMessageBox = new Object();  
                 var objAddress = new Object();  
                 var objNRIC = new Object();  
                 var objContact = new Object();  
                 var objEmail = new Object();  
                 var objGender = new Object();  
                 var objType = new Object();  
                 var objRemarks = new Object();  
                 var strMemberName = new String("");  
                 var strEmail = new String("");  
                 var strAddress = new String("");  
                 var strNRIC = new String("");  
                 var strContact = new String("");  
                 var strGender = new String("");  
                 var strType = new String("");  
                 var strRemarks = new String("");  
                 var blnIsAllOkay = new Boolean(true);  
                 var strMessageToUser = new String("");  

That is just a waste of space and js rendering time.

If you do not want both of the error messages to display, than do not do the second check if the first one fails.

Eric

[tangara goh]

But it is a requirement. I cannot have blank and I need to have validation rules.

Now, the DOB validation just doesn't work and I am taking it off, leaving the bare necessities.

Please advise and also the reset button. Netbean IDE keeps asking me to define object var.

tks.

[David Newton]

tangara goh wrote:But it is a requirement. I cannot have blank and I need to have validation rules.

I think you'll find that JavaScript does not work the way you believe it does.

[tangara goh]

I have a check with my friend. Yes. I just take out one and it will work as I want. Tks.

[Zhixiong Pan]

Regarding the radio validator issue, you can refer to the post of https://coderanch.com/t/476954/HTML-JavaScript/Radio-Validator.

[tangara goh]

Thank you.