Am i making use of classes in the right way?

[Mark Toddd]

Hi all.
Could you glance over my code and let me know if i'm made use of classes in the right way.
Much appreciated

    
package ruby;

public class Mainprog {

	public static void main(String[] args) {
		
		//Implement frame
		Rubyframe displayFrame = new Rubyframe();
		displayFrame.myframe();
		
		
		//Quit
		Leave complete = new Leave();
		complete.end();	
		
		
		//Dialog box
		Message boo = new Message();
		boo.popup();	
	}
	
}

    
package ruby;

import javax.swing.*;

public class Rubyframe {

	public void myframe() {
		
		JFrame frame = new JFrame("Ruby 0.1");;
		JPanel panel = new JPanel();
		JLabel label = new JLabel("Welcome to Ruby 0.1");
		JButton buttonA = new JButton("Quit");
		JButton buttonB = new JButton("Click Me");
		
		frame.add(panel);
		panel.add(label);
		panel.add(buttonA);
		panel .add(buttonB);
		
		frame.setSize(200,250);
		frame.setVisible(true);
		
		buttonA.addActionListener(new Leave());
		buttonB.addActionListener(new Message());		
	}
}

    
package ruby;

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

public class Leave implements ActionListener {
	public void end() {
	}
		
	public void actionPerformed(ActionEvent e) {
		System.exit(0);
			
	}

}

    
package ruby;

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import javax.swing.JOptionPane;

public class Message implements ActionListener {
	
	public void popup() {
		
	}
		
	public void actionPerformed (ActionEvent e) {
		JOptionPane.showMessageDialog(null, "Hi there");
	
	}
}

[Rob Spoor]

Have you tried it? I would say not, or you would notice that it doesn't work as you expect it.

I suggest you (re?)read the Swing tutorial.

[Mark Toddd]

Hi

Actually its works perfectly and as expected.

Could you be a little clearer as to why you think it is wrong.

Cheers

[Wouter Oet]

I think you did a good job . I would change three things:

Put the code in rubyframe.myframe into the constructor of Rubyframe.
Put the code in main into a instance method of Mainprog and create in main an instance.
Create the actionslisteners in mainprog instead of in myframe and use them as parameters in the Rubyframe constructor.

[Mark Toddd]

I'll have to go and do some reading on constructor(s) now haha

Thanks for the tips.

[pete stein]

... and I have to give you kudos for not extending JFrame when you didn't have to.

[Gregg Bolinger]

pete stein wrote:... and I have to give you kudos for not extending JFrame when you didn't have to.

He follows advice. See here so that is good. ;)

[Gregg Bolinger]

The code confuses me in the way you have used Listeners and how you are executing listener methods in your Mainprog class. Could you explain what you think this program should do?

[Mark Toddd]

Gregg Bolinger wrote:The code confuses me in the way you have used Listeners and how you are executing listener methods in your Mainprog class. Could you explain what you think this program should do?

No worries, I'll try

Please keep in mind that i'm only learning what I can via the 'net and a couple of Java books. Not to mention that I've only been mucking about with Java for around two weeks now. Now that I have my noob justification for crappy code out of the way here goes.


Assuming each class is a blueprint of a particular (re)usable action that I would like the application to perform.

1. I created a class for my the application interface. (Rubyframe.java)
2. I created a class to hold a actionlistener for a quit JButton belonging to the interface.(Leave.java)
3. I created another class to hold a second actionlistener for a JOptionPanel popup message.(Message.java)
4. I presumed that methods for these classes should be placed in the main Java file. (Mainprog.java)

I presumed that when Mainprog.java was executed the methods contained within were made available, which when called upon called the associated class into action.


Hope that makes sense

Cheers