fluctuation

[Muhammad usman shad]

Salam,

I have drawn a graph in java in paintComponet method which is repainted by using repaint method...

But my problem is that my GUI fluctuates...

How can i remove that fluctuation???

Please tell me some suggestion???

[Alex Parvan]

It shouldn't do that. Could you show us your code ? make sure you use the code tags.

[Darryl Burke]

The right way to do custom painting in Swing:
http://java.sun.com/docs/books/tutorial/uiswing/painting/index.html

[Campbell Ritchie]

Moving to GUI forum.

By "fluctuates" I presume you mean "flickers"?

Go into the API for whichever component you are painting on, and have a look at its constructors. You will probably find an overridden one with a boolean called doubleBuffered or something similar. Try putting "true" in that constructor. That might help.

[Muhammad usman shad]

Dear Campbell,

I am not using the buffer for painting.
I am drawing a bar graph on x and y axis..
The graph gets the axis values from user and draw the graph bars one by one...

When first bar appears that is well but when second to onwards bars appear,

The screen flickers due to repaint method...

My question is that:

How can i get rid of that flickering???

[Darryl Burke]

It isn't possible to guess what you might have done wrong from your description. To get better help sooner, post a SSCCE* that clearly demonstrates your problem.

* http://mindprod.com/jgloss/sscce.html

[Mikko Kohtamäki]

If the area is large what your program is painting then use buffering as recommended before, or call repaint(Rectangle) to repaint only renewing area (if it aint the whole area)

[Muhammad usman shad]

Here is the code of the graph...

Do follow the constraints wriiten on the JFrame...

And then post me the code which is anti-flickered...

 


import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

class Graph extends JFrame
{
	public JTextField x_axis;
	public JTextField y_axis;
	final JFrame GraphFrame;	
	
	String	constraints1;	
	String	constraints2;	
	String	constraints3;	
	String	constraints4;	
	String	constraints5;	
	String	constraints6;	
	String	constraints7;	
	String	constraints8;	
	String	constraints9;	
	String	constraints10;	
		
	Graph()
	{
		
	//////////////////////////////////////////////////////////////////////////////////////////////////////	
	/*	Not	The part of the program as these are constraints to use this program shown on the frames	*/	
	//////////////////////////////////////////////////////////////////////////////////////////////////////
		
		constraints1	=	"1.Do not let the both textfields null i.e Do enter a numerical integer value in them\n";
		constraints2	=	"2.In First text field i.e. x axis field\n";
		constraints3	=	"3.Enter the value from 2 to 12. No more and No less";
		constraints4	=	"4.In second field,Enter the values more than 1000 and less than 25000";
		constraints5	=	"5.When you have entered some value in both of the fields than click OK.";
		constraints6	=	"6.The Bar Graph will be displayed, this is well";
		constraints7	=	"7.But, now close the BarGraph Frame and again enter some value in the fileds\n";
		constraints8	=	"8.and click OK,Now you will see the screen Flickering...";
		constraints9	=	"9.How i remove it...";
		constraints10	=	"10.This is my PROBLEM...";
					
		setBounds(0,0,1024,748);
		setTitle("Graph");
		setDefaultCloseOperation(EXIT_ON_CLOSE);
		
		GraphFrame	=	new JFrame();
		GraphFrame.setBounds(30,60,940,675);
		GraphFrame.setTitle("GraphFrame");

		JPanel InputPanel	=	new JPanel();
		
		InputPanel.setLayout(null);
			
		JLabel	con1	=	new JLabel(constraints1);
		con1.setLocation(50,250);
		con1.setSize(con1.getPreferredSize());
		InputPanel.add(con1);

		JLabel	con2	=	new JLabel(constraints2);
		con2.setLocation(50,270);
		con2.setSize(con2.getPreferredSize());
		InputPanel.add(con2);

		JLabel	con3	=	new JLabel(constraints3);
		con3.setLocation(50,290);
		con3.setSize(con3.getPreferredSize());
		InputPanel.add(con3);

		JLabel	con4	=	new JLabel(constraints4);
		con4.setLocation(50,310);
		con4.setSize(con4.getPreferredSize());
		InputPanel.add(con4);

		JLabel	con5	=	new JLabel(constraints5);
		con5.setLocation(50,330);
		con5.setSize(con5.getPreferredSize());
		InputPanel.add(con5);

		JLabel	con6	=	new JLabel(constraints6);
		con6.setLocation(50,350);
		con6.setSize(con6.getPreferredSize());
		InputPanel.add(con6);

		JLabel	con7	=	new JLabel(constraints7);
		con7.setLocation(50,370);
		con7.setSize(con7.getPreferredSize());
		InputPanel.add(con7);

		JLabel	con8	=	new JLabel(constraints8);
		con8.setLocation(50,390);
		con8.setSize(con8.getPreferredSize());
		InputPanel.add(con8);

		JLabel	con9	=	new JLabel(constraints9);
		con9.setLocation(50,410);
		con9.setSize(con9.getPreferredSize());
		InputPanel.add(con9);

		JLabel	con10	=	new JLabel(constraints10);
		con10.setLocation(50,430);
		con10.setSize(con10.getPreferredSize());
		InputPanel.add(con10);

	////////////////////////////////////////////////////////////////////////////////////////////////////////////////
										/*	The Program starts from here	*/
	////////////////////////////////////////////////////////////////////////////////////////////////////////////////
	
		x_axis	=	new JTextField();
		x_axis.setBounds(400,10,100,30);
		InputPanel.add(x_axis);
		add(InputPanel);
		
		y_axis	=	new JTextField();
		y_axis.setBounds(510,10,100,30);
		InputPanel.add(y_axis);
		add(InputPanel);

		JLabel	x_label	=	new JLabel("X_Axis");
		JLabel	y_label	=	new JLabel("Y_Axis");

		x_label.setLocation(430,50);
		x_label.setSize(x_label.getPreferredSize());

		y_label.setLocation(540,50);
		y_label.setSize(y_label.getPreferredSize());

		InputPanel.add(x_label);
		InputPanel.add(y_label);
		
		JButton	ok	=	new JButton("OK");
		ok.setBounds(475,75,60,25);
		InputPanel.add(ok);
		
		ok.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent e)
			{
				String	xx	=	x_axis.getText();
				String	yy	=	y_axis.getText();
		
				GraphFrame.getContentPane().add(new GraphPanel(xx,yy));
				GraphFrame.setVisible(true);
			}
		});	//	new actionListener
	}
	public static void main (String[] args)
	{
		JFrame	frame	=	new Graph();
		frame.setVisible(true);
	}
}

class GraphPanel extends JPanel
{
	int	x_axis;
	int	y_axis;
	
	double y_axis_double;
	float y_axis_float;
	String	y_axis_string;
	
	String	tmcmp;

	GraphPanel(String x, String y)
	{
		x_axis	=	Integer.parseInt(x);
		x_axis	=	x_axis*50;							//	x_axis pixels
		
		y_axis_double	=	Double.parseDouble(y);
		y_axis_double	=	y_axis_double*0.02;			//	y_axis pixels
		y_axis_double	=	600.000-y_axis_double;

		y_axis_string	=	String.valueOf(y_axis_double);
		y_axis_float	=	Float.parseFloat(y_axis_string);

		y_axis		=	(int)(y_axis_float);

		tmcmp	=	y+" ns";

	}
	public void paintComponent(Graphics g)
	{
		super.paintComponent(g);

		g.setColor(Color.red);
		g.drawLine(100,600,825,600);		//	X_Axis
		g.drawLine(100,50,100,600);			//	Y_Axis

		g.setColor(Color.magenta);
		g.drawString("0",25,600);			//	0
		g.drawString("4000",25,520);		//	0
		g.drawString("8000",25,440);		//	0
		g.drawString("12000",25,360);		//	0
		g.drawString("16000",25,280);		//	0
		g.drawString("20000",25,200);		//	0
		g.drawString("24000",25,120);		//	0
		
		g.setColor(Color.blue);
		g.drawString("Time\nComplexty",15,40);		//	0
						
		g.setColor(Color.red);
		g.drawString("2",100,625);		//	5
		g.drawString("4",200,625);		//	5
		g.drawString("6",300,625);		//	5
		g.drawString("8",400,625);		//	5
		g.drawString("10",500,625);		//	5
		g.drawString("12",600,625);		//	5
		g.drawString("14",700,625);		//	5

		g.setColor(Color.magenta);
		g.drawString("Inputs",850,625);		//	5

		g.setColor(Color.blue);
		
		g.drawString(tmcmp,x_axis-15,y_axis-5);
		g.drawLine(x_axis,600,x_axis,y_axis);
		repaint();
	}
}

[Michael Dunn]

do you know what this does
repaint();
when called from paintComponent()?

[Muhammad usman shad]

Yes,
It repaints the screen...
But did you execute my program???

If yes,
then what is the solution???

[Michael Dunn]

> It repaints the screen...

which calls paintComponent(..)
which contains repaint()
which calls paintComponent(..)
which contains repaint()
which calls paintComponent(..)
which contains repaint()
which calls paintComponent(..)
which contains repaint()
which calls paintComponent(..)
which contains repaint()

do you now understand?

[Rok Štelcer]

Remove repaint(), as Michael already said ...

[Alex Parvan]

You can't call repaint() inside the paintComponent() method because repaint() calls paintComponent(). What you should do is either create a thread, either use a listener event.

I wrote you a quick program so you can understand:

import java.awt.Graphics;
import javax.swing.JFrame;
import javax.swing.JPanel;

public class B {
    public static void main(String args[]) {
        JFrame frame = new JFrame();
        frame.setSize(300, 300);
        frame.add(new MyPanel());
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setVisible(true);
    }
}

class MyPanel extends JPanel implements Runnable {
    private int i = 20;

    public MyPanel() {
        Thread th = new Thread(this);
        th.start();
    }

    public void run() {
        while(true) {
            i++;
            repaint();
            try {
                Thread.sleep(100); //miliseconds to wait before moving on
            } catch(InterruptedException e) {
                e.printStackTrace();
            }
        }
    }

    @Override
    public void paintComponent(Graphics g) {
        super.paintComponent(g);
        //draw whatever you want
        g.drawString("Metallica rulzz the world !", i, i);
    }
}

This should clear things up.

[vijay jamadade]

......
[MG]Removed hijack

[Maneesh Godbole]

Vijay,
I have removed your thread hijack. Please post your question in a new thread.
http://faq.javaranch.com/java/UseOneThreadPerQuestion

[Muhammad usman shad]

Parvan Alexandro!!!
Thank you very much...
You told me to solve my problem using thread...
I did that yesterday...
I have solved my problem...

Again thanks alot...