execute() issue in Action class

[Pradeep Adibatla]

My Execute function in action class is getting executed twice...initially with all relavant output and then with all zero and null values...

What should be the issue??

[David Newton]

Without any code, configuration, or anything else, it's impossible to help.

[Sagar Rohankar]

or debug that action class

[Pradeep Adibatla]

This is my execute method...

 
String tar;
    int why=1;

    @Override
    public String execute() throws Exception 
    {

         session=request.getSession();
         session.setAttribute("rsName",rsName);
         
        StorageBean.setIruleset(rsSelId);
        rulesetObjectToDBPersistence= new RulesetObjectToDBPersistence();
        rulesetToSerializableObjectPersistence =new RulesetToSerializableObjectPersistence();
        ruleList=new ArrayList<Rule>();

        System.out.println("==============================================================================================================");
        System.out.println("in RulesetAction Execute() !!! ");
        System.out.println("why is :--> "+why);
        System.out.println("addRuleSet--->"+addRuleSet);
        System.out.println("addrsok--->"+addRsok);
        System.out.println("rsName--->"+rsName);
       

        if (addRsok != null)
        {
            if (addRsok.equalsIgnoreCase("Ok"))
            {
                System.out.println("in addRsOK !!!");
                try
                {           
                   System.out.println("The values are :--->"+"1 "+rulesetCategory
                   +",2 "+rulesetName+",3 "+rulesetDescription+",4 "+rulesetAuthor
                   +",5 "+fromDate+",6 "+toDate);

                   ruleSet.setRsId(Integer.parseInt(rsId));
                   ruleSet.setCategory(rulesetCategory);
                   ruleSet.setRulesetName(rulesetName);
                   ruleSet.setDescripion(rulesetDescription);
                   ruleSet.setAuthor(rulesetAuthor);
                   ruleSet.setFromDate(fromDate);
                   ruleSet.setToDate(toDate);

                   System.out.println("The values to be persisted are :--->");

                   rulesetObjectToDBPersistence.setDataToDB(ruleSet);

               //    rulesetToSerializableObjectPersistence.serializeRuleset(ruleSet);

              //    tar= "success";

                  rulesetCategory="";
                  rulesetName="";
                  rulesetDescription="";
                  rulesetAuthor="";
                  fromDate="";
                  toDate="";

                }
                catch(Exception e)
                {
                    System.out.println("e is :--->"+e.getMessage());
                }

            }
        }
        else if(modifyRsOk!=null)
        {
            System.out.println("In modifyRSOk !!!");
            
            try
            {
                 System.out.println("The values are :--->"+"1 "+rulesetCategory
                   +",2 "+rulesetName+",3 "+rulesetDescription+",4 "+rulesetAuthor
                   +",5 "+fromDate+",6 "+toDate);

                ruleSet.setRsId(Integer.parseInt(rsId)) ;
                ruleSet.setCategory(rulesetCategory);
                ruleSet.setRulesetName(rulesetName);
                ruleSet.setDescripion(rulesetDescription);
                ruleSet.setAuthor(rulesetAuthor);
                ruleSet.setFromDate(fromDate);
                ruleSet.setToDate(toDate);

               System.out.println("The values to be persisted are :--->");

               rulesetObjectToDBPersistence.modifyRSDataToDB(ruleSet);

                tar= "success";

                rulesetCategory="";
                rulesetName="";
                rulesetDescription="";
                rulesetAuthor="";
                fromDate="";
                toDate="";

            }
            catch(Exception e)
            {
                System.out.println(" e is :---> "+e.getMessage());
            }
        }
        else if(deleteRuleSet!=null)
        {
            System.out.println("In deleteRuleSet !!!");

            try
            {

                ruleSet.setRsId(Integer.parseInt(rsId)) ;
                ruleSet.setCategory(rulesetCategory);
                ruleSet.setRulesetName(rulesetName);
                ruleSet.setDescripion(rulesetDescription);
                ruleSet.setAuthor(rulesetAuthor);
                ruleSet.setFromDate(fromDate);
                ruleSet.setToDate(toDate);

                rulesetObjectToDBPersistence.DeleteRSDataFromDB(ruleSet);

                tar= "success";

                rulesetCategory="";
                rulesetName="";
                rulesetDescription="";
                rulesetAuthor="";
                fromDate="";
                toDate="";

            }
            catch(Exception e)
            {
                System.out.println(" e is :---> "+e.getMessage());
            }
        }
        else if(rulesScreen != null)
        {
            if (rulesScreen.equalsIgnoreCase("Rules")) 
            {

                System.out.println("The value rsSelID is :---> "+Integer.toString(rsSelId));
               ruleObjectToDBPersistence.setRuleSetID(Integer.toString(rsSelId));
             //   StorageBean.setIruleset(rsSelId);
           //     System.out.println("The id in storageBean is :--> "+StorageBean.getIruleset());
          //      rulesScreen=null;

           //     loadRules();

           //     System.out.println("The ");

                 for (Iterator<Rule> it = ruleList.iterator(); it.hasNext();)
                 {
                       Rule ob = (Rule) it.next();

                       System.out.println("The ob is :--> "+ob);
                       System.out.println("The 1 is :--> "+ob.getRuleName());
                       System.out.println("The 2 is :--> "+ob.getRId());
                       System.out.println("The 3 is :--> "+ob.getPriority());
                       System.out.println("The 4 is :--> "+ob.getRuleDescription());
                       System.out.println("The 5 is :--> "+ob.getEnableStatus());
                       System.out.println("The 6 is :--> "+ob.getEffectiveFromDate());
                       System.out.println("The 7 is :--> "+ob.getEffectiveToDate());
                       System.out.println("The 8 is :--> "+ob.getRPid());

                 }

                System.out.println(" ----> size of ruleList is :--> "+ruleList.size());
                
                tar = "successA";

            }
        }
        else if (rulesetBack != null)
        {
            if (rulesetBack.equals("Back")) 
            {
                vIDList=new ArrayList();
                conList=new ArrayList();
                atrList=new ArrayList();
                dtypeList=new ArrayList();

                lpa=new LoadProjectAction();

                lpa.loadVocab();

                vIDList=lpa.getVIDList();
                conList=lpa.getConList();
                atrList=lpa.getAtrList();
                dtypeList=lpa.getDtypeList();

                System.out.println("The vIDList.size() are :--> "+vIDList.size());
                System.out.println("The conList.size() are :--> "+conList.size());
                System.out.println("The atrList.size() are :--> "+atrList.size());
                System.out.println("The dtypeList.size() are :--> "+dtypeList.size());

                tar = "successB";
            }
        } 
        else if (ruleDebuggerScreen != null)
        {
            if (ruleDebuggerScreen.equalsIgnoreCase("RuleDebugger"))
            {
                tar = "successC";
            }
        } 
        else if (pimpsmScreen != null)
        {
            if (pimpsmScreen.equalsIgnoreCase("PIM-PSM"))
            {
                tar = "successD";
            }
        }
       
        ++why;
        this.setRulesScreen(null);
        this.setRulesetBack(null);
        this.setRuleDebuggerScreen(null);
        this.setPimpsmScreen(null);

        System.out.println("The tar in RS is :--> "+tar);
       
        return tar;
        
    }

   

and these are the action mappings...

  
<action name="rulesets" class="com.infosys.struts.ibrs.RuleSetAction">
           
            <result name="successA">/jsp/rules.jsp</result>
            <result name="successB">/jsp/vocabulary.jsp</result>
            <result name="successC">/jsp/ruleDebugger.jsp</result>
            <result name="successD">/jsp/pim-psm.jsp</result>
            <result name="failure" >/jsp/rulesets.jsp</result>
        </action>

  

The above one is rulesetAction class...

In the rulesets jsp...I select row and I pass the button value "rulesScreen " and a value to this action class.

So rulesscreen is true and it enters that loop but it happens twice...this is the output...

   

==============================================================================================================
==============================================================================================================
in RulesetAction Execute() !!! 
in RulesetAction Execute() !!! 
why is :--> 1
why is :--> 1
addRuleSet--->null
addRuleSet--->null
addrsok--->null
addrsok--->null
rsName--->pro2_RS
rsName--->null
The value rsSelID is :---> 2
The value rsSelID is :---> 0
 ----> size of ruleList is :--> 0
The tar in RS is :--> successA
 ----> size of ruleList is :--> 0
The tar in RS is :--> successA

 

[vijay jamadade]

It must be because you have used submit tag in jsp and also you will be calling the javascript submit again thats why it is getting submitted twice. Use html button tag and then submit the page using javascript.

I think that will probably solve else send your code in jsp.

[Pradeep Adibatla]

This is that line in jsp...

  
<input type="submit" value="Rules" id="goRule" name="rulesScreen" onclick="rulesetCheck(); return rsReturn;"/>
  

I changed this to button it happens only once but the page isn't submitted!

This is the Javascript code on click...

 

function rulesetCheck()
{

    if (!document.getElementsByTagName || !document.createTextNode) return;
    var rows = document.getElementById('rs').getElementsByTagName('tbody')[0].getElementsByTagName('tr');

  //  alert("The length is :--> "+rows.length) ;

 //   alert("The rSave is :--> "+rsSav);

    rsReturn=true;

    if(rows.length<=1)
    {
        rsReturn=false;
        alert("Add a Ruleset to proceed !!!");

    }
    else if(rows.length>1 && rsSav!=1)
    {
        rsReturn=false;
        alert("save Ruleset/s to proceed further !!!");

    }
    else if(sel==0)
    {
        rsReturn=false;
        alert("Please Select a RS to proceed !");
    }

  //   alert("The rsReturn is :--> "+rsReturn);

  // return returnVal;
     if(rsReturn==true)
     {
         sendToRSAction();
     }

}


----------------------------------------------

function sendToRSAction()
    {
       alert("in sendToRSAction !!!");
       var xmlhttp;

      if (window.XMLHttpRequest)
      {
        // code for IE7+, Firefox, Chrome, Opera, Safari
        xmlhttp=new XMLHttpRequest();

        alert("xmlhttp is :--->"+xmlhttp);
      }
      else
      {
         alert(" in else !!! ");
        // code for IE6, IE5
        xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
        alert("xmlhttp is :--->"+xmlhttp);
      }

      alert("The value to be sent is :--> "+rsSel);

      alert("theRow.index is :--> "+theRow.rowIndex);
   //    var tBody=document.getElementById('rs').tBodies[0];

      var RSName=theRow.cells[2].innerHTML;

      alert("The value is :--> "+RSName)

      var selectedRSid=rsSel;
      var goToRulesScreen=document.getElementById('goRule').value;

      alert("selectedRSid is :--> "+selectedRSid);
      alert("goToRulesScreen is :--> "+goToRulesScreen);

     var url="http://localhost:8084/Struts_V1.0/jsp/rulesets.action?rsSelId="+selectedRSid+"&rulesScreen="+goToRulesScreen+"&rsName="+RSName;

     xmlhttp.open("GET", url, true);

   xmlhttp.onreadystatechange=function()
   {
      if(xmlhttp.readyState==4)
      {
 //          alert(xmlhttp.responseText);
      }
   }

    xmlhttp.send(null);
    }

   

[vijay jamadade]

See there are two things when you use input type submit it by default gets submitted to the action that you have specified for that form in form tag. And when you are using the button tag it acts as a button only. Here you need to submit that form using javascript form.submit(); in the method (javascript). Here you are implementing ajax form will not get submitted in this case.

Why are you using the xmlhttp object?

[Ankit Garg]

Where is this submit button of yours?? Wherever it is, in the containing form tag, include two hidden form fields, remove the AJAX request, in your javascript, set the selectedRSid and goToRulesScreen values to the hidden fields, and submit the form. Basically do this.

Add these two to your form element which contains the submit button

<input type="hidden" name="rsSelId" id="rsSelId" />
<input type="hidden" name="rulesScreen" id="rulesScreen" />
<input type="hidden" name="rsName" id="rsName" />

In your javascript, make the following changes

 

function rulesetCheck()
{
     //all the validation goes here
     if(rsReturn==true)
     {
         sendToRSAction();
         return true;
     }

}

function sendToRSAction()
{
      //remove the ajax request
      var RSName=theRow.cells[2].innerHTML;

      alert("The value is :--> "+RSName)

      var selectedRSid=rsSel;
      var goToRulesScreen=document.getElementById('goRule').value;

     document.getElementById('rsSelId').value=selectedRSid;
     document.getElementById('rulesScreen').value=goToRulesScreen;
     document.getElementById('rsName').value=RSName;
      //remove the ajax request
}

This should work...

[vijay jamadade]

Ankit,

There is no need of hidden parameters and all. You are making it more complex. When you submit the form you will get every value on page that is in the form.

Simple way is just call javascript function and submit the form for the action you want using form.action=xyz.do and after that submit the form using form.submit()

thats it.

[Ankit Garg]

vijay jamadade wrote:There is no need of hidden parameters and all. You are making it more complex. When you submit the form you will get every value on page that is in the form.

Maybe I'm making it more complex, but if you see, one of the parameters that he wants to send in the request is coming from the HTML content of a table cell

var RSName=theRow.cells[2].innerHTML;

That won't be submitted with the form right?? So that's why I included three hidden form fields. I don't know from where the other two values being passed as a request are coming (rsSel and goToRulesScreen in the javascript code). So my code will work (hopefully) from wherever the values are coming...

[vijay jamadade]

You can pass that value through url like form.action=test.do?Rs=true and get it in the action by request.getParameter("RS") . Else in any case the all the properties created on page can be accessed using name whether you create that using javascript it does not matters.

[Pradeep Adibatla]

This is the output i get...



========================================================================================================
in RulesetAction Execute() !!!
why is :--> 1
addRuleSet--->null
addrsok--->null
rsName--->
Now why is :--> 2
The tar in RS is :--> null

This is the new one and it should do ok...

 
<input type="button" value="Rules" id="goRule" name="rulesScreen" onclick="rulesetCheck(); return rsReturn;"/>
             <input type="submit" value="Back" name="rulesetBack"  />
             <input type="submit" value="RuleDebugger" name="ruleDebuggerScreen"/>
             <input type="submit" value="PIM-PSM" name="pimpsmScreen"/>
             <input type="hidden" name="rsSelId" id="rsSelId" />
             <input type="hidden" name="rulesScreen" id="rulesScreen" />
             <input type="hidden" name="rsName" id="rsName" />
   

I wonder why rsName isn't reaching to action class...

[vijay jamadade]

You need to pass through url my friend as i have replied onthe above post before submit.

[Pradeep Adibatla]

My form is like this...

 
<s:form action="rulesets" id="Rulesetform">

   

and I did this change in javascript method...

 

if(rsReturn==true)
     {
         sendToRSAction();
         document.getElementById('Rulesetform').submit();
        
     }

------------------
<input type="button" value="Rules" id="goRule" name="rulesScreen" onclick="rulesetCheck(); return rsReturn;"/>


   

This should suffice right?

this is what I get now...


----------------------

========================================================================================================
========================================================================================================
in RulesetAction Execute() !!!
why is :--> 1
addRuleSet--->null
addrsok--->null
rsName--->null
in RulesetAction Execute() !!!
why is :--> 1
addRuleSet--->null
addrsok--->null
rsName--->pro2_RS


strange type... what else could be...

[Ankit Garg]

vijay jamadade wrote:You need to pass through url my friend as i have replied onthe above post before submit.

The URL solution that you gave will not work in case of a GET request. If you have a form element like this

<form action="mypath?param=value" method="GET">
    <input type="text" name="param2" />
    <input type="submit" />
</form>

Now here only one request parameter will be sent which is param2 and param won't be sent. This is why I suggested the hidden field solution. Since he is using a form with GET method, so your parameter won't be sent. This can be fixed if we use POST method but then what's the whole purpose of using POST request if you can see some request parameters in the request URL.

Coming to the problem, Pradeep where is rsName actually declared in your action class?? I can't see it declared as a class field with tar and why. Looking at the output that you showed earlier, the output shows rsName---> not rsName---> null. So the request parameter is getting sent. Are you sure the javascript code is working properly??

var RSName=theRow.cells[2].innerHTML;

[Pradeep Adibatla]

Ankit,currently it looks like this....


in jsp...

 <input type="submit" value="Rules" id="goRule" name="rulesScreen" onclick="rulesetCheck(); return rsReturn;"/>
             <input type="submit" value="Back" name="rulesetBack"  />
             <input type="submit" value="RuleDebugger" name="ruleDebuggerScreen"/>
             <input type="submit" value="PIM-PSM" name="pimpsmScreen"/>
             <input type="hidden" name="rsSelId" id="rsSelId" />
             <input type="hidden" name="rsName" id="rsName" /> 

in Javascript...

  function sendToRSAction()
{
      //remove the ajax request
      alert("theRow.index is :--> "+theRow.rowIndex);
       
      
      var selectedRSid=rsSel;
      alert("selectedRSid is :--> "+selectedRSid);

      var RSName=nam;
      alert("The value is :--> "+RSName);
    
      document.getElementById('rsSelId').value=selectedRSid;
      document.getElementById('rsName').value=RSName;

      alert("document.getElementById('rsName').value is -->"+document.getElementById('rsName').value);
      
}  

the above 2 are fetched perfectly(nam,rsSel have the have the values)...
As you could see I removed the AJax call and have 2 hidden fields...


in action class....

  

 public int rsSelId;
    public String rsName;

    public void setRsName(String rsName)
    {
        this.rsName = rsName;
        System.out.println(" in setRsName is :--> "+rsName);
    }

    public String getRsName() 
    {
        return rsName;
    }

   
    public int getRsSelId() 
    {
     //   System.out.println("The rsSelId is :-- "+rsSelId);
        return rsSelId;
    }

    public void setRsSelId(int rsSelId) 
    {
        System.out.println(" in setRsSelId is :--> "+rsSelId);
        this.rsSelId = rsSelId;
    }

   ..........
   ..........

   public String execute() throws Exception 
    {

         session=request.getSession();
         session.setAttribute("rsName",rsName);


        .......
        ........

        System.out.println("======================================================================================================");
        System.out.println("in RulesetAction Execute() !!! ");
        System.out.println("why is :--> "+why);
        System.out.println("addRuleSet--->"+addRuleSet);
        System.out.println("addrsok--->"+addRsok);
        System.out.println("rsName--->"+rsName);
        System.out.println("rsSelId--->"+rsSelId);
        System.out.println("The size of rsName is :--> "+rsName.length());
       
        if(!rulesScreen.equalsIgnoreCase("null"))
        {
            if (rulesScreen.equalsIgnoreCase("Rules"))
            {

                System.out.println("The value rsSelID is :---> "+Integer.toString(rsSelId));
                tar = "successA";

                System.out.println("Exiting Rules screen !!! ");

            }

        }

..........
.........

        ++why;

        System.out.println("Now why is :--> "+why);
        
        this.setRulesScreen("null");
        this.setRulesetBack("null");
        this.setRuleDebuggerScreen("null");
        this.setPimpsmScreen("null");

        System.out.println("The tar in RS is :--> "+tar);
       
        return tar;
 

  

The output...
----------------------


==============================================================================================================
in RulesetAction Execute() !!!
why is :--> 1
addRuleSet--->null
addrsok--->null
rsName--->
rsSelId--->2
The size of rsName is :--> 0
The value rsSelID is :---> 2
----> size of ruleList is :--> 0
Exiting Rules screen !!!
Now why is :--> 2
The tar in RS is :--> successA



The Javascript code is just perfect,it's the action class that should be closely monitored I guess!

[David Newton]

That action class is really hard to follow, btw: its cyclomatic complexity is too high, it does way more than one thing. For the sake of whoever has to maintain it, I'd sure consider refactoring.