Boolean value not changing

[Joe Laviguer]

Hi I'm initializing a boolean as false in main, then trying to set it as true in another method, but it won't change to true after calling that second method. I tried creating a separate method so I could return the value of true, but I can't call that method separately through main because of if conditions in the second method. I call the boolean method in the second method, but that's not working either. If anyone can tell me why the boolean's value isn't changing in main, please let me know. Thanks!

 		
boolean bWin = false //this is in main

CheckWin(sBoard); //calling the CheckWin method

public static void CheckWin(String sBoard[][], boolean bWin) {  //a portion of the method
		
			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i]== "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X")))
				{

			}

					bWin = true;
					System.out.println("You win!");
					
				}
		}

public static boolean Game (boolean bWin) {  //also tried this by calling Game through above method

return bWin = true;
}

[Campbell Ritchie]

No, the value of a parameter to a method is not changed. Look up "pass by value and pass by reference" which you can find by searching this forum.

By the way, return boo = true; is a bit of dreadful code; it would be nearly as bad with a == instead of the =.

[Henry Wong]

http://faq.javaranch.com/java/CallByReferenceVsCallByValue

[Joe Laviguer]

That link only confused me more than I already was. So if I can't change the boolean value in the main, what if I create another kind of variable and have that as my while statement, and set that in my CheckWin method?

[Jesper de Jong]

Please PostRealCode, you're posting a few loose lines and snippets, which makes it harder to see what you're trying to do and what exactly the problem is.

In Java, variables are passed by value. That means that the arguments to a method are new variables, that are initialized with the values of the variables that you pass when you call the method. Changing the value of an argument variable inside the method will not change the original variable in the place where you called the method. Have a look at this:

public class Example {
	public static void main(String[] args) {
		int i = 2;

		myMethod(i);

		System.out.println(i); // Output: 2, not 4
	}

	private static void myMethod(int x) {
		x = 4;
	}
}

The variable x in myMethod() is a new variable that is initialized with the value of i (2) when the method is called. Assigning a different value to x inside the method has no effect on variable i in the main method.

[Joe Laviguer]

Jesper Young wrote:Please PostRealCode, you're posting a few loose lines and snippets, which makes it harder to see what you're trying to do and what exactly the problem is.

In Java, variables are passed by value. That means that the arguments to a method are new variables, that are initialized with the values of the variables that you pass when you call the method. Changing the value of an argument variable inside the method will not change the original variable in the place where you called the method. Have a look at this:

public class Example {
	public static void main(String[] args) {
		int i = 2;

		myMethod(i);

		System.out.println(i); // Output: 2, not 4
	}

	private static void myMethod(int x) {
		x = 4;
	}
}

The variable x in myMethod() is a new variable that is initialized with the value of i (2) when the method is called. Assigning a different value to x inside the method has no effect on variable i in the main method.

I don't have the entire code here at work, and didn't want to post a lot of extraneous code.

Okay so I understand that changing it inside a method and calling that method in main won't change the original value, but shouldn't returning a value from another method change the original value? If not, how do I change the original value? If I initialize a new variable in the second method, and have a while statement in main referring to it, it won't recognize that variable.

[fred rosenberger]

you can change the original value if you use the return value to set the variable:

public static void main(String [] args)
{
   boolean myBool = false;

   myBool = myMethod();
   //myBool is now true;

}

public static Boolean myMethod()
{
    return true;
}

[Joe Laviguer]

fred rosenberger wrote:you can change the original value if you use the return value to set the variable:

public static void main(String [] args)
{
   boolean myBool = false;

   myBool = myMethod();
   //myBool is now true;

}

public static Boolean myMethod()
{
    return true;
}

Can I return through a second method where there are if statements?

[Campbell Ritchie]

Joe Laviguer wrote: . . . Can I return through a second method where there are if statements?

Don't understand the question.

See if you can make anything out of this thread. It takes a long time to read.

[Joe Laviguer]

I can see how returning a value to main would change the original value, but can I return through a secondary method because the secondary as if statements? I don't want to change the value unless the conditions are met. Forgive me if the exact code isn't right...I'm winging it.

 
public static void main (Strings[] args) {

boolean myBool = false;

secondary(text,myBool);

}//end main

public static void secondary (String text, boolean myBool) {

if (statements) {

    System.out.println(print this stuff);
    myBool = third(myBool);

}//end secondary

public static boolean third (boolean myBool) {

return true;

}//end third

}//end class

[fred rosenberger]

If i understand what you're asking, no.

You're 'myBool' on line 15 will change, but then that gets lost when you return back to your main() method.

You MAY be able to get around this by changing from boolean primitives to Boolean objects/references. I don't recall if they are immutable or not, and can't test right now.

or you could do this:

public static void main(String [] args)  
{  
   boolean myBool = false;  
  
   myBool = myMethod();  
   //myBool is now true;  
  
}  
  
public static boolean myMethod(boolean original)  
{  
    //do whatever
    if (condition == leave it alone)
    {
       return original;  
    }
    else if (condition == it should be false)
   {
       return false;
   }
   else
   {
       return true;
   }
}  

Some people prefer only one 'return' statement in a method, so it could be adapted to:

public static Boolean myMethod(boolean original)  
{  
    boolean returnValue = original;
    //do whatever
   if (condition == it should be false)
   {
       returnValue =  false;
   }
   else if (condition == it should be true)
   {
       returnValue = true;
   }
   return returnValue ;
}  

[Joe Laviguer]

fred rosenberger wrote:If i understand what you're asking, no.

You're 'myBool' on line 15 will change, but then that gets lost when you return back to your main() method.

You MAY be able to get around this by changing from boolean primitives to Boolean objects/references. I don't recall if they are immutable or not, and can't test right now.

or you could do this:

public static void main(String [] args)  
{  
   boolean myBool = false;  
  
   myBool = myMethod();  
   //myBool is now true;  
  
}  
  
public static boolean myMethod(boolean original)  
{  
    //do whatever
    if (condition == leave it alone)
    {
       return original;  
    }
    else if (condition == it should be false)
   {
       return false;
   }
   else
   {
       return true;
   }
}  

Some people prefer only one 'return' statement in a method, so it could be adapted to:

public static Boolean myMethod(boolean original)  
{  
    boolean returnValue = original;
    //do whatever
   if (condition == it should be false)
   {
       returnValue =  false;
   }
   else if (condition == it should be true)
   {
       returnValue = true;
   }
   return returnValue ;
}  

My problem is that the secondary method has a String array in the if statements, so it won't let me return the boolean value to the main because its not a boolean-only method. So now I'm trying to think if there's anything else I can base a while statement off of in the main to end the game when it meets the conditions in the CheckWin method. Or should I just dump the second method and have the if statements in the main method? Thanks for your help.

public static void CheckWin(String sBoard[][],boolean bWin) {
		
			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i]== "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X")))
				{

			}//end for

					System.out.println("You win!");
                                  
			
				}//end if

			for (int i=0; i<3; i++)
			{
			
				if (((sBoard[0][i] == "O") && (sBoard[1][i] == "O") && (sBoard[2][i] == "O"))
				|| ((sBoard[i][0] == "O") && (sBoard[i][1] == "O") && (sBoard[i][2] == "O")))
				{

			}//end for

					System.out.println("You lose!");
					
				}//end if

				else
				{
				
					System.out.println("It's a tie!");
					
				}//end else
			
		}//end CheckWin

[fred rosenberger]

public static void CheckWin(String sBoard[][],boolean bWin) {
   for (int i=0; i<3; i++)
   {

      if (((sBoard[0][i]== "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
	|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X")))
      {
      }//end for
   System.out.println("You win!");
                                  
   }//end if
|

This doesn't make sense. You can't overlap a for and an if like this. You have to completely nest them. Where you're comment says "end for", you're actually closing your 'if' and vice versa.

[Joe Laviguer]

fred rosenberger wrote:

public static void CheckWin(String sBoard[][],boolean bWin) {
   for (int i=0; i<3; i++)
   {

      if (((sBoard[0][i]== "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
	|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X")))
      {
      }//end for
   System.out.println("You win!");
                                  
   }//end if
|

This doesn't make sense. You can't overlap a for and an if like this. You have to completely nest them. Where you're comment says "end for", you're actually closing your 'if' and vice versa.

Yes you're right I flip-flopped the end for and end if comments.

But the for and if statements actually run correctly.

[fred rosenberger]

can't you just change the signature so it returns a Boolean?

[Joe Laviguer]

fred rosenberger wrote:can't you just change the signature so it returns a Boolean?

Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method? I also tried a separate boolean only method.

 
import java.util.*;

public class TicTacToe {

	public static void main (String[] args) {
	
		Scanner console = new Scanner (System.in);
		Random row = new Random();
		Random column = new Random();
		
		String[][] sBoard = new String[3][3];
		int iUserColumn = 0;
		int iUserRow = 0;
		int iPCColumn = 0;
		int iPCRow = 0;
		int iCount = 0;
		boolean bWin = false;
		
		for (int i = 0; i <= 2; i++)
		{
			for (int j = 0; j <= 2; j++)
			{
				sBoard[i][j] = " ";
				
			}//end for
			
		}//end for

		while ((bWin != true) && (iCount <= 9))
		{

		DrawBoard(sBoard);

		do
		{
	
			System.out.println("It's your turn.");
			System.out.println("Please select row:");
			iUserRow = console.nextInt();
			System.out.println("Please select column:");
			iUserColumn = console.nextInt();
			
		} while (sBoard[iUserRow][iUserColumn] != " ");
	
				sBoard[iUserRow][iUserColumn] = "X";
				
				DrawBoard(sBoard);

				iCount++;


		do
		{

			System.out.println("It's my turn.");
				
			iPCRow = row.nextInt(3);
			iPCColumn = column.nextInt(3);
				
		} while (sBoard[iPCRow][iPCColumn] != " ");
		
				sBoard[iPCRow][iPCColumn] = "O";
				
				iCount++;
			
		}//end while

	}//end main

		public static void CheckWin (String sBoard[][],boolean bWin, int iCount) {

			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
				|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
				|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X")))
				{

				}//end if

					System.out.println("You win!");

					Game(bWin);
					
			}//end for
		

			for (int i=0; i<3; i++)
			{
			
				if (((sBoard[0][i] == "O") && (sBoard[1][i] == "O") && (sBoard[2][i] == "O"))
				|| ((sBoard[i][0] == "O") && (sBoard[i][1] == "O") && (sBoard[i][2] == "O"))
				|| ((sBoard[0][0] == "O") && (sBoard[1][1] == "O") && (sBoard[2][2] == "O"))
				|| ((sBoard[0][2] == "O") && (sBoard{1][1] == "O") && (sBoard[2][0] == "O")))
				{

				}//end if

					System.out.println("You lose!");

					Game(bWin);
					
			}//end for

				if (iCount == 9)
				{
				
					System.out.println("It's a tie!");

					Game(bWin);
					
				}//end if

		}//end CheckWin

		public static void DrawBoard(String sBoard[][]) {
		
		System.out.println("  0 1 2");
		System.out.println("0 " + sBoard[0][0] + "|" + sBoard[0][1] + "|" + sBoard[0][2]);
		System.out.println("  -----");
		System.out.println("1 " + sBoard[1][0] + "|" + sBoard[1][1] + "|" + sBoard[1][2]);
		System.out.println("  -----");
		System.out.println("2 " + sBoard[2][0] + "|" + sBoard[2][1] + "|" + sBoard[2][2]);
		System.out.println();

		}//end DrawBoard

		public static boolean Game (boolean gGame) {

		return true;

		}//end Game
	
}//end class
   

[Paul Clapham]

Joe Laviguer wrote:Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method?

You can declare your method to return whatever you like. There aren't any rules which say "You can't return X if your parameters include Y or Z"... why would any language have a rule like that?

[Joe Laviguer]

Paul Clapham wrote:

Joe Laviguer wrote:Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method?

You can declare your method to return whatever you like. There aren't any rules which say "You can't return X if your parameters include Y or Z"... why would any language have a rule like that?

That's why I'm here in Beginning Java. I don't know these things yet.

[Paul Clapham]

Joe Laviguer wrote:

Paul Clapham wrote:

Joe Laviguer wrote:Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method?

You can declare your method to return whatever you like. There aren't any rules which say "You can't return X if your parameters include Y or Z"... why would any language have a rule like that?

That's why I'm here in Beginning Java. I don't know these things yet.

Well, okay. But you're just making things harder for yourself if you start imagining weird stuff like that. If you decide you want your method to return a boolean, just try it. Don't go looking for trouble by trying to dream up reasons why you might not be able to do that, just do it. The trouble will find you soon enough if it actually exists.

And believe it or not, the Java language was designed to be simple. As such, you'll generally find the rules are simple. So for a method, it can be a void method (doesn't return anything) or it can return some type. That's all. It's simple, and there's no reason for the rule to be more complicated than that.

[Joe Laviguer]

Paul Clapham wrote:

Joe Laviguer wrote:

Paul Clapham wrote:

Joe Laviguer wrote:Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method?

You can declare your method to return whatever you like. There aren't any rules which say "You can't return X if your parameters include Y or Z"... why would any language have a rule like that?

That's why I'm here in Beginning Java. I don't know these things yet.

Well, okay. But you're just making things harder for yourself if you start imagining weird stuff like that. If you decide you want your method to return a boolean, just try it. Don't go looking for trouble by trying to dream up reasons why you might not be able to do that, just do it. The trouble will find you soon enough if it actually exists.

And believe it or not, the Java language was designed to be simple. As such, you'll generally find the rules are simple. So for a method, it can be a void method (doesn't return anything) or it can return some type. That's all. It's simple, and there's no reason for the rule to be more complicated than that.

So are you saying the following code would work (I can't test it here at work...have to wait until I get home)? Note: I have boolean bWin = false; initialized in Main.

		public static boolean CheckWin (String sBoard[][],boolean bWin,int iCount) {

			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
				|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
				|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X")))
				{

				}//end if

					System.out.println("You win!");

					bWin = true;
					return bWin;
					
			}//end for

                                         }//end CheckWin

[Joe Laviguer]

Joe Laviguer wrote:

Paul Clapham wrote:

Joe Laviguer wrote:

Paul Clapham wrote:

Joe Laviguer wrote:Can I have a public static boolean if there is a string array and an int as well as a boolean variable in the method?

You can declare your method to return whatever you like. There aren't any rules which say "You can't return X if your parameters include Y or Z"... why would any language have a rule like that?

That's why I'm here in Beginning Java. I don't know these things yet.

Well, okay. But you're just making things harder for yourself if you start imagining weird stuff like that. If you decide you want your method to return a boolean, just try it. Don't go looking for trouble by trying to dream up reasons why you might not be able to do that, just do it. The trouble will find you soon enough if it actually exists.

And believe it or not, the Java language was designed to be simple. As such, you'll generally find the rules are simple. So for a method, it can be a void method (doesn't return anything) or it can return some type. That's all. It's simple, and there's no reason for the rule to be more complicated than that.

So are you saying the following code would work (I can't test it here at work...have to wait until I get home)? Note: I have boolean bWin = false; initialized in Main.

		public static boolean CheckWin (String sBoard[][],boolean bWin,int iCount) {

			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
				|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
				|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X")))
				{

				}//end if

					System.out.println("You win!");

					bWin = true;
					return bWin;
					
			}//end for

                                         }//end CheckWin

I ran that code and java gave me an error that says it needed a return statement before the }//end CheckWin line, but the program won't run correctly if I have the return statement(s) outside the if loops.

Another thing I tried was to completely get away from the CheckWin method and imbed that code into the main method, but that means having to put those if statements in there after the user's turn and after the computer's turn. So I change the boolean value in the main and don't use the CheckWin or Game methods at all, and that seemed to run correctly and end the program after a win or loss, but it won't stop if the user wins. What it does is acknowledge that the user won, then the computer goes ahead and makes the next move anyway, and then it runs through the ifs again and acknowledges the user's victory once again (and if the computer won on its subsequent turn, it actually displays "You win!" and then "You lose!" I'd like it to end the program after the user wins.

[fred rosenberger]

Java requires you to have a return for every possible execution path. I don't think the compiler is smart enough to know that you will ALWAY run in your for loop, so it needs to have something to return just in case the loop is skipped.

Why won't the code run correctly with the return outside the loop? The way it's written now, you will ALWAYS return on the first iteration through the loop:

for (int i=0; i<3; i++)  
            {  
                if (//whatever)  
                {  
                }//end if  
  
                //this code will always execute each time through the loop
                //since it's outside the if block
                System.out.println("You win!");  
 
                bWin = true;  
                return bWin;  //this will exit the loop the first time you get here
                     
            }//end for  

Another thing I tried was to completely get away from the CheckWin method and imbed that code into the main method,

This is a bad idea. method (including main) should be kept as small as possible. Most people would tell you it's better to pull stuff OUT of a big method to make several smaller ones, rather than vice versa.

((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X"))

This is REALLY ugly. it's hard to read. I'd probably pull this into a method by itself...something like

if (winnerFoundX())
{
    //do whatever
}

public boolean winnerFoundX()
{
     //put logic here to determine winner
     //break it down into many small pieces, possibly with more methods called
     //in here, like
     return (winnerFoundAcross() || winnderFoundDown() || winnerFoundDiag())
}

//then write those methods...
public boolean winnerFoundAcross()
{

}
//etc
 

[Joe Laviguer]

fred rosenberger wrote:Java requires you to have a return for every possible execution path. I don't think the compiler is smart enough to know that you will ALWAY run in your for loop, so it needs to have something to return just in case the loop is skipped.

Why won't the code run correctly with the return outside the loop? The way it's written now, you will ALWAYS return on the first iteration through the loop:

for (int i=0; i<3; i++)  
            {  
                if (//whatever)  
                {  
                }//end if  
  
                //this code will always execute each time through the loop
                //since it's outside the if block
                System.out.println("You win!");  
 
                bWin = true;  
                return bWin;  //this will exit the loop the first time you get here
                     
            }//end for  

REPLY: Well that's the thing. I only want the boolean changed to true when the if conditions are met. If the user has three X's in a row, he wins, and the game is over. If changing the boolean to true is outside of the if loop, it will change the boolean no matter what happens, so theoretically, the game will be over after the very first move. Is my logic correct?

Another thing I tried was to completely get away from the CheckWin method and imbed that code into the main method,

This is a bad idea. method (including main) should be kept as small as possible. Most people would tell you it's better to pull stuff OUT of a big method to make several smaller ones, rather than vice versa.

((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X"))

This is REALLY ugly. it's hard to read. I'd probably pull this into a method by itself...something like

if (winnerFoundX())
{
    //do whatever
}

public boolean winnerFoundX()
{
     //put logic here to determine winner
     //break it down into many small pieces, possibly with more methods called
     //in here, like
     return (winnerFoundAcross() || winnderFoundDown() || winnerFoundDiag())
}

//then write those methods...
public boolean winnerFoundAcross()
{

}
//etc
 

REPLY: I'll have to write different variations of the code, first without any subsequent methods, make that work, then start breaking the different pieces out into their own methods. If only I had a way to test this code at work...no java IDE or JDK on these systems, USB devices are not authorized on the network, and they won't let me bring in my own network. UGH!

Thanks for your help....its much appreciated!

[fred rosenberger]

Friendly tip...you don't need to quote an entire post when you reply.

I would really suggest you not do it that way - writing one big method that does everything, then breaking it down to smaller ones. You're setting yourself up for failure.

The accepted best way is to write teeny tiny pieces at a time. Get one little thing to work, then add the next smallest thing you can. A lot of the time, you will write 'dummy' method bodies. for example, the first time you write a "winnerFoundAcross()" method, the entire body might be nothing more than this:

public boolean winnerFoundAcross()
{
    return TRUE;
}

you can write this, then test the rest of your code. When you need to, you can force it to return FALSE to test stuff - and that's easy to change. Eventually, you get to the point where you need actually have code here. You will be confident that the rest of your code is solid, since you've been testing it all along.

[Joe Laviguer]

I've been thinking about the return statement some more, and my thinking is that I can change the boolean from false to true inside the if statement(s), then return the boolean at the end of the boolean method. I'll just post the CheckWin method code; please let me know if you think this will work. Also, the final if statement...should that be an else if statement? Thanks!

 		public static boolean CheckWin (String sBoard[][],boolean bWin, int iCount) {

			for (int i=0; i<3; i++)
			{

				if (((sBoard[0][i] == "X") && (sBoard[1][i] == "X") && (sBoard[2][i] == "X"))
				|| ((sBoard[i][0] == "X") && (sBoard[i][1] == "X") && (sBoard[i][2] == "X"))
				|| ((sBoard[0][0] == "X") && (sBoard[1][1] == "X") && (sBoard[2][2] == "X"))
				|| ((sBoard[0][2] == "X") && (sBoard{1][1] == "X") && (sBoard[2][0] == "X")))
				{

					System.out.println("You win!");

					bWin = true;

				}//end if
					
			}//end for
		
			for (int i=0; i<3; i++)
			{
			
				if (((sBoard[0][i] == "O") && (sBoard[1][i] == "O") && (sBoard[2][i] == "O"))
				|| ((sBoard[i][0] == "O") && (sBoard[i][1] == "O") && (sBoard[i][2] == "O"))
				|| ((sBoard[0][0] == "O") && (sBoard[1][1] == "O") && (sBoard[2][2] == "O"))
				|| ((sBoard[0][2] == "O") && (sBoard{1][1] == "O") && (sBoard[2][0] == "O")))
				{

					System.out.println("You lose!");

					bWin = true;

				}//end if
					
			}//end for

				if (iCount == 9)
				{
				
					System.out.println("It's a tie!");

					bWin = true;
					
				}//end if

			return bWin; 

		}//end CheckWin  

[fred rosenberger]

what IF-block do you think it should be ELSE-IFed with?

more notes...

a method should do one thing, and one thing only.

Your method:

a) checks to see if X wins
b) prints out a message if he does
c) checks to see if O wins
d) prints a message if he does
e) prints a message if the game is a tie

and finally, it returns TRUE if there is a tie -which seems wrong to me based on the name "CheckWin". a tie is not a win.

I would strongly suggest you perhaps do something like

checkWin() calls a checkXWin() method and a checkOWin() method, sort of like

checkWin()
{
    boolean winnerFound = checkXwin();
    if (!winnerFound)
    {
        winnerFound  = checkYwin();
    }
    return winnerFound;
}

Then, in your main loop, after each move, call the checkWin. If it's true, you know the game is over. If false, then check to see if the number of moves is 9. If not, loop back around for the next move. If so, you can print your Tie method.

of course, now that I write that, I see a problem - you can't tell who won. maybe in your main loop you need to call checkXWin directly, handle a win appropriately, and if not, call checkOWin, etc....

Am I confusing you?

[Joe Laviguer]

Nope you're not confusing me. You're just highlighting more possibilities than I thought of and I really appreciate it.

The IF that I thought about changing to ELSE-IF was the last one, if the iCount = 9 then its a tie. I don't want a winner at the very last turn being told he won and its a tie, so if X isn't a winner (first IF), and O isn't a winner (second IF), then its a tie only if there were 9 turns, not if nobody has won yet if its less than 9.

But I see your point about multiple CheckWin methods. I can call the method that checks to see if X won at the end of X's turn, then call the method to see if O won after O's turn. But I think that's what you're saying. Not sure how to create a separate method to test for a tie without having to run through the IF scenarios all over again, so I'll probably just put the test for a tie in both the X and O methods.

Thanks very much!

[fred rosenberger]

I don't think you need a method to CHECK for a tie. If X didn't win, and O didn't win, and there have been 9 moves...it HAS to be a tie. So...

someone makes a move...
check if X wins
if so, game over X WINS!!!
check if Y wins
if so, game over O WINS!!!
check if total moves == 9
if so, game over TIE!!!
nobody won, so go back to top of this loop.

[Joe Laviguer]

It all seems so simple now!