How would i break this down into seperate metods?

[todd stolz-schroeder]

I have my whole program written but i need to break it down into 5 seperate methods one for the values, one for the average, one for the smallest, one for the largest and one for the median. im a little confused on how to do it, thanks.

   import java.util.Scanner;
import java.util.Arrays;




public class array
{
	

	public static void main(String [] args)

	{
	
	
		Scanner console = new Scanner(System.in);
		

			
     		boolean good = false;
    		int arraysize;
		int value;
		double average = 0;
		int smallest;
		double even = 0;
		String arraySizeString = null;
		String Stgarray = null;
		
		

		 while(!good)
     			{
      				good = true;
        			System.out.print("Enter size of array: ");
          			arraySizeString = console.nextLine();

     				for(int x=0; x<arraySizeString.length(); ++x)
					
     				
				if(!Character.isDigit(arraySizeString.charAt(x)))
         			good=false;
			


       				if(!good)
         			System.out.println("Invalid array size - please enter an integer value");
					
     						
			}
	




		
					
			arraysize = Integer.parseInt(arraySizeString);

			int[] array = new int[arraysize];



			good = false;

		for(int i = 0 ; i < array.length; ++i)
		{

		while(!good)
     			{

				good = true;
        			System.out.print("Enter Value #" + (i+1) + ":");
				
          			arraySizeString = console.nextLine();

     				for(int x=0; x<arraySizeString.length(); ++x)
					
     				
				if(!Character.isDigit(arraySizeString.charAt(x)))
         			good=false;
			


       				if(!good)
         			System.out.println("Invalid array size - please enter an integer value");
					
			}
			
					
			array[i] = Integer.parseInt(arraySizeString);
 			good = false;

    			
	
		}
		
			System.out.println("\n" + "Your data is:");
		
			for(int x = 0; x < array.length; ++x)
			{
  					System.out.println(array[x]);

			}

				

		Arrays.sort(array);




		for(int x = 0; x < array.length; ++x)
			{
				average=average + array[x];
			}
	
		System.out.println("\n"+"Average is: " + average/arraysize);
	

		
			



	

		smallest = array[0];
		
		int largest = array[0];
		
		for(int x = 1; x < array.length; x++)
		{
			if(largest < array[x])
			{
				largest = array[x];
			}

		}
		
							

		System.out.println("Smallest value is: " + smallest);
		System.out.println("Largest value is: " + largest);


		System.out.println("\n" + "Your sorted data is:");
		
		
		for(int x = 0; x < array.length; ++x)
			{
   			System.out.println(array[x]);
			}

		int result = array.length % 2; 

		double median = 0; 


		if (result == even) 
		{ 
			int rightNumber = array.length / 2; 
			int leftNumber = rightNumber - 1; 
			median = (array[rightNumber] + array[leftNumber]) / 2; 
		} 
		else 

		{
 
		median = array[array.length / 2]; 
 
		
		} 


		System.out.println("\n" + "The median is: " + median);


		

		
	}
} 

[Anupam Jain]

todd stolz-schroeder wrote:
I have my whole program written but i need to break it down into 5 seperate methods one for the values, one for the average, one for the smallest, one for the largest and one for the median. im a little confused on how to do it, thanks.

You have the answer in your question itself...

try to make the array reference variable as a class member. make five methods as:

getValues() //To store values in array
getAverage() //to find the average value
getSmallest() //to find the smallest value
getLargest() //to find the largest value
getMedian() //to find the Median value

Hope it helps....

[Bert Wilkinson]

Todd,

Previous post is correct. If you have a good understanding of how to make a method and what a class variable is, this shouldn't take long. Your program is a fine first whack at the solution.

Consider what your program will need to pass the method for input information (the parameters)....this will likely be your array... and what the output will be after it is done calculating (if a calculation is to be returned.)

Badda bing...

another minor formatting point: Your class name should always be a capital letter....and to avoid confusion with an already defined class, you may want to rename it something like "MyArray". Eclipse or NetBeans let you refactor and change names real easily.

Good luck

[Rob Camick]

Cross posted: http://www.java-forums.org/new-java/26927-how-do-i-make-bunch-arrays-into-list.html

[Ritesh Pareek]

Hi,

Hope it will work for.

  




import java.util.Scanner;
import java.util.Arrays;

public class MyArray {
  {
    if (true) throw new WeDontGiveOutAnswersLikeThisException();  }
}

[Campbell Ritchie]

Ritesh Pareek, you have been on the Ranch long enough to know not to give out straight answers like that. It helps nobody to be given such an answer; in fact if it is found out it will earn anybody using it a mark of 0.

I hope I was in time to delete your code before it did any harm.

[David Newton]

Campbell Ritchie wrote:It helps nobody to be given such an answer; in fact if it is found out it will earn anybody using it a mark of 0.

Or worse; it can lead to official, or unofficial, disciplinary action.

[todd stolz-schroeder]

Anupam Jain wrote:

todd stolz-schroeder wrote:
I have my whole program written but i need to break it down into 5 seperate methods one for the values, one for the average, one for the smallest, one for the largest and one for the median. im a little confused on how to do it, thanks.

You have the answer in your question itself...

try to make the array reference variable as a class member. make five methods as:

getValues() //To store values in array
getAverage() //to find the average value
getSmallest() //to find the smallest value
getLargest() //to find the largest value
getMedian() //to find the Median value

Hope it helps....

Yeah get that but i dont know what the write code for it would be and where to put it I worked on this all day yesterday and just wannna get it done

[Bert Wilkinson]

Well, if you're doing this for a class, there should be some text examples of how to make class methods....it's an early concept...so you might be missing some key knowledge.

You already have the code... you just need to rearrange a bit.

your final answer will have a "main method" to get things started and then other methods to do the subtask that are outside the main method. A variable that is accessible to all of these methods is a "class variable" or "instance variable" of your class, and you'll need one of those to retain info (at this level)

this will snap right into place after you do a little work on figuring out class methods.

[David Newton]

The code would be essentially identical to the code you have now, but in methods taking parameters and possibly returning values (depending on the method). It's unlikely anybody is going to write any of it for you (it's against JavaRanch policy). If you take a stab at it and have specific questions you're more likely to get help.

[todd stolz-schroeder]

Im trying to do it but when its like this why does it return nothing??

  import java.util.Scanner;
import java.util.Arrays;




public class array
{
	

	public static void main(String [] args)

	{
	
	
		Scanner console = new Scanner(System.in);
		

			
     		boolean good = false;
    		int arraysize;
		int value;		
		String arraySizeString = null;
		String Stgarray = null;
		
		

		 while(!good)
     			{
      				good = true;
        			System.out.print("Enter size of array: ");
          			arraySizeString = console.nextLine();

     				for(int x=0; x<arraySizeString.length(); ++x)
					
     				
				if(!Character.isDigit(arraySizeString.charAt(x)))
         			good=false;
			


       				if(!good)
         			System.out.println("Invalid array size - please enter an integer value");
					
     						
			}
	




		
					
			arraysize = Integer.parseInt(arraySizeString);

			int[] array = new int[arraysize];



			good = false;
		
			for(int i = 0 ; i < array.length; ++i)

			{

			while(!good)
     				{

					good = true;
        				System.out.print("Enter Value #" + (i+1) + ":");
				
          				arraySizeString = console.nextLine();

     					for(int x=0; x<arraySizeString.length(); ++x)
					
     				
					if(!Character.isDigit(arraySizeString.charAt(x)))
         				good=false;
			


       					if(!good)
         				System.out.println("Invalid array size - please enter an integer value");
					
				}
			
					
			array[i] = Integer.parseInt(arraySizeString);
 			good = false;

    			
	
		}
		
			System.out.println("\n" + "Your data is:");
		
			for(int x = 0; x < array.length; ++x)
			{
  					System.out.println(array[x]);

			}

				




		Arrays.sort(array);


	
		}
	
		public static void printAverage (int [] array)
		{
		double average = 0;
		for(int x = 0; x < array.length; ++x)
			{
				average=average + array[x];
			}
	
			System.out.println("\n"+"Average is: " + average/array.length);

			printAverage (array);
		}
		
			








		public static void printSmallest (int [] array)
		{
		
			int smallest;
		
			smallest = array[0];

		
			System.out.println("Smallest value is: " + smallest);

			printSmallest (array);
		}



		public static void printLargest (int [] array)
		{
			int largest = array[0];
		
			for(int x = 1; x < array.length; x++)
				{
					if(largest < array[x])
						{
				
							largest = array[x];
						}

				System.out.println("Largest value is: " + largest);


			}

			printLargest (array);
		}
							

		
		public static void printSorted (int [] array)	
		{

			System.out.println("\n" + "Your sorted data is:");
		
		
			for(int x = 0; x < array.length; ++x)
				{
   					System.out.println(array[x]);
				}
			
			printSorted (array);

		}


		public static void printMedian (int [] array)
		
		{
			double even = 0;

			int result = array.length % 2; 

			double median = 0; 


			if (result == even) 
				{ 
					int rightNumber = array.length / 2; 
					int leftNumber = rightNumber - 1; 
					median = (array[rightNumber] + array[leftNumber]) / 2; 
				}
 
			else 

				{
 
					median = array[array.length / 2]; 
 
		
				} 

			printMedian (array);
			System.out.println("\n" + "The median is: " + median);


		

		}

	

		
	
}  

[David Newton]

Why does *what* return nothing? And do you mean *return*, or display?

[todd stolz-schroeder]

it looks like this





instead of this

[David Newton]

Oh, that's obnoxious--just cut-and-paste next time, please.

Are you calling the functions? They won't call themselves.

[todd stolz-schroeder]

David Newton wrote:Oh, that's obnoxious--just cut-and-paste next time, please.

Are you calling the functions? They won't call themselves.

You cant copy out of the command promt so thats what i had to do.

And i added the return command and still the same thing

    import java.util.Scanner;
import java.util.Arrays;



public class array
{
	
	public static void main(String [] args)

	{
		
		Scanner console = new Scanner(System.in);		
     		boolean good = false;
    		int arraysize;
		int value;		
		String arraySizeString = null;
		String Stgarray = null;
				

		while(!good)
     			{
      				good = true;

        			System.out.print("Enter size of array: ");

          			arraySizeString = console.nextLine();

     				for(int x=0; x<arraySizeString.length(); ++x)
					
     				if(!Character.isDigit(arraySizeString.charAt(x)))

         			good=false;
			
       				if(!good)

         			System.out.println("Invalid array size - please enter an integer value");					
     						
			}
	

		
					
			arraysize = Integer.parseInt(arraySizeString);

			int[] array = new int[arraysize];



			good = false;
		
			for(int i = 0 ; i < array.length; ++i)

			{

			while(!good)
     				{

					good = true;

        				System.out.print("Enter Value #" + (i+1) + ":");
				
          				arraySizeString = console.nextLine();

     					for(int x=0; x<arraySizeString.length(); ++x)
					
     				
					if(!Character.isDigit(arraySizeString.charAt(x)))

         				good=false;
			
       					if(!good)

         				System.out.println("Invalid array size - please enter an integer value");
					
				}
			
					
			array[i] = Integer.parseInt(arraySizeString);

 			good = false;

    			
	
			}
		
			System.out.println("\n" + "Your data is:");
		
			for(int x = 0; x < array.length; ++x)
			{
  					System.out.println(array[x]);

			}			




		Arrays.sort(array);


	
		}
	
			public static double printAverage (int [] array)
			{
				double average = 0;

				for(int x = 0; x < array.length; ++x)
					{
						average=average + array[x];
					}
	
					System.out.println("\n"+"Average is: " + average/array.length);

				return average;
			}	
		
			

		public static int printSmallest (int [] array)
		{
		
			int smallest;
		
			smallest = array[0];

		
			System.out.println("Smallest value is: " + smallest);

			
			return smallest;
		}



		public static double printLargest (int [] array)
		{
			int largest = array[0];
		
			for(int x = 1; x < array.length; x++)
				{
					if(largest < array[x])
						{
				
							largest = array[x];
						}

				System.out.println("Largest value is: " + largest);

				}
			
			return largest;
		}
							
		
		public static int[] printSorted (int [] array)	
		{

			System.out.println("\n" + "Your sorted data is:");
		
		
			for(int x = 0; x < array.length; ++x)
				{
   					System.out.println(array[x]);
				}
			
			
			return array;

		}


		public static double printMedian (int [] array)
		
		{
			double even = 0;

			int result = array.length % 2; 

			double median = 0; 


			if (result == even) 
				{ 
					int rightNumber = array.length / 2; 
					int leftNumber = rightNumber - 1; 
					median = (array[rightNumber] + array[leftNumber]) / 2; 
					System.out.println("\n" + "The median is: " + median);
				}
 
			else 

				{
 
					median = array[array.length / 2]; 
 
		
				} 

			
			return median;
			

		}
	
}

[David Newton]

todd stolz-schroeder wrote:You cant copy out of the command promt so thats what i had to do.

Of course you can:

C:\newton\work\xxxx\eclipse_workspace\Dimension>dir
 Volume in drive C has no label.
 Volume Serial Number is 7808-635E

 Directory of C:\newton\work\xxxx\eclipse_workspace\Xxxxx

03/22/2010  03:38 PM    <DIR>          .
03/22/2010  03:38 PM    <DIR>          ..
03/22/2010  06:18 PM             4,187 .classpath
03/22/2010  03:29 PM               385 .project
03/22/2010  03:29 PM    <DIR>          .settings
03/22/2010  06:19 PM    <DIR>          bin
06/22/2005  08:55 AM             1,682 branch.sh
02/16/2010  04:36 PM             4,397 build.xml
02/16/2010  04:36 PM             8,899 buildComponent.xml
04/04/2008  05:10 PM             6,242 buildComponent2.xml
02/16/2010  04:36 PM             2,534 buildProperties.xml
12/14/2009  05:01 PM            13,663 buildTasks.xml
10/23/2008  10:22 AM            13,359 buildTasks2.xml
03/22/2010  03:33 PM    <DIR>          components
03/22/2010  03:33 PM    <DIR>          CVS
03/22/2010  03:33 PM    <DIR>          environments
03/22/2010  03:33 PM    <DIR>          extensions
08/05/2004  04:41 PM             1,142 release-diff.sh
03/17/2006  03:52 PM             4,636 setup.xml
03/22/2010  03:29 PM    <DIR>          src
09/25/2008  09:22 AM             1,843 tag.sh
10/01/2008  05:21 PM             2,011 tagAndBranch.sh
02/13/2006  01:06 PM             1,532 tagDir.sh
03/22/2010  03:33 PM    <DIR>          thirdParty
03/22/2010  03:33 PM    <DIR>          tools
              14 File(s)         66,512 bytes
              11 Dir(s)  53,725,704,192 bytes free

C:\newton\work\xxxx\eclipse_workspace\Xxxxx>

[David Newton]

Where do you *call* the methods you've written?

[Jim Hoglund]

Expanding on Anupam Jain's advice, here's an approach to consider. Move the
code you have written into the methods below. Since they are members of class
MyArray, they can all freely manipulate myArray.

public class MyArray {

    private int[] myArray;

    public static main(String[] args) {
        // call the other methods
        // and do some housekeeping
    }

    void getArraySize() {
        // to get array size from user  
    }

    void getValues() {
        // to store/show values in array 
    }

    void getAverage() { 
        // to find/show the average value
    }

    void getSmallest() {
        // to find/show the smallest value 
    } 

    void getLargest() {
        // to find/show the largest value
    }

    void getMedian() {
        // to find/show the Median value 
    } 
}

Jim... ...

[Anupam Jain]

todd stolz-schroeder wrote:

David Newton wrote:Oh, that's obnoxious--just cut-and-paste next time, please.

Are you calling the functions? They won't call themselves.

You cant copy out of the command promt so thats what i had to do.

And i added the return command and still the same thing

    import java.util.Scanner;
import java.util.Arrays;



public class array
{
	
	public static void main(String [] args)

	{
		
		Scanner console = new Scanner(System.in);		
     		boolean good = false;
    		int arraysize;
		int value;		
		String arraySizeString = null;
		String Stgarray = null;
				

		while(!good)
     			{
      				good = true;

        			System.out.print("Enter size of array: ");

          			arraySizeString = console.nextLine();

     				for(int x=0; x<arraySizeString.length(); ++x)
					
     				if(!Character.isDigit(arraySizeString.charAt(x)))

         			good=false;
			
       				if(!good)

         			System.out.println("Invalid array size - please enter an integer value");					
     						
			}
	

		
					
			arraysize = Integer.parseInt(arraySizeString);

			int[] array = new int[arraysize];



			good = false;
		
			for(int i = 0 ; i < array.length; ++i)

			{

			while(!good)
     				{

					good = true;

        				System.out.print("Enter Value #" + (i+1) + ":");
				
          				arraySizeString = console.nextLine();

     					for(int x=0; x<arraySizeString.length(); ++x)
					
     				
					if(!Character.isDigit(arraySizeString.charAt(x)))

         				good=false;
			
       					if(!good)

         				System.out.println("Invalid array size - please enter an integer value");
					
				}
			
					
			array[i] = Integer.parseInt(arraySizeString);

 			good = false;

    			
	
			}
		
			System.out.println("\n" + "Your data is:");
		
			for(int x = 0; x < array.length; ++x)
			{
  					System.out.println(array[x]);

			}			




		Arrays.sort(array);


	
		}
	
}

As far as I can see in your main() method you are not calling any of the other methods... (not included in the quote) so its no good to expect any results... otherwise your code seems OK.

[Joanne Neal]

todd stolz-schroeder wrote:You cant copy out of the command promt so thats what i had to do.

Right click on the text area of the command prompt and select the mark option.
Left-click and hold your mouse and drag your cursor over the area you want to cut and paste - the marked area will appear black on white.
Once you have selected the whole area you want to copy, release the mouse button.
Hit return
The selected area will now be in the copy buffer and can be pasted as usual.

[David Newton]

(Or set the Quick Edit mode in the command window options, then it's enabled by default.)