Can you have condition in <h:selectOneMenu> ?

[J James]

Hi all,
I'm trying to put condition in selectOneMenu and failing quite miserably. Can someone enlighten me if this is even possible? I’m getting the one selected value from Bean file as I should but I need to display two further more choices for an update. Here’s my current code.
Many thanks
JJ

  <h:selectOneMenu id="EVENT_TYPE_CODE" value="#{bean.selectedEvent.eventTypeCode}">
  <c:choose>
   <c:when test="#{bean.selectedEvent.eventTypeCode} == 'APPT'">
  <f:selectItem  itemValue="#{bean.selectedEvent.eventTypeCode}" itemLabel="Appointment" />
  <f:selectItem  itemValue="MEET" itemLabel="Meeting" />
  <f:selectItem  itemValue="ANNV" itemLabel="Anniversary" />
  </c:when>
  </c:choose>
</h:selectOneMenu>  

[Aman Goel]

No can't do by following this way......

[Bart Kummel]

Hi J,

I don't understand what exactly is your problem. However, I have a hint for you... Are you aware that there is also a <f:selectItems> component, that adds a list of items in one pass?

Best regards,
Bart

[J James]

Thanks for your replies , This is an update page I'm working on, the problem is I'm trying to put condition in <h:selectOneMenu> so if the value of <f:selectItem> is equal to lets say 'APPT' put the label to 'Appointment' and give them two more choices so they could update if they wish, like so;

  
   <h:selectOneMenu id="EVENT_TYPE_CODE" value="#{bean.selectedEvent.eventTypeCode}">
  <c:choose>
   <c:when test="#{bean.selectedEvent.eventTypeCode} == 'APPT'">
  <f:selectItem  itemValue="#{bean.selectedEvent.eventTypeCode}" itemLabel="Appointment" />
  <f:selectItem  itemValue="MEET" itemLabel="Meeting" />
  <f:selectItem  itemValue="ANNV" itemLabel="Anniversary" />
  </c:when>
  </c:choose>
</h:selectOneMenu> 

This code doesn't work. How do I do this ???

Bart Kummel wrote:Hi J,

I don't understand what exactly is your problem. However, I have a hint for you... Are you aware that there is also a <f:selectItems> component, that adds a list of items in one pass?

Best regards,
Bart

[Bart Kummel]

Hi,

Perhaps you could try this:

<h:selectOneMenu id="EVENT_TYPE_CODE" value="#{bean.selectedEvent.eventTypeCode}">  
  <f:selectItem  itemValue="#{bean.selectedEvent.eventTypeCode}" itemLabel="Appointment" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}"  />  
  <f:selectItem  itemValue="MEET" itemLabel="Meeting" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}" />  
  <f:selectItem  itemValue="ANNV" itemLabel="Anniversary" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}" />  
</h:selectOneMenu>

Note that I removed the <c:choose> and moved your condition to the rendered attribute of each <f:selectItem>. Alse notice the } that moved to the end of the expression. I hope this helps...

Best regards,
Bart Kummel

[Tim Holloway]

Mixing JSTL and JSF in the same view is almost always bad practice. So is putting application logic in the view.

As Bart said, you should consider building your selectItem list in a backing bean instead of on the page definition. It's much more flexible and easier to do as well.

[J James]

Thanks for your help Bart unfortunately I'm getting the following error. I don't think it likes rendered

   javax.faces.FacesException: /eveAddUpdate.jsp(185,2) Attribute rendered invalid for tag selectItem according to TLD 

jj

Bart Kummel wrote:Hi,

Perhaps you could try this:

<h:selectOneMenu id="EVENT_TYPE_CODE" value="#{bean.selectedEvent.eventTypeCode}">  
  <f:selectItem  itemValue="#{bean.selectedEvent.eventTypeCode}" itemLabel="Appointment" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}"  />  
  <f:selectItem  itemValue="MEET" itemLabel="Meeting" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}" />  
  <f:selectItem  itemValue="ANNV" itemLabel="Anniversary" rendered="#{bean.selectedEvent.eventTypeCode == 'APPT'}" />  
</h:selectOneMenu>

Note that I removed the <c:choose> and moved your condition to the rendered attribute of each <f:selectItem>. Alse notice the } that moved to the end of the expression. I hope this helps...

Best regards,
Bart Kummel

[Bart Kummel]

Sorry, I forgot the <f:selectItem> component doesn't have a rendered attribute. Then I guess there's no other option than creating your list in code and use a <f:selectItems>. That's a better solution anyway, as Tim mentioned correctly.

Best regards,
Bart

[J James]

Thanks for all your help guys, I'll have to work in backing bean.

JJ

Bart Kummel wrote:Sorry, I forgot the <f:selectItem> component doesn't have a rendered attribute. Then I guess there's no other option than creating your list in code and use a <f:selectItems>. That's a better solution anyway, as Tim mentioned correctly.

Best regards,
Bart