Struts2 + Spring + static method - best practices

[Marcin noway]

Hi

In my application I have:
FileParser interface with one method:HashSet<WordDescription> readWordsList(File file);
Strust2 Action class: FileUploadAction which has fileParser property.

In general I don't need instance of FileParser - readWordsList method can be static but I can't do it in interface. I set the method abstract and injected some implementation of FileParser to FileUploadAction as singleton.

Do you think its good solution? I'm not sure and I'm looking for something better. Have you got any ideas?

[David Newton]

Keeping implementation details non-specific helps testing and increases extensibility. Not sure what would be better, if anything.

[Marcin noway]

David Newton wrote:Keeping implementation details non-specific helps testing and increases extensibility. Not sure what would be better, if anything.

Great to hear it :) Thank you.