Spring with Quartz

[MichaelJ McCabe]

I have been ripping my hair out for a while with quartz just not working within my application. Being quite new to even Spring, I was hoping I am missing something simple and could be helped out. I have looked at online tutorials and even the spring in action book. But for some reason within my application it will not work.

I have a simple class

import org.springframework.scheduling.quartz.QuartzJobBean;
import org.quartz.JobExecutionException;
import org.quartz.JobExecutionContext;

public class MyJob extends QuartzJobBean {

    protected void executeInternal(JobExecutionContext ctx) throws JobExecutionException {

        System.out.println("EXECUTING QUARTZ JOB");
    }
}

and within my application-context (which I know is working with other beans)

    <bean name="myJob" class="org.springframework.scheduling.quartz.JobDetailBean">
        <property name="jobClass" value="path.MyJob"/>
    </bean>

    <bean id="simpleTrigger" class="org.springframework.scheduling.quartz.SimpleTriggerBean">
        <!-- see the example of method invoking job above -->
        <property name="jobDetail" ref="myJob"/>
        <property name="startDelay" value="1"/>
        <property name="repeatInterval" value="100"/>
    </bean>

    <bean class="org.springframework.scheduling.quartz.SchedulerFactoryBean">
        <propertyy name="triggers">
            <list>
                <ref bean="simpleTrigger"/>
            </list>
        </property>
    </bean>

That should be priting out the line over and over on the console, but its not. Any ideas?

[David Newton]

Is the misspelling of "property" a typo?

[MichaelJ McCabe]

David Newton wrote:Is the misspelling of "property" a typo?

Good eyes ;)

Yes it is, but only pasting here. In my code its spelt correctly... and double checked :P

[Christophe Verré]

How do you execute your application ? How do your read the context file ?

[MichaelJ McCabe]

Christophe Verré wrote:How do you execute your application ? How do your read the context file ?

I have my web.xml file with

	<context-param>
		<param-name>contextConfigLocation</param-name>
		<param-value>/WEB-INF/applicationContext.xml</param-value>
	</context-param>

[David Newton]

I think the question was more "How are you initializing Spring?"

[MichaelJ McCabe]

David Newton wrote:I think the question was more "How are you initializing Spring?"

Right ok. Like I said, my spring knowledge is limited but I am using ContextLoaderServlet

	<servlet>
	  <servlet-name>context</servlet-name>
	  <servlet-class>
		 org.springframework.web.context.ContextLoaderServlet
	  </servlet-class>
	<load-on-startup>1</load-on-startup>
	</servlet>

[MichaelJ McCabe]

I am getting this -

Error creating bean with name 'myJob' defined in ServletContext resource [/WEB-INF/applicationContext-hibernate.xml]:

Error setting property values; nested exception is org.springframework.beans.PropertyAccessExceptionsException: PropertyAccessExceptionsException (1 errors); nested propertyAccessExceptions are: [org.springframework.beans.TypeMismatchException: Failed to convert property value of type [java.lang.String] to required type [java.lang.Class] for property 'jobClass'; nested exception is java.lang.IllegalArgumentException: Class not found: MyJob

[Christophe Verré]

You're telling Spring that there is a JobDetailBean class called Myjob in the "path" package. Is the MyJob class in a package called "path" ? I don't see any package declaration in your code.

[MichaelJ McCabe]

Christophe Verré wrote:You're telling Spring that there is a JobDetailBean class called Myjob in the "path" package. Is the MyJob class in a package called "path" ? I don't see any package declaration in your code.

the "path" was just filled in as the path was really long. So although it wasnt specifically that, it turned out it was a path problem... which is quite embarasing.

But it brings me onto a simular question;

I want to reference a bean within the quartz job. Its a bean which is defined in my Struts-config, with its own action. Is this possible? The bean is as follows

	      <action
		      path="/importEmails"
		      name="ImportEmails"
		      scope="request"
		      validate="true"	      
		      input="/pages/user/importEmails"
		      type="dashboard.web.struts.action.ImportEmailsAction">
		      <forward name="success" path="/pages/user/admin.jsp"/>
		      <forward name="fail" path="/pages/user/importEmails.jsp"/>
                   </action>

[David Newton]

That's no bean, that's an action. Spring knows nothing about it.

Struts actions can be Spring beans (or vice-versa, depending on your point of view), but the action class itself would need to be defined as a Spring bean. There's Struts 1-Spring integration, so this is not a big deal.

That said: that's a *bad* idea, there should be no reason why a Quartz job would need to access a Struts action, unless something has gone wrong with your design: that's an inappropriate coupling.

[MichaelJ McCabe]

David Newton wrote:That's no bean, that's an action. Spring knows nothing about it.

Struts actions can be Spring beans (or vice-versa, depending on your point of view), but the action class itself would need to be defined as a Spring bean. There's Struts 1-Spring integration, so this is not a big deal.

That said: that's a *bad* idea, there should be no reason why a Quartz job would need to access a Struts action, unless something has gone wrong with your design: that's an inappropriate coupling.

Ok Thanks for the clear up. I'm very new to all this.

The reason I was to access a Struts action is as follows. Due to my lack of knowledge, I cannot think of a better way.

Within this quartz job, i want access to my SpringHibernateDao. Now I do this using

dashboard.dao.SpringHibernateDAO springHibernateDAO = (dashboard.dao.SpringHibernateDAO) ServiceFinder.getContext(request).getBean("SpringHibernateDao");

and my service finder

  public static ApplicationContext getContext(HttpServletRequest httpRequest) {
	   return WebApplicationContextUtils.getRequiredWebApplicationContext(
						httpRequest.getSession().getServletContext()); 
	 } 

this is the ONLY way I know of doing this. And it requires a HttpServletRequest. And the only way I know of having that is through a struts action

[David Newton]

Inject the DAO directly into your Quartz job--that's what Spring is for; why convolute things?

[MichaelJ McCabe]

David Newton wrote:Inject the DAO directly into your Quartz job--that's what Spring is for; why convolute things?

How would I go about doing this?

[David Newton]

Define the DAO bean in Spring and include it in the Quartz job bean: you might want to read up on some Spring basics before proceeding too much further; this IoC/DI (Inversion of Control/Dependency Injection) is one of the most basic aspects of Spring. getting a handle on it early will save you a lot of effort.

[MichaelJ McCabe]

David Newton wrote:Define the DAO bean in Spring and include it in the Quartz job bean: you might want to read up on some Spring basics before proceeding too much further; this IoC/DI (Inversion of Control/Dependency Injection) is one of the most basic aspects of Spring. getting a handle on it early will save you a lot of effort.

Thank you very much for all your help David. I looked into what you said and got it working by defining the DAO bean and;

 
    <bean name="myJob" class="org.springframework.scheduling.quartz.JobDetailBean">   
        <property name="jobClass" value="quartzJob"/>   
          <property name="jobDataAsMap">
		    <map>
		      <entry key="springHibernateDao">
		      	<ref bean="SpringHibernateDao"/>
		      </entry>
		    </map>
          </property>
    </bean>   

[David Newton]

Sweet :) Although I'd avoid naming Spring beans with a capital letter; it's a little confusing. Glad you got it working :)

[gopal chandra das]

Its not compiled with version - 2.5.2 ..... getting "The type org.quartz.Job cannot be resolved. It is indirectly referenced from required .class
files" messages in eclipse.

please help me.