Multiple File Save

[kavin clain]

In my code I receive uploaded image file and want to save it in two different sizes.

I am saving it using the given code:

The files of size 0 bytes get saved with the given names.
when I save only one at a time then it gets saved properly.
Please help me to debug the problem.

 
[b]//Step1.[/b]
File newFile = new File(Path.getUserPath()+"/"+(hs.getAttribute("userame"))+"/"+(hs.getAttribute("userame"))+".jpg");
if(newFile.exists()){
        newFile.delete();
}

OutputStream out=new FileOutputStream(newFile);
		
byte buf[]=new byte[1024];
	    
int len = 0;
	    
while((len=inputStream.read(buf))>0)
	out.write(buf,0,len);
		
out.flush();
out.close();


[b]//Step2.[/b]   
newFile = new File(Pathx.getUserPath()+"/"+(hs.getAttribute("userame"))+"/"+(hs.getAttribute("userame"))+"_original.jpg");
if(newFile.exists()){
	newFile.delete();
}
	    
OutputStream out2=new FileOutputStream(newFile);
		
byte buf2[]=new byte[1024];
	    
int len2 = 0;
	    
while((len2=inputStream.read(buf2))>0)
	out2.write(buf2,0,len2);
		
out2.flush();
out2.close();

[Ulf Dittmer]

Step 1 exhausts the input stream, so there's nothing in step 2 to read any more. You could read the entire contents of the input stream into memory using a ByteArrayOutputStream, and then work with the resulting byte[] as many times as you need to.

[Rob Spoor]

Or write to both files simultaneously:

// setup first output stream
File newFile = new File(Path.getUserPath()+"/"+(hs.getAttribute("userame"))+"/"+(hs.getAttribute("userame"))+".jpg");
if(newFile.exists()){
        newFile.delete();
}
OutputStream out=new FileOutputStream(newFile);

// setup second output stream
newFile = new File(Pathx.getUserPath()+"/"+(hs.getAttribute("userame"))+"/"+(hs.getAttribute("userame"))+"_original.jpg");
if(newFile.exists()){
	newFile.delete();
}
OutputStream out2=new FileOutputStream(newFile);

// now copy to both files
byte buf[]=new byte[1024];
	    
int len = 0;
	    
while((len=inputStream.read(buf))>=0) // important! 0 is a valid return value! -1 is not though
{
	out.write(buf,0,len);
	out2.write(buf,0,len);
}
	
out.flush();
out.close();

out2.flush();
out2.close();

Be sure to notice my remark on line 20.

[kavin clain]

I tried the below code:

Now only one file is getting saved but the the another file is just created with size 0 byte.

    
ByteArrayOutputStream baos = new ByteArrayOutputStream();
byte buf[]=new byte[1024];	    
int len;	    
while((len=inputStream.read(buf))>0)
	baos.write(buf,0,len);

		
File newFile2 = new File(Path.getUserPath()+"/"+(hs.getAttribute("username"))+"/"+(hs.getAttribute("username"))+"_original.jpg");
OutputStream out2 = new FileOutputStream(newFile2);
if(newFile2.exists()){
	newFile2.delete();
}
baos.writeTo(out2);


File newFile = new File(Path.getUserPath()+"/"+(hs.getAttribute("username"))+"/"+(hs.getAttribute("username"))+".jpg");		
if(newFile.exists()){
	newFile.delete();
}
OutputStream out=new FileOutputStream(newFile);
baos.writeTo(out);

[Rob Spoor]

You'll still need to flush() and close() the output streams.

[kavin clain]

Thank you Rob,

I followed your instructions and tried but again the same results. File with both names created but with size 0 byte.

[Ulf Dittmer]

How have you made sure that the input stream does contain any data?

[kavin clain]

In my second message after the last line baos.writeTo(out); I flushed both the out and out2 and again tried. This time the same results.

[kavin clain]

I followed your instructions and write the code (please see my second message with code), I was able to save one file correctly.

When I try to save only one file it gets saved. It means I am getting the input stream.

[Rob Spoor]

And what if you try the code from my post?

[kavin clain]

I tried the below code to find inputstream has some data!

    
while((len=inputStream.read(buf))>=0){
	System.out.println(len+"-");
	out.write(buf,0,len); 
        out2.write(buf,0,len);
}

Then one by one I tried to run codes suggested by both of you. Ulf your doubt is correct, the loop runs not for a single time.

[kavin clain]

I tried the code and I am getting desired results.

InputStream inputStream = avtarFile.getInputStream();		
BufferedImage bfimg = ImageIO.read(inputStream);

File newFile1 = new File(Path.getUserPath()+"/"+(hs.getAttribute("username"))+"/"+(hs.getAttribute("username"))+".jpg");		
if(newFile1.exists()){
	newFile1.delete();
}		
ImageIO.write(bfimg, "jpeg", newFile1);

File newFile2 = new File(Path.getUserPath()+"/"+(hs.getAttribute("username"))+"/"+(hs.getAttribute("username"))+"_original.jpg");		
if(newFile2.exists()){
	newFile2.delete();
}		
ImageIO.write(bfimg, "jpeg", newFile2);