Displaying ArrayList data in a JTable

[Jason Guyton]

So, while I take a break from that Accept/Reject problem, I'm trying to display the team rosters in a JTable that automatically updates with every player selection. I'm trying to embed all the code for the table into the DraftSimulation class. I've whittled it down to only one error.

package myPackage;

import java.util.ArrayList;
import javax.swing.*;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.DefaultTableModel;
import javax.swing.table.TableModel;

import myPackage.TableDemo.MyTableModel;

import java.awt.event.*;
import java.awt.*;

public class DraftSimulation extends javax.swing.JDialog {


	public ArrayList<Team> tl = new ArrayList<Team>();
	public ArrayList<Player> ap = new ArrayList<Player>();
	public ArrayList<Player> aqb = new ArrayList<Player>();
	public ArrayList<Player> arb= new ArrayList<Player>();
	public ArrayList<Player> ate = new ArrayList<Player>();
	public ArrayList<Player> awr = new ArrayList<Player>();
	private JTable jTable1;
	private JLabel jLabel2;

	public DraftSimulation(ArrayList<Team> list, ArrayList<Player> players){
		super();
		}
	
	public void doDraftSim(ArrayList<Team> list, ArrayList<Player> players, ArrayList<Player> qbs, ArrayList<Player> rbs, ArrayList<Player> tes, ArrayList<Player> wrs){
		initGUI(list);
		AddPlayer add = new AddPlayer();
		tl = list;
		int l;
		ap = players;
		aqb = qbs;
		arb = rbs;
		ate = tes;
		awr = wrs;
		
		// Outer loop for draft order
		for (int j = 0; j < 5; j++) {
			
			// Inner loop for forward half, 1 -> 10 
    		for (int i = 0; i < 1; i++) {
    			int half = 1;
    			// Calculate factors, multiply, and sort
    			RosterFactor rf = new RosterFactor();	
    			TierFactor tf = new TierFactor();
    			rf = RosterFactorCalculator.rosterFactorCalc(tl, i);
    			tf = TierFactorCalculator.tierFactorCalc(i, half, tl.get(i).control, aqb, arb, ate, awr);
    			System.out.println(tf);    			
    			MultSort.multSort(ap, rf, tf);  // add tf 

    			// add first position player to CPU controlled team
    			if (tl.get(i).control.equals("CPU")){
//        			System.out.println("cpu team detected");
        			l = 0;
        			add.addPlayer(l, i, tl, ap, aqb, arb, ate, awr);
        		// ask user if they want the recommended player
    			}else {
        			Boolean accepted = false;
        			l = 0;
        			while (accepted == false){
//						AcceptReject ask = new AcceptReject(ap.get(l));
//						ask.setVisible(true);
//        			CustomObjectPane ask = new CustomObjectPane(ap.get(l));
//       			System.out.println(ask);
        			JFrame frame = new JFrame("Accept / Reject");
        		    Object[] options = {"Accept","Reject"};
        			int m = JOptionPane.showOptionDialog(frame,
        					"Player: "+ap.get(l)+"Do you accept or reject this player?",
        						"Accept or Reject Player",
        						JOptionPane.YES_NO_OPTION,
        						JOptionPane.QUESTION_MESSAGE,
        						null,     //do not use a custom Icon
        						options,  //the titles of buttons
        						options[0]); //default button title
        			if (m == 0){
//            		if (accepted == true){	
						add.addPlayer(l, i, tl, ap, aqb, arb, ate, awr);
						accepted = true;
        			}
        			else {
        				l = l+1;
        			}
        		}
        		}
    		}
 
			// Inner loop for reverse half, 10 -> 1 
    		for (int i = 0; i >= 0; i--) {
    				int half = 0;
        			// Calculate factors, multiply, and sort
    				RosterFactor rf = new RosterFactor();	
    				TierFactor tf = new TierFactor();
    				rf = RosterFactorCalculator.rosterFactorCalc(tl, i);
    				tf = TierFactorCalculator.tierFactorCalc(i, half, tl.get(i).control, aqb, arb, ate, awr);
    				System.out.println(tf);    			
    				MultSort.multSort(ap, rf, tf);  // add tf 
//    				for (int k = 0; k <= 2; k++) {
//	    			System.out.println(aqb.get(k).name);
//    				}
    				if (tl.get(i).control.equals("CPU")){
 //   					System.out.println("cpu team detected");
    					l = 0;
    					add.addPlayer(l, i, tl, ap, aqb, arb, ate, awr);
    				}else {
        				Boolean accepted = false;
    					l = 0;
        				while (accepted == false){
//							AcceptReject ask = new AcceptReject(ap.get(l));
//							ask.setVisible(true);
//       				CustomObjectPane ask = new CustomObjectPane(ap.get(l));
    					JFrame frame = new JFrame("Accept / Reject");
    					Object[] options = {"Accept","Reject"};
    					int m = JOptionPane.showOptionDialog(frame,
        					"Player: "+ap.get(l)+"Do you accept or reject this player?",
        						"Accept or Reject Player",
        						JOptionPane.YES_NO_OPTION,
        						JOptionPane.QUESTION_MESSAGE,
        						null,     //do not use a custom Icon
        						options,  //the titles of buttons
        						options[0]); //default button title
    					if (m == 0){
//            			if (accepted == true){	
    						add.addPlayer(l, i, tl, ap, aqb, arb, ate, awr);
    						accepted = true;
    					}else {
    						l = l+1;
    					}
    				}
        		}
		}}
		// Output team rosters to console
		for (int j = 0; j < tl.size(); j++) {
			tl.get(j).fptot=tl.get(j).qb1fp+tl.get(j).qbbfp+tl.get(j).rb1fp+tl.get(j).rb2fp+
			tl.get(j).rbbfp+tl.get(j).wr1fp+tl.get(j).wr2fp+tl.get(j).wrbfp+tl.get(j).te1fp+tl.get(j).tebfp;
			System.out.println(tl.get(j));
		}
	}
    
	private void initGUI(ArrayList<Team> t) {
		try {
	                  
	//Create and set up the window.
        	JFrame frame = new JFrame("Draft Simulation");
        	frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        //Create and set up the content pane.
        	RosterTable newContentPane = new RosterTable(t);  ///////<<<<<-----RosterTable cannot be resolved to a type
        	newContentPane.setOpaque(true); //content panes must be opaque
        	frame.setContentPane(newContentPane);

        //Display the window.
        	frame.pack();
        	frame.setVisible(true);
			{
				jLabel2 = new JLabel();
				getContentPane().add(jLabel2, BorderLayout.NORTH);
				jLabel2.setText("Draft Simulation");
			}
		}
	 catch (Exception e) {
			e.printStackTrace();
		}
	}

    private void RosterTable(ArrayList<Team> tl) {
        //super();//new GridLayout(1,0));
        JTable table = new JTable(new RosterTableModel(tl));
        table.setPreferredScrollableViewportSize(new Dimension(700, 170));
        table.setFillsViewportHeight(true);

        //Create the scroll pane and add the table to it.
        JScrollPane scrollPane = new JScrollPane(table);

        //Add the scroll pane to this panel.
        add(scrollPane);
    }
    
    private class RosterTableModel extends AbstractTableModel {
    	private ArrayList<Team> t;
    	private RosterTableModel(ArrayList<Team> t){
    		this.t = t;
        }
       	private String[] columnNames = {"Team","QB1","RB1","RB2","WR1","WR2","TE1","QBB","RBB","WRB","TEB","TotFanPoints"};
        private Object[][] data = {
            {t.get(0).getName(),t.get(0).getQb1(),t.get(0).getRb1(),t.get(0).getRb2(),t.get(0).getWr1(),t.get(0).getWr2(),t.get(0).getTe1(),t.get(0).getQbb(),t.get(0).getRbb(),t.get(0).getWrb(),t.get(0).getTeb(),t.get(0).getFptot()},
            {t.get(1).getName(),t.get(1).getQb1(),t.get(1).getRb1(),t.get(1).getRb2(),t.get(1).getWr1(),t.get(1).getWr2(),t.get(1).getTe1(),t.get(1).getQbb(),t.get(1).getRbb(),t.get(1).getWrb(),t.get(1).getTeb(),t.get(1).getFptot()},
            {t.get(2).getName(),t.get(2).getQb1(),t.get(2).getRb1(),t.get(2).getRb2(),t.get(2).getWr1(),t.get(2).getWr2(),t.get(2).getTe1(),t.get(2).getQbb(),t.get(2).getRbb(),t.get(2).getWrb(),t.get(2).getTeb(),t.get(2).getFptot()},
            {t.get(3).getName(),t.get(3).getQb1(),t.get(3).getRb1(),t.get(3).getRb2(),t.get(3).getWr1(),t.get(3).getWr2(),t.get(3).getTe1(),t.get(3).getQbb(),t.get(3).getRbb(),t.get(3).getWrb(),t.get(3).getTeb(),t.get(3).getFptot()},
            {t.get(4).getName(),t.get(4).getQb1(),t.get(4).getRb1(),t.get(4).getRb2(),t.get(4).getWr1(),t.get(4).getWr2(),t.get(4).getTe1(),t.get(4).getQbb(),t.get(4).getRbb(),t.get(4).getWrb(),t.get(4).getTeb(),t.get(4).getFptot()},
            {t.get(5).getName(),t.get(5).getQb1(),t.get(5).getRb1(),t.get(5).getRb2(),t.get(5).getWr1(),t.get(5).getWr2(),t.get(5).getTe1(),t.get(5).getQbb(),t.get(5).getRbb(),t.get(5).getWrb(),t.get(5).getTeb(),t.get(5).getFptot()},
            {t.get(6).getName(),t.get(6).getQb1(),t.get(6).getRb1(),t.get(6).getRb2(),t.get(6).getWr1(),t.get(6).getWr2(),t.get(6).getTe1(),t.get(6).getQbb(),t.get(6).getRbb(),t.get(6).getWrb(),t.get(6).getTeb(),t.get(6).getFptot()},
            {t.get(7).getName(),t.get(7).getQb1(),t.get(7).getRb1(),t.get(7).getRb2(),t.get(7).getWr1(),t.get(7).getWr2(),t.get(7).getTe1(),t.get(7).getQbb(),t.get(7).getRbb(),t.get(7).getWrb(),t.get(7).getTeb(),t.get(7).getFptot()},
            {t.get(8).getName(),t.get(8).getQb1(),t.get(8).getRb1(),t.get(8).getRb2(),t.get(8).getWr1(),t.get(8).getWr2(),t.get(8).getTe1(),t.get(8).getQbb(),t.get(8).getRbb(),t.get(8).getWrb(),t.get(8).getTeb(),t.get(8).getFptot()},
            {t.get(9).getName(),t.get(9).getQb1(),t.get(9).getRb1(),t.get(9).getRb2(),t.get(9).getWr1(),t.get(9).getWr2(),t.get(9).getTe1(),t.get(9).getQbb(),t.get(9).getRbb(),t.get(9).getWrb(),t.get(9).getTeb(),t.get(9).getFptot()},
        };

        public int getColumnCount() {
            return columnNames.length;
        }

        public int getRowCount() {
            return t.size(); //data.length;
        }

        public String getColumnName(int col) {
            return columnNames[col];
        }

       	public Object getValueAt(int row, int col) {
            return data[row][col];
       }

        public Class getColumnClass(int c) {
            return getValueAt(0, c).getClass();
        }
               
        public void setValueAt(Object value, int row, int col) {
            data[row][col] = value;
            fireTableCellUpdated(row, col);
        }

        private void printDebugData() {
            int numRows = getRowCount();
            int numCols = getColumnCount();
            for (int i=0; i < numRows; i++) {
                System.out.print("    row " + i + ":");
                for (int j=0; j < numCols; j++) {
                    System.out.print("  " + data[i][j]);
                }
                System.out.println();
            }
            System.out.println("--------------------------");
        }
    }
    }

    

The error is "RosterTable cannot be resolved to a type". I don't see anything wrong with it, so I'm kind of stumped.

[Michael Dunn]

weirdest bit of code I've seen for a while

in the middle of a class that extends JDialog, you're creating multiple JFrames?

in the method (that you think is a class), you add the table/scrollpane to the extended JDialog,
but try to set that as a JFrame's contentPane.

[Jason Guyton]

Michael Dunn wrote:weirdest bit of code I've seen for a while

in the middle of a class that extends JDialog, you're creating multiple JFrames?

in the method (that you think is a class), you add the table/scrollpane to the extended JDialog,
but try to set that as a JFrame's contentPane.

As I explained in another thread, I'm a java beginner being asked to create a rather complex program for a class project. I'm trying to cobble something together that functions. I've scoured the internet for examples and tried to frankenstein them together with only a pittance of understanding. That's why that extra JFrame showed up, along with numerous other WTFs. Please, enlighten me. I am willing to learn.

If you have a great method for displaying arraylist data in a jtable that updates as the objects in the arraylist change, I'd love to see it.

[Michael Dunn]

> I'm a java beginner being asked to create a rather complex program for a class project

the purpose of such projects is to get you to learn/understand something, and submitting
something that works by accident won't get you many points.


> If you have a great method for displaying arraylist data in a jtable that updates as the objects in the arraylist change, I'd love to see it.

how do the objects in the arraylist change?

[Jason Guyton]

Actually, this is not even a java class. The purpose of the project is to understand information modeling and knowledge based systems. They just want us to implement a knowledge system using java. Java really should have been a prerequisite.

The ArrayList that I want to display is a list of Team objects. The Team object includes QB1, RB1, RB2, etc. These are initially empty. As my system runs thru a draft simulation, these positions are filled with a player name. So, as each player is placed on a team, I'd like to see the jTable pop in the name at the correct position. I believe this can be done with fireTableCellUpdated. But, since I can't get the table to display, I can't tell if that is working.

[Michael Dunn]

here's a (very) simple demo of working with the table's model.

the table/model loads initially with some data from an arraylist (presumably arraylist is loaded from a file)

click the 'Add Player' button, fill in the 3 textfields, click 'OK', and the table will update (via the model)
(extra code required if new player is to be saved to file, for next time loading)

    
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.table.*;

class Testing
{
  String colNames[] = {"First Name", "Last Name","Position"};
  DefaultTableModel dtm = new DefaultTableModel(null,colNames);
  public void buildGUI()
  {
    java.util.List<Player> players = new java.util.ArrayList<Player>(java.util.Arrays.asList(
      new Player[]{new Player("Jim","Jones","Keeper"),new Player("Michael","Jackson","Winger"),
      new Player("Tiger","Woods","Striker"), new Player("Michael","Dunn","Left-right-out")}));

    JTable table = new JTable(dtm);
    for(int x = 0, y = players.size(); x < y; x++)
    {
      addPlayer(players.get(x));
    }
    JScrollPane sp = new JScrollPane(table);
    JButton addPlayerBtn = new JButton("Add Player");

    final JFrame f = new JFrame("Players");
    f.getContentPane().add(sp);
    f.getContentPane().add(addPlayerBtn,BorderLayout.SOUTH);
    f.pack();
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setVisible(true);
    addPlayerBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        JLabel[] labels = {new JLabel("First Name: "),new JLabel("Last Name: "),new JLabel("Position: ")};
        JTextField[] data = {new JTextField(5),new JTextField(5),new JTextField(5)};
        final int ROWS = 3;
        final int COLUMNS = 2;
        JPanel p = new JPanel(new GridLayout(ROWS,COLUMNS));
        for(int x = 0; x < ROWS; x++)
        {
          p.add(labels[x]);
          p.add(data[x]);
        }
        JOptionPane.showMessageDialog(f.getContentPane(),p);//needs error handling
        addPlayer(new Player(data[0].getText(),data[1].getText(),data[2].getText()));
      }
    });
  }
  public void addPlayer(Player player)
  {
    dtm.addRow(player.getData());
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}
class Player
{
  String firstName;
  String lastName;
  String position;
  public Player(String fn, String ln, String p)
  {
    firstName = fn; lastName = ln; position = p;
  }
  public String[] getData()
  {
    return new String[]{firstName,lastName,position};
  }
}

[Rohit Kedia]

Hi There please do not use an Array for setting Value in Jtable you can use directly from a List to a Cell.
you can use in this way

getValueAt(int row){
VO vo = list.get(int row);
if col==1
return vo.getPropertyValue();
}

setValueAT(int row){
similaryly you can set the Value in the List
the FireTablecellUpdate()

}

[Rohit Kedia]

NOte this changes need to be done in the TableModel which will be extended by your customized Table Model

[Jason Guyton]

Wow, that's pretty slick. But, that's not quite the functionality I was looking for. Let me be more specific.

I have a class called Autodrafter that has the main. This starts a window that has a button for doing a draft simulation. That button starts a window that takes user input to initialize the team names and a few other attributes. Hitting the enter button creates 10 team objects. Each team object also has an attribute for each roster spot that are initially set to an empty string. There is also a "Draft Simulation" button that calls a class to do the sim. Right now, this function has no GUI component, all the info is displayed in the console. I'm trying to add this table that shows all 10 teams and all the roster spots (that would initially be empty). Then as the sim function goes thru the simulation adding players into these roster positions, the table would update the appropriate fields as they are assigned. From what I've read about tables, this should be possible, since the cells just reference the objects. the fireTableCellUpdated should enable this.

So, the DraftSimulation method is passed the playerlist and the teamlist. The simulation function includes the Accept/Reject functionality that I just got working. So, the main GUI element of the Simulation is the roster table.

[Jason Guyton]

OK, I coded a new class called RosterTable that is called by two other functions of the program. It actually displays a table! But I have two problems.

Problem 1: The table is displayed very small. All the data in the cells is truncated, showing only a few characters of the player's names. I can resize the window and all the columns expand equally, but i have to make it about 3 times the original width to see the names well enough. Also, there is gray space below the table that double the height of the window. How can I size the window to my liking?

Problem2: The table displays an initial state of the data in the arraylist, which is mostly empty strings. As the popups for selecting players come and go, the table does not update. I tried the public void fireTableDataChanged() in the table model, but it didn't work.

The call from the parent...

 		RosterTable r = new RosterTable();
		r.createRosterTable(tl);
   

The RosterTable class..

  
package myPackage;

import javax.swing.JFrame;
import java.util.*;
import java.awt.Container;
import javax.swing.JTable;
import javax.swing.JScrollPane;
import javax.swing.table.AbstractTableModel;
import java.awt.BorderLayout;

public class RosterTable extends JFrame {

	public ArrayList<Team> tl = new ArrayList<Team>();
	
	public RosterTable(){
		super("Roster Table");
	}
	
	public void createRosterTable(ArrayList<Team> list){
		tl = list;
		Container contentPane = getContentPane();
		contentPane.setLayout(new BorderLayout());
		contentPane.add(new JScrollPane (new JTable (new RosterTableModel(tl))));
		pack();
		setLocation(300,600);
		setVisible(true);
	}
	
	private class RosterTableModel extends AbstractTableModel{
		private ArrayList<Team> tl;
		private String[] columnNames = {"Team","QB1","RB1","RB2","WR1","WR2","TE1","QBB","RBB","WRB","TEB","TotFanPoints"};
		public RosterTableModel(){
			super();
		}
		public RosterTableModel(ArrayList<Team> list){
			this.tl = list;
			System.out.println(tl.get(0));
		}
		public int getColumnCount(){
			return 12;
		}
		public String getColumnName(int col) {
            return columnNames[col];
        }
        public int getRowCount() {
            return tl.size();
        }
        public Object getValueAt (int rowIndex, int  columnIndex) {
        	Object value;
        	Team team = tl.get (rowIndex);
        	if (columnIndex == 0) {
        	value = team.getName();
        	} else if (columnIndex == 1) {
        	value = team.getQb1();
        	} else if (columnIndex == 2) {
            	value = team.getRb1();
        	} else if (columnIndex == 3) {
            	value = team.getRb2();
        	} else if (columnIndex == 4) {
            	value = team.getWr1();
        	} else if (columnIndex == 5) {
            	value = team.getWr2();
        	} else if (columnIndex == 6) {
            	value = team.getTe1();
        	} else if (columnIndex == 7) {
            	value = team.getQbb();
        	} else if (columnIndex == 8) {
            	value = team.getRbb();
        	} else if (columnIndex == 9) {
            	value = team.getWrb();
        	} else if (columnIndex == 10) {
            	value = team.getTeb();
        	} else if (columnIndex == 11) {
            	value = team.getFptot();
        	} else {
        	throw new IndexOutOfBoundsException ();
        	}
        	return value;
        	}
        	protected int rowMargin(){
        	return 10;
        	}
        	public void fireTableDataChanged(){}
	}
}
 

[Rob Spoor]

First some small improvements for your class:
1) use a switch statement in the getValueAt method

2) you have no setValueAt method which indicates that all values are read-only. If this should be the case you should override isCellEditable to return false for all read-only columns. Simply return false to make all cells read-only.

Jason Guyton wrote:Problem 1: The table is displayed very small. All the data in the cells is truncated, showing only a few characters of the player's names. I can resize the window and all the columns expand equally, but i have to make it about 3 times the original width to see the names well enough.

Use the JTable and its TableColumnModel to get hold of all TableColumn objects, then give each column a minimum size.

Also, there is gray space below the table that double the height of the window. How can I size the window to my liking?

After you've created the window and sized it (using pack()), you can call setSize:

Dimension size = window.getSize();
size.height = something else
window.setSize(size); // keeps the same width

Problem2: The table displays an initial state of the data in the arraylist, which is mostly empty strings. As the popups for selecting players come and go, the table does not update. I tried the public void fireTableDataChanged() in the table model, but it didn't work.

Do you call fireTableDataChanged() after you've added a team to your ArrayList? Because the model needs to have changed before you can notify the table. If that still does not work try calling fireTableRowsInserted instead. The new index is of course getRowCount() - 1 or tl.size() - 1 (which are of course the same).

[Jason Guyton]

I'm trying to add in some of your suggestions.

1 - Not sure what you mean by switch statement.

2 - setValueAt - Got it.

3 - On the TableColumnModel for setting column size, do I have to create another inner class for TableColumnModel to do that?

4 - Setting window size did not seem to have any effect. I was doing this to the contentPane object.

5 - The set of teams is fixed at 10. there is no adding of columns or rows. The only the values in the cells are changed by the draft algorithm. A roster slot is changed from " " to "Drew Brees" for example. The table will fill in all the new info as soon as I manually resize it, but it doesn't do anything when the picks are happening.

[Rob Spoor]

Jason Guyton wrote:I'm trying to add in some of your suggestions.

1 - Not sure what you mean by switch statement.

switch (column)
{
    case 0:
        value = ...
        break;
    case 1:
        value = ...
        break;
    ...
    default:
        throw new IndexOutOfBoundsException();
}

3 - On the TableColumnModel for setting column size, do I have to create another inner class for TableColumnModel to do that?

Just retrieve the one from the JTable:

TableColumnModel columnModel = table.getColumnModel();

4 - Setting window size did not seem to have any effect. I was doing this to the contentPane object.

The content pane is not the window, is it? The frame is your window.

5 - The set of teams is fixed at 10. there is no adding of columns or rows. The only the values in the cells are changed by the draft algorithm. A roster slot is changed from " " to "Drew Brees" for example. The table will fill in all the new info as soon as I manually resize it, but it doesn't do anything when the picks are happening.

Then call fireTableCellUpdated.

[Jason Guyton]

I will implement those changes when I get home. Thanks for the input.

I think I'm still confused about the fireTableCellUpdated call. I found an example that has this in the table model..

        public void setValueAt(Object value, int row, int col) {
                  data[row][col] = value;
            fireTableCellUpdated(row, col);
        }

Is that correct?

So, theoretically, if I have a line in the parent class (the one that called the RosterTable class to draw the table) that changes a roster position from " " to "Joe Schmo", the table cell will immediately update in the table? I don't need any other listeners or other tricksies. I hope so, because that's the functionality that I want.

[Rob Spoor]

The JTable is a listener itself, so calling this method will make the JTable repaint this cell.

[Jason Guyton]

Wow, I keep getting stuck. Passing these arraylists around is hard work (and the source of many errors).

So, to put in this code...

   
public void setValueAt(Object value, int row, int col) {  
     data[row][col] = value;  
     fireTableCellUpdated(row, col);  
} 

I need the values to be defined by a 2d array called data. But, I had my values defined by this....

 
        public Object getValueAt (int row, int  col) {
        	Object value;
        	Team team = tl.get (row);
        	if (col == 0) {
        	value = team.getName();
        	} else if (col == 1) {
        	value = team.getQb1();
        	} else if (col == 2) {
            	value = team.getRb1();
        	} else if (col == 3) {
            	value = team.getRb2();
        	} else if (col == 4) {
            	value = team.getWr1();
        	} else if (col == 5) {
            	value = team.getWr2();
        	} else if (col == 6) {
            	value = team.getTe1();
        	} else if (col == 7) {
            	value = team.getQbb();
        	} else if (col == 8) {
            	value = team.getRbb();
        	} else if (col == 9) {
            	value = team.getWrb();
        	} else if (col == 10) {
            	value = team.getTeb();
        	} else if (col == 11) {
            	value = team.getFptot();
        	} else {
        	throw new IndexOutOfBoundsException ();
        	}
        	return value;  
         } 

So, then I tried to define the data array by using this....

 
		private Object[][] data;{ 
                for (int i = 0; i <10; i++){
                	data[i][0]= this.tl.get(i).getName();  //<------ run error on this line
                	data[i][1]= tl.get(i).getQb1();
                	data[i][2]= tl.get(i).getRb1();
                	data[i][3]= tl.get(i).getRb2();
                	data[i][4]= tl.get(i).getWr1();
                	data[i][5]= tl.get(i).getWr2();
                	data[i][6]= tl.get(i).getTe1();
                	data[i][7]= tl.get(i).getQbb();
                	data[i][8]= tl.get(i).getRbb();
                	data[i][9]= tl.get(i).getWrb();
                	data[i][10]= tl.get(i).getTeb();
                	data[i][11]= tl.get(i).getFptot();
                	}
	}   

Eclipse shows no errors until I run it. It bombs out with an out of bounds error on the line marked above. So, I can only assume one of two things...

Thing 1. The arraylist isn't getting passed to this table model class. But, it works for the other methods in the table model.
Thing 2. I'm not declaring this data array properly. It seems I can't just declare

private Object[][] data;

It demands a brace block after that presumably to define the values. Anyway, I'm stuck again.

Funny, I read on one of these many sites that writing your own table model is simple. Yeah, maybe for a pro.

[Jason Guyton]

Oh, and the column width stuff didn't have any effect.

Nor did the window sizing.

I suck at this.

Here's what I have so far....

package myPackage;

import javax.swing.JFrame;
import java.awt.Dimension;
import java.util.*;
import java.awt.Container;
import javax.swing.JTable;
import javax.swing.JScrollPane;
import javax.swing.table.AbstractTableModel;
import java.awt.BorderLayout;
import javax.swing.table.TableColumnModel;
import javax.swing.table.TableColumn;

public class RosterTable extends JFrame {

	public ArrayList<Team> tl = new ArrayList<Team>();
	
	public RosterTable(){
		super("Roster Table");
	}
	
	public void createRosterTable(ArrayList<Team> list){
		tl = list;
		Container contentPane = getContentPane();
		contentPane.setLayout(new BorderLayout());
		JTable table = new JTable(new RosterTableModel(tl));
		contentPane.add(new JScrollPane (table));//new JTable (new RosterTableModel(tl))));
		pack();
		setLocation(100,800);
		TableColumnModel columnModel = table.getColumnModel(); //<------ says columnModel is never read
		TableColumn column = null;
		for (int i = 0; i < 12; i++) {
		    column = table.getColumnModel().getColumn(i);
		    if (i == 11) {
		        column.setPreferredWidth(100); 
		    } else {
		        column.setPreferredWidth(350);
		    }
		}
//		Dimension size = contentPane.getSize();  
//		size.height = 100;  
//		contentPane.setSize(size); // keeps the same width
		setVisible(true);
	}
	
	private class RosterTableModel extends AbstractTableModel{
		private ArrayList<Team> tl;
		private String[] columnNames = {"Team","QB1","RB1","RB2","WR1","WR2","TE1","QBB","RBB","WRB","TEB","TotFanPoints"};
/*		private Object[][] data;{ 
                for (int i = 0; i <10; i++){
                	data[i][0]= this.tl.get(i).getName();
                	data[i][1]= tl.get(i).getQb1();
                	data[i][2]= tl.get(i).getRb1();
                	data[i][3]= tl.get(i).getRb2();
                	data[i][4]= tl.get(i).getWr1();
                	data[i][5]= tl.get(i).getWr2();
                	data[i][6]= tl.get(i).getTe1();
                	data[i][7]= tl.get(i).getQbb();
                	data[i][8]= tl.get(i).getRbb();
                	data[i][9]= tl.get(i).getWrb();
                	data[i][10]= tl.get(i).getTeb();
                	data[i][11]= tl.get(i).getFptot();
                	}
	}*/
		public RosterTableModel(){
			super();
		}
		public RosterTableModel(ArrayList<Team> list){
			this.tl = list;
			System.out.println(tl.get(0));
		}
		public int getColumnCount(){
			return 12;
		}
		public String getColumnName(int col) {
            return columnNames[col];
        }
        public int getRowCount() {
            return tl.size();
        }
        public Object getValueAt (int row, int  col) {
       	Object value;
        	Team team = tl.get (row);
        	if (col == 0) {
        	value = team.getName();
        	} else if (col == 1) {
        	value = team.getQb1();
        	} else if (col == 2) {
            	value = team.getRb1();
        	} else if (col == 3) {
            	value = team.getRb2();
        	} else if (col == 4) {
            	value = team.getWr1();
        	} else if (col == 5) {
            	value = team.getWr2();
        	} else if (col == 6) {
            	value = team.getTe1();
        	} else if (col == 7) {
            	value = team.getQbb();
        	} else if (col == 8) {
            	value = team.getRbb();
        	} else if (col == 9) {
            	value = team.getWrb();
        	} else if (col == 10) {
            	value = team.getTeb();
        	} else if (col == 11) {
            	value = team.getFptot();
        	} else {
        	throw new IndexOutOfBoundsException ();
        	}
        	return value;
//            return data[row][col];
        	}
        	public void setValueAt(Object value, int row, int col) {  
 //       		data[row][col] = value;  
        		fireTableCellUpdated(row, col);  
        	}
}}
    

I get a table out of it. But it's still small, and won't update. Does somebody make a GUI plugin to make my GUI?

[Michael Dunn]

> Oh, and the column width stuff didn't have any effect.

add this line
table.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);

[Jason Guyton]

Sweet. that fixed the column width. Phew. But the window is still small. How do I access the JFrame when it's not explicitly defined. It's created by having the class extend JFrame correct?

So, this...
# Dimension size = window.getSize();
# size.height = something else
# window.setSize(size); // keeps the same width

Refers to the window. How do I get window?

[Michael Dunn]

> window.setSize(size); // keeps the same width

shouldn't, unless it is followed by a pack()

[Jason Guyton]

You are a man of few words. But they are valuable words. I just wish I could put them all together into something that works.

That piece of code refers to the object "window". But it's not explicitly defined. contentPane and table are explicitly defined. But how do I get to the window? I tried making a new JFrame and adding the stuff in it, but the table disappeared from the window. I'm getting really frustrated now.

[Michael Dunn]

I see what you mean now.

if you're extending JFrame (or JDialog), then the class that extends JFrame is a JFrame, so all you need to do is
setSize(w,h);

just make sure there's no pack() following

[Jason Guyton]

That's what I was thinking, but the pack() at the end made that command useless. It works now!

One last hurdle, the auto updating of the table data. Did you follow the problem I'm having trying to implement the fireTableCellUpdated(row, col); command?

I tried copy and pasting the same if statements from the getvalue method in to the setvalue method, but that had no effect. I tried to switch the order of the equals statements to match the "data[row][col] = value" statement, but Mr.JavaMan didn't like that.

        	public void setValueAt(Object value, int row, int col) {  
 //       		data[row][col] = value; //<--------  this was from the original fireTableCellUpdated example that I'm trying to work around
//               	Object value;   //<-----this was from the getValueAt method, but it was duplicating a variable
            	Team team = tl.get (row);
            	if (col == 0) {
            	value = team.getName();
            	} else if (col == 1) {
            	value = team.getQb1();
            	} else if (col == 2) {
                	value = team.getRb1();
            	} else if (col == 3) {
                	value = team.getRb2();
            	} else if (col == 4) {
                	value = team.getWr1();
            	} else if (col == 5) {
                	value = team.getWr2();
            	} else if (col == 6) {
                	value = team.getTe1();
            	} else if (col == 7) {
                	value = team.getQbb();
            	} else if (col == 8) {
                	value = team.getRbb();
            	} else if (col == 9) {
                	value = team.getWrb();
            	} else if (col == 10) {
                	value = team.getTeb();
            	} else if (col == 11) {
                	value = team.getFptot();
            	} else {
            	throw new IndexOutOfBoundsException ();
            	}
        		fireTableCellUpdated(row, col);  
        	}    

[Rob Spoor]

You're not changing any data that is related to your table model. You'll need to call team.setXXX with setXXX being the method to set the value for that column.

[Michael Dunn]

I'm still not convinced updating the ArrayList is the way to go (unless you have no control over this)

here's my earlier code, now with team names/positions, but empty player info,
with a button to fill a team/position with a player name.
(the basic description I'm reading in this thread)

click the button, then fill in the team number (1 to 10), the position number (1 to 6),
and any player name. click OK and the table's model updates

    
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.table.*;

class Testing
{
  String colNames[] = {"Team Name","Pos 1","Pos 2","Pos 3","Pos 4","Pos 5","Pos 6"};
  DefaultTableModel dtm = new DefaultTableModel(null,colNames);
  public void buildGUI()
  {
    dtm.setRowCount(10);
    for(int x = 0, y = dtm.getRowCount(); x < y; x++)
    {
      dtm.setValueAt("Team "+(x+1),x,0);
    }
    JTable table = new JTable(dtm);
    JScrollPane sp = new JScrollPane(table);
    JButton fillPositionBtn = new JButton("Fill Position");

    final JFrame f = new JFrame("Teams");
    f.getContentPane().add(sp);
    f.getContentPane().add(fillPositionBtn,BorderLayout.SOUTH);
    f.setSize(750,500);
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setVisible(true);
    fillPositionBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        JLabel[] labels = {new JLabel("Team Number: "),new JLabel("Position Number: "),new JLabel("Player Name: ")};
        JTextField[] data = {new JTextField(5),new JTextField(5),new JTextField(5)};
        final int ROWS = 3;
        final int COLUMNS = 2;
        JPanel p = new JPanel(new GridLayout(ROWS,COLUMNS));
        for(int x = 0; x < ROWS; x++)
        {
          p.add(labels[x]);
          p.add(data[x]);
        }
        JOptionPane.showMessageDialog(f.getContentPane(),p);//needs error handling
        int teamNumber = Integer.parseInt(data[0].getText());//ensure a number 1 to 10 is entered
        int positionNumber = Integer.parseInt(data[1].getText());//ensure a number 1 to 6 is entered
        String playerName = data[2].getText();// any string will do
        dtm.setValueAt(playerName,teamNumber-1,positionNumber);
      }
    });
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}

[Jason Guyton]

All right, I'll try to explain what I'm doing.

I have a system that calculates the best player to choose based on their point total and other factors that are calculated as the draft progresses. So, when the program is started, the player data is read in from an excel file. This creates multiple instances of the Player object. These objects are collected into several ArrayLists, one for all players, and one each for each position. Then the user sets up the teams. This creates 10 team objects with empty rosters. These are collected into a TeamList arraylist.

Now, when the draft function is called, it is passed all of these ArrayLists. It displays this Table to show the rosters. The user is asked what player was taken by each team in their predetermined draft order. Then, when it's the user's turn to choose, the system calculates the appropriate factors, multiplies each player's point total by the factors, and sorts the arraylist. Then the user is asked to accept or reject the top ranked player in the newly sorted list. For each selection, I call an AddPlayer class to modify the Player's team attribute, modify the Team's appropriate roster slot, and remove the player from the arraylists.

The table will always be displayed during the selection process. There are no rows or columns added to the table. Only the attributes of the Team objects are getting changed. So, after every selection, I want the player to appear in the table. Can this be done by calling a method related to the table as part of the AddPlayer routine?

Hopefully, that clears things up. Are we still one the right track with fireTableCellUpdated? Or is that not appropriate for this case?

[Jason Guyton]

I thought I almost had it. So, the Draft class calls the RosterTable straight away. Then the draft logic starts with some for loops and such which include calls to AddPlayer. I modified AddPlayer to return a value to identify the correct roster slot that was filled. Then I can invoke the setValueAt method using a row and column index (team and slot). But the method is buried in the RosterTableModel within the RosterTable object.

How do I reach down into the RosterTableModel to trigger the setvalueAt?

[Michael Dunn]

> How do I reach down into the RosterTableModel to trigger the setvalueAt?

((RosterTableModel)table.getModel()).setValueAt(...);

[Rob Spoor]

Do you really need that cast?

[Jason Guyton]

Damn, I almost had it. I got it all in there without any errors. Ran it. But, no update. Booooooo.

Code from calling parent...

 
	public void doLiveDraft(ArrayList<Team> list, ArrayList<Player> players, ArrayList<Player> qbs, ArrayList<Player> rbs, ArrayList<Player> tes, ArrayList<Player> wrs){
		AddPlayer add = new AddPlayer();
		tl = list;
		RosterTable r = new RosterTable();
		r.createRosterTable(tl);
		int l;
		ap = players;
		aqb = qbs;
		arb = rbs;
		ate = tes;
		awr = wrs;
		int slot;
		// Outer loop for draft order
		for (int j = 0; j < 1; j++) {
			
			// Inner loop for forward half, 1 -> 10
    		for (int i = 0; i < 5; i++) {
    			int half = 1;
    			// If team is CPU controlled, ask for a player taken
    			if (tl.get(i).control.equals("CPU")){
    				PlayerPicker pick = new PlayerPicker();
    				l = pick.startPlayerPicker(ap, tl.get(i).getName());  //<------  this is the player chooser dialog, returns index of player in list
    				String name = ap.get(i).getName();   //<------  grabs name of player before calling addPlayer because addPlayer removes it from the arraylist
    				slot = add.addPlayer(l, i, tl, ap, aqb, arb, ate, awr);    //<----  this is what changes the attribute of the Team, modified to return the slot (column)
    				r.getModel().setValueAt(name,i,slot);   //<------- should update table

    			}   

But, now, I'm confused about what exactly to put in the setValueAt method.

        	public void setValueAt(Object valu, int row, int col) {  
 //      		data[row][col] = valu; //   <------this is what was in the example I saw, but I don't have that data array.
        		fireTableCellUpdated(row, col);   //<-----why isn't this enough to update the cell?
        	}    

[Jason Guyton]

Update.... I threw in a system.out line in the setValueAt method just to see if it was processing it. Seems to be working fine. So, I just need the proper code in the method to make it work. I'm wondering if the fireTableCellUpdated line is only for user edits to the table itself, but not necessarily changes in the underlying array data.