Trouble with return value from a JDialog

[Jason Guyton]

I thought I had this one working, but seems I've honked it up.

I'm trying to popup a window that displays the list of available players. The user clicks a name on the list, some text fields on the right fill in with the selected plyaer's info. This all works fine. The getSelectedIndex method works fine for those text fields. But I can't seem to return that index when the user clicks the Select button. Seems like it's something really simple I'm overlooking.

public class PlayerPicker extends javax.swing.JDialog {
	private JList ItemList;	
	private JTextField nameText;
	private JTextField positionText;
	private JTextField fanpointtotalText;
	private JButton jButton1;
	private JLabel jLabel4;
	private JScrollPane jScrollPane1;
	private JList jList1;
	private JLabel jLabel3;
	private JLabel jLabel2;
	private JLabel jLabel1;
	private Vector<Player> itemContainer = new Vector<Player>();
	private Vector<String> itemNameContainer = new Vector<String>();
	private ArrayList<Player> ap = new ArrayList<Player>();
	private String teamName;
	private JLabel jLabel5;
	private JLabel jLabel6;
	public int indx;

	/**
	* Auto-generated main method to display this JDialog
	*/
	public PlayerPicker(){
		super();
}
	public int startPlayerPicker(ArrayList<Player> players, String tn) {
		ap = players;
		Collections.sort(ap, new FanPointComparator());
		for (int i = 0; i < ap.size(); i++){
			itemContainer.add(ap.get(i));
			itemNameContainer.add(ap.get(i).getName());			
		}
		teamName = tn;
		int indx = initGUI();  //<--------------seems like this just sets indx to 0 and keeps going, not waiting for input
		System.out.println("return from initgui: "+indx);
        return indx;
	}
	
	private int initGUI() {
		try {
			{
				getContentPane().setLayout(null);
				this.setSize(603, 384);
				this.setLocationRelativeTo(null);//setLocation(600,100);
				this.setTitle("Player Chooser");
				setModal(true);
				{
					nameText = new JTextField();
					getContentPane().add(nameText);
					nameText.setBounds(385, 147, 196, 28);
				}
				{
					positionText = new JTextField();
					getContentPane().add(positionText);
					positionText.setBounds(385, 189, 42, 28);
				}
				{
					fanpointtotalText = new JTextField();
					getContentPane().add(fanpointtotalText);
					fanpointtotalText.setBounds(385, 231, 42, 28);
				}
				{
					jLabel1 = new JLabel();
					getContentPane().add(jLabel1);
					jLabel1.setText("Select the player taken by:");
					jLabel1.setBounds(308, 49, 217, 28);
					jLabel1.setHorizontalAlignment(SwingConstants.CENTER);
					jLabel1.setFont(new java.awt.Font("Tahoma",1,14));
				}
				{
					jLabel2 = new JLabel();
					getContentPane().add(jLabel2);
					jLabel2.setText("Position:");
					jLabel2.setBounds(315, 189, 63, 28);
					jLabel2.setHorizontalAlignment(SwingConstants.RIGHT);
					jLabel2.setFont(new java.awt.Font("Tahoma",1,11));
				}
				{
					jLabel3 = new JLabel();
					getContentPane().add(jLabel3);
					jLabel3.setText("Fantasy Point Total:");
					jLabel3.setBounds(252, 231, 126, 28);
					jLabel3.setHorizontalAlignment(SwingConstants.RIGHT);
					jLabel3.setFont(new java.awt.Font("Tahoma",1,11));
				}
				{
					jLabel4 = new JLabel();
					getContentPane().add(jLabel4);
					jLabel4.setText("Player Chooser");
					jLabel4.setBounds(91, 7, 413, 28);
					jLabel4.setFont(new java.awt.Font("Copperplate Gothic Bold",1,18));
					jLabel4.setHorizontalAlignment(SwingConstants.CENTER);
				}
				{
					jLabel5 = new JLabel();
					getContentPane().add(jLabel5);
					jLabel5.setText("Player:");
					jLabel5.setHorizontalAlignment(SwingConstants.RIGHT);
					jLabel5.setBounds(315, 147, 63, 28);
					jLabel5.setFont(new java.awt.Font("Tahoma",1,11));
				}
				{
					jLabel6 = new JLabel();
					getContentPane().add(jLabel6);
					jLabel6.setText(teamName);
					jLabel6.setBounds(259, 91, 322, 28);
					jLabel6.setHorizontalAlignment(SwingConstants.CENTER);
					jLabel6.setFont(new java.awt.Font("Tahoma",1,18));
				}
				{
					jScrollPane1 = new JScrollPane();
					getContentPane().add(jScrollPane1);
					jScrollPane1.setBounds(28, 49, 217, 280);
					{
						ListModel ItemListModel = new DefaultComboBoxModel(
							itemNameContainer);
						ItemList = new JList();
						jScrollPane1.setViewportView(ItemList);
						ItemList.setModel(ItemListModel);
						ItemList.setBounds(343, 49, 210, 280);
						ItemList.setBorder(new LineBorder(new java.awt.Color(
							0,
							0,
							0), 1, false));
						ItemList.addMouseListener(new MouseAdapter() {
							public void mouseClicked(MouseEvent evt) {
								int indx = ItemList.getSelectedIndex();
								Player cp = (Player) itemContainer.get(indx);
								nameText.setText(cp.getName());
								positionText.setText(cp.getPosition());
								fanpointtotalText.setText(String.valueOf(cp
									.getFanPointTotal()));
							}
						});
					}
				}
				{
					jButton1 = new JButton();
					getContentPane().add(jButton1);
					jButton1.setText("Select");
					jButton1.setBounds(336, 294, 168, 28);
					jButton1.setFont(new java.awt.Font("Tahoma",1,14));
					jButton1.addActionListener(new ActionListener() {
						public void actionPerformed(ActionEvent evt) {
//							System.out
//								.println("jButton1.actionPerformed, event="
//									+ evt);
							//TODO add your code for jButton1.actionPerformed
							indx = ItemList.getSelectedIndex();
							System.out.println(indx);
							dispose();
						}
					});
				}
			}
		} catch (Exception e) {
			e.printStackTrace();
		}
		return ItemList.getSelectedIndex();  //<--- I've tried indx here, that didn't work either.
	}
	
	public JList getJList1() {
		return jList1;
	}

}   

Also, it seems like the PlayerPicker method returns a value to the parent before the input is given. It pops the window up, but then it doesn't wait for the return from initGUI. I thought setting modal to true would fix that.

[Michael Dunn]

> Seems like it's something really simple I'm overlooking.

initGUI() returns immediately (there's no setVisible(..) in the code), so
int indx = initGUI();
is determined prior to any selection

[Jason Guyton]

OK, I stuck this.setVisible(true) in at the bottom, right above the return statement of initGUI. It returns the proper value now. But, when I click the select button, the window doesn't go away. If I hit it again, it disappears and does what I want. In fact, I can select a different player from the list before the second click on Select and it still returns the original value. Odd behavior for a button that has dispose() as it's only function.

[Michael Dunn]

sounds like in the code you're not showing you have another setVisible(true) (perhaps the original)
that simply re-shows the dialog after it is initially disposed (very quickly, and you wouldn't notice it)

[Jason Guyton]

Michael Dunn wrote:sounds like in the code you're not showing you have another setVisible(true) (perhaps the original)
that simply re-shows the dialog after it is initially disposed (very quickly, and you wouldn't notice it)

You are good. I had a setVisible in the parent class, not sure why I did that. All is good now. Thank you very much. Now my last hurdle is the JTable. But, I'm gonna try to code it up from scratch and see what happens.