Forum:

JDBC and Relational Databases

Null Pointer Exception

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hello friends ,
I am trying to develop a web app that will show flight timings of different airports...
but i am having the following error when running servlet...
the interface is basic from beer application in headfirst but i was trying a test run
type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

java.lang.NullPointerException
AirportDD.getFlights(AirportDD.java:34)
AirportSelect.doPost(AirportSelect.java:16)
javax.servlet.http.HttpServlet.service(HttpServlet.java:647)
javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

note The full stack trace of the root cause is available in the Apache Tomcat/5.5.28 logs.
here are the files
web.xml

Form.html

AirportSelect.java

AirportDD.java

import java.sql.*;
import java.util.*;
import java.io.*;
import javax.swing.*;
public class AirportDD
{

Statement stmt;
	ResultSet rset;
	PreparedStatement p;
	Connection con;
	List code,from,to,Dtime,ARtime,Airline,Ter;

public void getFlights(String airport)
		{
			String fcode,from_d,to_d,day,arline,ter;
			int artime,dtime;
			code= new ArrayList();
			from= new ArrayList();
			to= new ArrayList();
			Dtime= new ArrayList();
			ARtime= new ArrayList();
			Airline= new ArrayList();
			Ter= new ArrayList();
			String q1= "select * from FlightCD ,FlightDD where fromD = "+ "'" +airport +"' and FlightCD.FCode= FlightDD.FCode"
			              + " and day = initcap(To_Char(Sysdate,'DY'))";
			ResultSet rs1=View(q1);
			try
					{
						System.out.println("resulting flights are");
						while(rs1.next())
						{
							fcode=rs1.getString(1);
							from_d=rs1.getString(2);
							to_d=rs1.getString(3);
							dtime=rs1.getInt(5);
							day=rs1.getString(6);
							String q3= "select * from FlightD , DAirplane where FlightD.Airline=DAirplane.Airline and FCode="+ "'" + fcode + "'" + "and  DTime="+
								         "'" + dtime + "'"+ " order by DTime asc";
							ResultSet rs3= View(q3);

while(rs3.next())
								{
									artime=rs3.getInt(3);
									arline=rs3.getString(4);
									ter=rs3.getString(6);
									System.out.println("flights for today are " + fcode+" "+ from_d+" "+to_d+" "+ dtime+" "+ artime +" "+arline+ " "+ ter);
									code.add(fcode);from.add(from_d);to.add(to_d);Dtime.add(dtime);ARtime.add(artime);Airline.add(arline);Ter.add(ter);
								}

}
						}
			catch(SQLException e)
					{
						System.out.println("problem");
					}

}

public Connection conn() throws SQLException
		{

try
				{
					Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
				}
			catch(ClassNotFoundException e)
				{
					System.out.println("Database Driver not found");
					System.out.println(e.toString());
				}
			catch(Exception e)
				{
					System.out.println(e.toString());
				}
			return(DriverManager.getConnection("jdbc:odbc:link","system","oracle"));
			}
	public  ResultSet View(String qry)
	{
		try
		{
			 con=conn();
			qry=qry;
			stmt=con.createStatement();
			rset=stmt.executeQuery(qry);

}
		catch(Exception e)
		{
			System.out.println(e.toString());
		}

return rset;
	}
}

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

if someone can help me further in the application ..
it will be appreciated.

Ben Souther

Sheriff

Posts: 13411

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Null pointer exceptions occur when you try to call a method on an object when the object is null.

Your error message told you that this occurred on line 34.
Do you have a variable on line 34?
Are you trying to call a method of the object pointed to by that variable?

Java API J2EE API Servlet Spec JSP Spec How to ask a question... Simple Servlet Examples jsonf

Raza Mohd

Ranch Hand

Posts: 247

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

yeah it is the case the data you are trying to fetch from database might be null.you should check that what values it is getting by printing on console .

regards
Raza!

Good luck!!
A small leak can sink a Gigantic ship.>

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

i have used these class files from command prompt and they were returning values..
its only creating problems when i started using a servlet for retrieving values

Raza Mohd

Ranch Hand

Posts: 247

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

You dint mention the AirportSelect.java file.

Good luck!!
A small leak can sink a Gigantic ship.>

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

now i have added it...

Stephen McConnell

Greenhorn

Posts: 19

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

The initial exception occurs on Line 34 of your AirPortDD.java file.... that is in the general areas of the attempt to access the result set....

Did you get the output from line 96 here in AirPortDD.java? which is the error from an exception trying to retrieve the result set in the first place....

There is so much wrong with this code from a design point of view... no closing of connections, no closing of statements.... Bad handling of exceptions....

Stephen McConnell

Stephen McConnell

"Boredom is a personal defect"
-- Lamar Stephens

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

i called the function from another class and it is returning values..
check.java

results are fine...

sudheer kiran

Ranch Hand

Posts: 237

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

some where object is not initialized.
best way is to run un debug mode or print incremental integers in the doubted line..by that you will get to know where exactly your code got struck.

Sudheer
SCWCD, SCJP 5

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

the problem is that nothing is being added to the ArrayList..
is there any problem with the logic??
the servlet creates an object of class AirportDD , having a varaible of type List code.
the function is called and the function instantiates code as an arraylist and adds some string to it...
will the servlet have the same list as the attribute of the object it created ???
can any one help....

assume missing things....

Bear Bibeault

Sheriff

Posts: 67753

173

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Please properly indent your code.

[Asking smart questions] [About Bear] [Books by Bear]

HTML 5 (verified skill)
Skill verified by Jeanne Boyarsky

CSS 3 (verified skill)
Skill verified by Jeanne Boyarsky

JavaScript (verified skill)
Skill verified by Jeanne Boyarsky

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

problem is that resultset is returning nothing when run from a servlet but it
returns the desired values when the same function is run from different class' main

Ben Souther

Sheriff

Posts: 13411

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Look at my first reply to this question.

If the NPE is being thrown on a line that contains only a rs.next() statement, then the problem isn't that the resultSet is returning nothing.
It's that the resultSet variable "rs" is null.

This means that your problem is happening before you get to that line.

You've got print statements in all of your catch blocks.
I suggest you clear all of your logs, run it again until it breaks and go through them to see what else is being thrown before you try to call rs.next().
If I had to take a wild guess it would be that the app can't find your JDBC driver.
You might want to do something more in your catch block than just log errors.
If you can't make the database call, your app should be dying before you try to read from the resultSet.

Java API J2EE API Servlet Spec JSP Spec How to ask a question... Simple Servlet Examples jsonf

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

how can i make sure that the application can find the JDBC drivers??
please help i am new to all this and this is my first application..

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

i tried the following program to check the problem
and the exceptions were can anyone explain how to correct this??

import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.sql.*;
public class HelloWorldServlet extends HttpServlet {

public void doGet (HttpServletRequest req, HttpServletResponse res)
	    throws ServletException, IOException {
	    res.setContentType("text/html");

ServletOutputStream out = res.getOutputStream();
	    out.println("<html>");
	    out.println("<head><title>Hello World</title></head>");
	    out.println("<body>");

try {
		
	        out.println("Good till now");
		Class.forName("sun.jdbc.odbc.JdbcOdbcDriver").newInstance();
	    }
	    catch (Exception E) {
		out.println("Unable to load driver.problem is here");
		E.printStackTrace();
	    }

out.println("<br><hr>");

try {
		Connection Conn =
		    DriverManager.getConnection("jdbc:odbc:link","system","oracle");

Statement Stmt = Conn.createStatement();
		ResultSet RS = Stmt.executeQuery("SELECT * from ankur");

while (RS.next()) {
		    out.println(RS.getString(1));
		}
		RS.close();
		Stmt.close();
		Conn.close();

}
	    catch (SQLException E) {
		out.println("SQLException is this: " + E.getMessage());
		out.println("    SQLState :     " + E.getSQLState());
		out.println("     VendorError:  " + E.getErrorCode());
	    }

out.println("<h1>Hello World. Sun... 1.4</h1>");
	    out.println("</body></html>");
	}

public String getServletInfo() {
	  return "Create a page that says <i>Hello World</i> and send it back";
	}
    }

result is
Good till now
SQLException is this: [Microsoft][ODBC Driver Manager] Data source name not found and no default driver specified SQLState : IM002 VendorError: 0
Hello World. Sun... 1.4

Ben Souther

Sheriff

Posts: 13411

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Where did you put your JDBC driver jar file?

Java API J2EE API Servlet Spec JSP Spec How to ask a question... Simple Servlet Examples jsonf

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

the initial problem was removed by making a system DSN.
the servlet is getting values ..and page is generated.
but there is a new sort of problem now..
when i start the database and the tomcat and load the page , the values are shown just fine but if i refresh the page 4-5 times
the servlet starts giving the same exception all over again..
i suspect its because not clossing connections as mentioned by Ben

can someone suggest me how to close connection in respect to the code AirportDD.java
as i am using different functions...

Ben Souther

Sheriff

Posts: 13411

I like...

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

as i am using different functions...

Do you have a good reason for using different methods?

Typically a database call is laid out like this:

The finally block will always get executed, even if something blows up in the try or catch blocks.
This guarantees that your connections will always get closed.

If you're not closing them, your app will work for a while.
Then, when you've hit the maximum number of open connections, it will fail.

Java API J2EE API Servlet Spec JSP Spec How to ask a question... Simple Servlet Examples jsonf

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

i am using functions because i am using nested queries, so i would need to paste the code twice ..
even then i tried doing it with this code..

import java.sql.*;
import java.util.*;
import java.io.*;
import javax.swing.*;
public class AirportDD
{

Statement stmt=null,stmt2=null;
	ResultSet rs1=null,rs3=null ;
	PreparedStatement p;
	Connection con1,con2;
	List code,from,to,Dtime,ARtime,Airline,Ter;

public void getFlights(String airport)
		{
			String fcode,from_d,to_d,day,arline,ter;
			int artime,dtime;
			code= new ArrayList();
			from= new ArrayList();
			to= new ArrayList();
			Dtime= new ArrayList();
			ARtime= new ArrayList();
			Airline= new ArrayList();
			Ter= new ArrayList();
			String q1= "select * from FlightCD ,FlightDD where fromD = "+ "'" +airport +"' and FlightCD.FCode= FlightDD.FCode"
			              + " and day = initcap(To_Char(Sysdate,'DY'))";
			try
				{
					try
						{
							Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
						}
					catch(ClassNotFoundException e)
						{
							System.out.println("Database Driver not found");
							System.out.println(e.toString());
						}
					catch(Exception e)
						{
							System.out.println(e.toString());
						}
					Connection con1=DriverManager.getConnection("jdbc:odbc:link","system","oracle");
					Statement stmt=con1.createStatement();
					ResultSet rs1=stmt.executeQuery(q1);

System.out.println("resulting flights are");

while(rs1.next())
						{
							fcode=rs1.getString(1);
							from_d=rs1.getString(2);
							to_d=rs1.getString(3);
							dtime=rs1.getInt(5);
							day=rs1.getString(6);
							String q3= "select * from FlightD , DAirplane where FlightD.Airline=DAirplane.Airline and FCode="+ "'" + fcode + "'" + "and  DTime="+
								         "'" + dtime + "'"+ " order by DTime asc";
							try
								{
									Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
								}
							catch(ClassNotFoundException e)
								{
									System.out.println("Database Driver not found");
									System.out.println(e.toString());
								}
							catch(Exception e)
								{
									System.out.println(e.toString());
								}
							Connection con2=DriverManager.getConnection("jdbc:odbc:link","system","oracle");

Statement stmt2=con2.createStatement();
							ResultSet rs3=stmt.executeQuery(q3);

while(rs3.next())
								{

artime=rs3.getInt(3);
									arline=rs3.getString(4);
									ter=rs3.getString(6);
									System.out.println("flights for today are " + fcode+" "+ from_d+" "+to_d+" "+ dtime+" "+ artime +" "+arline+ " "+ ter);
									code.add(fcode);from.add(from_d);to.add(to_d);Dtime.add(dtime);ARtime.add(artime);Airline.add(arline);Ter.add(ter);
								}

}

}
			catch(SQLException e)
					{
						code.add("pr");from.add("blm");to.add("null");Dtime.add(0000);ARtime.add(0000);Airline.add("h");Ter.add("00");
						System.out.println("problem");
					}
			finally
				{
					try
						{
							if(rs1 !=null)
							rs1.close();
							if(stmt !=null)
							stmt.close();
							if(con1 !=null)
							con1.close();
							if(rs3 !=null)
							rs3.close();
							if(stmt2 !=null)
							stmt2.close();
							if(con2 !=null)
							con2.close();
						}
					catch(SQLException e)
					{
					}
				}
			}

public Connection conn() throws SQLException
		{

but the result was that i only get the first column from the table
and nothing else and this time i was able to refresh it as many times i want...

Lawrence Xu

Greenhorn

Posts: 11

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

can you execute sql to see the record num in fact.

ankur tyagi

Ranch Hand

Posts: 49

posted 14 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

do you mean running directly sql command in oracle...??
yes they run just fine...
they are running with servlet as well but due to not closing of connections, it gives NPE