Looping through Checkboxes

[michell rosvlet]

I have to loop through checkbox and the once which are checked I will be extracting there values. Code what I have written is giving me multiple values for eg

Apple

Apple
Mango

Apple
Mango
Banana

but I want it to display in the form

Apple
Mango
Banana

 function B1_Email_Template_OnClick()
{
  var SelectedValue = " "
  var count = 0
    for(count = 0; count < 3; count++){ 
      alert ('Value of Count ' + count)
      for(var j = 1; j <= count; j = j + 1){    
        alert ('Value of J ' + j)
          if(eval("serviceForm.B1_Info_Security_Email_Cond_Generic.Chk" + j + ".getValue()") != undefined){
            if(eval("serviceForm.B1_Info_Security_Email_Cond_Generic.Chk" + j + ".getValue()") == "Include"){ 
               SelectedValue = SelectedValue + eval("serviceForm.B1_Info_Security_Email_Cond_Generic.Cond" + j + ".getValue()")
              }
            
          }
          SelectedValue = SelectedValue + '\n'
      }
    }
    alert(SelectedValue)
  }   

Can someone tell me where I am going wrong.

[Bear Bibeault]

Why on earth are you using eval()?

Also, without seeing the checkbox markup, it's hard to comment.

[michell rosvlet]

Is something wrong with EVAL

[Bear Bibeault]

If you aren't going to answer the questions, it's unlikely you'll get much help here.

[michell rosvlet]

Voowww
I seriously don't understand what the problem with Eval is. Since I am trying to bring new value for J every time i want to evaluate that. If I don't put that it will not display me the value of check boxes I am trying to retrive
I am sure by removing that my code will not start working the way I want it.

[Bear Bibeault]

OK, since you'd rather not answer the questions that I need to know in order to make suggestions to help you, I cannot help you at this point.

eval() is like using a sledgehammer to crack walnuts. It's inefficient, unnecessary and just makes the code harder to read.

[David Newton]

michell rosvlet wrote:Voowww
I seriously don't understand what the problem with Eval is. Since I am trying to bring new value for J every time i want to evaluate that. If I don't put that it will not display me the value of check boxes I am trying to retrive
I am sure by removing that my code will not start working the way I want it.

Have you considered using a JavaScript library (like jQuery, Prototype, basically anything)?

In any case--the point is that eval is almost certainly not the solution you want, but without further information, it's tough to provide any alternatives.

Also, it's a dangerous habit to rely on JavaScript's semicolon insertion mechanism--I'd counsel against it.

[michell rosvlet]

I have not tried any of those you mentioned. I did remove EVAL after you and Bear Bibeault mentioned.
I know I am doing some mistake in looping. But not sure where I am going wrong.

[michell rosvlet]

If I don't use EVAL I am not able to read any values from Check box. It gives me a blank screen

[Bear Bibeault]

How can we help without seeing code?

[michell rosvlet]

I did post the code

[Bear Bibeault]

How is the old code going to help debug your new code?

Some friendly advice: making people jump through hoops to try and help you isn't exactly a winning strategy. I'd rethink your approach.

[michell rosvlet]

Sorry to trouble you guys so much I was able to debug it.
Not sure what I was thinking when I added an extra For loop for count.
Sorry Guys. I am really Sorry. It is working now the way I wanted.

[David Newton]

Good deal--glad you figured it out!