Returning array To Method

[Nick Rowe]

Hi guys im new to Java and have been building up some code over the past week. This is actually the first program i've ever written. Looking online at some examples im having a tough time with what i believe should be something simple.

Basically i need to create a method to return an array called "arrayList" and sort it. Then i need to print that array. I believe Im almost there but am a bit unsure.

//import java librarys
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.util.ArrayList;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
//class to find string
public class Find {

    BufferedReader br = null;
    
//method to read html file line by line and return string to tore in array
    public Find() throws java.io.IOException {
        try {
//read in file		
            br = new BufferedReader(new FileReader("C:/Documents and Settings/Kieren McDonald/Desktop/Nick/Java/my.html"));
//declaring string identifiers 
			String line = null;
			String beg ="<@dynamichtml ";
			String end ="@>";
			ArrayList<String> arrayList = new ArrayList<String>(); 
//while line is not equal to null find 3 string values           
		   while ((line = br.readLine()) != null) {
                line = find(beg,end,line);
//if line is not equal to null store line in array list
				if (line != null)
				arrayList.add(line);
            }
        } catch (FileNotFoundException ex) {
            ex.printStackTrace();
        } finally {
            br.close();
        }
    }
//method to find the value between the beginning and end of a string
    public static String find(String beg, String end, String line) {
//match pattern to store string between strings
        Pattern p = Pattern.compile(beg + "(.*)" + end);
        Matcher m = p.matcher(line);

        return m.find() ? line.substring(m.start(1), m.end(1)) : null;

    }
//-----------------------------------------------
//returns contents of an array	
  public Object [] arrayList(){
	    return arrayList();
	    Collections.sort(arrayList);
	    System.out.println("Resource Name: " + arrayList); 
	}
//--------------------------------------------	
//main method to find the resource name
    public static void main(String[] args) throws IOException {
        Find findResources = new Find();
    }
}

[Nicola Garofalo]

Hi Nick,
forget your method arrayList(), it's completely wrong, delete it.

For example you could write a method that receives a List as a parameter, performs the sort and prints it out.

public static void printOrderedList(List<String> l){
 Collections.sort(l); //list sorted
 System.out.println(l) //list printed
}

[Campbell Ritchie]

Can you write Object[line] as a return type? Surely it would be Object[].

I am not convinced about the printOrderedList method either; that does two things, viz printing the List, and sorting it; the latter is a side-effect which may cause problems when the List is used later, because its contents are in different locations.
As I said yesterday, make each method do one thing and do it well.

[Campbell Ritchie]

And in that method, you cannot have code after the return statement.

[Nick Rowe]

lol i did write Object[] i corrected myself straight away. obviously you cant have an array size set when you dont know how big it is thanks tho

[Nick Rowe]

Nicola Garofalo wrote:Hi Nick,
forget your method arrayList(), it's completely wrong, delete it.

For example you could write a method that receives a List as a parameter, performs the sort and prints it out.

public static void printOrderedList(List<String> l){
 Collections.sort(l); //list sorted
 System.out.println(l) //list printed
}

If i use this method however shouldn't i be returning the array as an object rather than an ordered list of strings? I mean i'd like it to appear in that manner but doesn't java have a rule about returning an array as an object in general?

[Nicola Garofalo]

You have a list that can be sorted. Do it in one or two methods, as you prefer, but why should you convert it to an array?

[Nick Rowe]

Nicola Garofalo wrote:You have a list that can be sorted. Do it in one or two methods, as you prefer, but why should you convert it to an array?

Ohh i was thinking of it as an array storing a list and not a list. In my head i was thinking
return the array to the method
sort the array
print the array

[Nicola Garofalo]

Nick,
if you want to convert a list to an array of Objects, do it as an exercise , it's ok, but with your list in your hand you can do whatever you want to do for your purpouses, without converting anything:
sort it and print it out.

If you need two methods, one for sorting and one for printing you could write those ones, take them as an example:

1) write a method that takes a List as an argument and returns the same list sorted

List<String> sortList(List<String> unsortedList){
//sort it and return it
}

2) write a method that prints out a list of Strings given as an argument

void printList(List<String> list){
//print it
}

[Nick Rowe]

Ok, i've imported the extra libararys and compiled the program with no errors. Lovely

However I need to call my method so that It only prints after its read the entire document line by line. else, loop back to my find method.

regards Nick

[David Newton]

* Please try to normalize your indentation and make sure any comments actually communicate something useful: the "why", not the "what". For example, I already know that the "import" statement imports Java libraries.

* Comments for classes and methods, when necessary at all, should follow standard Javadoc conventions rather than using the double-slash notation.

* Please PostRealCode -- as written this code won't compile. This adds a layer of aggravation for folks who prefer to look at Java code in an IDE (so we can format it rationally :)

* Remove the infinite loop.

* All of your functionality is in the constructor--this won't "return" anything, as its comment claims. A constructor will just return a new Find--consider putting the code that actually *does* something into an instance method, then calling that method. Perhaps with a file name as an argument (it could also be a constructor argument; whichever).

Particularly when requesting help from others, it's nice to make things as easy for us as possible.

[Nick Rowe]

David Newton wrote:* Please try to normalize your indentation and make sure any comments actually communicate something useful: the "why", not the "what". For example, I already know that the "import" statement imports Java libraries.

* Comments for classes and methods, when necessary at all, should follow standard Javadoc conventions rather than using the double-slash notation.

* Please PostRealCode -- as written this code won't compile. This adds a layer of aggravation for folks who prefer to look at Java code in an IDE (so we can format it rationally :)

* Remove the infinite loop.

* All of your functionality is in the constructor--this won't "return" anything, as its comment claims. A constructor will just return a new Find--consider putting the code that actually *does* something into an instance method, then calling that method. Perhaps with a file name as an argument (it could also be a constructor argument; whichever).

Particularly when requesting help from others, it's nice to make things as easy for us as possible.

Apologies, i try to keep my comments to one line and simplistic in my posts to save space and people the trouble of reading.

Im new to java but basically explaining in a bit more detail. I have a html file which lists several resource names the names however are listed for example as <@dyanmichtml resource_name@>, the only part of that instance i want is resource_name.

So to capture these data instances (which are always on one line) with html code below. I have a program which will read in the file line by line. I then list the identifiers in order to capture the data at the beginning, middle and end of the line.

In my program I am assigning the data stored in the middle of the program to aa string called "line". the loop reads the document until an instance of line is found and then adds it (if true) to an array list.
then we have a method to return the array list, sort it and print it.

However there is still no output for this program although I am having no compilation errors. So am i right in thinking
Would i not have to now call my newly created print method in the main method with an if statement saying If the buffer has finised reading the document then call printOrderedList(); else loop back to Find();

Or would i add that in the main and add an else to the If loop within the while saying if line = null || document is read (im not sure how to say this in java) then call printOrderedList();

regards Nick

[Nicola Garofalo]

Sorry Nick, you solved the first part of your problem. You now have the ArrayList, the code compiles and we saw it yesterday that it works.
Now you just have to sort this ArrayList and print it out.

Don't think about the file operations. They are over, your parsed lines are in an ArrayList, the reader has finished its operations and it is closed now.

Just add 2 rows to your code and your work is over.

Collections.sort(arrayList);
System.out.println(arrayList);

No more things to do. Be sure that data are printed out in the desired order. Then we will talk about splitting code into different methods.

[Nick Rowe]

Just add 2 rows to your code and your work is over.

Collections.sort(arrayList);
System.out.println(arrayList);

.

Im a little confused now, where am i executing the above mentioned code?
Because we have the printOrderedList method which is returning the list as an integer. I then thought it was sorting and printing out the list.

So why am I adding the above code referencing the arrayList object?
This may be a silly question but i just want to understand things as best I can.

regards & thanks

Nick

[David Newton]

Nick Rowe wrote:Apologies, i try to keep my comments to one line and simplistic in my posts to save space and people the trouble of reading.

What I'm saying is that the comments in the code weren't useful, and because of their strange indentation were even more distracting than usual.

It wasn't a request for more explanation--we all know what you're trying to do. It was a request to keep things as clean and readable as possible, along with the other comments.

[Nicola Garofalo]

Nothing is silly,
you are going away form the solution, that is in front of you.

printOrderedList method which is returning the list as an integer

Where in this discussion someone said that?

Anyway:

after the line

Collections.sort(arrayList);

your arraylist will be sorted.

After

System.out.println(arrayList);

Your arrayList will be printed on the output.

Why don't you try to do it?

Add the above 2 lines after the while loop, like the following:

while ((line = br.readLine()) != null) {   
   line = find(beg,end,line);   
   arrayList.add(line);   
 }
Collections.sort(arrayList);
System.out.println(arrayList); 

[Campbell Ritchie]

Another way to put what David Newton said: Get all your code into a format and quality which you would hand in for your assignment, or show to your boss as production code, then it will be easier for us to read and test. Comments about methods should be proper documentation comments /** . . . */, for example.
And "quality" includes correct indentation.

[Nick Rowe]

apologies i put integer instead of parameter, Nope still no output. Though from looking at the example you gave wont that if it did work, print out every time an instance of line is found?

I need the array to build up instance by instance of line (IF) there is an instance of a resource to be captured on a line then capture it, however this is not always the case, so there isnt an instance on each line of the document.
I only want to sort and print the array once the resource names have all been collected from the document. until then i just want to keep it looping until the document is read.

regards Nick

[Nicola Garofalo]

In the example i asked you to test, you print the arrayList, the entire one, outside the loop, after it, once the html file is completely parsed line by line.
The method find filters all the lines. If there's no line that matches your pattern your ArrayList may be empty, thus your output could be empty.

[Nick Rowe]

Nicola Garofalo wrote:In the example i asked you to test, you print the arrayList, the entire one, outside the loop, after it, once the html file is completely parsed line by line.
The method find filters all the lines. If there's no line that matches your pattern your ArrayList may be empty, thus your output could be empty.

There are 3 instances of resources within the document itself in this case and the pattern matches any data caught between <@dynamichtml and @> This is always the case the data does not change, the instance will always be between these two string values. As such there should be three results.

regards Nick

public Find() throws java.io.IOException {
			try {
/**read in file*/		
				br = new BufferedReader(new FileReader("C:/Documents and Settings/Kieren McDonald/Desktop/Nick/Java/my.html"));
/**declaring string identifiers for beginning and end of string aswel as one other line string to store the data between*/
					String line = null;
					String beg ="<@dynamichtml ";
					String end ="@>";
					ArrayList<String> arrayList = new ArrayList<String>(); 
/**while line is not equal to null then find 3 string values*/           
		   while ((line = br.readLine()) != null) {
					line = find(beg,end,line);
						
/**if line is not equal to null store line in array list adding a resource name*/
					if (line != null){
						arrayList.add(line);}	
            }
/**sort and print array before calling printOrderedList method*/
						Collections.sort(arrayList);   
						System.out.println(arrayList);
						printOrderedList(arrayList);	
						}
						
		catch (FileNotFoundException ex) {
            ex.printStackTrace();
			} 
		finally {
            br.close();
			}

[Nicola Garofalo]

delete line 22, it's useless since you sorted and printed the arrayList just two rows before.

The rest is ok, no reasons not to work if the html file is well formed.
May i see the html lines that contains the pattern searched?

[Campbell Ritchie]

That seems to be improving, but

You ought not put executing code in a constructor, only code to set up the object's initial state and invariants.

You have no access to the List<String> from anywhere else.

[Nick Rowe]

Since i am not calling the printOrderedList I should safely be able to remove it?

Below is a copy of an instance from the html file as requested

<!-- 17/5/2007 ------- -->
<!-- TIMELINEMANAGER TOP LINKS ------------------------ -->
<@dynamichtml TimelineManager_top_links@>
	<$nodeLabel=ssGetNodeProperty("Label")$>
	<$if strEquals(nodeLabel, "Home")$>
		<small><a title="Advanced Search" accesskey="1" href="AdvancedSearch/index.htm">Advanced Search</a> | <a title="Help" accesskey="2" href="Help/index.htm">Help</a></small>
	<$else$>
		<small><a title="Advanced Search" accesskey="1" href="../AdvancedSearch/index.htm">Advanced Search</a> | <a title="Help" accesskey="2" href="../Help/index.htm">Help</a></small>
	<$endif$>
<@end@>

[Nicola Garofalo]

Yes, remove it. I guarantee, nothing bad is going to happen

I get the following output if i save your code in a file called my.html placed in a folder of my filesystem, and if i execute your application.

[TimelineManager_top_links]

The output,as expected, is made of one element, because one is the line that matches your pattern.

[Nick Rowe]

Nicola Garofalo wrote:Yes, remove it. I guarantee, nothing bad is going to happen

I get the following output if i save your code in a file called my.html placed in a folder of my filesystem, and if i execute your application.

[TimelineManager_top_links]

The output,as expected, is made of one element, because one is the line that matches your pattern.

Hi Nicola,

Yeh i figured since it wasn't being executed it would be safe to remove, thankyou
I'm confused though my html file is stored in the aformentioned route and when i use Dos and do a javac Find.java nothing happens it just compiles and has no errors. Am i missing/doing something wrong?

P.s. thankyou sososososososososososoosososososoooooooooooo much for your help, you've been an absolute angel and really really helped me out on a mahusive scale with this xxxxxxxxxx

[Nicola Garofalo]

Oh, really no problem Nick.

Well, once the file is compiled you should execute the program. You are missing the funny part

Now find in your file system the file Find.class generated by the execution of your javac command
As you wrote the class it should be in the same folder of your Find.java file

then execute the command

java Find

see what happens and let me know

[Nick Rowe]

Nicola Garofalo wrote:Oh, really no problem Nick.

Well, once the file is compiled you should execute the program. You are missing the funny part

Now find in your file system the file Find.class generated by the execution of your javac command
As you wrote the class it should be in the same folder of your Find.java file

then execute the command

java Find

see what happens and let me know

Ok So i've checked and Find.class is in the same folder as generated by the compiler.
I then drilled down to the directory via Dos and exected the compiler as normal via the javac Find.java comm and then attempted to execute the Find.java and get exception to thread "main " java.lang.NoClassDefFoundError: Find

caused by a series of at java.net.URLClassLoader$1.run<Unknown Source> plus various others.

regards Nick

[Nicola Garofalo]

Not

java Find.java

But

java Find

Exactly as i have written it

[Nick Rowe]

Nicola Garofalo wrote:Not

java Find.java

But

java Find

Exactly as i have written it

Apologies, the previous message had a typo lol java Find is what i entered
regards Nick

[Nick Rowe]

java Find is the command I used to execute the program after the normal javac command. Once i executed the java Find command the previously mentioned errors popped up.



I'll post my code up again.

/**import java librarys*/
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.util.ArrayList;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.Collections;
import java.util.List;

/**class to find string*/
	public class Find {

		BufferedReader br = null;
    
/**method to read html file line by line and return string to tore in array*/
			public Find() throws java.io.IOException {
			try {
/**read in file*/		
				br = new BufferedReader(new FileReader("C:/Documents and Settings/Kieren McDonald/Desktop/Nick/Java/Test/my.html"));
/**declaring string identifiers for beginning and end of string aswel as one other line string to store the data between*/
					String line = null;
					String beg ="<@dynamichtml ";
					String end ="@>";
					ArrayList<String> arrayList = new ArrayList<String>(); 
/**while line is not equal to null then find 3 string values*/           
		   while ((line = br.readLine()) != null) {
					line = find(beg,end,line);
						
/**if line is not equal to null store line in array list adding a resource name*/
					if (line != null){
						arrayList.add(line);}	
            }
/**sort and print array before calling printOrderedList method*/
						Collections.sort(arrayList);   
						System.out.println(arrayList);
							
						}
						
		catch (FileNotFoundException ex) {
            ex.printStackTrace();
			} 
		finally {
            br.close();
			}
    }

/**method to find the value between the beginning and end of a string*/
    public static String find(String beg, String end, String line) {
/**match pattern to store string between strings and match to line*/
        Pattern p = Pattern.compile(beg + "(.*)" + end);
        Matcher m = p.matcher(line);

        return m.find() ? line.substring(m.start(1), m.end(1)) : null;	
		}

/**main method to find the resource name calling */
		public static void main(String[] args) throws IOException {
			Find findResources = new Find();
			}
}

[Nicola Garofalo]

Go to the the directory where your Find.class file is.

Then type

java -cp . Find

[Nick Rowe]

Nicola Garofalo wrote:Go to the the directory where your Find.class file is.

Then type

java -cp . Find

Is the above command correct? if i type java -cp.Find? When i enter this I get unrecognised option.
However if I type java-cp.Find i get an error list as previously saying

could not find the main class cp.Find program will exit?
regards Nick

[Nicola Garofalo]

java -cp . Find

type java then space the -cp then space the . then space then Find

[Nick Rowe]

Nicola Garofalo wrote:

java -cp . Find

type java then space the -cp then space the . then space then Find

YEAAAAAAH! that worked, thank you

Sorry to be inquisitive but I am curios as to why this is, for example;
Does my program always have to be executed this way?
Why doen't it execute with the java Find command???
Is their anything I need to do because of this issue?
Also what does the command "java -cp . Find" do, i get that javac is the compiler and java Find executes the program so what does java -cp . do, search for something and why do we have to search for it?

regards Nick

[Nicola Garofalo]

It's a classpath issue.
Java has to know where to find resources

if i type

java -cp . Find

i tell java that the classpath is the current directory (.)

To avoid to specify it every time you invke the command you can set the environment variable CLASSPATH in your system, for example

Look at this link for detailed information

[Nick Rowe]

Haha that was such and awesome little icon

Thanks, i've successlly changed the class path via the control panel and Dos seems happy now.
However, lol. The html file I read was a cut down version, which had only 3 resources in, this worked fine.
When using the full html file however Its printed out the resources but not in alphabetical order like before. Is there any reason for this, ill attach the html file

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>
TimelineManager htmlIncludeOrString
</title>
</head>
<body>





<!-- TIMELINEMANAGER TOP LINKS ------------------------ -->
<@dynamichtml TimelineManager_top_links@>
	<$nodeLabel=ssGetNodeProperty("Label")$>
	<$if strEquals(nodeLabel, "Home")$>
		<small><a title="Advanced Search" accesskey="1" href="AdvancedSearch/index.htm">Advanced Search</a> | <a title="Help" accesskey="2" href="Help/index.htm">Help</a></small>
	<$else$>
		<small><a title="Advanced Search" accesskey="1" href="../AdvancedSearch/index.htm">Advanced Search</a> | <a title="Help" accesskey="2" href="../Help/index.htm">Help</a></small>
	<$endif$>
<@end@>






<!-- TIMELINEMANAGER FOOTER ---------------------------- -->
<@dynamichtml TimelineManager_footer@>
  <table cellspacing="0" cellpadding="0" width="100%" border="0">
    <tbody>
      <tr class="lgrey">
        <td rowspan="2"> Gibbs Building, 215 Euston Road, London NW1 2BE, UK   tel:[phone]   email:<a accesskey="i" href="mailto:[e-mail]">[e-mail]</a></td>
      </tr>

      <tr class="lgrey">
        <td><img height="6" alt="" src="/assets/px.gif" width="1" border="0" /></td>
      </tr>
    </tbody>
  </table>	
<@end@>





<!-- TIMELINEMANAGER QuickSearch Form ------------------- -->
<@dynamichtml TimelineManager_quicksearch_form@>
	<div>
	<form name="QUICK_SEARCHFORM" method="GET" action="<$ssNodeLink(80013)$>" style="PADDING-RIGHT: 0px; DISPLAY: inline; PADDING-LEFT: 0px; PADDING-BOTTOM: 0px; MARGIN: 0px; PADDING-TOP: 0px">
	  <input type=hidden name="QueryText" value="">
	  <input type=hidden name="ResultCount" value="<$AdvancedSearch_ResultCount$>">
	  <input class="searchField" accesskey="f" size="16" name="searchStr">  
	  <input class="searchButton" accesskey="g" type="button" value="Search" onclick="QuickSearch_BuildQueryTextAndSubmit()">
	</form>
	</div>
<@end@>






<!-- TIMELINEMANAGER Advanced Search Javascript functions ----- -->
<@dynamichtml TimelineManager_advancedsearch_javascript_functions@>
		
		function AdvancedSearch_BuildQueryTextAndSubmit()
		{
			var ItemTitle = ADVANCED_SEARCHFORM.ItemTitle.value;
			var ItemType = ADVANCED_SEARCHFORM.ItemType.value;
			var ReleaseDate_From = ADVANCED_SEARCHFORM.ReleaseDate_From.value;
			var ReleaseDate_To = ADVANCED_SEARCHFORM.ReleaseDate_To.value;
			var GrantID = ADVANCED_SEARCHFORM.txtGrantID.value;
			var SPOContact = ADVANCED_SEARCHFORM.txtSPOContact.value;
			var GrantType = ADVANCED_SEARCHFORM.txtGrantType.value;
			var FullTextSearch = ADVANCED_SEARCHFORM.FullTextSearch.value;
			
			Query = "dDocTitle <substring> " + "'" + ItemTitle + "'";
			if (ItemType!="")
			{
				Query = Query + " <AND> dDocType <matches> " + "'" + ItemType + "'";
			}
			
			if (ReleaseDate_From!="")
			{
				Query = Query + " <AND> dInDate >= `" + ReleaseDate_From + "`";
			}
			if (ReleaseDate_To!="")
			{
				Query = Query + " <AND> dInDate <= `" + ReleaseDate_To + "`";
			}
			if (GrantID!="")
			{
				Query = Query + " <AND> xGrant_ID <substring> '" + GrantID + "'";
			}
			if (SPOContact!="")
			{
				Query = Query + " <AND> xSPO_Contact <substring> '" + SPOContact + "'";
			}
			if (GrantType!="")
			{
				Query = Query + " <AND> xGrant_Type <substring> '" + GrantType + "'";
			}
			
			Query = Query + " <AND> dSecurityGroup <matches> 'Timeline'";
			Query = Query + " <AND> <NOT> dDocType <matches> 'SiteStudioObject'";
			Query = Query + " <AND> <NOT> dDocType <matches> 'STELLENTPROJECT'";
			Query = Query + " <AND> <NOT> dDocType <matches> 'Image'";
			
			if (FullTextSearch!="")
			{
				Query = Query + " <AND> <ftx>" + FullTextSearch + "</ftx>";
				ADVANCED_SEARCHFORM.ftx.value = 1;
			}

			ADVANCED_SEARCHFORM.QueryText.value = Query;
			ADVANCED_SEARCHFORM.submit();
		}
		
<@end@>






<!-- TIMELINEMANAGER QuickSearch Javascript functions ----- -->
<@dynamichtml TimelineManager_quicksearch_javascript_functions@>
		
		function QuickSearch_BuildQueryTextAndSubmit()
		{
			var SearchString = QUICK_SEARCHFORM.searchStr.value;
			var ItemType = "";
			Query = "(dDocTitle <substring> " + "`" + SearchString + "`";
	
			if (SearchString=="Research Story"){ItemType="Research_Story"}
			else if (SearchString=="Research History"){ItemType="Research_History"}
			else if (SearchString=="Research Highlight"){ItemType="Research_Highlight"}
			
			if (ItemType!=""){Query = Query + " <OR> dDocType <matches> " + "`" + ItemType + "`)";}
			else {Query = Query + " <OR> dDocType <matches> " + "`" + SearchString + "`)";}

			Query = Query + " <AND> dSecurityGroup <matches> `Timeline`";
			Query = Query + " <AND> <NOT> dDocType <matches> `SiteStudioObject`";
			Query = Query + " <AND> <NOT> dDocType <matches> `STELLENTPROJECT`";		
			Query = Query + " <AND> <NOT> dDocType <matches> `Image`";
			
			QUICK_SEARCHFORM.QueryText.value = Query;
			QUICK_SEARCHFORM.submit();
		}

<@end@>






<!-- TIMELINEMANAGER Advanced Search form ------------- -->
<@dynamichtml TimelineManager_advanced_search_form@>

	<p>
	<form name="ADVANCED_SEARCHFORM" method="GET" action="<$ssNodeLink(80013)$>">
		<input type=hidden name="QueryText" value="">
		<input type=hidden name="ResultCount" value="<$AdvancedSearch_ResultCount$>">
		<input type=hidden name="ftx" value="">

		<table border=0>
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>Title:</span></td>
				<td>
					<input type="text" size=43 name="ItemTitle" value="">
				</td>
			</tr>
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>Type:</span></td>
				<td>
					<select class="selectbox_width" name="ItemType">
						<option value=""></option>
						<option value="Decade_Summary">Decade Summary</option>
						<option value="Event">Event</option>
						<option value="Filter">Filter</option>
						<option value="Glossary">Glossary</option>
						<option value="Indicator">Indicator</option>
						<option value="Research_Highlight">Research Highlight</option>
						<option value="Research_History">Research History</option>
						<option value="Research_Story">Research Story</option>
					</select>
				</td>
			</tr>
			<tr>
				<td align=left width=15%></td>
				<td align=left><span class=searchLabel>Release Date From [DD/MM/YYYY]:</span></td>
				<td align=left>
					<input type="text" size=16 maxlength=20 name="ReleaseDate_From" value="">
					<span class=searchLabel>To:</span>
					<input type="text" size=16 maxlength=20 name="ReleaseDate_To" value="">
				</td>
			</tr>
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>Grant ID (for Profiles):</span></td>
				<td>
					<input type="text" size=43 name="txtGrantID" value="">
				</td>
			</tr>
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>SPO Contact (for Profiles):</span></td>
				<td>
					<input type="text" size=43 name="txtSPOContact" value="">
				</td>
			</tr>
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>Grant Type (for Profiles):</span></td>
				<td>
					<input type="text" size=43 name="txtGrantType" value="">
				</td>
			</tr>

				
			<tr>
				<td align=left width=15%></td>
				<td align=left width=25%><span>Full Text:</span></td>
				<td>
					<input type="text" size=43 name="FullTextSearch" value="">
				</td>
			</tr>
			<!--
			<tr>
				<td align=left width=20%></td>
				<td align=left width=20%><span>Funder(s):</span></td>
				<td>
					<input type="text" size=43 name="Funder" value="">
				</td>
			</tr>
			-->
			<tr>
				<td align=left width=15%></td>
				<td><span class=searchLabel>Sort By:</span></td>
				<td>
					<select name="SortField">
						<option selected value="dInDate">Release Date
						<option value="dDocTitle">Title
						<option value="dDocType">Type
					</select>
					   
					<select name="SortOrder">
						<option selected value="Desc">Descending
						<option value="Asc">Ascending
					</select>
				</td>
			</tr>
			<tr>
				<td colspan=2></td>
				<td align=left>
					<input type="button" value="Search" class="searchButton" onclick="AdvancedSearch_BuildQueryTextAndSubmit()">
				</td>
			</tr>
		</table>
				
	</form>
	</p>

<@end@>






<!-- TIMELINEMANAGER Search Results -------------------- -->
<@dynamichtml TimelineManager_search_results@>


	<$if QueryText$>

	<$executeService("GET_SEARCH_RESULTS")$>
	<table border="0">
		<tr><td colspan=4><h3></h3></td></tr>
		<tr><td colspan=4><h3>Results</h3></td></tr>
		<$if strEquals(TotalRows,"0")$>
		<tr>
			<td colspan=4>Your search returned no results.<td>
		</tr>
		<$else$>
		<tr>
			<td colspan=4>Found <$TotalRows$> results<br><br><td>
		</tr>

		<tr>
			<td><b>Title</b></td>
			<td><b>Type</b></td>
			<td><b>Release Date</b></td>
			<td><b>Content ID</b></td>
		</tr>
		<$loop SearchResults$>
		
			<!-- PF: Setup the target page to display the item -->
			<$if strEquals(dDocType, "Event")$>
				<$TargetNode=ssNodeLink(80001)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Research_Highlight")$>
				<$TargetNode=ssNodeLink(80003)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Research_History")$>
				<$TargetNode=ssNodeLink(80004)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Research_Story")$>
				<$TargetNode=ssNodeLink(80005)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Decade_Summary")$>
				<$TargetNode=ssNodeLink(80006)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Indicator")$>
				<$TargetNode=ssNodeLink(80007)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Filter")$>
				<$TargetNode=ssNodeLink(80008)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$elseif strEquals(dDocType, "Glossary")$>
				<$TargetNode=ssNodeLink(80010)$>
				<$TargetPage=strReplace(TargetNode,"index.htm","")$>
			<$endif$>

			<tr>
				<td>
					<li><a href="<$TargetPage$><$dDocName$>"><$dDocTitle$></a>
				</td>
				<td>
					<li>
					<$if strEquals(dDocType,"Research_Story")$>
						Research Story
					<$elseif strEquals(dDocType,"Research_Highlight")$>
						Research Highlight
					<$elseif strEquals(dDocType,"Research_History")$>
						Research History
					<$elseif strEquals(dDocType,"Decade_Summary")$>
						Decade Summary
					<$else$>
						<$dDocType$>
					<$endif$>
				</td>
				<td>
					<li><$dInDate$>
				</td>
				<td>
					<li><$dDocName$>
				</td>
				
			</tr>
		<$endloop$>
		
			<tr><td>
			<!--The following line calls the pagination include-->
			<$if TotalRows > ResultCount$>
				<br><br>
				<h3 class="bread">Page: <$include pirCustomsearchapi_navigation_list$></h3>
			<$endif$>
			</td></tr>
		<$endif$>
	</table>
	<$endif$>
<@end@>





<!-- TIMELINEMANAGER Wellcome Logo -------------------- -->
<@dynamichtml TimelineManager_Wellcome_Logo@>
	<img height="27" 
		alt="The Wellcome Trust" 
		hspace="21" 
		src="<$HttpRelativeWebRoot$>groups/timeline/@Timeline_Management_Team/documents/image/tl_wtlogo.gif" 
		width="171" 
		align="bottom" 
		border="0" />
<@end@>



















<@dynamichtml TimelineManager_searchapi_result_navigation_list_header@>
		<!---Navigation Bar-->
		<hr>
		<p align="center">
		<$include TimelineManager_searchapi_navigation_list$>
		</p>
		<hr>
		<!--End Navigation bar-->
<@end@>




<@dynamichtml TimelineManager_searchapi_navigation_list@>
		<$lc("wwListNavigation")$>
		<$if PreviousPage$>
		<a class="xuiAltHeader" href="<$strRemoveWs(inc("TimelineManager_searchapi_navigation_previous"))$>">
				<$lc("wwPrev")$></a>
		<$endif$>
		<$if not (TotalRows like "-1")$>
		<$loop NavigationPages$>
			<$if IsCurrentNav$>
				<$HeaderPageNumber$>
			<$else$>
				<a class="xuiAltHeader" href="<$strRemoveWs(inc("TimelineManager_searchapi_navigation_specific_page"))$>">
					<$HeaderPageNumber$></a>
			<$endif$>
		<$endloop$>
		<$endif$>
		<$if NextPage$>
		<a class="xuiAltHeader" href="<$strRemoveWs(inc("TimelineManager_searchapi_navigation_next_page"))$>">
				<$lc("wwNext")$></a>
		<$endif$>
<@end@>

<@dynamichtml TimelineManager_searchapi_navigation_previous@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$PreviousPage$>&StartRow=<$PreviousStartRow$>&<$if TotalRows like "-1"$>ResultCount=<$ResultCount$><$else$>EndRow=<$PreviousEndRow$><$endif$>
<@end@>

<@dynamichtml TimelineManager_searchapi_navigation_specific_page@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$PageReference$>&
StartRow=<$StartRow$>&EndRow=<$EndRow$>
<@end@>

<@dynamichtml TimelineManager_searchapi_navigation_next_page@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$NextPage$>&StartRow=<$NextStartRow$>&<$if TotalRows like "-1"$>ResultCount=<$ResultCount$><$else$>EndRow=<$NextEndRow$><$endif$>
<@end@>

<@dynamichtml TimelineManager_searchapi_navigation_common_url@>
				<$ssNodeLink(80013)$>?
				QueryText=<$urlEscape7Bit(QueryText)$>
				&SortField=<$#active.SortField$>
				&SortOrder=<$#active.SortOrder$>&ResultCount=<$url(ResultCount)$>
				<$if ItemTitle$>&ItemTitle=<$url(ItemTitle)$>&<$endif$>
				<$if ItemType$>&ItemType=<$url(ItemType)$>&<$endif$>
				<$if ReleaseDate_From$>&ReleaseDate_From=<$url(ReleaseDate_From)$>&<$endif$>
				<$if ReleaseDate_To$>&ReleaseDate_To=<$url(ReleaseDate_To)$><$endif$>
				<$if ftx$>&ftx=1<$endif$>
<@end@>




<!-- *******************************SEARCH RESULTS********************************** -->


<@dynamichtml pirsearchResults@>
<!--The following lines run the search query-->
<!--$QueryText = "dDocType <matches> `WEBPAGES` <and> xPubSite <matches> `PiR Website` <and> xSearchable <matches> `YES` <and> (dDocTitle <substring> `" & search & "` <or> xDescription <substring> `" & search & "` <or> xPubArea <substring> `" & search & "`)"$>-->
<!--The following line modifies the search to include words within the content items-->
<$QueryText = "dDocType <matches> `WEBPAGES` <and> xPubSite <matches> `PiR Website` <and> xSearchable <matches> `Yes` <and> (dDocTitle <substring> `" & search & "` <or> xDescription <substring> `" & search & "` <or> xPubArea <substring> `" & search & "` <or> `" & search & "`)"$>
<$SortField="dInDate"$>
<$SortOrder="desc"$>
<$ResultCount=5$>
<$executeService("GET_SEARCH_RESULTS")$>

<!--The following lines detect if there are no matching items and display the error message-->
<$if TotalRows == 0$>
	<br />
	<strong>Sorry but there are no items matching your criteria of '<$search$>'</strong><br />
	Please refine your search and try again
	<br /><br />
<$elseif strEquals(search,"")$>
	<br />
	<strong>You have not entered any search criteria</strong><br />
	Please refine your search and try again
	<br /><br />
<$else$>
<!--The following lines display the criteria and all matching content items-->
A total of <strong><$TotalRows$></strong> items matching <strong>'<$search$>'</strong> have been found
<br /><br />

<$loop SearchResults$>
<a href="<$HttpWebRoot$>groups/public/documents/webpages/<$dDocName$>.<$dExtension$>?src=3&search=<$search$>" title="<$dDocTitle$>"><h3 class="boxheader"><$dDocTitle$></h3></a>
<$VDKSUMMARY$>
<a href="<$HttpWebRoot$>groups/public/documents/webpages/<$dDocName$>.<$dExtension$>?src=3&search=<$search$>" title="more...">(more...)</a><br /><br/>
<$endloop$>
<!--The following line calls the pagination include-->
<$if TotalRows > 5$><h3 class="bread">Page: <$include pirCustomsearchapi_navigation_list$></h3><$endif$>
<$endif$>
<@end@>


<!-- *******************************SEARCH RESULTS END****************************** -->



<!-- *************************DISPLAY PAGINATION OF RESULTS************************* -->

<!-- The code within this section creates the pagination of the results-->


<@dynamichtml pirCustomsearchapi_navigation_list@>
<$if PreviousPage$>
		<a href="<$strRemoveWs(inc("pirCustomsearchapi_navigation_previous"))$>"><$lc("wwPrev")$></a><$endif$>
		<$i=0$>
		<$loop NavigationPages$>
			<$i=i+1$>

		<$if i<PageNumber-4 and i>PageNumber-6$>
			...
		<$endif$>

			<$if i>PageNumber-5 and i<PageNumber+3$>
			<$maxpageno=PageNumber+5$>
				<$if IsCurrentNav$>
					<strong><$HeaderPageNumber$></strong>
				<$else$>
					<a class="" href="<$strRemoveWs(inc("pirCustomsearchapi_navigation_specific_page"))$>"><$HeaderPageNumber$></a>
				<$endif$>
			<$endif$>

		<$if i>PageNumber+4 and i<PageNumber+6$>
			...
		<$endif$>

		<$endloop$>
		<$if NextPage$>
		<a class="" href="<$strRemoveWs(inc("pirCustomsearchapi_navigation_next_page"))$>"><$lc("wwNext")$></a>
		<$endif$>
<@end@>


<@dynamichtml pirCustomsearchapi_navigation_previous@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$PreviousPage$>&StartRow=<$PreviousStartRow$>&<$if TotalRows like "-1"$>ResultCount=<$ResultCount$><$else$>EndRow=<$PreviousEndRow$><$endif$><$if isTraySearch$>&isTraySearch=1<$endif$>
<@end@>

<@dynamichtml pirCustomsearchapi_navigation_specific_page@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$PageReference$>&StartRow=<$StartRow$>&EndRow=<$EndRow$><$if isTraySearch$>&isTraySearch=1<$endif$>
<@end@>

<@dynamichtml pirCustomsearchapi_navigation_next_page@>
<$include TimelineManager_searchapi_navigation_common_url$>
&PageNumber=<$NextPage$>&StartRow=<$NextStartRow$>&<$if TotalRows like "-1"$>ResultCount=<$ResultCount$><$else$>EndRow=<$NextEndRow$><$endif$><$if isTraySearch$>&isTraySearch=1<$endif$>
<@end@>



<@dynamichtml pirCustomsearchapi_navigation_common_url@>
<$c="  --- check for additional search parameters  ---  "$>
<$pir_additional_search=""$>
<$if xSearch_1 and not strEquals(xSearch_1,"")$>
	<$pir_additional_search=pir_additional_search & "&xSearch_1=" & url(xSearch_1)$>
<$else$>
<$endif$>
<$if xSearch_2 and not strEquals(xSearch_2,"")$>
	<$pir_additional_search=pir_additional_search & "&xSearch_2=" & url(xSearch_2)$>
<$else$>
<$endif$>
<$if xSearch_3 and not strEquals(xSearch_3,"")$>
	<$pir_additional_search=pir_additional_search & "&xSearch_3=" & url(xSearch_3)$>
<$else$>
<$endif$>
<$if xSearch_4 and not strEquals(xSearch_4,"")$>
	<$pir_additional_search=pir_additional_search & "&xSearch_4=" & url(xSearch_4)$>
<$else$>
<$endif$>



<$if strIndexOf(Level2,"News & Media") >= 0$>
	<$HttpWebRoot$>groups/public/documents/webpages/pir_newsmedia.hcsp?
<$elseif strEquals(Level3,"Noticeboard")$>
	<$HttpWebRoot$>groups/public/documents/webpages/pir_Noticeboard.hcsp?
<$elseif strEquals(Level3,"Members Directory")$>
	<$if pirletter$>
		<$HttpWebRoot$>groups/public/documents/webpages/pir_RegeneratorsDirectory.hcsp?pirletter=<$pirletter$><$pir_additional_search$>&
	<$else$>
		<$HttpWebRoot$>groups/public/documents/webpages/pir_RegeneratorsDirectory.hcsp?<$pir_additional_search$>&
	<$endif$>
<$elseif strEquals(Level3,"Events")$>
	<$if pirmonth$>
		<$HttpWebRoot$>groups/public/documents/webpages/pir_SharedDiaryofEvents.hcsp?pirmonth=<$pirmonth$><$pir_additional_search$>&
	<$else$>
		<$HttpWebRoot$>groups/public/documents/webpages/pir_SharedDiaryofEvents.hcsp?<$pir_additional_search$>&
	<$endif$>
<$elseif strEquals(Level3,"Publications")$>
	<$HttpWebRoot$>groups/public/documents/webpages/pir_SearchResources.hcsp?<$pir_additional_search$>&
<$else$>
	<$HttpWebRoot$>groups/public/documents/webpages/pir_quickfind.hcsp?search=<$search$>&
<$endif$>
<@end@>


<!-- *************************DISPLAY PAGINATION OF RESULTS END********************** -->

</body></html>

[Nicola Garofalo]

Yes, that's another issue.

The ordering on String is not alphabetical but an Unicode ordering.

So letters from A to Z goes from 65 to 90

Letters from a to z from 97 to 122

Then every uppercase letter will come first than a lowercase letter. Zorro is "less than" batman

You have 2 choices dependng on how important is for you the Upper - Lower case thing.

1) If you don't care about the letter's case you put all your lines in the List in lower case or upper case. Then the sort will be performed as you expected.
2) If you do care you write a class that implements a Comparator, and pass it to the Collections.sort method, so that when the List will be sorted it will be sorted with your criteria

[Campbell Ritchie]

There is a case-insensitive Comparator<String> as a field of the String class.

[Nick Rowe]

Hi guys apologies about not posting for the past few days my sister was in a car accident over the weekend and i've spent pretty much all of my time at the hospital with her.

Anyway, my program now organises and prints each resource name alphabetically on a seperate line ( which is nice) , however the program organises the resources in a case sensitive mannor and not in a general way. For example Timlinemanager_alpha may be listed infront of searchapi_footer purely because it begins with a capital T where as it should be listed before.

I have been looking into comparator interfaces to try and do something along the lines of A==a,B==b etc but am not really sure how to go about it.

The code I now have I tidied up after discovering Eclipse the other day.

regards Nick

/**import java librarys*/
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.util.ArrayList;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.Collections;
import java.util.List;

/** class to find string */
public class Find {
	BufferedReader br = null;

	/** method to read html file line by line and return string to tore in array */
	public Find() throws java.io.IOException {
		try {
			/** read in file */
			br = new BufferedReader(
					new FileReader(
							"C:/Documents and Settings/Kieren McDonald/Desktop/Nick/Java/timelinemanager_resource.htm"));
			/**
			 * declaring string identifiers for beginning and end of string
			 * aswel as one other line string to store the data between
			 */
			String resourceline = null;
			String beg = "<@dynamichtml ";
			String end = "@>";
			ArrayList<String> arrayList = new ArrayList<String>();
			/** while line is not equal to null then find 3 string values */
			while ((resourceline = br.readLine()) != null) {
				resourceline = find(beg, end, resourceline);

				/**
				 * if line is not equal to null store line in array list adding
				 * a resource name
				 */
				if (resourceline != null) {
					resourceline= resourceline.trim();
					arrayList.add(resourceline);
				}

			}
			sortAndPrint(arrayList);
		} catch (FileNotFoundException ex) {
			ex.printStackTrace();
		} finally {
			br.close();
		}
	}

	/** method to sort and print the array collection */
	private void sortAndPrint(List<String> results) {
		Collections.sort(results);
		for (String resourceline : results)
			System.out.println(resourceline);
	}

	/** method to find the value between the beginning and end of a string */
	public String find(String beg, String end, String resourceline) {
		/** match pattern to store string between strings and match to line */
		Pattern p = Pattern.compile(beg + "(.*)" + end);
		Matcher m = p.matcher(resourceline);
		return m.find() ? resourceline.substring(m.start(1), m.end(1)) : null;
	}

	/** main method to find the resource name calling */
	public static void main(String[] args) throws IOException {
		Find findResources = new Find();
	}
}

[Nicola Garofalo]

Hey Nick,
hope everything is ok with your sister now.

Anyway, there wasn't much left to do

just replace

Collections.sort(results);

with

Collections.sort(results,String.CASE_INSENSITIVE_ORDER); 

as suggested above.
Good luck.