Table cells not editable

[Mike Lipay]

I'm not sure why this isn't working, the table displays fine, I can sort the columns, I can select a cell, but I cannot change the contents inside. I can't see anything that would be turning editing off. Hopefully this is a small enough contained code to work with.

import java.awt.*;
import java.io.*;
import java.text.*;
import java.util.prefs.*;

import javax.swing.*;
import javax.swing.table.*;


/**
 * Service Form
 * @author	Mike Lipay
 * @version	1.0
*/
public class Service
{
	public static void main (String[] args)
	{
		JFrame MainFrame = new JFrame();
		MainFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		MainFrame.pack();
		MainFrame.setLocationRelativeTo(null);
		MainFrame.setVisible(true);
		Service.Service(MainFrame);
	}


	public static void Service (JFrame frame)
	{
		displayMenu(frame);
	}


	/**
	 * Display main window to the user
	*/
	public static void displayMenu(JFrame aFrame)
	{
		final JFrame frame = aFrame;

		EventQueue.invokeLater (new Runnable()
		{
			public void run()
			{
				ServiceDialog dialog = new ServiceDialog(frame);
				dialog.setDefaultCloseOperation (JFrame.DISPOSE_ON_CLOSE);
				dialog.setVisible(true);
			}
		});
	}
}



/**
* Create the window frame
*/
class ServiceDialog extends JDialog implements Serializable
{
	/**
	 * Create the main frame which enables the selection of or addition of
	 * vehicles to the Vehicle Identification File (VIF.obj)
	*/
	public ServiceDialog(JFrame owner)
	{
		super (owner, "Vehicle Specifications", true);
		

	// Main window setup
		setLocationByPlatform(true);
		setSize(windowWidth, windowHeight);
		setTitle("Vehicle Service");
		GridBagLayout layout = new GridBagLayout();
		setLayout(layout);


	// Add Service Table to panel
		TableModel model = new ServiceTableModel(2, 7);
		JTable table = new JTable(model);
	
		add (new JScrollPane(table), gbcTablField);

		table.setAutoCreateRowSorter(true);
		table.setFillsViewportHeight(true);
		table.setCellSelectionEnabled(true);
	}


	// Service Table Model
	class ServiceTableModel extends AbstractTableModel
	{
		public ServiceTableModel (int r, int c)
		{
			row = r;
			col = c;
		}

		public int getRowCount()			{ return row; }
		public int getColumnCount()			{ return col; }
		public String getColumnName(int c)		{ return columnNames[c]; }
		public Class<?> getColumnClass(int c)
		{
			if (c == clmnCost)	return Integer.class;
			return serviceTable[0][c].getClass();
		}


		public Object getValueAt (int r, int c)
		{
			if (c == clmnMileage)	return mf.format(serviceTable[r][c]);
			if (c == clmnCost)
			{
				return cf.format(serviceTable[r][c]);
			}
			return serviceTable [r][c];
		}

		private int row;
		private int col;
	}


// Field formatting
	final DecimalFormat mf = new DecimalFormat ("000,000");
	final NumberFormat cf  = NumberFormat.getCurrencyInstance();


// Main panel fields
	final int windowWidth= 600;
	final int windowHeight = 350;

	private JPanel servicePanel	= new JPanel();


// Table values
	private int ttlRows = 0;
	final int clmnMileage = 0;
	final int clmnSvcDate = 1;
	final int clmnShop= 2;
	final int clmnInvoice = 3;
	final int clmnLabor = 4;
	final int clmnParts = 5;
	final int clmnCost= 6;
	final String[] columnNames = {
		"Mileage", 
		"Service Date", 
		"Shop", 
		"Invoice Nbr", 
		"Labor", 
		"Parts", 
		"Cost", 
	};
	private Object[][] serviceTable = {
		{ 97300, "1/26/2009", "McElhinney's Service", 4798, "Check alternator and oil pressure",
		  "Battery, Alternator, Serpentine Belt, Oil Pressure Sensor", 707.68},
		{ 0, "3/20/2008", "McElhinney's Service", 11112, "Replace engine",
		  "Motor, cables, fluids", 4534.61}
	};


// Field locations in panel
	private GBC gbcTablField = new GBC(0,5,3,1).setFill(GBC.BOTH).setWeight(100, 100);


// Send message dialog
	public void sendMessage(String msg)
	{
		JOptionPane.showMessageDialog(
		servicePanel,
		msg,
		"Message Dialog",
		JOptionPane.INFORMATION_MESSAGE);
	}
}

[Rob Spoor]

Please split longer lines of code next time. That way the forum layout is preserved.

Where have you implemented setValueAt? AbstractTableModel.setValueAt does nothing at all, so neither does your table model. You can try to change the values all you want in the GUI, the model ignores these changes and returns the array values you hard coded.

[Mike Lipay]

Rob Prime wrote:Please split longer lines of code next time. That way the forum layout is preserved.

Where is too long? 80 chars, 90?

Rob Prime wrote:Where have you implemented setValueAt? AbstractTableModel.setValueAt does nothing at all, so neither does your table model. You can try to change the values all you want in the GUI, the model ignores these changes and returns the array values you hard coded.

I understand that, what I am saying is that I can click on any cell, but I cannot change the contents, even delete. The insertion cursor will not set. I thought that I would still be able to get focus on the cell and modify the contents, but when I moved out of the cell that it would be redrawn. No?

[Maneesh Godbole]

Whether a cell is editable or not is defined by the table model's isCellEditable.
Your model extends the AbstractTableModel whose isCellEditable defaults to false. Override it to return true.

[Mike Lipay]

Maneesh Godbole wrote:Whether a cell is editable or not is defined by the table model's isCellEditable.
Your model extends the AbstractTableModel whose isCellEditable defaults to false. Override it to return true.

Thanks, I hadn't realized it defaulted to false.

[Rob Spoor]

Maneesh Godbole wrote:Your model extends the AbstractTableModel whose isCellEditable defaults to false. Override it to return true.

Hmmm, I thought it returned true... I probably thought of DefaultTableModel.

Still, without a setValueAt that will actually change the data in the model you can try to edit the contents all you want, as soon as you try to commit (e.g. by pressing enter) you'll see the old data.