file.delete works most of the time, but fails every so often

[joe abernathy]

hi all. i'm not sure why this erratic behavior is happening. my program downloads zip files from an ftp server, unzips them to a temp directory, processes the text files in the temp dir, and then finally cleans out the temp directory. About 95% of the time, it's able to clean out the temp directory successfully, but every once in a while, it'll run into a file that it can't delete. When that happens, I have to login to windows and delete the rest of the files manually. In the program, i have a bufferedreader that's reading the contents of each text file, and I'm closing the bufferedreader every time i'm done with it. So, if it's not a problem with closing the handle to the file, what else could it be? Also, there are no other processes on this machine that are taking control of these text files; it's just my program. any help would be greatly appreciated! thanks

[David Newton]

Chances are it's your code, but it's impossible to say since there isn't any to look at. I've never had *any* issues with deleting files through Java that weren't caused by code, another process, etc. Doesn't mean you're *not*, but I'm skeptical.

[joe abernathy]

after the program unzips the zip files, it goes through and parses each of the text files. Here's the parsing:

public void parse(Artifact a) throws Exception {
// TODO Auto-generated method stub
Connection conn = null;
Class.forName(ParseBehavior.GARD_DB_DRIVERNAME);
String url = "jdbc:oracle:thin:" +
ParseBehavior.GARD_DB_USERNAME + "/" +
ParseBehavior.GARD_DB_PW + "@" +
ParseBehavior.GARD_DB_HOST + ":" +
ParseBehavior.GARD_DB_PORT + ":" +
ParseBehavior.GARD_DB_SID;
conn = DriverManager.getConnection(url);
conn.setAutoCommit(false);
File unzippedFolder = new File(dea.getUnzippedFolder());
String[] listOfFiles = unzippedFolder.list(eff);
Map<String, String> m = new HashMap<String, String>();
setActivityDateValue(m);
setUserIdValue(m);
setFormTypeValue(m);
for (int i=0; i < listOfFiles.length; i++) {
log.info("Parsing " + listOfFiles[i]);
String fullPath = unzippedFolder + "\\" + listOfFiles[i];
setEmbarkPersonIdValue(m, listOfFiles[i]);
setEmbarkApplIdValue(m, listOfFiles[i]);
setFileNameValue(m, listOfFiles[i]);
BufferedReader br = new BufferedReader(new FileReader(new File(fullPath)));
String row = br.readLine();
while (row != null) {
setRowTypeValue(m, row);
setContentsValue(m, row);
String sql = "<insert statement>";
PreparedStatement ps = conn.prepareStatement(sql);
ps.setString(1, m.get("CONTENTS"));
try {
ps.executeUpdate();
} catch (SQLException e) {
br.close();
conn.rollback();
disconnectFromDatabase(conn);
throw new EtgSQLException("Insert query failed", e);
}
ps.close();
row = br.readLine();
}
br.close();
}
conn.commit();
disconnectFromDatabase(conn);
updateTrackingFile(a);
}
//after the parsing is complete, it cleans up the temp directory
public void cleanUnzippedFolder() throws Exception {
File unzippedDir = new File(dea.getUnzippedFolder());
String[] listOfFiles = unzippedDir.list();
for (int i=0; i < listOfFiles.length; i++) {
String fullPath = dea.getUnzippedFolder() + "\\" + listOfFiles[i];
File temp = new File(fullPath);
if (temp.delete())
log.info("Deleted: " + fullPath);
else
throw new FileDeleteFailedException(fullPath);
}
}

[David Newton]

Please UseCodeTags when posting code or configuration. Unformatted code and configuration is unnecessarily difficult to read. You can edit your post by using the button.

[joe abernathy]

sorry, my bad. code looks much better now!