Out of bound on removeRow

[Mike Lipay]

Still working through the table issues, but learning.

I am trying to implement removing a row from the table. I click on the row, then click on a button to remove the row. The action listener is called, and the model can be referenced, but when I issue the removeRow() method I get an Out Of Bounds exception, even though the row number being removed does exist. I just can't seem to see what I am doing wrong with this.

import java.awt.*;
import java.awt.event.*;
import java.io.*;
import java.lang.Integer;
import java.lang.Object;
import java.text.*;
import java.util.*;
import java.util.GregorianCalendar.*;
import java.util.Locale;
import java.util.prefs.*;
import java.util.regex.*;

import javax.swing.*;
import javax.swing.event.ListSelectionEvent;
import javax.swing.event.ListSelectionListener;
import javax.swing.JComponent.*;
import javax.swing.RowFilter.*;
import javax.swing.SwingConstants;
import javax.swing.table.*;


/**
 * Service Form
 * @author	Mike Lipay
 * @version	1.0
*/
public class Service
{
	public static void main (String[] args)
	{
		JFrame MainFrame = new JFrame();
		MainFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		MainFrame.pack();
		MainFrame.setLocationRelativeTo(null);
		MainFrame.setVisible(true);
		Service.Service(MainFrame);
	}


	public static void Service (JFrame frame)
	{ displayMenu(frame); }


	/**
	 * Display main window to the user
	*/
	public static void displayMenu(JFrame aFrame)
	{
		final JFrame frame = aFrame;

		EventQueue.invokeLater (new Runnable()
		{
			public void run()
			{
				ServiceDialog dialog = new ServiceDialog(frame);
				dialog.setDefaultCloseOperation (JFrame.DISPOSE_ON_CLOSE);
				dialog.setVisible(true);
			}
		});
	}
}



/**
* Create the window frame
*/
class ServiceDialog extends JDialog implements Serializable
{
	/**
	 * Create the main frame which enables the selection of or addition of
	 * vehicles to the Vehicle Identification File (VIF.obj)
	*/
	public ServiceDialog(JFrame owner)
	{
		super (owner, "Vehicle Specifications", true);
		

	// Main window setup
		setLocationByPlatform(true);
		setSize(windowWidth, windowHeight);
		setTitle("Vehicle Service");
		GridBagLayout layout = new GridBagLayout();
		setLayout(layout);


	// Add Service Table to panel
		table = new JTable(model);
	
		add (new JScrollPane(table), gbcTablField);

		table.setAutoCreateRowSorter(true);
		table.setFillsViewportHeight(true);

		add (jbDelete, gbcDelete);	jbDelete.setEnabled(true);
		ButtonAction deleteAction = new ButtonAction(jbDelete);
		jbDelete.addActionListener(deleteAction);
	}


	private class ButtonAction implements ActionListener
	{
		public ButtonAction(JButton b)
		{ button = b; }

		public void actionPerformed(ActionEvent event)
		{
			String buttonSelected = event.getActionCommand();

			if (buttonSelected.equals("Delete"))
			{
				System.out.println ("Delete");
				int[] selected = table.getSelectedRows();
				for (int i = selected.length - 1; i >= 0; i--)
				{
					int s = selected[i];
					System.out.println(s + "," + model.getRowCount());
					model.removeRow(s);
				}
				return;
			}
		}
	}



	// Service Table Model
	class ServiceTableModel extends DefaultTableModel
	{
		public ServiceTableModel (int r, int c)
		{
			row = r;
			col = c;
		}

		public int getRowCount()			{ return row; }
		public int getColumnCount()			{ return col; }
		public String getColumnName(int c)		{ return columnNames[c]; }
		public Class<?> getColumnClass(int c)
		{
			if (c == clmnCost)	return Integer.class;
			return serviceTable[0][c].getClass();
		}


		public Object getValueAt (int r, int c)
		{
			if (c == clmnMileage)	return mf.format(serviceTable[r][c]);
			if (c == clmnCost)
			{
				return cf.format(serviceTable[r][c]);
			}
			return serviceTable [r][c];
		}

		private int row;
		private int col;
	}


// Field formatting
	final DecimalFormat mf = new DecimalFormat ("000,000");
	final NumberFormat cf  = NumberFormat.getCurrencyInstance();


// Main panel fields
	final int windowWidth= 600;
	final int windowHeight = 350;

	private JPanel servicePanel	= new JPanel();


// Table values
	private JTable table;
	private ServiceTableModel model = new ServiceTableModel(2, 7);

	private int ttlRows = 0;
	final int clmnMileage = 0;
	final int clmnSvcDate = 1;
	final int clmnShop= 2;
	final int clmnInvoice = 3;
	final int clmnLabor = 4;
	final int clmnParts = 5;
	final int clmnCost= 6;
	final String[] columnNames = {
		"Mileage", 
		"Service Date", 
		"Shop", 
		"Invoice Nbr", 
		"Labor", 
		"Parts", 
		"Cost", 
	};
	private Object[][] serviceTable = {
		{ 97300, "1/26/2009", "McElhinney's Service", 4798, "Check alternator and oil pressure", 
			"Battery, Alternator, Serpentine Belt, Oil Pressure Sensor", 707.68},
		{ 0, "3/20/2008", "McElhinney's Service", 11112, "Replace engine", 
			"Motor, cables, fluids", 4534.61}
	};


// Field locations in panel
	private JButton button		= new JButton();
	private JButton jbDelete	= new JButton("Delete");
	private GBC gbcDelete	 = new GBC(0,10,1,1).setFill(GBC.CENTER).setWeight(100, 100);
	private GBC gbcTablField = new GBC(0,5,3,1).setFill(GBC.BOTH).setWeight(100, 100);


// Send message dialog
	public void sendMessage(String msg)
	{
		JOptionPane.showMessageDialog(
		servicePanel,
		msg,
		"Message Dialog",
		JOptionPane.INFORMATION_MESSAGE);
	}
}

I've tried selecting the first and second rows, get the same errors regardless:

Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.

C:\Documents and Settings\pmll42>cd desktop\java\test

C:\Documents and Settings\pmll42\Desktop\Java\Test>java Service
Delete
0,2
Exception occurred during event dispatching:
java.lang.ArrayIndexOutOfBoundsException: 0 >= 0
        at java.util.Vector.removeElementAt(Unknown Source)
        at javax.swing.table.DefaultTableModel.removeRow(Unknown Source)
        at ServiceDialog$ButtonAction.actionPerformed(Service.java:118)
        at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
        at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
        at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
        at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
        at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Sour
ce)
        at java.awt.Component.processMouseEvent(Unknown Source)
        at javax.swing.JComponent.processMouseEvent(Unknown Source)
        at java.awt.Component.processEvent(Unknown Source)
        at java.awt.Container.processEvent(Unknown Source)
        at java.awt.Component.dispatchEventImpl(Unknown Source)
        at java.awt.Container.dispatchEventImpl(Unknown Source)
        at java.awt.Component.dispatchEvent(Unknown Source)
        at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
        at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
        at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
        at java.awt.Container.dispatchEventImpl(Unknown Source)
        at java.awt.Window.dispatchEventImpl(Unknown Source)
        at java.awt.Component.dispatchEvent(Unknown Source)
        at java.awt.EventQueue.dispatchEvent(Unknown Source)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
        at java.awt.Dialog$1.run(Unknown Source)
        at java.awt.Dialog$3.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.awt.Dialog.show(Unknown Source)
        at java.awt.Component.show(Unknown Source)
        at java.awt.Component.setVisible(Unknown Source)
        at java.awt.Window.setVisible(Unknown Source)
        at java.awt.Dialog.setVisible(Unknown Source)
        at Service$1.run(Service.java:57)
        at java.awt.event.InvocationEvent.dispatch(Unknown Source)
        at java.awt.EventQueue.dispatchEvent(Unknown Source)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
        at java.awt.EventDispatchThread.run(Unknown Source)

C:\Documents and Settings\pmll42\Desktop\Java\Test>

[Maneesh Godbole]

Hint: After you remove the 1st selected row, think what happens to the row count.

[Mike Lipay]

Maneesh Godbole wrote:Hint: After you remove the 1st selected row, think what happens to the row count.

I don't know. I put a println after the removeRow just to check that (I had the thought that I was looping and removing more than the two rows), the println was never executed. Apparently the exception is being thrown on the removeRow command itself.

[pete stein]

Are you sure that you don't want to use an AbstractTableModel and not a DefaultTableModel here? The DTM comes with its own Vector of Vectors to hold the data, and as you are using it, currently this object is empty, so the DTM sees no rows. If in fact you want to use your own array as the model, then I think you're better off with the ATM.

YMMV.

[Rob Camick]

I always recommend you start by using the DefaultTableModel because all the methods and functionality is implemented for you. Once you understand how models work then you can create a custom model if you feel it is necessary.

So start with the DefaultTableModel. The only method you need to override is the getColumnClass() method. You can create a DefaultTableModel by using a 2D array. The values in the Array will be copied to the DefaultTableModel so the model can reference the data. Now any changes to the data MUST be done by using the model.

When you delete multiple row you delete the last row first. That is instead of deleting rows 0, 1, 2, you delete rows 2, 1, 0. That way to don't try to delete a row that doesn't exist.

[Mike Lipay]

Pete, Rob,

Thanks, this is going to take some re-working of the code, but I think you are right. Should have waded in rather than jumping into the deep end first.