try-catch logic design issue

[pamir sonmez]

Rather than long explain, I am writing the sample code.
And I wonder how should I design this or is it a good design?

  
public class myClass {

	enum RelationEnum {
		G,GT,L,LT,E,NE
	}
	
	...................
	...................

		try {
			...................
			...................
			
			for (int i = 0; i < length; i++) {
			              ...................
                                                         ...................
				try {
					relationEnum = RelationEnum.valueOf(string);
				} catch (Exception e) {
					...................
					...................
					continue; //using continue in here, I dont like it, but i have to
							  //is there any option for a control flow like this
				}

			}
			...................
			...................
		}
}

[Seetharaman Venkatasamy]

catch specific possible exception instead of java.lang.Exception and what is the significant of continue in your catch block ? regardless continue the control flow goes to the increment part of you for loop.

[pamir sonmez]

if there is an error, the jobs will not be done after try-catch block
and in for loop i will take another object from list

[frank braunstein]

Your solution should work, but why you use an exception? You can do the same with an if-else line of code. I dont know but using an exception seems odd to me in this particular case.

[Seetharaman Venkatasamy]

pamir sonmez wrote:if there is an error, the jobs will not be done after try-catch block

do you mean if any exception in try block then statement after catch block wont get execute? are you sure ?

<edit>
you doestnt put any code after the continue; but you put before continue.
so in this case you can put simply

catch(SpecificException specificException)
{
try
{
//---- your logic
}
catch(Exception e)
{
//log exception
}
//continue; Ignore this

}

</edit>

[pamir sonmez]

Seetharaman Venkatasamy please tell something logical rather than smileys ))))))

I mean that if there occurs an exception while I am getting the valueof string to the enum, program enters the catch block and then program goes out the catch block and goes its own way after catch block. Ooop what I want is, damn stupid programme if you enter the catch block do not process your flow with this object, go the for loop increment i and get another objecct from list and start your job. hell yeah...
am I clear now???

thanks frank braunstein,
the reason I am using exception because I have to do.
I am reading a string from file and I am getting its enum value with valueOf(...) method, if string matches wth enum no problem.
But however, if string is written wrong, valueOf(..) method throws an exception. So I don want to use a long if block if this is equal to this, so it that enum.

[Seetharaman Venkatasamy]

cool

pamir sonmez wrote:am I clear now???.

no, still you dont answer my previous question . did you test your code as I suggest ?

[pamir sonmez]

Seetharaman Venkatasamy
Thanks, but you do not understand what I mean or you do not read exactly what I wrote so you are asking same question again and again.
I am implementing the program flow as I wrote the code before, when program enters catch block, continues to the for loop from start of flow by incrementing i(variable) and if it does not enter catch block, I mean no exception occurs, goes to the end of flow and then goes to the start of flow by incrementing i(variable). I know the logic behind try-catch block.

The most important thing I want to ask is there any efficient or correct way of using valueOf(..) function for enumerations.
And In valueOf(string) function, if string is not an enum, how could I handle it? because it throws an exception and enters catch block.
And I have to stop the execution of flow if catch block is entered, and program must continue the for loop.

[Dave Lorde]

It's really not clear to me what you're trying to achieve, but if you want to exit the loop when there is an exception, put the loop inside the try block (so the catch is outside the loop). If you want to continue looping after an exception, put the try...catch inside the loop.

[Garrett Rowe]

Is there a reason you don't put the rest of your processing logic in the try block? That would seem to be the most straightforward approach to avoid the dangling continue.

for (int i = 0; i < length; i++) {
  try {
    RelationEnum relationEnum = RelationEnum.valueOf(string);
    process(relationEnum)
  } catch (IllegalArgumentException e) {
    //log or just ignore exception here 
  }
}