Images in downloaded files

[P Mc Gartoll]

I created a small little java game and sent it to my friends but I realized that they don't have the images so they won't see the pictures that I put in the game. How would I make it able for them to view these images. Do I put them in the jar somehow? And what would I put for the path to these images?

Thanks!

[pete stein]

Yes, put them in the Jar, often in their own directory, possibly off of the directory that holds the class files. You'll want to access them using resources not as files. The tutorials should show you the way.

[P Mc Gartoll]

How do I insert it into the jar? And what tutorials are you talking about? I'm sorry I feel so silly right now but it would be really cool if I could get this working!

[pete stein]

These tutorials:

http://download.oracle.com/docs/cd/E17409_01/javase/tutorial/deployment/jar/index.html
http://download.oracle.com/docs/cd/E17409_01/javase/tutorial/deployment/jar/build.html

[P Mc Gartoll]

How do I set the image path as a resource. If possible just give me an example and I should be able to figure it out!

[pete stein]

The tutorials can tell you better than I can and can show you better examples. Please look here:
Loading Images Using getResource

[P Mc Gartoll]

Sweet thanks so much that's awesome!!!

[P Mc Gartoll]

I spoke too soon, I thought I had it but this code

  java.net.URL imageURL = Dodge.class.getResource("Run1.jpg");
        if (imageURL != null) { 
            ImageIcon icon = new ImageIcon(imageURL); 
            System.out.print(icon);
        }

        Image run1 = icon.getImage();  

I don't know why it doesn't work, the System.out.print prints out this
file:/PatricksFolder/java/Dodge!/Run1.jpg
Which appears correct but it won't run. Compiles fine but won't run.
Can I only run this when it is in the jar?

[pete stein]

What happens when you try to run it? Any exceptions get triggered?

For my money, I'd try to create a small program that does nothing more than create an ImageIcon, places it in a JLabel, and shows the JLabel in a JOptionPane, and then make a Jar of it. If you can get this to work, you can get your main program to work, I'll bet.

[Rob Spoor]

P Mc Gartoll wrote:Compiles fine

If that's your real code I very much doubt so; you declare icon inside the if-statement, then try to access it afterwards when it's already out of scope.
And if it's not, PostRealCode.

[P Mc Gartoll]

Here is my entire code for the main class. If you need all the other classes I can post them. The error I get is a null pointer exception for this code

  Image run1 = icon.getImage();   

Weird huh?

  import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import javax.swing.ImageIcon;
import java.util.Random;

public class Dodge extends Core implements KeyListener
{
    
    public static void main(String[] args) 
    {
        new Dodge().run();
    }
    
    private Image run1;
    private Image run2;
    private Image jump;
    private Image slide;
    private Sprite dude;
    private int score;
    private int eX;
    private int eY;
    private boolean run;
    private boolean menu;
    private double evX;
    private double evY;
    private Animation rAni,jAni,sAni;
    private ScreenManager s;
    private ImageIcon icon;
    
    public void loadImages()
    {
        java.net.URL imageURL = Dodge.class.getResource("Run1.jpg");
        if (imageURL != null) { 
            ImageIcon icon = new ImageIcon(imageURL); 
            System.out.print(icon);
        }
        
        Image run1 = icon.getImage(); 
        //Image run1 = new ImageIcon("images/Run1.jpg").getImage();
        Image run2 = new ImageIcon("images/Run2.jpg").getImage();
        Image jump = new ImageIcon("images/jump1.jpg").getImage();
        Image slide = new ImageIcon("images/slide1.jpg").getImage();

        rAni = new Animation();
        rAni.addScene(run1,500);
        rAni.addScene(run2,500);
        jAni = new Animation();
        jAni.addScene(jump,500);
        jAni.addScene(jump,500);
        sAni = new Animation();
        sAni.addScene(slide,500);
        sAni.addScene(slide,500);
        dude = new Sprite(rAni,jAni,sAni);
        dude.setVelocityX(0f);
        dude.setVelocityY(0f);
        dude.setX(0);
        dude.setY(400);
        dude.setCurrentAnimation(1);
    }
    
    public void loadEnemy()
    {
        Random gen = new Random();
        int r = gen.nextInt(2);
        if (r == 0) { eY = 524; }else{ eY = 449; }
        eX = 850;
        evX += -0.3;
    }
    
    public void init() {
        loadImages();
        loadEnemy();
        super.init();
        menu = true;
        evX = -5;
        evY = 0;
        score = 0;
        s = new ScreenManager();
        Window w = s.getFullScreenWindow();
        w.setFocusTraversalKeysEnabled(false);
        w.addKeyListener(this);
        run = true;
    }
    
    public void keyPressed(KeyEvent e)
    {
        int keyCode = e.getKeyCode();
        if(keyCode == KeyEvent.VK_ESCAPE)  stop();
        else if(keyCode == KeyEvent.VK_UP) dude.setCurrentAnimation(2);
        else if(keyCode == KeyEvent.VK_DOWN) dude.setCurrentAnimation(3); 
        else e.consume();
    }
    
    //key released
    public void keyReleased(KeyEvent e)
    {
        e.consume();
    }
    
    //useless
    public void keyTyped(KeyEvent e)
    {
        e.consume();
    }
    
    public void update(long timePassed)
    {
        dude.update(timePassed);
    }

    public void updateEnemy(Graphics2D g)
    {
        if(run) 
        eX += evX;
        eY += evY;
        if (eX <= 0) {
            loadEnemy();
            score += 1;
        }
        chkCollision();
    }
    
    //checks to see if user is hit
    public void chkCollision()
    {
        if(eX <= 74 && eX >= 34) {
            if(dude.getCAnimation() == 0) run = false;
            else if(dude.getCAnimation() == 1) {
                if(eY == 449) run = false;
            }
            else if(dude.getCAnimation() == 2) {
                if(eY == 524) run = false;
            }
        }
    }
    
    public void draw(Graphics2D g) {
        if(run) {
            if(menu) {
                g.setColor(Color.black);
                try {
                    Thread.sleep(10);
                }catch(Exception ex) {}
                g.drawString("Press up to jump and down to slide", 250, 300);
                try {
                    Thread.sleep(3000);
                }catch(Exception ex) {}
                menu = false;
            }
            g.setColor(Color.WHITE);
            g.fillRect(0, 0, 800, 600);
            g.drawImage(dude.getImage(), Math.round(dude.getX()), Math.round(dude.getY()), null);
            g.setColor(Color.GREEN);
            g.fillRect(eX, eY, 15, 75);
            g.setColor(Color.BLACK);
            g.drawString("Score: " + score, 650, 30);
        }
        else {
            g.setColor(Color.WHITE);
            g.fillRect(0, 0, 800, 600);
            g.setColor(Color.BLACK);
            g.drawString("Your Score Is: " + score, 300, 300);
            g.drawString("Press esc to quit", 300, 400);
        }
    }
}
  

EDIT: I set the private ImageIcon icon = new ImageIcon();
and I don't get the null pointer exceptions but now none of the images appear
It still prints out the correct file path and everything but no image appears

[Rob Spoor]

Is the Run1.jpg file located in the same folder (inside the JAR or not) as your Dodge.class file?

Oh, and change line 35 to "icon = ...". You are now declaring a new local variable that is instantiated in the if-block (if the resource is found). After that it goes out of scope (as I said) and the non-instantiated (and therefore null) icon instance field is used.

[P Mc Gartoll]

I am making a jar of the folder Dodge
Inside this folder are all the class files and another folder called images.
All my images are in this images folder.

[Rob Spoor]

Then use an absolute resource name, starting with /